)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"f8d6753fbc15e499193ac4ed2c9a9ca7716665c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jimmygc \u003cguochao@winhong.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-24 11:32:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add vSphere Support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add oslo.vmware and vmware_nsx packages into kolla."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2a1ed314b970a4832f7f8256c1929921f36069f2"},{"line_number":12,"context_line":"Implements: blueprint kolla-support-vsphere"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ffe62b97_1380508b","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":51},"updated":"2017-03-24 07:02:02.000000000","message":"Is it the good way to go to include \"proprietary\" driver code in Docker, I don\u0027t think so? \nIf we go this way, the list will be very long...\n\nAnyway, commit message must be update to reflect Jeffrey comment.","commit_id":"32f3df4b3ef98b488e885ade810fd88ad924aa2d"}],"docker/neutron/neutron-server/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"da24b1feedc5ce63f88f5847040721a1e35f4731","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% set neutron_server_pip_packages \u003d ["},{"line_number":34,"context_line":"    \u0027oslo.vmware\u0027,"},{"line_number":35,"context_line":"    \u0027vmware-nsx\u0027"},{"line_number":36,"context_line":"] %}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"RUN {{ macros.install_pip(neutron_server_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ffe62b97_dd50bcd7","line":35,"updated":"2017-03-24 02:38:48.000000000","message":"vmware-nsx is not in requirements project. it should be installed from tarballs.o.o site.\n\nhttp://tarballs.openstack.org/vmware-nsx/","commit_id":"36bb4541909b8f2de230c4106116d750742fb0af"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"4797ad00292471cc5c188d326ea5975a226bb8e3","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% set neutron_server_pip_packages \u003d ["},{"line_number":34,"context_line":"    \u0027oslo.vmware\u0027,"},{"line_number":35,"context_line":"    \u0027vmware-nsx\u0027"},{"line_number":36,"context_line":"] %}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"RUN {{ macros.install_pip(neutron_server_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ffe62b97_d72c0d9b","line":35,"in_reply_to":"ffe62b97_dd50bcd7","updated":"2017-03-24 09:27:33.000000000","message":"Done","commit_id":"36bb4541909b8f2de230c4106116d750742fb0af"},{"author":{"_account_id":22959,"name":"Zeyu Zhu","email":"zhuzeyu0409@gmail.com","username":"zhuzeyu"},"change_message_id":"1a58c47d54e019b8e64133c8992fed34cb152c29","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% set neutron_server_pip_packages \u003d ["},{"line_number":34,"context_line":"    \u0027oslo.vmware\u0027,"},{"line_number":35,"context_line":"    \u0027vmware-nsx\u0027"},{"line_number":36,"context_line":"] %}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"RUN {{ macros.install_pip(neutron_server_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ffe62b97_5d394c3f","line":35,"in_reply_to":"ffe62b97_dd50bcd7","updated":"2017-03-24 02:57:14.000000000","message":"agree","commit_id":"36bb4541909b8f2de230c4106116d750742fb0af"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d4d6f5b911b1f57e14851ccc1361f599bfa4112","unresolved":false,"context_lines":[{"line_number":35,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_neutron_extend_start"},{"line_number":36,"context_line":"RUN chmod 755 /usr/local/bin/kolla_neutron_extend_start \\"},{"line_number":37,"context_line":"    \u0026\u0026 if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":38,"context_line":"           {{ macros.install_pip(neutron_server_plugins_pip_packages | customizable(\"pip_packages\")) }}; \\"},{"line_number":39,"context_line":"       fi"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{% block neutron_server_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ffe62b97_ba085028","side":"PARENT","line":38,"range":{"start_line":38,"start_character":69,"end_line":38,"end_character":100},"updated":"2017-03-24 09:51:48.000000000","message":"why remove customizable plugins for user?","commit_id":"2cf58e2c122ce024a12718b94b854db0948f5994"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"f2e524d4e8991b9cd2068aaf35539c0f753e70f7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_neutron_extend_start"},{"line_number":36,"context_line":"RUN chmod 755 /usr/local/bin/kolla_neutron_extend_start \\"},{"line_number":37,"context_line":"    \u0026\u0026 if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":38,"context_line":"           {{ macros.install_pip(neutron_server_plugins_pip_packages | customizable(\"pip_packages\")) }}; \\"},{"line_number":39,"context_line":"       fi"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{% block neutron_server_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ffe62b97_4d474c1f","side":"PARENT","line":38,"range":{"start_line":38,"start_character":69,"end_line":38,"end_character":100},"in_reply_to":"ffe62b97_ba085028","updated":"2017-03-24 10:13:51.000000000","message":"I move it to the RUN command above.\nI am not sure whether this should appear in one Dockerfile twice.","commit_id":"2cf58e2c122ce024a12718b94b854db0948f5994"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d4d6f5b911b1f57e14851ccc1361f599bfa4112","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    {% set neutron_server_pip_packages \u003d ["},{"line_number":33,"context_line":"        \u0027oslo.vmware\u0027"},{"line_number":34,"context_line":"    ] %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"RUN {{ macros.install_pip(neutron_server_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ffe62b97_97a32550","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":20},"updated":"2017-03-24 09:51:48.000000000","message":"please, use source code instead of pip package.\nhttps://tarballs.openstack.org/oslo.vmware/\n\nNot sure if this part should be installed in neutron base.","commit_id":"32f3df4b3ef98b488e885ade810fd88ad924aa2d"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"d4a5bba37437c55faff651681a8b7abd93718f91","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    {% set neutron_server_pip_packages \u003d ["},{"line_number":33,"context_line":"        \u0027oslo.vmware\u0027"},{"line_number":34,"context_line":"    ] %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"RUN {{ macros.install_pip(neutron_server_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ffe62b97_6251d9d8","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":20},"in_reply_to":"ffe62b97_97a32550","updated":"2017-03-25 02:09:08.000000000","message":"See patch set 8, Installing oslo.vmware from tarball causes failure.","commit_id":"32f3df4b3ef98b488e885ade810fd88ad924aa2d"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"f2e524d4e8991b9cd2068aaf35539c0f753e70f7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    {% set neutron_server_pip_packages \u003d ["},{"line_number":33,"context_line":"        \u0027oslo.vmware\u0027"},{"line_number":34,"context_line":"    ] %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"RUN {{ macros.install_pip(neutron_server_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ffe62b97_0d74a434","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":20},"in_reply_to":"ffe62b97_97a32550","updated":"2017-03-24 10:13:51.000000000","message":"oslo.vmware is in the upper-constraint file. Installation will fail if you install a tarball using upper-constraint?","commit_id":"32f3df4b3ef98b488e885ade810fd88ad924aa2d"}],"docker/nova/nova-compute/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d4d6f5b911b1f57e14851ccc1361f599bfa4112","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"{% set nova_compute_pip_packages \u003d ["},{"line_number":89,"context_line":"        \u0027libvirt-python\u0027,"},{"line_number":90,"context_line":"        \u0027oslo.vmware\u0027"},{"line_number":91,"context_line":"    ]"},{"line_number":92,"context_line":"%}"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ffe62b97_1a8e1c78","line":90,"range":{"start_line":90,"start_character":9,"end_line":90,"end_character":20},"updated":"2017-03-24 09:51:48.000000000","message":"ditto, use source code","commit_id":"32f3df4b3ef98b488e885ade810fd88ad924aa2d"}]}