)]}'
{"docker/iscsid/Dockerfile.j2":[{"author":{"_account_id":22959,"name":"Zeyu Zhu","email":"zhuzeyu0409@gmail.com","username":"zhuzeyu"},"change_message_id":"6bda9b454153283b9471ed619a35c0e22c45ac45","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":"    {% set iscsid_packages \u003d ["},{"line_number":16,"context_line":"        \u0027open-iscsi\u0027,"},{"line_number":17,"context_line":"    ] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Debian/stretch uses rtslib-fb (like CentOS does)"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ffe62b97_c94a42ab","line":16,"range":{"start_line":16,"start_character":20,"end_line":16,"end_character":21},"updated":"2017-03-30 11:51:52.000000000","message":"remove","commit_id":"d6f9f68d6d705ee5c011100ba7adc17815644fe5"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c03dacb19c49d5181fabaa0cba19872c74be1182","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set iscsid_packages \u003d ["},{"line_number":10,"context_line":"        \u0027iscsi-initiator-utils\u0027,"},{"line_number":11,"context_line":"        \u0027python-rtslib\u0027,"},{"line_number":12,"context_line":"        \u0027targetcli\u0027"},{"line_number":13,"context_line":"    ] %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bff0334d_8aca139e","side":"PARENT","line":11,"updated":"2017-04-12 08:51:30.000000000","message":"We probably need this library for centos.  We don\u0027t have iscsi gating - so it doesn\u0027t pick up this failure.","commit_id":"a130ecb153f555ffd96bebf554eaa10c34a1486d"}],"docker/nova/nova-compute/Dockerfile.j2":[{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"b00769f4ac5b61907670c23d3260569051d2f93d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        ] %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # Debian/stretch uses rtslib-fb (like CentOS does)"},{"line_number":43,"context_line":"        {% if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":44,"context_line":"           {% set nova_compute_packages \u003d nova_compute_packages + ["},{"line_number":45,"context_line":"                \u0027targetcli-fb\u0027"},{"line_number":46,"context_line":"           ] %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bff0334d_763534da","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":40},"updated":"2017-04-06 08:19:27.000000000","message":"This will be never invoked, because it is inside the condition \u0027{% elif base_distro in [\u0027ubuntu\u0027] %}\u0027","commit_id":"d89892f9f4ac823caaa9a6c23573b3738963966d"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"b00769f4ac5b61907670c23d3260569051d2f93d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"           ] %}"},{"line_number":47,"context_line":"        {% elif base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":48,"context_line":"           {% set nova_compute_packages \u003d nova_compute_packages + ["},{"line_number":49,"context_line":"                \u0027targetcli\u0027"},{"line_number":50,"context_line":"           ] %}"},{"line_number":51,"context_line":"        {% endif %}"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bff0334d_162dc894","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":27},"updated":"2017-04-06 08:19:27.000000000","message":"This is already in line 39, so please remove this elif condition from here and add condition only for debian \n\nOR remove this package from the line 39 and preserve this condition here and add debian to the condition in the line 25.","commit_id":"d89892f9f4ac823caaa9a6c23573b3738963966d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c03dacb19c49d5181fabaa0cba19872c74be1182","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \u0027nfs-utils\u0027,"},{"line_number":16,"context_line":"            \u0027openstack-nova-compute\u0027,"},{"line_number":17,"context_line":"            \u0027openvswitch\u0027,"},{"line_number":18,"context_line":"            \u0027python-rtslib\u0027,"},{"line_number":19,"context_line":"            \u0027sysfsutils\u0027,"},{"line_number":20,"context_line":"            \u0027targetcli\u0027,"},{"line_number":21,"context_line":"            \u0027python-oslo-vmware\u0027"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bff0334d_2a71c776","side":"PARENT","line":18,"updated":"2017-04-12 08:51:30.000000000","message":"for centos and variants we need rtslib for iscsi to work correctly.","commit_id":"a130ecb153f555ffd96bebf554eaa10c34a1486d"}]}