)]}'
{"docker/nova/nova-compute-ironic/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d00fb5c3e8443c63f1d0a337968c2a9cac827b95","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set nova_compute_ironic_packages  \u003d ["},{"line_number":10,"context_line":"            \u0027genisoimage\u0027"},{"line_number":11,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_b1a6ed52","line":8,"updated":"2017-04-26 03:29:31.000000000","message":"this doesn\u0027t look correct.  Should add to  the specific binary or source section.  It may be needed in both.","commit_id":"af55e5282f13a1f73c1b8e04ee47963131f1105e"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"a71fb7031611d0f1e0ca552fb51859d694a71f34","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set nova_compute_ironic_packages  \u003d ["},{"line_number":10,"context_line":"            \u0027genisoimage\u0027"},{"line_number":11,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_362f65f7","line":8,"in_reply_to":"5ff73747_398e432e","updated":"2017-04-26 12:14:55.000000000","message":"These bits are required for both source and binary, so the logic here is very simple, just need to follow it.\n1. Check distro type and install these bits (Since it is need in both source and binary no other check is needed)\n2. Check for installation type and install type depended packages.\n\nMake sense, no?","commit_id":"af55e5282f13a1f73c1b8e04ee47963131f1105e"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"00b4d6a18403bb174c692e8fd81f72c36a24ae30","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set nova_compute_ironic_packages  \u003d ["},{"line_number":10,"context_line":"            \u0027genisoimage\u0027"},{"line_number":11,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_398e432e","line":8,"in_reply_to":"5ff73747_b1a6ed52","updated":"2017-04-26 04:01:39.000000000","message":"agree, this change should be move after line 22","commit_id":"af55e5282f13a1f73c1b8e04ee47963131f1105e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"829f3347e0c56119bfbd10f9d2d45025c93b8b3c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \u0027nova-compute\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN rm /etc/nova/nova-compute.conf"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    {% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5ff73747_67f1b4cd","line":23,"updated":"2017-04-26 13:42:28.000000000","message":"macro at line 23 cannot be removed because this nova-compute.conf depends on it","commit_id":"7dc8c4b87d7f2e6372ef6851eb0a44e789ee64ec"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"829f3347e0c56119bfbd10f9d2d45025c93b8b3c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"         ] %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    {% endif %}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{% endif %}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"{{ macros.install_packages(nova_compute_ironic_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5ff73747_87cba070","line":40,"updated":"2017-04-26 13:42:28.000000000","message":"since the other macro will be applied to binary install, please move macro at line 43 here","commit_id":"7dc8c4b87d7f2e6372ef6851eb0a44e789ee64ec"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"81a6a23f8ddb0172dc228422ebb695af7fd7ffd0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \u0027genisoimage\u0027,"},{"line_number":13,"context_line":"            \u0027openstack-nova-compute\u0027"},{"line_number":14,"context_line":"        ] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        {% set nova_compute_ironic_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_8dc73f46","line":15,"updated":"2017-04-26 14:36:08.000000000","message":"You forgot to install packages under RPM distros.","commit_id":"a6a0d948c0ee1b9ca207ed3b54fe9604b803e751"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"81a6a23f8ddb0172dc228422ebb695af7fd7ffd0","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN rm /etc/nova/nova-compute.conf"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ macros.install_packages(nova_compute_ironic_packages | customizable(\"packages\")) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    {% endif %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_ada31b9e","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":26},"updated":"2017-04-26 14:36:08.000000000","message":"First install then remove file.","commit_id":"a6a0d948c0ee1b9ca207ed3b54fe9604b803e751"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2c58d22e6ded14dec2aede31d59c52ef216bd415","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN rm /etc/nova/nova-compute.conf"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ macros.install_packages(nova_compute_ironic_packages | customizable(\"packages\")) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    {% endif %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_ad7e7b16","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":86},"updated":"2017-04-26 14:34:46.000000000","message":"packages should be installed before doing rm file.\nOtherwise nova-compute package adds the file and not being removed.","commit_id":"a6a0d948c0ee1b9ca207ed3b54fe9604b803e751"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2c58d22e6ded14dec2aede31d59c52ef216bd415","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% endif %}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block nova_compute_ironic_footer %}{% endblock %}"},{"line_number":49,"context_line":"{% block footer %}{% endblock %}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_ed99236e","line":47,"updated":"2017-04-26 14:34:46.000000000","message":"please, remove empty line","commit_id":"a6a0d948c0ee1b9ca207ed3b54fe9604b803e751"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"81a6a23f8ddb0172dc228422ebb695af7fd7ffd0","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% endif %}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block nova_compute_ironic_footer %}{% endblock %}"},{"line_number":49,"context_line":"{% block footer %}{% endblock %}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_4dd6d7f3","line":47,"updated":"2017-04-26 14:36:08.000000000","message":"remove that empty line","commit_id":"a6a0d948c0ee1b9ca207ed3b54fe9604b803e751"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"23bab4c78b29d7f9bf7139b912034ef021df96e9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block nova_compute_ironic_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5ff73747_0dc20fea","line":7,"updated":"2017-04-26 14:42:14.000000000","message":"Does it makes sense to simply initialise the nova_compute_ironic_packages variable with genisoimage here and to append the additional packages in the next lines? This way we could avoid to add genisoimage 4 times.","commit_id":"4a2dc346a2574db51bed8c50a763d66dc1ed4bbf"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"a4e20b902c9d540f1eb68dad7e43a618b61e33d8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block nova_compute_ironic_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5ff73747_76f5e482","line":7,"in_reply_to":"5ff73747_0dc20fea","updated":"2017-04-26 15:31:41.000000000","message":"yeah I think this is good idea.","commit_id":"4a2dc346a2574db51bed8c50a763d66dc1ed4bbf"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"94c2f1a4c49a02e50b691cbc446d58e47e49225c","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027  %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{ macros.install_packages(nova_compute_ironic_packages | customizable(\"packages\")) }}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5ff73747_e1412c0d","line":31,"updated":"2017-04-26 15:44:49.000000000","message":"remove this if block and move macro from :23 outside if block","commit_id":"5993eda184102d739c6e9bb68ef1d998d878328a"}]}