)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-04-26 10:28:18 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add skydive service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iab783179c2c3aba496a91debfd38a12215ae9f10"},{"line_number":10,"context_line":"Implements: skydive-service"},{"line_number":11,"context_line":"Co-Authored-By: Nicolas Bouron \u003cnicolas.bouron@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_45deb911","line":8,"updated":"2017-04-26 10:47:31.000000000","message":"Please, add empty line and brief description of the change","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-04-26 10:28:18 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add skydive service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iab783179c2c3aba496a91debfd38a12215ae9f10"},{"line_number":10,"context_line":"Implements: skydive-service"},{"line_number":11,"context_line":"Co-Authored-By: Nicolas Bouron \u003cnicolas.bouron@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_f090ce45","line":8,"in_reply_to":"5ff73747_45deb911","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add skydive service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iab783179c2c3aba496a91debfd38a12215ae9f10"},{"line_number":10,"context_line":"Implements: skydive-service"},{"line_number":11,"context_line":"Co-Authored-By: Nicolas Bouron \u003cnicolas.bouron@gmail.com\u003e"},{"line_number":12,"context_line":"Sign-off-by: Mathieu Rohon \u003cmathieu.rohon@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_e5b5c5ce","line":10,"updated":"2017-04-26 10:47:31.000000000","message":"please add blueprint \u003cblueprint_name\u003e","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add skydive service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iab783179c2c3aba496a91debfd38a12215ae9f10"},{"line_number":10,"context_line":"Implements: skydive-service"},{"line_number":11,"context_line":"Co-Authored-By: Nicolas Bouron \u003cnicolas.bouron@gmail.com\u003e"},{"line_number":12,"context_line":"Sign-off-by: Mathieu Rohon \u003cmathieu.rohon@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_d095d234","line":10,"in_reply_to":"5ff73747_e5b5c5ce","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"}],"docker/skydive/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027)}}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tRUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive-binaries/raw/travis-builds/skydive-latest\" \\"},{"line_number":13,"context_line":"\t\t\u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_e5038572","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":1},"updated":"2017-04-26 10:47:31.000000000","message":"align RUNs to left","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tRUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive-binaries/raw/travis-builds/skydive-latest\" \\"},{"line_number":13,"context_line":"\t\t\u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_c5d1a9fd","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"updated":"2017-04-26 10:47:31.000000000","message":"weird tabs created by your IDE, remove those chars on all the file","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tRUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive-binaries/raw/travis-builds/skydive-latest\" \\"},{"line_number":13,"context_line":"\t\t\u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_cd7f79de","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"in_reply_to":"5ff73747_c5d1a9fd","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027)}}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tRUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive-binaries/raw/travis-builds/skydive-latest\" \\"},{"line_number":13,"context_line":"\t\t\u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_8d85f1d1","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":1},"in_reply_to":"5ff73747_e5038572","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\t{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\t\t{% set skydive_base_packages \u003d ["},{"line_number":20,"context_line":"\t\t  \u0027git\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_c5fac973","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":1},"updated":"2017-04-26 10:47:31.000000000","message":"use only 4 spaces for tabs","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\t{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\t\t{% set skydive_base_packages \u003d ["},{"line_number":20,"context_line":"\t\t  \u0027git\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_8dd3b1d5","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":1},"in_reply_to":"5ff73747_c5fac973","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\t{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\t\t{% set skydive_base_packages \u003d ["},{"line_number":20,"context_line":"\t\t  \u0027git\u0027,"},{"line_number":21,"context_line":"\t\t  \u0027make\u0027,"},{"line_number":22,"context_line":"\t\t  \u0027go\u0027,"},{"line_number":23,"context_line":"\t\t  \u0027libpcap-devel\u0027,"},{"line_number":24,"context_line":"\t\t  \u0027libxml2-devel\u0027,"},{"line_number":25,"context_line":"\t\t  \u0027wget\u0027,"},{"line_number":26,"context_line":"\t\t  \u0027unzip\u0027"},{"line_number":27,"context_line":"\t\t] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\t\t{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_05367153","line":26,"range":{"start_line":20,"start_character":4,"end_line":26,"end_character":11},"updated":"2017-04-26 10:47:31.000000000","message":"sort alphabetically packages","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\t{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\t\t{% set skydive_base_packages \u003d ["},{"line_number":20,"context_line":"\t\t  \u0027git\u0027,"},{"line_number":21,"context_line":"\t\t  \u0027make\u0027,"},{"line_number":22,"context_line":"\t\t  \u0027go\u0027,"},{"line_number":23,"context_line":"\t\t  \u0027libpcap-devel\u0027,"},{"line_number":24,"context_line":"\t\t  \u0027libxml2-devel\u0027,"},{"line_number":25,"context_line":"\t\t  \u0027wget\u0027,"},{"line_number":26,"context_line":"\t\t  \u0027unzip\u0027"},{"line_number":27,"context_line":"\t\t] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\t\t{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_6ddce5e3","line":26,"range":{"start_line":20,"start_character":4,"end_line":26,"end_character":11},"in_reply_to":"5ff73747_05367153","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\t\t{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"\t{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\t\t {% set skydive_base_packages \u003d ["},{"line_number":34,"context_line":"\t\t   \u0027git\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_452c7901","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":33},"updated":"2017-04-26 10:47:31.000000000","message":"first debian to be alphabetically shorted","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\t\t{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"\t{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\t\t {% set skydive_base_packages \u003d ["},{"line_number":34,"context_line":"\t\t   \u0027git\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_cdf65964","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":33},"in_reply_to":"5ff73747_452c7901","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\t{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\t\t {% set skydive_base_packages \u003d ["},{"line_number":34,"context_line":"\t\t   \u0027git\u0027,"},{"line_number":35,"context_line":"\t\t   \u0027curl\u0027,"},{"line_number":36,"context_line":"\t\t   \u0027gcc\u0027,"},{"line_number":37,"context_line":"\t\t   \u0027make\u0027,"},{"line_number":38,"context_line":"\t\t   \u0027libpcap-dev\u0027,"},{"line_number":39,"context_line":"\t\t   \u0027libxml2-dev\u0027,"},{"line_number":40,"context_line":"\t\t   \u0027wget\u0027,"},{"line_number":41,"context_line":"\t\t   \u0027pkg-config\u0027,"},{"line_number":42,"context_line":"\t\t   \u0027unzip\u0027"},{"line_number":43,"context_line":"\t\t] %}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\t\t{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_a53a1d31","line":42,"range":{"start_line":34,"start_character":0,"end_line":42,"end_character":12},"updated":"2017-04-26 10:47:31.000000000","message":"ditto for sorted packages","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\t{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\t\t {% set skydive_base_packages \u003d ["},{"line_number":34,"context_line":"\t\t   \u0027git\u0027,"},{"line_number":35,"context_line":"\t\t   \u0027curl\u0027,"},{"line_number":36,"context_line":"\t\t   \u0027gcc\u0027,"},{"line_number":37,"context_line":"\t\t   \u0027make\u0027,"},{"line_number":38,"context_line":"\t\t   \u0027libpcap-dev\u0027,"},{"line_number":39,"context_line":"\t\t   \u0027libxml2-dev\u0027,"},{"line_number":40,"context_line":"\t\t   \u0027wget\u0027,"},{"line_number":41,"context_line":"\t\t   \u0027pkg-config\u0027,"},{"line_number":42,"context_line":"\t\t   \u0027unzip\u0027"},{"line_number":43,"context_line":"\t\t] %}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\t\t{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_8da17149","line":42,"range":{"start_line":34,"start_character":0,"end_line":42,"end_character":12},"in_reply_to":"5ff73747_a53a1d31","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\t\t{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"\t\tRUN cd /tmp \\"},{"line_number":48,"context_line":"\t\t\t\u0026\u0026 curl -O https://storage.googleapis.com/golang/go1.7.4.linux-amd64.tar.gz \\"},{"line_number":49,"context_line":"\t\t\t\u0026\u0026 tar xvzf go1.7.4.linux-amd64.tar.gz \\"},{"line_number":50,"context_line":"\t\t\t\u0026\u0026 chown -R root:root ./go \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_654415b8","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":2},"updated":"2017-04-26 10:47:31.000000000","message":"align to left","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\t\t{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"\t\tRUN cd /tmp \\"},{"line_number":48,"context_line":"\t\t\t\u0026\u0026 curl -O https://storage.googleapis.com/golang/go1.7.4.linux-amd64.tar.gz \\"},{"line_number":49,"context_line":"\t\t\t\u0026\u0026 tar xvzf go1.7.4.linux-amd64.tar.gz \\"},{"line_number":50,"context_line":"\t\t\t\u0026\u0026 chown -R root:root ./go \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_edbfd55e","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":2},"in_reply_to":"5ff73747_654415b8","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\t{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"\tRUN cd /tmp \\"},{"line_number":56,"context_line":"\t\t\u0026\u0026 wget https://github.com/google/protobuf/releases/download/v3.0.0/protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":57,"context_line":"\t\t\u0026\u0026 unzip -d ./protoc3.0.0 protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":58,"context_line":"\t\t\u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_852281ff","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":1},"updated":"2017-04-26 10:47:31.000000000","message":"ditto","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\t{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"\tRUN cd /tmp \\"},{"line_number":56,"context_line":"\t\t\u0026\u0026 wget https://github.com/google/protobuf/releases/download/v3.0.0/protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":57,"context_line":"\t\t\u0026\u0026 unzip -d ./protoc3.0.0 protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":58,"context_line":"\t\t\u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_6d618505","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":1},"in_reply_to":"5ff73747_852281ff","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"\t\t\u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"},{"line_number":59,"context_line":"\t\t\u0026\u0026 chmod 755 /usr/bin/protoc"},{"line_number":60,"context_line":"\tRUN mkdir -p /tmp/go/src/github.com/"},{"line_number":61,"context_line":"\tRUN mkdir /tmp/go/bin"},{"line_number":62,"context_line":"\tADD skydive-archive /tmp/go/src/github.com/skydive-project"},{"line_number":63,"context_line":"\tRUN cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":64,"context_line":"\t\t\u0026\u0026 mv skydive-archive-* skydive \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_e55f0570","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":22},"updated":"2017-04-26 10:47:31.000000000","message":"please, merge this mkdir with previous run.\nI\u0027d say that both runs can be merged with previous one","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":58,"context_line":"\t\t\u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"},{"line_number":59,"context_line":"\t\t\u0026\u0026 chmod 755 /usr/bin/protoc"},{"line_number":60,"context_line":"\tRUN mkdir -p /tmp/go/src/github.com/"},{"line_number":61,"context_line":"\tRUN mkdir /tmp/go/bin"},{"line_number":62,"context_line":"\tADD skydive-archive /tmp/go/src/github.com/skydive-project"},{"line_number":63,"context_line":"\tRUN cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":64,"context_line":"\t\t\u0026\u0026 mv skydive-archive-* skydive \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_8d3df1de","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":22},"in_reply_to":"5ff73747_e55f0570","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\t\t\u0026\u0026 unzip -d ./protoc3.0.0 protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":58,"context_line":"\t\t\u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"},{"line_number":59,"context_line":"\t\t\u0026\u0026 chmod 755 /usr/bin/protoc"},{"line_number":60,"context_line":"\tRUN mkdir -p /tmp/go/src/github.com/"},{"line_number":61,"context_line":"\tRUN mkdir /tmp/go/bin"},{"line_number":62,"context_line":"\tADD skydive-archive /tmp/go/src/github.com/skydive-project"},{"line_number":63,"context_line":"\tRUN cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":64,"context_line":"\t\t\u0026\u0026 mv skydive-archive-* skydive \\"},{"line_number":65,"context_line":"\t\t\u0026\u0026 cd skydive \\"},{"line_number":66,"context_line":"\t\t\u0026\u0026 export GOPATH\u003d/tmp/go \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_e586e5db","line":63,"range":{"start_line":60,"start_character":0,"end_line":63,"end_character":1},"updated":"2017-04-26 10:47:31.000000000","message":"ditto","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\t\t\u0026\u0026 unzip -d ./protoc3.0.0 protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":58,"context_line":"\t\t\u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"},{"line_number":59,"context_line":"\t\t\u0026\u0026 chmod 755 /usr/bin/protoc"},{"line_number":60,"context_line":"\tRUN mkdir -p /tmp/go/src/github.com/"},{"line_number":61,"context_line":"\tRUN mkdir /tmp/go/bin"},{"line_number":62,"context_line":"\tADD skydive-archive /tmp/go/src/github.com/skydive-project"},{"line_number":63,"context_line":"\tRUN cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":64,"context_line":"\t\t\u0026\u0026 mv skydive-archive-* skydive \\"},{"line_number":65,"context_line":"\t\t\u0026\u0026 cd skydive \\"},{"line_number":66,"context_line":"\t\t\u0026\u0026 export GOPATH\u003d/tmp/go \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_2d05bd14","line":63,"range":{"start_line":60,"start_character":0,"end_line":63,"end_character":1},"in_reply_to":"5ff73747_e586e5db","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"\tRUN cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":64,"context_line":"\t\t\u0026\u0026 mv skydive-archive-* skydive \\"},{"line_number":65,"context_line":"\t\t\u0026\u0026 cd skydive \\"},{"line_number":66,"context_line":"\t\t\u0026\u0026 export GOPATH\u003d/tmp/go \\"},{"line_number":67,"context_line":"\t\t\u0026\u0026 export GOBIN\u003d$GOPATH/bin \\"},{"line_number":68,"context_line":"\t\t\u0026\u0026 export PATH\u003d$PATH:$GOPATH:$GOBIN:/usr/local/go/bin \\"},{"line_number":69,"context_line":"\t\t\u0026\u0026 make install"},{"line_number":70,"context_line":"\tRUN cp /tmp/go/bin/skydive /usr/bin/  \\"},{"line_number":71,"context_line":"\t\t\u0026\u0026 chmod 755 /usr/bin/skydive"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_25f4cd5a","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":57},"updated":"2017-04-26 10:47:31.000000000","message":"will be this exports needed when skydive is running, if so, please use Docker exports to set globally","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":63,"context_line":"\tRUN cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":64,"context_line":"\t\t\u0026\u0026 mv skydive-archive-* skydive \\"},{"line_number":65,"context_line":"\t\t\u0026\u0026 cd skydive \\"},{"line_number":66,"context_line":"\t\t\u0026\u0026 export GOPATH\u003d/tmp/go \\"},{"line_number":67,"context_line":"\t\t\u0026\u0026 export GOBIN\u003d$GOPATH/bin \\"},{"line_number":68,"context_line":"\t\t\u0026\u0026 export PATH\u003d$PATH:$GOPATH:$GOBIN:/usr/local/go/bin \\"},{"line_number":69,"context_line":"\t\t\u0026\u0026 make install"},{"line_number":70,"context_line":"\tRUN cp /tmp/go/bin/skydive /usr/bin/  \\"},{"line_number":71,"context_line":"\t\t\u0026\u0026 chmod 755 /usr/bin/skydive"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_d0539216","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":57},"in_reply_to":"5ff73747_25f4cd5a","updated":"2017-04-26 21:00:01.000000000","message":"no this will only be needed for the build of skydive. It is not needed for the run of the skydive binary.","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"\t\t\u0026\u0026 export GOBIN\u003d$GOPATH/bin \\"},{"line_number":68,"context_line":"\t\t\u0026\u0026 export PATH\u003d$PATH:$GOPATH:$GOBIN:/usr/local/go/bin \\"},{"line_number":69,"context_line":"\t\t\u0026\u0026 make install"},{"line_number":70,"context_line":"\tRUN cp /tmp/go/bin/skydive /usr/bin/  \\"},{"line_number":71,"context_line":"\t\t\u0026\u0026 chmod 755 /usr/bin/skydive"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"{% endif %}"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_05a0b142","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":31},"updated":"2017-04-26 10:47:31.000000000","message":"this RUN can be merged with previous one to avoid unnecessary image layers","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":67,"context_line":"\t\t\u0026\u0026 export GOBIN\u003d$GOPATH/bin \\"},{"line_number":68,"context_line":"\t\t\u0026\u0026 export PATH\u003d$PATH:$GOPATH:$GOBIN:/usr/local/go/bin \\"},{"line_number":69,"context_line":"\t\t\u0026\u0026 make install"},{"line_number":70,"context_line":"\tRUN cp /tmp/go/bin/skydive /usr/bin/  \\"},{"line_number":71,"context_line":"\t\t\u0026\u0026 chmod 755 /usr/bin/skydive"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"{% endif %}"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_70defe6d","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":31},"in_reply_to":"5ff73747_05a0b142","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a43be32b6ceda2da97055d8bf90892de337c45f5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"{% block skydive_footer %}{% endblock %}"},{"line_number":76,"context_line":"{% block footer %}{% endblock %}"},{"line_number":77,"context_line":"{{ include_footer }}"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_a5ad7d32","line":78,"updated":"2017-04-26 10:47:31.000000000","message":"pleae, remove empty line","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e3cf3a64357b766960f24fee04ac7a770f9694ee","unresolved":false,"context_lines":[{"line_number":75,"context_line":"{% block skydive_footer %}{% endblock %}"},{"line_number":76,"context_line":"{% block footer %}{% endblock %}"},{"line_number":77,"context_line":"{{ include_footer }}"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_90ce2ab2","line":78,"in_reply_to":"5ff73747_a5ad7d32","updated":"2017-04-26 21:00:01.000000000","message":"Done","commit_id":"f0546b7c82f8167b223a0160d41a669d40233033"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b43857dc2d2988e596476d9b971419a2163ad0c1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        {{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"RUN cd /tmp \\"},{"line_number":48,"context_line":"    \u0026\u0026 curl -O https://storage.googleapis.com/golang/go1.7.4.linux-amd64.tar.gz \\"},{"line_number":49,"context_line":"    \u0026\u0026 tar xvzf go1.7.4.linux-amd64.tar.gz \\"},{"line_number":50,"context_line":"    \u0026\u0026 chown -R root:root ./go \\"},{"line_number":51,"context_line":"    \u0026\u0026 mv ./go /usr/local/"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_3352c0df","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":11},"updated":"2017-04-26 21:24:06.000000000","message":"why not download with wget instead of curl? wget is being installed in previous tasks.\nAlso wget can handle packet drops and network issues","commit_id":"4ecbd169dfe44e7aa48485d02e26e18d5c00b75e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b43857dc2d2988e596476d9b971419a2163ad0c1","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        {{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"RUN cd /tmp \\"},{"line_number":48,"context_line":"    \u0026\u0026 curl -O https://storage.googleapis.com/golang/go1.7.4.linux-amd64.tar.gz \\"},{"line_number":49,"context_line":"    \u0026\u0026 tar xvzf go1.7.4.linux-amd64.tar.gz \\"},{"line_number":50,"context_line":"    \u0026\u0026 chown -R root:root ./go \\"},{"line_number":51,"context_line":"    \u0026\u0026 mv ./go /usr/local/"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_5349cc2e","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":11},"updated":"2017-04-26 21:24:06.000000000","message":"wondering if can use absolute paths;\nRUN curl -L \u003curl\u003e -o \u003cpath\u003e/\u003cname\u003e \\\n\u0026\u0026 tar xvzf \u003cpath\u003e/\u003cname\u003e\n...","commit_id":"4ecbd169dfe44e7aa48485d02e26e18d5c00b75e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b43857dc2d2988e596476d9b971419a2163ad0c1","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    {% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"RUN cd /tmp \\"},{"line_number":56,"context_line":"    \u0026\u0026 wget https://github.com/google/protobuf/releases/download/v3.0.0/protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":57,"context_line":"    \u0026\u0026 unzip -d ./protoc3.0.0 protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":58,"context_line":"    \u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_d366fcc1","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":13},"updated":"2017-04-26 21:24:06.000000000","message":"ditto","commit_id":"4ecbd169dfe44e7aa48485d02e26e18d5c00b75e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b43857dc2d2988e596476d9b971419a2163ad0c1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"},{"line_number":59,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/protoc \\"},{"line_number":60,"context_line":"    \u0026\u0026 mkdir -p /tmp/go/src/github.com/ \\"},{"line_number":61,"context_line":"    \u0026\u0026 mkdir /tmp/go/bin"},{"line_number":62,"context_line":"ADD skydive-archive /tmp/go/src/github.com/skydive-project"},{"line_number":63,"context_line":"RUN cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":64,"context_line":"    \u0026\u0026 mv skydive-archive-* skydive \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_336be085","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":24},"updated":"2017-04-26 21:24:06.000000000","message":"please, merge this mkdir with previous one:\nmkdir -p \u003cpath1\u003e \u003cpath2\u003e","commit_id":"4ecbd169dfe44e7aa48485d02e26e18d5c00b75e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b43857dc2d2988e596476d9b971419a2163ad0c1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/protoc \\"},{"line_number":60,"context_line":"    \u0026\u0026 mkdir -p /tmp/go/src/github.com/ \\"},{"line_number":61,"context_line":"    \u0026\u0026 mkdir /tmp/go/bin"},{"line_number":62,"context_line":"ADD skydive-archive /tmp/go/src/github.com/skydive-project"},{"line_number":63,"context_line":"RUN cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":64,"context_line":"    \u0026\u0026 mv skydive-archive-* skydive \\"},{"line_number":65,"context_line":"    \u0026\u0026 cd skydive \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_f30698ce","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":58},"updated":"2017-04-26 21:24:06.000000000","message":"we usually add source archives to /skydive\nhttps://github.com/openstack/kolla/blob/master/docker/senlin/senlin-base/Dockerfile.j2#L17","commit_id":"4ecbd169dfe44e7aa48485d02e26e18d5c00b75e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b43857dc2d2988e596476d9b971419a2163ad0c1","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% block skydive_footer %}{% endblock %}"},{"line_number":76,"context_line":"{% block footer %}{% endblock %}"},{"line_number":77,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5ff73747_73fa88bd","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":20},"updated":"2017-04-26 21:24:06.000000000","message":"this footers are deprecaded and not being used anymore","commit_id":"4ecbd169dfe44e7aa48485d02e26e18d5c00b75e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f471576b8c35644c471742a44dfea93deb9260f5","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027)}}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5ff73747_190188b0","line":8,"range":{"start_line":8,"start_character":40,"end_line":8,"end_character":42},"updated":"2017-05-03 08:13:02.000000000","message":"please, add space before","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"304271279696e9ad0908a6b9e081ba99f7315ea6","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027)}}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f044301_819bca70","line":8,"range":{"start_line":8,"start_character":40,"end_line":8,"end_character":42},"in_reply_to":"5ff73747_190188b0","updated":"2017-05-05 07:40:42.000000000","message":"Done","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f471576b8c35644c471742a44dfea93deb9260f5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        {{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"RUN cd /tmp \\"},{"line_number":47,"context_line":"    \u0026\u0026 wget https://storage.googleapis.com/golang/go1.7.4.linux-amd64.tar.gz \\"},{"line_number":48,"context_line":"    \u0026\u0026 tar xvzf go1.7.4.linux-amd64.tar.gz \\"},{"line_number":49,"context_line":"    \u0026\u0026 chown -R root:root ./go \\"},{"line_number":50,"context_line":"    \u0026\u0026 mv ./go /usr/local/"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5ff73747_39cb2473","line":47,"range":{"start_line":47,"start_character":7,"end_line":47,"end_character":76},"updated":"2017-05-03 08:13:02.000000000","message":"please, use -P \u003cdirectory\u003e or -o \u003cdirectory\u003e/\u003cfile_name\u003e to download in a specific path.\nThis will remove cd /tmp/","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e4d7cb3025cd58790b1cc997c400b02f47bd8abc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        {{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"RUN cd /tmp \\"},{"line_number":47,"context_line":"    \u0026\u0026 wget https://storage.googleapis.com/golang/go1.7.4.linux-amd64.tar.gz \\"},{"line_number":48,"context_line":"    \u0026\u0026 tar xvzf go1.7.4.linux-amd64.tar.gz \\"},{"line_number":49,"context_line":"    \u0026\u0026 chown -R root:root ./go \\"},{"line_number":50,"context_line":"    \u0026\u0026 mv ./go /usr/local/"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f044301_4d629040","line":47,"range":{"start_line":47,"start_character":7,"end_line":47,"end_character":76},"in_reply_to":"5ff73747_39cb2473","updated":"2017-05-05 12:38:04.000000000","message":"deprecated since we\u0027ll use the same build process as the one used for binary install type","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f471576b8c35644c471742a44dfea93deb9260f5","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"RUN cd /tmp \\"},{"line_number":47,"context_line":"    \u0026\u0026 wget https://storage.googleapis.com/golang/go1.7.4.linux-amd64.tar.gz \\"},{"line_number":48,"context_line":"    \u0026\u0026 tar xvzf go1.7.4.linux-amd64.tar.gz \\"},{"line_number":49,"context_line":"    \u0026\u0026 chown -R root:root ./go \\"},{"line_number":50,"context_line":"    \u0026\u0026 mv ./go /usr/local/"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    {% endif %}"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5ff73747_f9993c79","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":26},"updated":"2017-05-03 08:13:02.000000000","message":"please, use absolute paths while removing cd /tmp","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e4d7cb3025cd58790b1cc997c400b02f47bd8abc","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"RUN cd /tmp \\"},{"line_number":47,"context_line":"    \u0026\u0026 wget https://storage.googleapis.com/golang/go1.7.4.linux-amd64.tar.gz \\"},{"line_number":48,"context_line":"    \u0026\u0026 tar xvzf go1.7.4.linux-amd64.tar.gz \\"},{"line_number":49,"context_line":"    \u0026\u0026 chown -R root:root ./go \\"},{"line_number":50,"context_line":"    \u0026\u0026 mv ./go /usr/local/"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    {% endif %}"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f044301_2d674450","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":26},"in_reply_to":"5ff73747_f9993c79","updated":"2017-05-05 12:38:04.000000000","message":"ditto","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f471576b8c35644c471742a44dfea93deb9260f5","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    {% endif %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"RUN cd /tmp \\"},{"line_number":55,"context_line":"    \u0026\u0026 wget https://github.com/google/protobuf/releases/download/v3.0.0/protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":56,"context_line":"    \u0026\u0026 unzip -d ./protoc3.0.0 protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":57,"context_line":"    \u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5ff73747_d98d602b","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":13},"updated":"2017-05-03 08:13:02.000000000","message":"same comments with absolute paths and wget -o \u003cdirectory\u003e","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e4d7cb3025cd58790b1cc997c400b02f47bd8abc","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    {% endif %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"RUN cd /tmp \\"},{"line_number":55,"context_line":"    \u0026\u0026 wget https://github.com/google/protobuf/releases/download/v3.0.0/protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":56,"context_line":"    \u0026\u0026 unzip -d ./protoc3.0.0 protoc-3.0.0-linux-x86_64.zip \\"},{"line_number":57,"context_line":"    \u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f044301_0d5c887c","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":13},"in_reply_to":"5ff73747_d98d602b","updated":"2017-05-05 12:38:04.000000000","message":"ditto","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f471576b8c35644c471742a44dfea93deb9260f5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"},{"line_number":58,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/protoc \\"},{"line_number":59,"context_line":"    \u0026\u0026 mkdir -p /tmp/go/src/github.com/ /tmp/go/bin"},{"line_number":60,"context_line":"ADD skydive-archive /tmp/go/src/github.com/skydive-project"},{"line_number":61,"context_line":"RUN ln -s /tmp/go/src/github.com/skydive-project /skydive \\"},{"line_number":62,"context_line":"    \u0026\u0026 cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":63,"context_line":"    \u0026\u0026 mv skydive-archive-* skydive \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5ff73747_799c0c5d","line":60,"updated":"2017-05-03 08:13:02.000000000","message":"please, add an empty line between","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"304271279696e9ad0908a6b9e081ba99f7315ea6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"},{"line_number":58,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/protoc \\"},{"line_number":59,"context_line":"    \u0026\u0026 mkdir -p /tmp/go/src/github.com/ /tmp/go/bin"},{"line_number":60,"context_line":"ADD skydive-archive /tmp/go/src/github.com/skydive-project"},{"line_number":61,"context_line":"RUN ln -s /tmp/go/src/github.com/skydive-project /skydive \\"},{"line_number":62,"context_line":"    \u0026\u0026 cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":63,"context_line":"    \u0026\u0026 mv skydive-archive-* skydive \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f044301_81a98a7c","line":60,"in_reply_to":"5ff73747_799c0c5d","updated":"2017-05-05 07:40:42.000000000","message":"Done","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e4d7cb3025cd58790b1cc997c400b02f47bd8abc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0026\u0026 cp -p ./protoc3.0.0/bin/protoc /usr/bin/ \\"},{"line_number":58,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/protoc \\"},{"line_number":59,"context_line":"    \u0026\u0026 mkdir -p /tmp/go/src/github.com/ /tmp/go/bin"},{"line_number":60,"context_line":"ADD skydive-archive /tmp/go/src/github.com/skydive-project"},{"line_number":61,"context_line":"RUN ln -s /tmp/go/src/github.com/skydive-project /skydive \\"},{"line_number":62,"context_line":"    \u0026\u0026 cd /tmp/go/src/github.com/skydive-project \\"},{"line_number":63,"context_line":"    \u0026\u0026 mv skydive-archive-* skydive \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f044301_ed603c35","line":60,"in_reply_to":"5ff73747_799c0c5d","updated":"2017-05-05 12:38:04.000000000","message":"ditto","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5562b642f94d79987678f12e15c9e08b21104459","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.11.0/skydive\" \\"},{"line_number":11,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% block skydive_footer %}{% endblock %}"},{"line_number":14,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1f013ff3_20764908","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":32},"updated":"2017-05-15 13:00:02.000000000","message":"add \"if base_arch \u003d\u003d x86_64\" \n\na way to build from source for other architectures would be nice","commit_id":"f8c4e28e14443c47176561d35d5b403b1ac15998"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"209155995a98e67c4e0af6e62be56954fde9763a","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.11.0/skydive\" \\"},{"line_number":11,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% block skydive_footer %}{% endblock %}"},{"line_number":14,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1f013ff3_8b4c07c8","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":32},"in_reply_to":"1f013ff3_20764908","updated":"2017-05-16 07:11:43.000000000","message":"I\u0027ll ask the skydive team if they plan to release binaries for other architectures. The alternative wound be aarch64?","commit_id":"f8c4e28e14443c47176561d35d5b403b1ac15998"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a7868d0c206107665e58d2a3504a55b34615231","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block skydive_header %}{% endblock %}"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1f013ff3_daa2d69a","line":2,"updated":"2017-05-16 08:26:28.000000000","message":"missing some labels https://github.com/openstack/kolla/blob/master/docker/heat/heat-api/Dockerfile.j2#L2","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"5774c84579231a27935d8fd14cb089888a27132e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block skydive_header %}{% endblock %}"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ff0f0b1f_894c4577","line":2,"in_reply_to":"1f013ff3_daa2d69a","updated":"2017-05-17 15:45:45.000000000","message":"Done","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a7868d0c206107665e58d2a3504a55b34615231","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":11,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.11.0/skydive\" \\"},{"line_number":12,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1f013ff3_9a77ae3b","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":18},"updated":"2017-05-16 08:26:28.000000000","message":"guess wrong operator, this is for x86_64.","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"5774c84579231a27935d8fd14cb089888a27132e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":11,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.11.0/skydive\" \\"},{"line_number":12,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ff0f0b1f_8927a5b7","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":18},"in_reply_to":"1f013ff3_9a77ae3b","updated":"2017-05-17 15:45:45.000000000","message":"oops","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a7868d0c206107665e58d2a3504a55b34615231","unresolved":false,"context_lines":[{"line_number":11,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.11.0/skydive\" \\"},{"line_number":12,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% block skydive_footer %}{% endblock %}"},{"line_number":16,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1f013ff3_5adda612","line":14,"updated":"2017-05-16 08:26:28.000000000","message":"what user runs skydive? root? if not please add:\nUSER skydive at the end of the file","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"5774c84579231a27935d8fd14cb089888a27132e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.11.0/skydive\" \\"},{"line_number":12,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% block skydive_footer %}{% endblock %}"},{"line_number":16,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ff0f0b1f_1a975293","line":14,"in_reply_to":"1f013ff3_5adda612","updated":"2017-05-17 15:45:45.000000000","message":"the analyzer can be run with the skydive user. Concerning the agent, it depends on the activated probes. The default skydive.conf provided in the kolla-ansible patch includes the netns probe, which needs root rights.\n\nSo to keep a single image for both the analyzer and the agent, we should run those two containers as root.","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"}],"docker/skydive/skydive-agent/Dockerfile.j2":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"32110fd62581cd98d6637ac43912e8a1bb8c7317","unresolved":false,"context_lines":[{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block skydive_agent_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block skydive_agent_footer %}{% endblock %}"},{"line_number":7,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"df140735_4c5ea912","line":5,"updated":"2017-06-02 09:09:39.000000000","message":"Can this container run as the skydive user?","commit_id":"e41bb33782987aa44c882224fedfa19ffb983319"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"08fe699321f903511bf86820b19a5191a44e7b54","unresolved":false,"context_lines":[{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block skydive_agent_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block skydive_agent_footer %}{% endblock %}"},{"line_number":7,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"df140735_2ca375b4","line":5,"in_reply_to":"df140735_4c5ea912","updated":"2017-06-02 09:18:10.000000000","message":"this container needs root access rights, at least for the skydive netns probe, which is mandatory. So with skydive 0.11, root permissions are required for the skydive agent.","commit_id":"e41bb33782987aa44c882224fedfa19ffb983319"}],"docker/skydive/skydive-analyzer/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b132f0869a65f9c845f822867ae6d2fdbd7bce55","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block skydive_analyzer_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"USER skydive"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block skydive_analyzer_footer %}{% endblock %}"},{"line_number":9,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"df140735_ca573458","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":12},"updated":"2017-06-02 12:58:00.000000000","message":"user directive is the last on each dockerfile, please move it to line 9","commit_id":"36f5c9f5c4c3d766828127c934a16796e29bf0ca"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"0d20a8ba38e43f21cf97138a5cc42c7cef801d4c","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block skydive_analyzer_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"USER skydive"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block skydive_analyzer_footer %}{% endblock %}"},{"line_number":9,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"df140735_e5d8eaef","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":12},"in_reply_to":"df140735_ca573458","updated":"2017-06-02 13:55:30.000000000","message":"Done","commit_id":"36f5c9f5c4c3d766828127c934a16796e29bf0ca"}],"docker/skydive/skydive-base/Dockerfile.j2":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"32110fd62581cd98d6637ac43912e8a1bb8c7317","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":11,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.11.0/skydive\" \\"},{"line_number":12,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"df140735_8c3f21b3","line":10,"updated":"2017-06-02 09:09:39.000000000","message":"Can you please add a block around this so people can easily override the external curl. e.g. https://github.com/openstack/kolla/blob/master/docker/kafka/Dockerfile.j2#L23","commit_id":"e41bb33782987aa44c882224fedfa19ffb983319"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"08fe699321f903511bf86820b19a5191a44e7b54","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":11,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.11.0/skydive\" \\"},{"line_number":12,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"df140735_aca425a7","line":10,"in_reply_to":"df140735_8c3f21b3","updated":"2017-06-02 09:18:10.000000000","message":"Done","commit_id":"e41bb33782987aa44c882224fedfa19ffb983319"}],"kolla/common/config.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e22aadcd9158565ac3de93a465ec139dc6457936","unresolved":false,"context_lines":[{"line_number":844,"context_line":"    \u0027zun-user\u0027: {"},{"line_number":845,"context_line":"        \u0027uid\u0027: 42463,"},{"line_number":846,"context_line":"        \u0027gid\u0027: 42463,"},{"line_number":847,"context_line":"    }"},{"line_number":848,"context_line":"    \u0027skydive-user\u0027: {"},{"line_number":849,"context_line":"        \u0027uid\u0027: 42463,"},{"line_number":850,"context_line":"        \u0027gid\u0027: 42463,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_021c7a68","line":847,"updated":"2017-05-15 07:52:39.000000000","message":"missing comma","commit_id":"f8c4e28e14443c47176561d35d5b403b1ac15998"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"209155995a98e67c4e0af6e62be56954fde9763a","unresolved":false,"context_lines":[{"line_number":844,"context_line":"    \u0027zun-user\u0027: {"},{"line_number":845,"context_line":"        \u0027uid\u0027: 42463,"},{"line_number":846,"context_line":"        \u0027gid\u0027: 42463,"},{"line_number":847,"context_line":"    }"},{"line_number":848,"context_line":"    \u0027skydive-user\u0027: {"},{"line_number":849,"context_line":"        \u0027uid\u0027: 42463,"},{"line_number":850,"context_line":"        \u0027gid\u0027: 42463,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_eb76ebd8","line":847,"in_reply_to":"1f013ff3_021c7a68","updated":"2017-05-16 07:11:43.000000000","message":"Done","commit_id":"f8c4e28e14443c47176561d35d5b403b1ac15998"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e22aadcd9158565ac3de93a465ec139dc6457936","unresolved":false,"context_lines":[{"line_number":846,"context_line":"        \u0027gid\u0027: 42463,"},{"line_number":847,"context_line":"    }"},{"line_number":848,"context_line":"    \u0027skydive-user\u0027: {"},{"line_number":849,"context_line":"        \u0027uid\u0027: 42463,"},{"line_number":850,"context_line":"        \u0027gid\u0027: 42463,"},{"line_number":851,"context_line":"    }"},{"line_number":852,"context_line":"}"},{"line_number":853,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_220f762f","line":850,"range":{"start_line":849,"start_character":0,"end_line":850,"end_character":21},"updated":"2017-05-15 07:52:39.000000000","message":"use next uid/gui number","commit_id":"f8c4e28e14443c47176561d35d5b403b1ac15998"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"209155995a98e67c4e0af6e62be56954fde9763a","unresolved":false,"context_lines":[{"line_number":846,"context_line":"        \u0027gid\u0027: 42463,"},{"line_number":847,"context_line":"    }"},{"line_number":848,"context_line":"    \u0027skydive-user\u0027: {"},{"line_number":849,"context_line":"        \u0027uid\u0027: 42463,"},{"line_number":850,"context_line":"        \u0027gid\u0027: 42463,"},{"line_number":851,"context_line":"    }"},{"line_number":852,"context_line":"}"},{"line_number":853,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_0b7237e6","line":850,"range":{"start_line":849,"start_character":0,"end_line":850,"end_character":21},"in_reply_to":"1f013ff3_220f762f","updated":"2017-05-16 07:11:43.000000000","message":"Done","commit_id":"f8c4e28e14443c47176561d35d5b403b1ac15998"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a7868d0c206107665e58d2a3504a55b34615231","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                    \u0027openvswitch\u0027,"},{"line_number":73,"context_line":"                    \u0027rabbitmq\u0027,"},{"line_number":74,"context_line":"                    \u0027redis\u0027,"},{"line_number":75,"context_line":"                    \u0027tgtd\u0027,"},{"line_number":76,"context_line":"                ],"},{"line_number":77,"context_line":"                help\u003d\u0027Infra images\u0027),"},{"line_number":78,"context_line":"    cfg.ListOpt(\u0027main\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f013ff3_faeb52ad","line":75,"updated":"2017-05-16 08:26:28.000000000","message":"I see skydive more as a infra service","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"5774c84579231a27935d8fd14cb089888a27132e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                    \u0027openvswitch\u0027,"},{"line_number":73,"context_line":"                    \u0027rabbitmq\u0027,"},{"line_number":74,"context_line":"                    \u0027redis\u0027,"},{"line_number":75,"context_line":"                    \u0027tgtd\u0027,"},{"line_number":76,"context_line":"                ],"},{"line_number":77,"context_line":"                help\u003d\u0027Infra images\u0027),"},{"line_number":78,"context_line":"    cfg.ListOpt(\u0027main\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_ae2a6f8d","line":75,"in_reply_to":"1f013ff3_faeb52ad","updated":"2017-05-17 15:45:45.000000000","message":"Done","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a7868d0c206107665e58d2a3504a55b34615231","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                    \u0027sahara\u0027,"},{"line_number":115,"context_line":"                    \u0027searchlight\u0027,"},{"line_number":116,"context_line":"                    \u0027senlin\u0027,"},{"line_number":117,"context_line":"                    \u0027skydive\u0027,"},{"line_number":118,"context_line":"                    \u0027solum\u0027,"},{"line_number":119,"context_line":"                    \u0027tacker\u0027,"},{"line_number":120,"context_line":"                    \u0027telegraf\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f013ff3_bacdca5e","line":117,"range":{"start_line":117,"start_character":21,"end_line":117,"end_character":28},"updated":"2017-05-16 08:26:28.000000000","message":"please, see comment above","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"5774c84579231a27935d8fd14cb089888a27132e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                    \u0027sahara\u0027,"},{"line_number":115,"context_line":"                    \u0027searchlight\u0027,"},{"line_number":116,"context_line":"                    \u0027senlin\u0027,"},{"line_number":117,"context_line":"                    \u0027skydive\u0027,"},{"line_number":118,"context_line":"                    \u0027solum\u0027,"},{"line_number":119,"context_line":"                    \u0027tacker\u0027,"},{"line_number":120,"context_line":"                    \u0027telegraf\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_8e19eb89","line":117,"range":{"start_line":117,"start_character":21,"end_line":117,"end_character":28},"in_reply_to":"1f013ff3_bacdca5e","updated":"2017-05-17 15:45:45.000000000","message":"Done","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a7868d0c206107665e58d2a3504a55b34615231","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":552,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/senlin/\u0027"},{"line_number":553,"context_line":"                     \u0027senlin-master.tar.gz\u0027)},"},{"line_number":554,"context_line":"    \u0027skydive\u0027: {"},{"line_number":555,"context_line":"        \u0027type\u0027: \u0027git\u0027,"},{"line_number":556,"context_line":"        \u0027reference\u0027: \u0027master\u0027,"},{"line_number":557,"context_line":"        \u0027location\u0027: (\u0027https://github.com/skydive-project/skydive\u0027)},"},{"line_number":558,"context_line":"    \u0027solum-base\u0027: {"},{"line_number":559,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":560,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/solum/\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f013ff3_1a003e67","line":557,"range":{"start_line":554,"start_character":0,"end_line":557,"end_character":68},"updated":"2017-05-16 08:26:28.000000000","message":"this is not used anywhere","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"5774c84579231a27935d8fd14cb089888a27132e","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":552,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/senlin/\u0027"},{"line_number":553,"context_line":"                     \u0027senlin-master.tar.gz\u0027)},"},{"line_number":554,"context_line":"    \u0027skydive\u0027: {"},{"line_number":555,"context_line":"        \u0027type\u0027: \u0027git\u0027,"},{"line_number":556,"context_line":"        \u0027reference\u0027: \u0027master\u0027,"},{"line_number":557,"context_line":"        \u0027location\u0027: (\u0027https://github.com/skydive-project/skydive\u0027)},"},{"line_number":558,"context_line":"    \u0027solum-base\u0027: {"},{"line_number":559,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":560,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/solum/\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_09127559","line":557,"range":{"start_line":554,"start_character":0,"end_line":557,"end_character":68},"in_reply_to":"1f013ff3_1a003e67","updated":"2017-05-17 15:45:45.000000000","message":"I\u0027ll remove that part","commit_id":"6b3d6d8c1f4ea86c21c16bb9822cebf37f330460"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b4f024fa4227db08f2c7737ca385bef1e18dafa7","unresolved":false,"context_lines":[{"line_number":855,"context_line":"        \u0027gid\u0027: 42465,"},{"line_number":856,"context_line":"    }"},{"line_number":857,"context_line":"}"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"def get_source_opts(type_\u003dNone, location\u003dNone, reference\u003dNone):"},{"line_number":860,"context_line":"    return [cfg.StrOpt(\u0027type\u0027, choices\u003d[\u0027local\u0027, \u0027git\u0027, \u0027url\u0027],"},{"line_number":861,"context_line":"                       default\u003dtype_,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff0f0b1f_dfb533f0","line":858,"updated":"2017-05-18 08:33:29.000000000","message":"http://logs.openstack.org/95/459995/11/check/gate-kolla-pep8-ubuntu-xenial/206d9ee/console.html#_2017-05-18_07_44_43_403630","commit_id":"2d473ccd0bb7ecd879ab9870e6337a6a8deebd4e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b132f0869a65f9c845f822867ae6d2fdbd7bce55","unresolved":false,"context_lines":[{"line_number":870,"context_line":"    },"},{"line_number":871,"context_line":"    \u0027skydive-user\u0027: {"},{"line_number":872,"context_line":"        \u0027uid\u0027: 42468,"},{"line_number":873,"context_line":"        \u0027gid\u0027: 42468"},{"line_number":874,"context_line":"    }"},{"line_number":875,"context_line":"}"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"df140735_cadcd4e5","line":873,"updated":"2017-06-02 12:58:00.000000000","message":"missing comma","commit_id":"36f5c9f5c4c3d766828127c934a16796e29bf0ca"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"0d20a8ba38e43f21cf97138a5cc42c7cef801d4c","unresolved":false,"context_lines":[{"line_number":870,"context_line":"    },"},{"line_number":871,"context_line":"    \u0027skydive-user\u0027: {"},{"line_number":872,"context_line":"        \u0027uid\u0027: 42468,"},{"line_number":873,"context_line":"        \u0027gid\u0027: 42468"},{"line_number":874,"context_line":"    }"},{"line_number":875,"context_line":"}"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"df140735_056e3e2e","line":873,"in_reply_to":"df140735_cadcd4e5","updated":"2017-06-02 13:55:30.000000000","message":"Done","commit_id":"36f5c9f5c4c3d766828127c934a16796e29bf0ca"}],"releasenotes/notes/add-skydive-52c3fb964fe6cc1b.yaml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f471576b8c35644c471742a44dfea93deb9260f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skydive Dockerfile"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5ff73747_99b0f8df","line":3,"updated":"2017-05-03 08:13:02.000000000","message":"please, add more information","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e4d7cb3025cd58790b1cc997c400b02f47bd8abc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add skydive Dockerfile"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f044301_2df50458","line":3,"in_reply_to":"5ff73747_99b0f8df","updated":"2017-05-05 12:38:04.000000000","message":"I\u0027ll do my best","commit_id":"5df22cfc356554d607fc3389c2040aa6554fe201"}]}