)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"740b8a0d0276d55a38c7444cadb84b228c0744cb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"enable the kolla build system to use out of tree docker files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change introduces a docker-dir config option to enable"},{"line_number":10,"context_line":"  specifying an out of tree addtional docker file"},{"line_number":11,"context_line":"  root dir for use with  kolla build."},{"line_number":12,"context_line":"- This change allows kolla\u0027s build system to be reused by non kolla"},{"line_number":13,"context_line":"  or external project to build arbitray docker images using jinja2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f231b9d_27d9fc20","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":37},"updated":"2017-06-19 04:08:54.000000000","message":"additional","commit_id":"5047bebab37bf9869637e0c7eef7dc344cea598b"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"740b8a0d0276d55a38c7444cadb84b228c0744cb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  specifying an out of tree addtional docker file"},{"line_number":11,"context_line":"  root dir for use with  kolla build."},{"line_number":12,"context_line":"- This change allows kolla\u0027s build system to be reused by non kolla"},{"line_number":13,"context_line":"  or external project to build arbitray docker images using jinja2"},{"line_number":14,"context_line":"  templatised docker files."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Michal (inc0) Jastrzebski \u003cinc007@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f231b9d_c70b688b","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":39},"updated":"2017-06-19 04:08:54.000000000","message":"arbitrary","commit_id":"5047bebab37bf9869637e0c7eef7dc344cea598b"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"740b8a0d0276d55a38c7444cadb84b228c0744cb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  root dir for use with  kolla build."},{"line_number":12,"context_line":"- This change allows kolla\u0027s build system to be reused by non kolla"},{"line_number":13,"context_line":"  or external project to build arbitray docker images using jinja2"},{"line_number":14,"context_line":"  templatised docker files."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Michal (inc0) Jastrzebski \u003cinc007@gmail.com\u003e"},{"line_number":17,"context_line":"Change-Id: Idbba02a8910866ef1b838e5cbac3ab230551b7e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f231b9d_47f7588c","line":14,"range":{"start_line":14,"start_character":2,"end_line":14,"end_character":13},"updated":"2017-06-19 04:08:54.000000000","message":"templatized ;)","commit_id":"5047bebab37bf9869637e0c7eef7dc344cea598b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6058498b4f5cbf90f29cba9bedd1b3e51fb89c47","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  root dir for use with  kolla build."},{"line_number":12,"context_line":"- This change allows kolla\u0027s build system to be reused by non kolla"},{"line_number":13,"context_line":"  or external project to build arbitray docker images using jinja2"},{"line_number":14,"context_line":"  templatised docker files."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Michal (inc0) Jastrzebski \u003cinc007@gmail.com\u003e"},{"line_number":17,"context_line":"Change-Id: Idbba02a8910866ef1b838e5cbac3ab230551b7e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f1d235d_42a78a0c","line":14,"range":{"start_line":14,"start_character":2,"end_line":14,"end_character":13},"in_reply_to":"7f231b9d_47f7588c","updated":"2017-07-05 11:54:27.000000000","message":"i think that a uk vs us english thing but i \"fixed\" it in the next patch.","commit_id":"5047bebab37bf9869637e0c7eef7dc344cea598b"}],"kolla/common/config.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2303272f62f0feda7b1f37ef33ce873afb4517f0","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    cfg.MultiOpt(\u0027template-override\u0027, types.String(),"},{"line_number":245,"context_line":"                 help\u003d\u0027Path to template override file\u0027),"},{"line_number":246,"context_line":"    cfg.StrOpt(\u0027docker-dir\u0027, help\u003d\u0027Path to docker file template directory\u0027,"},{"line_number":247,"context_line":"                short\u003d\u0027D\u0027, default\u003d\u0027auto\u0027),"},{"line_number":248,"context_line":"    cfg.StrOpt(\u0027logs-dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":249,"context_line":"    cfg.BoolOpt(\u0027pull\u0027, default\u003dTrue,"},{"line_number":250,"context_line":"                help\u003d\u0027Attempt to pull a newer version of the base image\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_e2303eeb","line":247,"updated":"2017-05-19 01:07:37.000000000","message":"how about support much dir here?\n\nthen you can run once to build all images ( kolla + custom )","commit_id":"3dfc54e7d6b54abf9b54c7e17951e06d73d7ac11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d1da8d4e6af38e1e590f3dd4f8ee6bd560dcb3b5","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    cfg.MultiOpt(\u0027template-override\u0027, types.String(),"},{"line_number":245,"context_line":"                 help\u003d\u0027Path to template override file\u0027),"},{"line_number":246,"context_line":"    cfg.StrOpt(\u0027docker-dir\u0027, help\u003d\u0027Path to docker file template directory\u0027,"},{"line_number":247,"context_line":"                short\u003d\u0027D\u0027, default\u003d\u0027auto\u0027),"},{"line_number":248,"context_line":"    cfg.StrOpt(\u0027logs-dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":249,"context_line":"    cfg.BoolOpt(\u0027pull\u0027, default\u003dTrue,"},{"line_number":250,"context_line":"                help\u003d\u0027Attempt to pull a newer version of the base image\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_ad1460a1","line":247,"in_reply_to":"ff0f0b1f_8dd63c27","updated":"2017-05-19 17:43:38.000000000","message":"oh actully on that would making this \n\ncfg.MultiOpt(\u0027docker-dir\u0027, types.String(), help\u003d\u0027Path to addtional docker file template directory\u0027,\n                short\u003d\u0027D\u0027),\n\nsound better to you?\n\nthen you could just tell the build system to look at a set of additional directories for images by repeating the -D/--docker-dir flags.","commit_id":"3dfc54e7d6b54abf9b54c7e17951e06d73d7ac11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"858fa5c407ef4bba9c0bc3e0210d136f7f5bd38e","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    cfg.MultiOpt(\u0027template-override\u0027, types.String(),"},{"line_number":245,"context_line":"                 help\u003d\u0027Path to template override file\u0027),"},{"line_number":246,"context_line":"    cfg.StrOpt(\u0027docker-dir\u0027, help\u003d\u0027Path to docker file template directory\u0027,"},{"line_number":247,"context_line":"                short\u003d\u0027D\u0027, default\u003d\u0027auto\u0027),"},{"line_number":248,"context_line":"    cfg.StrOpt(\u0027logs-dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":249,"context_line":"    cfg.BoolOpt(\u0027pull\u0027, default\u003dTrue,"},{"line_number":250,"context_line":"                help\u003d\u0027Attempt to pull a newer version of the base image\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_8dd63c27","line":247,"in_reply_to":"ff0f0b1f_e2303eeb","updated":"2017-05-19 17:37:41.000000000","message":"yep that is definetly possible infact i think it will be really easy to enable. \ninstead of the if i added on in the build.py \n\ni think i just have to add\nshutil.copytree(self.conf.docker_dir, self.working_dir)\nafter \nhttps://github.com/openstack/kolla/blob/d3302929e001b89798727f0e312149c5abc0da5a/kolla/image/build.py#L660\n\ni started with a direct replacement because i assumened this was going to be a bigger code change then it turned out to be but allowing both kolla + custom images all in one build should be easy so ill test and reupload in that form.","commit_id":"3dfc54e7d6b54abf9b54c7e17951e06d73d7ac11"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"740b8a0d0276d55a38c7444cadb84b228c0744cb","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    cfg.MultiOpt(\u0027template-override\u0027, types.String(),"},{"line_number":246,"context_line":"                 help\u003d\u0027Path to template override file\u0027),"},{"line_number":247,"context_line":"    cfg.MultiOpt(\u0027docker-dir\u0027, types.String(),"},{"line_number":248,"context_line":"                 help\u003d\u0027Path to addtional docker file template directory\u0027,"},{"line_number":249,"context_line":"                 short\u003d\u0027D\u0027, default\u003d[]),"},{"line_number":250,"context_line":"    cfg.StrOpt(\u0027logs-dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":251,"context_line":"    cfg.BoolOpt(\u0027pull\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_a7b4ecf2","line":248,"range":{"start_line":248,"start_character":31,"end_line":248,"end_character":40},"updated":"2017-06-19 04:08:54.000000000","message":"additional","commit_id":"5047bebab37bf9869637e0c7eef7dc344cea598b"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"6ec042baaa0ed9fe280039fd3a02ac8fdbb84794","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    cfg.MultiOpt(\u0027template-override\u0027, types.String(),"},{"line_number":246,"context_line":"                 help\u003d\u0027Path to template override file\u0027),"},{"line_number":247,"context_line":"    cfg.MultiOpt(\u0027docker-dir\u0027, types.String(),"},{"line_number":248,"context_line":"                 help\u003d\u0027Path to addtional docker file template directory\u0027,"},{"line_number":249,"context_line":"                 short\u003d\u0027D\u0027, default\u003d[]),"},{"line_number":250,"context_line":"    cfg.StrOpt(\u0027logs-dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":251,"context_line":"    cfg.BoolOpt(\u0027pull\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_7ebbe5e4","line":248,"range":{"start_line":248,"start_character":31,"end_line":248,"end_character":40},"in_reply_to":"7f231b9d_a7b4ecf2","updated":"2017-06-20 14:33:01.000000000","message":"agree,  please fix the typo","commit_id":"5047bebab37bf9869637e0c7eef7dc344cea598b"}],"kolla/image/build.py":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"740b8a0d0276d55a38c7444cadb84b228c0744cb","unresolved":false,"context_lines":[{"line_number":652,"context_line":"            shutil.copytree(src, dest)"},{"line_number":653,"context_line":"        else:"},{"line_number":654,"context_line":"            for file in os.listdir(src):"},{"line_number":655,"context_line":"                s \u003d os.path.join(src, file)"},{"line_number":656,"context_line":"                d \u003d os.path.join(dest, file)"},{"line_number":657,"context_line":"                if os.path.isdir(s):"},{"line_number":658,"context_line":"                    self.copy_dir(s, d)"},{"line_number":659,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_67a5b4a1","line":656,"range":{"start_line":655,"start_character":15,"end_line":656,"end_character":18},"updated":"2017-06-19 04:08:54.000000000","message":"It would be much better if you improve readability of code, just by renaming it to `src_path` and `dest_path` like that or the best you like.","commit_id":"5047bebab37bf9869637e0c7eef7dc344cea598b"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"740b8a0d0276d55a38c7444cadb84b228c0744cb","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                s \u003d os.path.join(src, file)"},{"line_number":656,"context_line":"                d \u003d os.path.join(dest, file)"},{"line_number":657,"context_line":"                if os.path.isdir(s):"},{"line_number":658,"context_line":"                    self.copy_dir(s, d)"},{"line_number":659,"context_line":"                else:"},{"line_number":660,"context_line":"                    shutil.copy2(s, d)"},{"line_number":661,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_07bf20aa","line":658,"range":{"start_line":658,"start_character":33,"end_line":658,"end_character":38},"updated":"2017-06-19 04:08:54.000000000","message":"ditto","commit_id":"5047bebab37bf9869637e0c7eef7dc344cea598b"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"740b8a0d0276d55a38c7444cadb84b228c0744cb","unresolved":false,"context_lines":[{"line_number":657,"context_line":"                if os.path.isdir(s):"},{"line_number":658,"context_line":"                    self.copy_dir(s, d)"},{"line_number":659,"context_line":"                else:"},{"line_number":660,"context_line":"                    shutil.copy2(s, d)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    def setup_working_dir(self):"},{"line_number":663,"context_line":"        \"\"\"Creates a working directory for use while building\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_c7e248d5","line":660,"range":{"start_line":660,"start_character":33,"end_line":660,"end_character":37},"updated":"2017-06-19 04:08:54.000000000","message":"ditto","commit_id":"5047bebab37bf9869637e0c7eef7dc344cea598b"}]}