)]}'
{"docker/novajoin/novajoin-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bbb9b7a0aa4f935c05f5d7a75aa73f5c0f68e519","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":12,"context_line":"            \u0027python-novajoin\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_a48da0d4","line":9,"range":{"start_line":9,"start_character":36,"end_line":9,"end_character":42},"updated":"2017-05-19 14:39:08.000000000","message":"missing oraclelinux","commit_id":"81e4669104a2cc44922923e046f24a5508238e20"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bbb9b7a0aa4f935c05f5d7a75aa73f5c0f68e519","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u0026\u0026 /bin/false"},{"line_number":18,"context_line":"    {% endif %}"},{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":21,"context_line":"\u0026\u0026 /bin/false"},{"line_number":22,"context_line":"{% endif %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{ macros.install_packages(novajoin_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_446da402","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":13},"updated":"2017-05-19 14:39:08.000000000","message":"source code tarballs exists for novajoin https://tarballs.openstack.org/novajoin/","commit_id":"81e4669104a2cc44922923e046f24a5508238e20"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bbb9b7a0aa4f935c05f5d7a75aa73f5c0f68e519","unresolved":false,"context_lines":[{"line_number":32,"context_line":"{% block novajoin_base_footer %}{% endblock %}"},{"line_number":33,"context_line":"{% block footer %}{% endblock %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"#USER nova"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_c480948e","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":10},"updated":"2017-05-19 14:39:08.000000000","message":"please,remove it","commit_id":"81e4669104a2cc44922923e046f24a5508238e20"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":16,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":17,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":18,"context_line":"    {% endif %}"},{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        {% set novajoin_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_af4e4d35","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":7},"updated":"2017-05-23 08:34:00.000000000","message":"{% elif install_type \u003d\u003d \u0027source\u0027 %}","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":23,"context_line":"            \u0027ipa-admintools\u0027,"},{"line_number":24,"context_line":"            \u0027openstack-nova-common\u0027,"},{"line_number":25,"context_line":"            \u0027python-glanceclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_6f95d532","line":22,"range":{"start_line":22,"start_character":15,"end_line":22,"end_character":37},"updated":"2017-05-23 08:34:00.000000000","message":"for source images python libraries should be installed by pip","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":24,"context_line":"            \u0027openstack-nova-common\u0027,"},{"line_number":25,"context_line":"            \u0027python-glanceclient\u0027,"},{"line_number":26,"context_line":"            \u0027python-keystonemiddleware\u0027,"},{"line_number":27,"context_line":"            \u0027python-keystoneauth1\u0027,"},{"line_number":28,"context_line":"            \u0027python-neutronclient\u0027,"},{"line_number":29,"context_line":"            \u0027python-novaclient\u0027,"},{"line_number":30,"context_line":"            \u0027python-oslo-concurrency\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_0f7f7915","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":35},"updated":"2017-05-23 08:34:00.000000000","message":"nit, alphabetize before the other keystone package","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":23,"context_line":"            \u0027ipa-admintools\u0027,"},{"line_number":24,"context_line":"            \u0027openstack-nova-common\u0027,"},{"line_number":25,"context_line":"            \u0027python-glanceclient\u0027,"},{"line_number":26,"context_line":"            \u0027python-keystonemiddleware\u0027,"},{"line_number":27,"context_line":"            \u0027python-keystoneauth1\u0027,"},{"line_number":28,"context_line":"            \u0027python-neutronclient\u0027,"},{"line_number":29,"context_line":"            \u0027python-novaclient\u0027,"},{"line_number":30,"context_line":"            \u0027python-oslo-concurrency\u0027,"},{"line_number":31,"context_line":"            \u0027python-oslo-messaging\u0027,"},{"line_number":32,"context_line":"            \u0027python-oslo-policy\u0027,"},{"line_number":33,"context_line":"            \u0027python-oslo-serialization\u0027,"},{"line_number":34,"context_line":"            \u0027python-oslo-service\u0027,"},{"line_number":35,"context_line":"            \u0027python-oslo-utils\u0027,"},{"line_number":36,"context_line":"            \u0027python-paste\u0027,"},{"line_number":37,"context_line":"            \u0027python-routes\u0027,"},{"line_number":38,"context_line":"            \u0027python-six\u0027,"},{"line_number":39,"context_line":"            \u0027python-webob\u0027,"},{"line_number":40,"context_line":"        ] %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    {% else %}"},{"line_number":43,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_6f0cb5a4","line":40,"range":{"start_line":23,"start_character":0,"end_line":40,"end_character":12},"updated":"2017-05-23 08:34:00.000000000","message":"probably most libraries are installed as dependency of http://tarballs.openstack.org/novajoin/","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \u0027python-six\u0027,"},{"line_number":39,"context_line":"            \u0027python-webob\u0027,"},{"line_number":40,"context_line":"        ] %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    {% else %}"},{"line_number":43,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":44,"context_line":"    \u0026\u0026 /bin/false"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_8f7a69ee","line":41,"updated":"2017-05-23 08:34:00.000000000","message":"missing source install for novajoin\nexample:\nhttps://github.com/openstack/kolla/blob/master/docker/tacker/Dockerfile.j2#L26#L40","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":56,"context_line":"{% block novajoin_base_footer %}{% endblock %}"},{"line_number":57,"context_line":"{% block footer %}{% endblock %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"#USER nova"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_4f80d1bf","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":10},"updated":"2017-05-23 08:34:00.000000000","message":"no used, please remove it","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f9946b3302651bdec2cd64863713871c353a854c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":23,"context_line":"            \u0027ipa-admintools\u0027,"},{"line_number":24,"context_line":"            \u0027openstack-nova-common\u0027"},{"line_number":25,"context_line":"        ] %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"ADD novajoin-archive /novajoin-source"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ff0f0b1f_bac32d57","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":35},"updated":"2017-05-23 09:03:42.000000000","message":"nova-common cannot be installed in source, this have to be done through plugins or making this image children of nova-base.\nExample for plugins https://review.openstack.org/#/c/454743/","commit_id":"a81af2609e1b25452e76ad7de2951a151e65135d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f9946b3302651bdec2cd64863713871c353a854c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"RUN ln -s novajoin-source/* novajoin \\"},{"line_number":34,"context_line":"    \u0026\u0026 {{ macros.install_pip(novajoin_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":35,"context_line":"    \u0026\u0026 mkdir -p /etc/nova \\"},{"line_number":36,"context_line":"    \u0026\u0026 cp -r /novajoin/etc/nova/* /etc/nova \\"},{"line_number":37,"context_line":"    \u0026\u0026 chown -R nova: /etc/nova"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    {% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ff0f0b1f_da45c1b5","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":45},"updated":"2017-05-23 09:03:42.000000000","message":"build will fail because etc does not exists in novajoin https://github.com/openstack/novajoin","commit_id":"a81af2609e1b25452e76ad7de2951a151e65135d"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"e0e77a4259fed09be83f7579445ce496235d51b0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_novajoin_extend_start"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"{% block novajoin_base_footer %}{% endblock %}"},{"line_number":54,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ff0f0b1f_3becbf8d","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":32},"updated":"2017-05-23 10:41:13.000000000","message":"\"Note The generic footer block {% block footer %}{% endblock %} should not be included in base images (e.g. glance-base).\" (https://docs.openstack.org/developer/kolla/CONTRIBUTING.html)","commit_id":"0620ee71bb0a30ee9cc8deb0a7c7569bafcd15df"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"591eec3d40c9e876916bd01820819c4c16ee93ab","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            \u0027ipa-admintools\u0027,"},{"line_number":26,"context_line":"            \u0027openstack-nova-common\u0027"},{"line_number":27,"context_line":"        ] %}"},{"line_number":28,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":29,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":30,"context_line":"            \u0027freeipa-admintools\u0027,"},{"line_number":31,"context_line":"            \u0027nova-common\u0027"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"df140735_1767a6bf","line":28,"range":{"start_line":28,"start_character":28,"end_line":28,"end_character":36},"updated":"2017-06-02 04:44:58.000000000","message":"should we remove debian because the freeipa packages aren\u0027t there?","commit_id":"604fdb03b1bcaf3d54fd78ed488ec8ccdbec5a53"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e71a10aaf4ac8255dc405c9906c1ca5cce216a7a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":24,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":25,"context_line":"            \u0027ipa-admintools\u0027,"},{"line_number":26,"context_line":"            \u0027openstack-nova-common\u0027"},{"line_number":27,"context_line":"        ] %}"},{"line_number":28,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":29,"context_line":"        {% set novajoin_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f231b9d_51985e73","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":35},"updated":"2017-06-16 08:15:46.000000000","message":"binary packages are not allowed in source images.\nadd nova tarball in line 38 or use plugins (check neutron-base as example)","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"85693e6ecafe4d4da55b034c8967676c91921870","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":24,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":25,"context_line":"            \u0027ipa-admintools\u0027,"},{"line_number":26,"context_line":"            \u0027openstack-nova-common\u0027"},{"line_number":27,"context_line":"        ] %}"},{"line_number":28,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":29,"context_line":"        {% set novajoin_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f231b9d_dd0fdf85","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":35},"in_reply_to":"7f231b9d_51985e73","updated":"2017-06-16 10:34:37.000000000","message":"agree with @egonzalez. you can follow below for little reference.\nhttps://review.openstack.org/#/c/454743","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"41ccee24521a3c9b7d3a2039e01b313440a4788d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":24,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":25,"context_line":"            \u0027ipa-admintools\u0027,"},{"line_number":26,"context_line":"            \u0027openstack-nova-common\u0027"},{"line_number":27,"context_line":"        ] %}"},{"line_number":28,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":29,"context_line":"        {% set novajoin_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f231b9d_df36a903","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":35},"in_reply_to":"7f231b9d_dd0fdf85","updated":"2017-06-16 18:06:18.000000000","message":"Done","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e71a10aaf4ac8255dc405c9906c1ca5cce216a7a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":29,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":30,"context_line":"            \u0027freeipa-admintools\u0027,"},{"line_number":31,"context_line":"            \u0027nova-common\u0027"},{"line_number":32,"context_line":"        ] %}"},{"line_number":33,"context_line":"    {% endif %}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f231b9d_f182caff","line":31,"range":{"start_line":31,"start_character":12,"end_line":31,"end_character":25},"updated":"2017-06-16 08:15:46.000000000","message":"same","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"41ccee24521a3c9b7d3a2039e01b313440a4788d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":29,"context_line":"        {% set novajoin_base_packages \u003d ["},{"line_number":30,"context_line":"            \u0027freeipa-admintools\u0027,"},{"line_number":31,"context_line":"            \u0027nova-common\u0027"},{"line_number":32,"context_line":"        ] %}"},{"line_number":33,"context_line":"    {% endif %}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f231b9d_9f3cb1e1","line":31,"range":{"start_line":31,"start_character":12,"end_line":31,"end_character":25},"in_reply_to":"7f231b9d_f182caff","updated":"2017-06-16 18:06:18.000000000","message":"Done","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e71a10aaf4ac8255dc405c9906c1ca5cce216a7a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"RUN ln -s novajoin-base-source/* novajoin \\"},{"line_number":44,"context_line":"    \u0026\u0026 {{ macros.install_pip(novajoin_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":45,"context_line":"    \u0026\u0026 mkdir -p /etc/nova \\"},{"line_number":46,"context_line":"    \u0026\u0026 mkdir -p /etc/novajoin \\"},{"line_number":47,"context_line":"    \u0026\u0026 chown -R nova: /etc/nova \\"},{"line_number":48,"context_line":"    \u0026\u0026 chown -R nova: /etc/novajoin"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f231b9d_51673eb8","line":46,"range":{"start_line":46,"start_character":16,"end_line":46,"end_character":29},"updated":"2017-06-16 08:15:46.000000000","message":"please, merge this mkdir with previous one","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e71a10aaf4ac8255dc405c9906c1ca5cce216a7a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \u0026\u0026 mkdir -p /etc/nova \\"},{"line_number":46,"context_line":"    \u0026\u0026 mkdir -p /etc/novajoin \\"},{"line_number":47,"context_line":"    \u0026\u0026 chown -R nova: /etc/nova \\"},{"line_number":48,"context_line":"    \u0026\u0026 chown -R nova: /etc/novajoin"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f231b9d_d110ee02","line":48,"range":{"start_line":48,"start_character":22,"end_line":48,"end_character":35},"updated":"2017-06-16 08:15:46.000000000","message":"same","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"}],"docker/novajoin/novajoin-notifier/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bbb9b7a0aa4f935c05f5d7a75aa73f5c0f68e519","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}novajoin-base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block novajoin_notifier_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_7fff1501","line":3,"updated":"2017-05-19 14:39:08.000000000","message":"same comments as previous dockerfile","commit_id":"81e4669104a2cc44922923e046f24a5508238e20"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":11,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":"    {% if base_distro not in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":16,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block novajoin_notifier_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_6fcdd52f","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":11},"updated":"2017-05-23 08:34:00.000000000","message":"installing from source will allow ubuntu and centos installs, only install_type binary conditional is needed. sources are already installed in novajoin base","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1c1bb73c05174eebafa1f8844ba110250ca2d990","unresolved":false,"context_lines":[{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":11,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":"    {% if base_distro not in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":16,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block novajoin_notifier_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_3a439d15","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":11},"in_reply_to":"ff0f0b1f_5af091fd","updated":"2017-05-23 08:49:51.000000000","message":"yep, if novajoin is installed from source code, will be available for ubuntu/debian source images.\n\nAs source code is only installed in base images, this notifier children of base already have novajoin installed on it.\n\nMy comment is just to remove the else after binary block.","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c8d8177c665cac45b6b53c5486d87332b28e0acd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":11,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":"    {% if base_distro not in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":16,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block novajoin_notifier_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_5af091fd","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":11},"in_reply_to":"ff0f0b1f_6fcdd52f","updated":"2017-05-23 08:47:29.000000000","message":"can you ellaborate on this?","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{% block novajoin_notifier_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#USER nova"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_0fdc19e2","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":10},"updated":"2017-05-23 08:34:00.000000000","message":"remove, unless need nova user","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6640517f6b3dbf4869cb56c83de6e8a8cf43ebff","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro not in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":11,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% block novajoin_notifier_footer %}{% endblock %}"},{"line_number":16,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"df140735_94463021","line":13,"range":{"start_line":8,"start_character":0,"end_line":13,"end_character":11},"updated":"2017-06-01 11:24:49.000000000","message":"So for Debian this image is perfectly fine?\n\nDo not think so.","commit_id":"604fdb03b1bcaf3d54fd78ed488ec8ccdbec5a53"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"4ac773ddb2b9ca095c5d22fbd97ae2e2f8070913","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro not in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":11,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% block novajoin_notifier_footer %}{% endblock %}"},{"line_number":16,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7f231b9d_aafab03f","line":13,"range":{"start_line":8,"start_character":0,"end_line":13,"end_character":11},"in_reply_to":"df140735_574f5e33","updated":"2017-06-15 16:39:57.000000000","message":"@hrw: do note the negation, it excludes everything that\u0027s not an rpm distro.","commit_id":"604fdb03b1bcaf3d54fd78ed488ec8ccdbec5a53"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"591eec3d40c9e876916bd01820819c4c16ee93ab","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro not in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":11,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% block novajoin_notifier_footer %}{% endblock %}"},{"line_number":16,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"df140735_574f5e33","line":13,"range":{"start_line":8,"start_character":0,"end_line":13,"end_character":11},"in_reply_to":"df140735_94463021","updated":"2017-06-02 04:44:58.000000000","message":"That is handled in the base image.","commit_id":"604fdb03b1bcaf3d54fd78ed488ec8ccdbec5a53"}],"docker/novajoin/novajoin-server/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block novajoin_server_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff0f0b1f_6ff6f565","line":19,"updated":"2017-05-23 08:34:00.000000000","message":"same comments as previous file","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6640517f6b3dbf4869cb56c83de6e8a8cf43ebff","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro not in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":11,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% block novajoin_server_footer %}{% endblock %}"},{"line_number":16,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"df140735_3461a4aa","line":13,"range":{"start_line":8,"start_character":0,"end_line":13,"end_character":11},"updated":"2017-06-01 11:24:49.000000000","message":"same here","commit_id":"604fdb03b1bcaf3d54fd78ed488ec8ccdbec5a53"}],"kolla/common/config.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"40e3b6804fdb7df0a11079e20e87dbe5c8ca85af","unresolved":false,"context_lines":[{"line_number":859,"context_line":"        \u0027uid\u0027: 42465,"},{"line_number":860,"context_line":"        \u0027gid\u0027: 42465,"},{"line_number":861,"context_line":"    },"},{"line_number":862,"context_line":"    \u0027novajoin-user\u0027: {"},{"line_number":863,"context_line":"        \u0027uid\u0027: 42466,"},{"line_number":864,"context_line":"        \u0027gid\u0027: 42466,"},{"line_number":865,"context_line":"    }"},{"line_number":866,"context_line":"}"},{"line_number":867,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_aff76d59","line":864,"range":{"start_line":862,"start_character":0,"end_line":864,"end_character":21},"updated":"2017-05-23 08:34:00.000000000","message":"not created in any dockerfile, is used or needed? if so, please add the macro for novajoin user at novajoin-base image","commit_id":"2b080f940a6fd98d2923a3598e535ba4bb68503c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f9946b3302651bdec2cd64863713871c353a854c","unresolved":false,"context_lines":[{"line_number":859,"context_line":"        \u0027uid\u0027: 42465,"},{"line_number":860,"context_line":"        \u0027gid\u0027: 42465,"},{"line_number":861,"context_line":"    },"},{"line_number":862,"context_line":"    \u0027novajoin-user\u0027: {"},{"line_number":863,"context_line":"        \u0027uid\u0027: 42466,"},{"line_number":864,"context_line":"        \u0027gid\u0027: 42466,"},{"line_number":865,"context_line":"    }"},{"line_number":866,"context_line":"}"},{"line_number":867,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_9a7aa9ee","line":864,"range":{"start_line":862,"start_character":0,"end_line":864,"end_character":21},"updated":"2017-05-23 09:03:42.000000000","message":"where is the user used?","commit_id":"a81af2609e1b25452e76ad7de2951a151e65135d"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1d10e43f52f1c93c62890dbd509bf4b4ccf6281b","unresolved":false,"context_lines":[{"line_number":859,"context_line":"        \u0027uid\u0027: 42465,"},{"line_number":860,"context_line":"        \u0027gid\u0027: 42465,"},{"line_number":861,"context_line":"    },"},{"line_number":862,"context_line":"    \u0027novajoin-user\u0027: {"},{"line_number":863,"context_line":"        \u0027uid\u0027: 42466,"},{"line_number":864,"context_line":"        \u0027gid\u0027: 42466,"},{"line_number":865,"context_line":"    }"},{"line_number":866,"context_line":"}"},{"line_number":867,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_bade8dd7","line":864,"range":{"start_line":862,"start_character":0,"end_line":864,"end_character":21},"in_reply_to":"ff0f0b1f_9a7aa9ee","updated":"2017-05-23 09:07:58.000000000","message":"It\u0027s not, I was just following convention and it explicitly mentioned adding it in the docs IIRC.","commit_id":"a81af2609e1b25452e76ad7de2951a151e65135d"}],"tests/test_build.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bbb9b7a0aa4f935c05f5d7a75aa73f5c0f68e519","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"kuryr-base\","},{"line_number":124,"context_line":"        \"mistral-event-engine\","},{"line_number":125,"context_line":"        \"monasca-base\","},{"line_number":126,"context_line":"        \"novajoin-base\","},{"line_number":127,"context_line":"        \"neutron-sfc-agent\","},{"line_number":128,"context_line":"        \"octavia-base\","},{"line_number":129,"context_line":"        \"panko-base\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_4414844e","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":24},"updated":"2017-05-19 14:39:08.000000000","message":"is needed on each  group packages not exist, debian and ubuntu binary","commit_id":"81e4669104a2cc44922923e046f24a5508238e20"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"319ab60d47f91874e6cd322aa8f718b7a2706e67","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        \"mistral-event-engine\","},{"line_number":170,"context_line":"        \"monasca-base\","},{"line_number":171,"context_line":"        \"novajoin-base\","},{"line_number":172,"context_line":"        \"neutron-sfc-agent\","},{"line_number":173,"context_line":"        \"neutron-sfc-agent\","},{"line_number":174,"context_line":"        \"octavia-base\","},{"line_number":175,"context_line":"        \"panko-base\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_944059a7","line":172,"updated":"2017-05-22 15:36:41.000000000","message":"Looks like you duplicate neutron-sfc-agent.\n\nGiven that Debian and Ubuntu aren\u0027t support yet will adding novajoin-base blow up?","commit_id":"7501974910380d5d8ebc36385bafdaa08efb2f56"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e71a10aaf4ac8255dc405c9906c1ca5cce216a7a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"kuryr-base\","},{"line_number":124,"context_line":"        \"mistral-event-engine\","},{"line_number":125,"context_line":"        \"monasca-base\","},{"line_number":126,"context_line":"        \"novajoin-base\","},{"line_number":127,"context_line":"        \"neutron-sfc-agent\","},{"line_number":128,"context_line":"        \"octavia-base\","},{"line_number":129,"context_line":"        \"panko-base\","}],"source_content_type":"text/x-python","patch_set":11,"id":"7f231b9d_11c2e659","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":24},"updated":"2017-06-16 08:15:46.000000000","message":"please, alphabetize","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"1eb0d533f0bf38543e0cf6a125ecc32b9e523508","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"kuryr-base\","},{"line_number":124,"context_line":"        \"mistral-event-engine\","},{"line_number":125,"context_line":"        \"monasca-base\","},{"line_number":126,"context_line":"        \"novajoin-base\","},{"line_number":127,"context_line":"        \"neutron-sfc-agent\","},{"line_number":128,"context_line":"        \"octavia-base\","},{"line_number":129,"context_line":"        \"panko-base\","}],"source_content_type":"text/x-python","patch_set":11,"id":"7f231b9d_7d91ebf0","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":24},"in_reply_to":"7f231b9d_11c2e659","updated":"2017-06-16 10:37:15.000000000","message":"move it to L127.","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"41ccee24521a3c9b7d3a2039e01b313440a4788d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"kuryr-base\","},{"line_number":124,"context_line":"        \"mistral-event-engine\","},{"line_number":125,"context_line":"        \"monasca-base\","},{"line_number":126,"context_line":"        \"novajoin-base\","},{"line_number":127,"context_line":"        \"neutron-sfc-agent\","},{"line_number":128,"context_line":"        \"octavia-base\","},{"line_number":129,"context_line":"        \"panko-base\","}],"source_content_type":"text/x-python","patch_set":11,"id":"7f231b9d_5f2299ba","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":24},"in_reply_to":"7f231b9d_7d91ebf0","updated":"2017-06-16 18:06:18.000000000","message":"Done","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e71a10aaf4ac8255dc405c9906c1ca5cce216a7a","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        \"kuryr-base\","},{"line_number":169,"context_line":"        \"mistral-event-engine\","},{"line_number":170,"context_line":"        \"monasca-base\","},{"line_number":171,"context_line":"        \"novajoin-base\","},{"line_number":172,"context_line":"        \"neutron-sfc-agent\","},{"line_number":173,"context_line":"        \"octavia-base\","},{"line_number":174,"context_line":"        \"panko-base\","}],"source_content_type":"text/x-python","patch_set":11,"id":"7f231b9d_f1b40af4","line":171,"range":{"start_line":171,"start_character":8,"end_line":171,"end_character":24},"updated":"2017-06-16 08:15:46.000000000","message":"ditto","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"41ccee24521a3c9b7d3a2039e01b313440a4788d","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        \"kuryr-base\","},{"line_number":169,"context_line":"        \"mistral-event-engine\","},{"line_number":170,"context_line":"        \"monasca-base\","},{"line_number":171,"context_line":"        \"novajoin-base\","},{"line_number":172,"context_line":"        \"neutron-sfc-agent\","},{"line_number":173,"context_line":"        \"octavia-base\","},{"line_number":174,"context_line":"        \"panko-base\","}],"source_content_type":"text/x-python","patch_set":11,"id":"7f231b9d_3f2d9da7","line":171,"range":{"start_line":171,"start_character":8,"end_line":171,"end_character":24},"in_reply_to":"7f231b9d_f1b40af4","updated":"2017-06-16 18:06:18.000000000","message":"Done","commit_id":"ed4d4dbffe1c223c634433184e25e1d2511f8d66"}]}