)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"a8c661137d2730597c11c3fbe3f19fbe61b957fe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Juan Badia Payno \u003cjbadiapa@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-04 16:40:45 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modified fluentd Image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use the fluentd package on the CentOS OpsTools repository"},{"line_number":10,"context_line":"creted by the CentOS OpsTools SIG."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3f1d235d_050d2ea0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"updated":"2017-07-05 02:37:18.000000000","message":"IMO, you should clarify the title a little bit, something like \"Change fluentd repository for CentOS\"?","commit_id":"5806336ec2126a8a74492fe6d4e3660171033395"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"a8c661137d2730597c11c3fbe3f19fbe61b957fe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modified fluentd Image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use the fluentd package on the CentOS OpsTools repository"},{"line_number":10,"context_line":"creted by the CentOS OpsTools SIG."},{"line_number":11,"context_line":"This patch should only affect the RedHat base image."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4802618373cfa53d67d1dfe65be7abe1950b3d04"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3f1d235d_45c0c62a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":6},"updated":"2017-07-05 02:37:18.000000000","message":"created","commit_id":"5806336ec2126a8a74492fe6d4e3660171033395"},{"author":{"_account_id":894,"name":"Juan J. Martínez","email":"jjm@usebox.net","username":"jjmartinez"},"change_message_id":"67d42c6de53e29842532bb5a833284a0495b57cb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use the fluentd package on the CentOS OpsTools repository"},{"line_number":10,"context_line":"created by the CentOS OpsTools SIG."},{"line_number":11,"context_line":"This patch should only affect CentOS/RedHat base image."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"-The user changed to fluentd from td-agent"},{"line_number":14,"context_line":"-Plugins are installed either as rpm packages or gems on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"ff346bd7_d7aab283","line":11,"updated":"2017-07-24 08:59:36.000000000","message":"And Oraclelinux? To be honest, I would remove this line as it really doesn\u0027t add useful information that is not implicit from reading the rest of the commit message.","commit_id":"4160be69642f2faa2f5c4be81b49629fbb297ddb"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"820720c76401db6b9407bb1e7b3a6da655db9c40","unresolved":false,"context_lines":[{"line_number":312,"context_line":"      \u00274D1BB29D63D98E422B2113B19334A25F8507EFA5\u0027,"},{"line_number":313,"context_line":"      \u002758118E89F3A912897C070ADBF76221572C52609D\u0027,"},{"line_number":314,"context_line":"      \u00274D8EB5FDA37AB55F41A135203BF88A0C6A770882\u0027,"},{"line_number":315,"context_line":"      \u0027901F9177AB97ACBE\u0027"},{"line_number":316,"context_line":"    ] %}"},{"line_number":317,"context_line":"{% elif base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":318,"context_line":"    {% set base_apt_keys \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_01d2a500","line":315,"updated":"2017-05-23 12:54:46.000000000","message":"missing osops repo for deb distros","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"bb51600f5d1747601a03877c659c02ea6e31342b","unresolved":false,"context_lines":[{"line_number":312,"context_line":"      \u00274D1BB29D63D98E422B2113B19334A25F8507EFA5\u0027,"},{"line_number":313,"context_line":"      \u002758118E89F3A912897C070ADBF76221572C52609D\u0027,"},{"line_number":314,"context_line":"      \u00274D8EB5FDA37AB55F41A135203BF88A0C6A770882\u0027,"},{"line_number":315,"context_line":"      \u0027901F9177AB97ACBE\u0027"},{"line_number":316,"context_line":"    ] %}"},{"line_number":317,"context_line":"{% elif base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":318,"context_line":"    {% set base_apt_keys \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_9770370a","line":315,"in_reply_to":"ff0f0b1f_01d2a500","updated":"2017-05-23 14:23:39.000000000","message":"I do not know that debian has a Opstools repo.\nHowever the fluentd repo is already installed.\nhttps://github.com/openstack/kolla/blob/master/docker/base/sources.list.ubuntu#L37","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1f6a6188b9c1e4cd5728bd20df09f79abf9a6167","unresolved":false,"context_lines":[{"line_number":312,"context_line":"      \u00274D1BB29D63D98E422B2113B19334A25F8507EFA5\u0027,"},{"line_number":313,"context_line":"      \u002758118E89F3A912897C070ADBF76221572C52609D\u0027,"},{"line_number":314,"context_line":"      \u00274D8EB5FDA37AB55F41A135203BF88A0C6A770882\u0027,"},{"line_number":315,"context_line":"      \u0027901F9177AB97ACBE\u0027"},{"line_number":316,"context_line":"    ] %}"},{"line_number":317,"context_line":"{% elif base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":318,"context_line":"    {% set base_apt_keys \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_f4ed2eb7","line":315,"in_reply_to":"ff0f0b1f_9770370a","updated":"2017-05-23 14:32:08.000000000","message":"yep, it is, there is other change (sensu iirc) implementing ops repos","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"ab5b9de8e629acae87df24425b590d7c77de6262","unresolved":false,"context_lines":[{"line_number":312,"context_line":"      \u00274D1BB29D63D98E422B2113B19334A25F8507EFA5\u0027,"},{"line_number":313,"context_line":"      \u002758118E89F3A912897C070ADBF76221572C52609D\u0027,"},{"line_number":314,"context_line":"      \u00274D8EB5FDA37AB55F41A135203BF88A0C6A770882\u0027,"},{"line_number":315,"context_line":"      \u0027901F9177AB97ACBE\u0027"},{"line_number":316,"context_line":"    ] %}"},{"line_number":317,"context_line":"{% elif base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":318,"context_line":"    {% set base_apt_keys \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_7737e04e","line":315,"in_reply_to":"ff0f0b1f_d74eac6d","updated":"2017-05-23 15:03:55.000000000","message":"yeah, sorry about that","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"ada4ce3a810303dc1dcf730adf72eeadb1de6aaf","unresolved":false,"context_lines":[{"line_number":312,"context_line":"      \u00274D1BB29D63D98E422B2113B19334A25F8507EFA5\u0027,"},{"line_number":313,"context_line":"      \u002758118E89F3A912897C070ADBF76221572C52609D\u0027,"},{"line_number":314,"context_line":"      \u00274D8EB5FDA37AB55F41A135203BF88A0C6A770882\u0027,"},{"line_number":315,"context_line":"      \u0027901F9177AB97ACBE\u0027"},{"line_number":316,"context_line":"    ] %}"},{"line_number":317,"context_line":"{% elif base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":318,"context_line":"    {% set base_apt_keys \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_d74eac6d","line":315,"in_reply_to":"ff0f0b1f_f4ed2eb7","updated":"2017-05-23 14:52:54.000000000","message":"Yes, you\u0027re right. There is a sensu patch on-going and it also included the opstools repo for centos. But what they added here it is the sensu repo, not the deb-ops-repo.","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"b5dd34e425d154da3dd38ef53a46671e21aee40d","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    {% set base_centos_yum_repo_packages \u003d base_centos_yum_repo_packages + ["},{"line_number":137,"context_line":"        \u0027centos-release-ceph-jewel\u0027,"},{"line_number":138,"context_line":"        \u0027centos-release-opstools\u0027,"},{"line_number":139,"context_line":"        \u0027centos-release-qemu-ev\u0027"},{"line_number":140,"context_line":"    ] %}"},{"line_number":141,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"df140735_8f69c526","line":138,"updated":"2017-05-30 07:15:44.000000000","message":"when enabling centos-release-opstools, I\u0027d prefer to disable epel.\n\nPackages not in centos-opstools are: libtomcrypt, libtommatch, and scsi-target-utils. In my tests I did not saw any issues with just removing them","commit_id":"6f643aa438d6342f510b323c9d5526af7b2e0c40"}],"docker/fluentd/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"820720c76401db6b9407bb1e7b3a6da655db9c40","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {{ macros.configure_user(name\u003d\u0027fluentd\u0027, groups\u003d\u0027fluentd\u0027) }}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_a142d9a9","line":8,"range":{"start_line":8,"start_character":31,"end_line":8,"end_character":32},"updated":"2017-05-23 12:54:46.000000000","message":"extra space","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"72bc3ffeae9a0cb552986ca1ccb26cc6127f55ab","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {{ macros.configure_user(name\u003d\u0027fluentd\u0027, groups\u003d\u0027fluentd\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":13,"context_line":"        \u0027fluentd\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_94a8328c","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":65},"updated":"2017-05-23 14:31:24.000000000","message":"for the user mean this, is creating fluentd.","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"820720c76401db6b9407bb1e7b3a6da655db9c40","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    {{ macros.configure_user(name\u003d\u0027fluentd\u0027, groups\u003d\u0027fluentd\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":13,"context_line":"        \u0027fluentd\u0027"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_c18f0dcb","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":16},"updated":"2017-05-23 12:54:46.000000000","message":"what version is this installing, upgrade to other version need many changes in other deployment tools and thing on the upgrade proceidure","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"ab5b9de8e629acae87df24425b590d7c77de6262","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    {{ macros.configure_user(name\u003d\u0027fluentd\u0027, groups\u003d\u0027fluentd\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":13,"context_line":"        \u0027fluentd\u0027"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_775ec076","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":16},"in_reply_to":"ff0f0b1f_7296d1f2","updated":"2017-05-23 15:03:55.000000000","message":"my concern with the version is: if we have two sources (ops repo and the other(not sure which repo provides this binary) is how we manage versioning, when fluentd config differs from the binary in centos or ubuntu or oraclelinux.\nzhubinbing can clarify more this which is our fluentd expert","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"bb51600f5d1747601a03877c659c02ea6e31342b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    {{ macros.configure_user(name\u003d\u0027fluentd\u0027, groups\u003d\u0027fluentd\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":13,"context_line":"        \u0027fluentd\u0027"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_7296d1f2","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":16},"in_reply_to":"ff0f0b1f_c18f0dcb","updated":"2017-05-23 14:23:39.000000000","message":"The version is 0.12.26","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"820720c76401db6b9407bb1e7b3a6da655db9c40","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% else %}"},{"line_number":17,"context_line":"   {{ macros.configure_user(name\u003d\u0027td-agent\u0027, groups\u003d\u0027mysql\u0027) }}"},{"line_number":18,"context_line":"   {% if base_distro in [\u0027oraclelinux\u0027] %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":21,"context_line":"        \u0027gcc-c++\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_21d369d7","line":18,"range":{"start_line":18,"start_character":26,"end_line":18,"end_character":37},"updated":"2017-05-23 12:54:46.000000000","message":"why oraclelinux have a different install, repos are the same as centos,rhel","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"820720c76401db6b9407bb1e7b3a6da655db9c40","unresolved":false,"context_lines":[{"line_number":56,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":57,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027,\u0027oraclelinux\u0027] %}"},{"line_number":60,"context_line":"RUN chown -R td-agent: /etc/td-agent"},{"line_number":61,"context_line":"USER td-agent"},{"line_number":62,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":63,"context_line":"RUN chown -R fluentd: /etc/fluentd"},{"line_number":64,"context_line":"USER fluentd"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% block fluentd_footer %}{% endblock %}"},{"line_number":68,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_4143fd6c","line":65,"range":{"start_line":59,"start_character":0,"end_line":65,"end_character":11},"updated":"2017-05-23 12:54:46.000000000","message":"users should be at the end of the dockerfile","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cb8564a580262b4cf1cbad01998c35e7c6e5e5e2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{ macros.install_packages(fluentd_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# NOTE: We use fluentd version is v12.0 so fluent-plugin-grok-parse version should \u003c 1.0.0."},{"line_number":30,"context_line":"# https://github.com/fluent/fluent-plugin-grok-parser"},{"line_number":31,"context_line":"RUN ulimit -n 65536 \\"},{"line_number":32,"context_line":"    \u0026\u0026 sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"},{"line_number":33,"context_line":"    \u0026\u0026 td-agent-gem install fluent-plugin-parser fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch fluent-plugin-grep fluent-plugin-grok-parser:0.3.1 fluent-plugin-rewrite-tag-filter \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df140735_6bc17c2e","side":"PARENT","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":53},"updated":"2017-06-01 10:00:24.000000000","message":"please, not remove this NOTE, to make people know the issue with grok-parser","commit_id":"ddad3fc6af469ef721c44a114daba8638e24fcce"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cb8564a580262b4cf1cbad01998c35e7c6e5e5e2","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {{ macros.configure_user(name\u003d\u0027fluentd\u0027, groups\u003d\u0027fluentd\u0027) }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":13,"context_line":"        \u0027fluentd\u0027"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df140735_4b8b581e","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":61},"updated":"2017-06-01 10:00:24.000000000","message":"mysql group was needed to read mariadb logs.macro to create an user, creates the group with the same user, this groups is to append into other groups","commit_id":"41ef5849b9b9dae8ad1a34e0603450b32baa20ad"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cb8564a580262b4cf1cbad01998c35e7c6e5e5e2","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":31,"context_line":"RUN sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"},{"line_number":32,"context_line":"    \u0026\u0026 td-agent-gem install fluent-plugin-parser fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch fluent-plugin-grep fluent-plugin-grok-parser:0.3.1 fluent-plugin-rewrite-tag-filter \\"},{"line_number":33,"context_line":"    \u0026\u0026 rm -f /etc/td-agent/td-agent.conf"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df140735_0b01e06b","line":32,"range":{"start_line":32,"start_character":7,"end_line":32,"end_character":27},"updated":"2017-06-01 10:00:24.000000000","message":"why plugins install was removed for centos? will break ansible and k8s deployments.","commit_id":"41ef5849b9b9dae8ad1a34e0603450b32baa20ad"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cb8564a580262b4cf1cbad01998c35e7c6e5e5e2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":37,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":40,"context_line":"RUN sed -i -e \"s/USERGROUP/td-agent\\:kolla/g\"  -e \"s/FLUENTD/td-agent/g\" /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":41,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":42,"context_line":"RUN sed -i -e \"s/USERGROUP/td-agent\\:kolla/g\" -e \"s/FLUENTD/fluentd/g\" /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":46,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df140735_8e517d65","line":43,"range":{"start_line":39,"start_character":0,"end_line":43,"end_character":11},"updated":"2017-06-01 10:00:24.000000000","message":"please, try to merge all those RUN into a single one to reduce image layers, one for debian\u0027s and other for centos.","commit_id":"41ef5849b9b9dae8ad1a34e0603450b32baa20ad"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cb8564a580262b4cf1cbad01998c35e7c6e5e5e2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"RUN sed -i -e \"s/USERGROUP/td-agent\\:kolla/g\" -e \"s/FLUENTD/fluentd/g\" /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":46,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":49,"context_line":"RUN chown -R td-agent: /etc/td-agent"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df140735_6e774904","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":50},"updated":"2017-06-01 10:00:24.000000000","message":"can we move this run to line 37?","commit_id":"41ef5849b9b9dae8ad1a34e0603450b32baa20ad"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e243b424f0ebf68a25c4fefec6d3e84e80ce0f2a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{ macros.install_packages(fluentd_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":"# NOTE: We use fluentd version is v12.0 so fluent-plugin-grok-parse version should \u003c 1.0.0."},{"line_number":28,"context_line":"# https://github.com/fluent/fluent-plugin-grok-parser"},{"line_number":29,"context_line":"RUN ulimit -n 65536"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":32,"context_line":"RUN sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9f0e0f27_d1fc2440","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":10},"updated":"2017-06-09 10:58:18.000000000","message":"integrate that RUN with next one","commit_id":"c6fe1e77fede5bb83e9d8cc2d3424d91713b51e4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e243b424f0ebf68a25c4fefec6d3e84e80ce0f2a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":43,"context_line":"RUN sed -i -e \"s/USERGROUP/td-agent\\:kolla/g\"  -e \"s/FLUENTD/td-agent/g\" /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":44,"context_line":"RUN chown -R td-agent: /etc/td-agent"},{"line_number":45,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":46,"context_line":"RUN sed -i -e \"s/USERGROUP/td-agent\\:kolla/g\" -e \"s/FLUENTD/fluentd/g\" /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":47,"context_line":"RUN chown -R fluentd: /etc/fluentd"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9f0e0f27_91bd8c6a","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":36},"updated":"2017-06-09 10:58:18.000000000","message":"merge them into one","commit_id":"c6fe1e77fede5bb83e9d8cc2d3424d91713b51e4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e243b424f0ebf68a25c4fefec6d3e84e80ce0f2a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"RUN sed -i -e \"s/USERGROUP/td-agent\\:kolla/g\"  -e \"s/FLUENTD/td-agent/g\" /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":44,"context_line":"RUN chown -R td-agent: /etc/td-agent"},{"line_number":45,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":46,"context_line":"RUN sed -i -e \"s/USERGROUP/td-agent\\:kolla/g\" -e \"s/FLUENTD/fluentd/g\" /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":47,"context_line":"RUN chown -R fluentd: /etc/fluentd"},{"line_number":48,"context_line":"{% endif %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"{% block fluentd_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9f0e0f27_71c2f8eb","line":47,"range":{"start_line":46,"start_character":11,"end_line":47,"end_character":16},"updated":"2017-06-09 10:58:18.000000000","message":"merge them into one","commit_id":"c6fe1e77fede5bb83e9d8cc2d3424d91713b51e4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e243b424f0ebf68a25c4fefec6d3e84e80ce0f2a","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"{% block fluentd_footer %}{% endblock %}"},{"line_number":51,"context_line":"{% block footer %}{% endblock %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":54,"context_line":"USER td-agent"},{"line_number":55,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":56,"context_line":"USER fluentd"},{"line_number":57,"context_line":"{% endif %}"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9f0e0f27_51b7f487","line":57,"range":{"start_line":52,"start_character":0,"end_line":57,"end_character":11},"updated":"2017-06-09 10:58:18.000000000","message":"usual order is first rpm ones, then deb ones","commit_id":"c6fe1e77fede5bb83e9d8cc2d3424d91713b51e4"},{"author":{"_account_id":894,"name":"Juan J. Martínez","email":"jjm@usebox.net","username":"jjmartinez"},"change_message_id":"d1b381c19d6097a6132f2da051f4e6d2ecf0b3e9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":15,"context_line":"        \u0027gcc-c++\u0027"},{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":"{% elif base_distro in [\u0027oraclelinux\u0027] %}"},{"line_number":18,"context_line":"    {{ macros.configure_user(name\u003d\u0027td-agent\u0027, groups\u003d\u0027mysql\u0027) }}"},{"line_number":19,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":20,"context_line":"        \u0027gcc-c++\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"5f201791_cc104a5a","line":17,"updated":"2017-06-27 15:37:49.000000000","message":"Why not base_distro \u003d\u003d \u0027oraclelinux\u0027? Is there a reason to use  \"in\" with just one single item in the list?","commit_id":"c6789aaed40b1ed40e1e5238e4986ef145d6e9c5"},{"author":{"_account_id":894,"name":"Juan J. Martínez","email":"jjm@usebox.net","username":"jjmartinez"},"change_message_id":"d1b381c19d6097a6132f2da051f4e6d2ecf0b3e9","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# NOTE: We use fluentd version is v12.0 so fluent-plugin-grok-parse version should \u003c 1.0.0."},{"line_number":39,"context_line":"# https://github.com/fluent/fluent-plugin-grok-parser"},{"line_number":40,"context_line":"{% if base_distro in [\u0027centos\u0027] %}"},{"line_number":41,"context_line":"RUN ulimit -n 65536 \\"},{"line_number":42,"context_line":"    \u0026\u0026 gem install --minimal-deps activesupport:4.2.9 fluent-plugin-parser fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch fluent-plugin-grep fluent-plugin-grok-parser:0.3.1 fluent-plugin-rewrite-tag-filter \\"},{"line_number":43,"context_line":"    \u0026\u0026 rm -f /etc/fluentd/fluentd.conf"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"5f201791_6c013606","line":40,"updated":"2017-06-27 15:37:49.000000000","message":"Same; \"in\" used with only one item in the list.","commit_id":"c6789aaed40b1ed40e1e5238e4986ef145d6e9c5"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"ff15413ccaabf1126c83bb90e23cc6e2647c2c96","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{% if base_distro in [\u0027rhel\u0027] %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"COPY rhel_fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":41,"context_line":"COPY rhel_extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"RUN ulimit -n 65536 \\"},{"line_number":44,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":45,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":46,"context_line":"    \u0026\u0026 chown -R fluentd: /etc/fluentd"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% else %}"},{"line_number":49,"context_line":"# NOTE: We use fluentd version is v12.0 so fluent-plugin-grok-parse version should \u003c 1.0.0."}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"3f1d235d_138eff26","line":46,"range":{"start_line":40,"start_character":0,"end_line":46,"end_character":37},"updated":"2017-07-10 10:13:13.000000000","message":"If we are going to need sudoers file and extend_start script, I don\u0027t think it should be used only for rhel. \n\nIMO the only difference between centos and rhel should be that we don\u0027t install gems on rhel.","commit_id":"63a02b9c6bff8deb3a86ee1e167ba31ccf8b2151"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"287b45551e844fbc6973f78c934726284d6307ae","unresolved":false,"context_lines":[{"line_number":40,"context_line":"COPY rpm_extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"RUN ulimit -n 65536 \\"},{"line_number":43,"context_line":"    \u0026\u0026 gem install --minimal-deps activesupport:4.2.9 fluent-plugin-parser fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch fluent-plugin-grep fluent-plugin-grok-parser:0.3.1 fluent-plugin-rewrite-tag-filter \\"},{"line_number":44,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":45,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":46,"context_line":"    \u0026\u0026 chown -R fluentd: /etc/fluentd"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f1d235d_b770300a","line":43,"range":{"start_line":43,"start_character":7,"end_line":43,"end_character":18},"updated":"2017-07-11 09:58:31.000000000","message":"are plugins bundled into rpms deps for redhat? whats the difference in the packages?","commit_id":"8355d4cb98d575404c76a17af4e57122417096a4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c0b4e7f1f18677f947ae5bda68753ebef6c9af33","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":38,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":39,"context_line":"    \u0026\u0026 chown -R fluentd: /etc/fluentd \\"},{"line_number":40,"context_line":"    \u0026\u0026 mkdir -p /var/run/fluentd \\"},{"line_number":41,"context_line":"    \u0026\u0026 chown -R fluentd: /var/run/fluentd"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"{% elif base_distro \u003d\u003d \u0027rhel\u0027  %}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1f1a1f67_b40df538","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":32},"updated":"2017-07-13 08:18:25.000000000","message":"Is fluentd using this path? in my previous ansible changes failed because is not created. I think is another path. By chance know what is fluentd defaults? Tried fluent and fluentd but none seems to exists","commit_id":"d662ad2949779455d01c21544f9d85bf74cdb38c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ed493393d9d0f41f2c1a5c83efb10741281faf7a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    \u0026\u0026 mkdir -p /var/run/fluentd \\"},{"line_number":52,"context_line":"    \u0026\u0026 chown -R fluentd: /var/run/fluentd"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% else %}"},{"line_number":56,"context_line":"# NOTE: We use fluentd version is v12.0 so fluent-plugin-grok-parse version should \u003c 1.0.0."},{"line_number":57,"context_line":"# https://github.com/fluent/fluent-plugin-grok-parser"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1f1a1f67_2c22b9a5","line":54,"updated":"2017-07-13 10:31:51.000000000","message":"remove one lines.","commit_id":"d662ad2949779455d01c21544f9d85bf74cdb38c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"253893c50a6dabc8c388f6864e283a35956b103f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    \u0026\u0026 chown -R fluentd: /var/run/fluentd"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% else %}"},{"line_number":56,"context_line":"# NOTE: We use fluentd version is v12.0 so fluent-plugin-grok-parse version should \u003c 1.0.0."},{"line_number":57,"context_line":"# https://github.com/fluent/fluent-plugin-grok-parser"},{"line_number":58,"context_line":"RUN ulimit -n 65536 \\"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1f1a1f67_caa44a0b","line":55,"range":{"start_line":55,"start_character":3,"end_line":55,"end_character":7},"updated":"2017-07-13 09:17:51.000000000","message":"elif for ubuntu and debian","commit_id":"d662ad2949779455d01c21544f9d85bf74cdb38c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f24ff2d861268654e67e31fc9cf414061e98b582","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {{ macros.configure_user(name\u003d\u0027fluentd\u0027, groups\u003d\u0027mysql\u0027) }}"},{"line_number":11,"context_line":"# TODO:remove hostname package as it should be installed by the "},{"line_number":12,"context_line":"# fluentd dependencies."},{"line_number":13,"context_line":"# hostname package is installed by default on CentOS/RHEL but not on"},{"line_number":14,"context_line":"# oraclelinux."}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"1f1a1f67_d20d173f","line":11,"range":{"start_line":11,"start_character":63,"end_line":11,"end_character":64},"updated":"2017-07-13 13:57:24.000000000","message":"whitespace","commit_id":"74db2b7149a7fe102478f536206e5e5e55fbbc9e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"72d94c47e6ccd68f0322b402ce19fa1a1ab5a72d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# oraclelinux."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":17,"context_line":"        \u0027hostname\u0027,"},{"line_number":18,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":19,"context_line":"        \u0027make\u0027,"},{"line_number":20,"context_line":"        \u0027ruby-devel\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"1f1a1f67_752bfb81","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":19},"updated":"2017-07-20 10:35:21.000000000","message":"alphabetize","commit_id":"655eecdfbd6a4a5dafbbddc32a739e182c56a087"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"72d94c47e6ccd68f0322b402ce19fa1a1ab5a72d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":19,"context_line":"        \u0027make\u0027,"},{"line_number":20,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":21,"context_line":"        \u0027fluentd\u0027"},{"line_number":22,"context_line":"    ] %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"1f1a1f67_5520ff9b","line":21,"range":{"start_line":21,"start_character":9,"end_line":21,"end_character":17},"updated":"2017-07-20 10:35:21.000000000","message":"ditto","commit_id":"655eecdfbd6a4a5dafbbddc32a739e182c56a087"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"72d94c47e6ccd68f0322b402ce19fa1a1ab5a72d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027g++\u0027,"},{"line_number":28,"context_line":"        \u0027make\u0027,"},{"line_number":29,"context_line":"        \u0027td-agent\u0027"},{"line_number":30,"context_line":"     ] %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"1f1a1f67_b53073ea","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":5},"updated":"2017-07-20 10:35:21.000000000","message":"remove this space","commit_id":"655eecdfbd6a4a5dafbbddc32a739e182c56a087"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"e7b7b250f39bb08bc077efb26cb7016885edfb8f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{{ macros.install_packages(fluentd_packages | customizable(\"packages\")) }}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% if base_distro in  [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":37,"context_line":"COPY rpm_fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":38,"context_line":"COPY rpm_extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"RUN ulimit -n 65536 \\"},{"line_number":41,"context_line":"    \u0026\u0026 gem install --minimal-deps activesupport:4.2.9 fluent-plugin-parser fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch fluent-plugin-grep fluent-plugin-grok-parser:0.3.1 fluent-plugin-rewrite-tag-filter \\"},{"line_number":42,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":43,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":44,"context_line":"    \u0026\u0026 chown -R fluentd: /etc/fluentd \\"},{"line_number":45,"context_line":"    \u0026\u0026 mkdir -p /var/run/fluentd \\"},{"line_number":46,"context_line":"    \u0026\u0026 chown -R fluentd: /var/run/fluentd"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":49,"context_line":"# NOTE: We use fluentd version is v12.0 so fluent-plugin-grok-parse version should \u003c 1.0.0."},{"line_number":50,"context_line":"# https://github.com/fluent/fluent-plugin-grok-parser"},{"line_number":51,"context_line":"RUN ulimit -n 65536 \\"},{"line_number":52,"context_line":"    \u0026\u0026 sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"},{"line_number":53,"context_line":"    \u0026\u0026 td-agent-gem install fluent-plugin-parser fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch fluent-plugin-grep fluent-plugin-grok-parser:0.3.1 fluent-plugin-rewrite-tag-filter \\"},{"line_number":54,"context_line":"    \u0026\u0026 rm -f /etc/td-agent/td-agent.conf"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":57,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":60,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":61,"context_line":"    \u0026\u0026 chown -R td-agent: /etc/td-agent"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% endif %}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% block fluentd_footer %}{% endblock %}"},{"line_number":66,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"ff346bd7_46001602","line":63,"range":{"start_line":36,"start_character":0,"end_line":63,"end_character":11},"updated":"2017-07-25 17:27:22.000000000","message":"Please wrap this in appropriate {% block %}.","commit_id":"77e48fb510e250406646a400252c4eb22aa35c00"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f09c72e1c7043c62264c41b83ed047aeb84a38b3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":45,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":46,"context_line":"    \u0026\u0026 chown -R fluentd: /etc/fluentd \\"},{"line_number":47,"context_line":"    \u0026\u0026 mkdir -p /var/run/fluentd \\"},{"line_number":48,"context_line":"    \u0026\u0026 chown -R fluentd: /var/run/fluentd"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"ff346bd7_25ee08b4","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":34},"updated":"2017-07-26 14:02:13.000000000","message":"can we move this mkdir before chown in line 46, and then merge chown from 46 and 48 into one line command?","commit_id":"1c796fe9c4f9f8b8e448f7995cfa8bb85849bae2"}],"docker/fluentd/extend_start.sh":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"72bc3ffeae9a0cb552986ca1ccb26cc6127f55ab","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    FLUENTD\u003d\"td-agent\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d ${USERGROUP} ]]; then"},{"line_number":17,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":"if [[ $(stat -c %a /var/log/kolla) !\u003d \"2775\" ]]; then"},{"line_number":20,"context_line":"    sudo chmod 2775 /var/log/kolla"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_f471ae45","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":42},"updated":"2017-05-23 14:31:24.000000000","message":"And for the upgrade when user changes, can this cause an upgrade issue changing owner of files?","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"ab5b9de8e629acae87df24425b590d7c77de6262","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    FLUENTD\u003d\"td-agent\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d ${USERGROUP} ]]; then"},{"line_number":17,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":"if [[ $(stat -c %a /var/log/kolla) !\u003d \"2775\" ]]; then"},{"line_number":20,"context_line":"    sudo chmod 2775 /var/log/kolla"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_1790a4ec","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":42},"in_reply_to":"ff0f0b1f_d7610cab","updated":"2017-05-23 15:03:55.000000000","message":"well, not really, we use to have conditionals per distro as made here, oraclelinux also have redhat-release iirc.\n\nWhat I\u0027m really concern is where the binary come. Changing the user is straight forward, check nova_libvirt as example where qemu and libvirt users differs","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"ada4ce3a810303dc1dcf730adf72eeadb1de6aaf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    FLUENTD\u003d\"td-agent\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d ${USERGROUP} ]]; then"},{"line_number":17,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":"if [[ $(stat -c %a /var/log/kolla) !\u003d \"2775\" ]]; then"},{"line_number":20,"context_line":"    sudo chmod 2775 /var/log/kolla"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff0f0b1f_d7610cab","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":42},"in_reply_to":"ff0f0b1f_f471ae45","updated":"2017-05-23 14:52:54.000000000","message":"Well, What I want it\u0027s to do the check regarding the distro. It seems that the user on the distros are different.\nMaybe it will be better to have two files (deb-base \u0026 centos-base) and have the users and path static.\nI thought this way will be easier to maintain, but I\u0027m not close to this solution.\nDo you think that having two files would be easier?","commit_id":"09c1c6310f3f38148c86b0816c28498fb15c7214"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"1f3635f617e26e5336a8dffc2883c6936e09b9b6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Also set the setgid permission on the /var/log/kolla directory so that new"},{"line_number":7,"context_line":"# files and sub-directories in that directory inherit its group id (\"kolla\")."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":10,"context_line":"    USERGROUP\u003d\"td-agent:kolla\""},{"line_number":11,"context_line":"    FLUENTD\u003d\"td-agent\""}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff346bd7_b0722a7a","line":8,"updated":"2017-07-26 20:29:43.000000000","message":"the rpm_... version had important part, which is missing here:\n\n  if [ ! -d /var/log/kolla ]; then\n    mkdir -p /var/log/kolla\n  fi","commit_id":"0e2f8cfd61e6ee34ff60a436552c2e4487e53a3b"}],"docker/fluentd/rpm_extend_start.sh":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"eb6acaed3b5e51922dc8206bc7dd764f031e6a0a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# and sub-directories in the /var/log/kolla directory."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Also set the setgid permission on the /var/log/kolla directory so that new"},{"line_number":7,"context_line":"# files and sub-directories in that directory inherit its group id (\"kolla\")."},{"line_number":8,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d \"fluentd:kolla\" ]]; then"},{"line_number":9,"context_line":"    sudo chown fluentd:kolla /var/log/kolla"},{"line_number":10,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":19,"id":"1f1a1f67_c30b7927","line":7,"updated":"2017-07-18 20:58:31.000000000","message":"Here I had to add: \n\n  mkdir -p /var/log/kolla\n\nto be able to run this image via TripleO. So the question is now if it make sense to have the creation of the directory here or to wrap the COPY directives of (rpm_)extend_start.sh and (rpm_)sudoers with a {% block %}, so we can avoid having those two scripts in the image?","commit_id":"f24bb525093c896796e99b7ce2f67484dad6d8af"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f09c72e1c7043c62264c41b83ed047aeb84a38b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Give processes executed with the \"kolla\" group the permission to create files"},{"line_number":4,"context_line":"# and sub-directories in the /var/log/kolla directory."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Also set the setgid permission on the /var/log/kolla directory so that new"},{"line_number":7,"context_line":"# files and sub-directories in that directory inherit its group id (\"kolla\")."},{"line_number":8,"context_line":"if [ ! -d /var/log/kolla ]; then"},{"line_number":9,"context_line":"    mkdir -p /var/log/kolla"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d \"fluentd:kolla\" ]]; then"},{"line_number":12,"context_line":"    sudo chown fluentd:kolla /var/log/kolla"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":"if [[ $(stat -c %a /var/log/kolla) !\u003d \"2775\" ]]; then"},{"line_number":15,"context_line":"    sudo chmod 2775 /var/log/kolla"},{"line_number":16,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":25,"id":"ff346bd7_65541054","line":16,"range":{"start_line":1,"start_character":0,"end_line":16,"end_character":2},"updated":"2017-07-26 14:02:13.000000000","message":"why duplicate a file only for a user name difference?\nThis can be acomplish in main extend_start with a conditional.\nif [[ \"$(whoami)\" \u003d\u003d \u0027fluentd\u0027 ]]; then\n   FLUENTD_USER\u003dfluentd\nelse\n   FLUENTD_USER\u003dtg-agent\nfi\n\nor a similar logic","commit_id":"1c796fe9c4f9f8b8e448f7995cfa8bb85849bae2"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"58749c247cdcd98b02345c6bdf349efbfbd0ebd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Give processes executed with the \"kolla\" group the permission to create files"},{"line_number":4,"context_line":"# and sub-directories in the /var/log/kolla directory."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Also set the setgid permission on the /var/log/kolla directory so that new"},{"line_number":7,"context_line":"# files and sub-directories in that directory inherit its group id (\"kolla\")."},{"line_number":8,"context_line":"if [ ! -d /var/log/kolla ]; then"},{"line_number":9,"context_line":"    mkdir -p /var/log/kolla"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d \"fluentd:kolla\" ]]; then"},{"line_number":12,"context_line":"    sudo chown fluentd:kolla /var/log/kolla"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":"if [[ $(stat -c %a /var/log/kolla) !\u003d \"2775\" ]]; then"},{"line_number":15,"context_line":"    sudo chmod 2775 /var/log/kolla"},{"line_number":16,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":25,"id":"ff346bd7_8526d4cd","line":16,"range":{"start_line":1,"start_character":0,"end_line":16,"end_character":2},"in_reply_to":"ff346bd7_65541054","updated":"2017-07-26 14:05:33.000000000","message":"or better.\n\nif [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then\n   FLUENTD_USER\u003dtg-agent\nelse\n   FLUENTD_USER\u003dfluentd\nfi","commit_id":"1c796fe9c4f9f8b8e448f7995cfa8bb85849bae2"}],"docker/fluentd/rpm_fluentd_sudoers":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ed493393d9d0f41f2c1a5c83efb10741281faf7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/log/kolla, /usr/bin/chown fluentd\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/lib/fluentd, /usr/bin/chown fluentd\\:kolla /var/lib/fluentd"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/fluentd, /usr/bin/chmod 2775 /var/lib/fluentd"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"1f1a1f67_4c0a95d2","line":2,"updated":"2017-07-13 10:31:51.000000000","message":"this line seem useless.","commit_id":"d662ad2949779455d01c21544f9d85bf74cdb38c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ed493393d9d0f41f2c1a5c83efb10741281faf7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/log/kolla, /usr/bin/chown fluentd\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/lib/fluentd, /usr/bin/chown fluentd\\:kolla /var/lib/fluentd"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/fluentd, /usr/bin/chmod 2775 /var/lib/fluentd"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"1f1a1f67_ecf841c5","line":4,"updated":"2017-07-13 10:31:51.000000000","message":"ditto.","commit_id":"d662ad2949779455d01c21544f9d85bf74cdb38c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f09c72e1c7043c62264c41b83ed047aeb84a38b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/log/kolla, /usr/bin/chown fluentd\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/lib/fluentd, /usr/bin/chown fluentd\\:kolla /var/lib/fluentd"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/fluentd, /usr/bin/chmod 2775 /var/lib/fluentd"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"ff346bd7_c5ce1c2c","line":1,"updated":"2017-07-26 14:02:13.000000000","message":"same for this file,\nwe can use a single file as source of truth for all distros\njust a user name differs","commit_id":"1c796fe9c4f9f8b8e448f7995cfa8bb85849bae2"}],"kolla/common/config.py":[{"author":{"_account_id":18737,"name":"KongWei","email":"kong.wei2@zte.com.cn","username":"kongwei"},"change_message_id":"780c4a40ed645104c163d8ca1121fc60d15adf9a","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        \u0027uid\u0027: 42473,"},{"line_number":936,"context_line":"        \u0027gid\u0027: 42473,"},{"line_number":937,"context_line":"    }"},{"line_number":938,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e Use community fluentd packages for CentOS/RHEL/Oraclelinux"},{"line_number":939,"context_line":"}"},{"line_number":940,"context_line":""},{"line_number":941,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"df3967d1_0d282d84","line":938,"updated":"2017-07-31 07:40:39.000000000","message":"Is this comments?","commit_id":"bf1122909aacf792136eea5b9dae4deca0dd9a6b"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"f3037d3bcaa86902498673878e9f4426411a5dbb","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        \u0027uid\u0027: 42473,"},{"line_number":936,"context_line":"        \u0027gid\u0027: 42473,"},{"line_number":937,"context_line":"    }"},{"line_number":938,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e Use community fluentd packages for CentOS/RHEL/Oraclelinux"},{"line_number":939,"context_line":"}"},{"line_number":940,"context_line":""},{"line_number":941,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"df3967d1_6fcb2453","line":938,"in_reply_to":"df3967d1_0d282d84","updated":"2017-07-31 14:01:52.000000000","message":"I don\u0027t think so. This is screwed up rebase.","commit_id":"bf1122909aacf792136eea5b9dae4deca0dd9a6b"}]}