)]}'
{"docker/ec2-api/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"183782aa24ccb8e175989b08e4f5218c56532979","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"        {% set ec2_api_packages \u003d ["},{"line_number":14,"context_line":"                \u0027openstack-ec2-api\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df140735_a7660851","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":16},"updated":"2017-05-29 08:07:07.000000000","message":"only 4 spaces per indentation","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"6f0c01a0a44e1da8df0a6e176bd699c0f92804f5","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"        {% set ec2_api_packages \u003d ["},{"line_number":14,"context_line":"                \u0027openstack-ec2-api\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df140735_01f0fcc8","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":16},"in_reply_to":"df140735_a7660851","updated":"2017-05-29 11:29:24.000000000","message":"Took it over from tacker. Will fix it though.","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"183782aa24ccb8e175989b08e4f5218c56532979","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":20,"context_line":"            \u0026\u0026 /bin/false"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% endif %}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df140735_875b0486","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":12},"updated":"2017-05-29 08:07:07.000000000","message":"ditto","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9483f4b075007af2e8747451245d6da392ad4347","unresolved":false,"context_lines":[{"line_number":32,"context_line":"] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"RUN ln -s ec2-api-source/* ec2-api \\"},{"line_number":35,"context_line":"    \u0026\u0026 {{ macros.install_pip(ec2_api_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":36,"context_line":"    \u0026\u0026 mkdir -p /etc/ec2api \\"},{"line_number":37,"context_line":"    \u0026\u0026 cp -r /ec2-api/etc/ec2api/* /etc/ec2api \\"},{"line_number":38,"context_line":"    \u0026\u0026 chown -R ec2api: /etc/ec2api"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_84188075","line":35,"updated":"2017-05-26 21:16:09.000000000","message":"Why not doing it in the same way like in the other Dockerfiles?\n\n/var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /ec2-api","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3addd15dd6936277450fa702869272215c38cc4d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"RUN ln -s ec2-api-source/* ec2-api \\"},{"line_number":35,"context_line":"    \u0026\u0026 {{ macros.install_pip(ec2_api_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":36,"context_line":"    \u0026\u0026 mkdir -p /etc/ec2api \\"},{"line_number":37,"context_line":"    \u0026\u0026 cp -r /ec2-api/etc/ec2api/* /etc/ec2api \\"},{"line_number":38,"context_line":"    \u0026\u0026 chown -R ec2api: /etc/ec2api"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df140735_e14bc8ad","line":35,"in_reply_to":"df140735_c1d20435","updated":"2017-05-29 11:36:22.000000000","message":"yep, is OK","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"6f0c01a0a44e1da8df0a6e176bd699c0f92804f5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"RUN ln -s ec2-api-source/* ec2-api \\"},{"line_number":35,"context_line":"    \u0026\u0026 {{ macros.install_pip(ec2_api_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":36,"context_line":"    \u0026\u0026 mkdir -p /etc/ec2api \\"},{"line_number":37,"context_line":"    \u0026\u0026 cp -r /ec2-api/etc/ec2api/* /etc/ec2api \\"},{"line_number":38,"context_line":"    \u0026\u0026 chown -R ec2api: /etc/ec2api"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df140735_c1d20435","line":35,"in_reply_to":"df140735_e74be0ad","updated":"2017-05-29 11:29:24.000000000","message":"So it\u0027s ok like that?","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"6f0c01a0a44e1da8df0a6e176bd699c0f92804f5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"RUN ln -s ec2-api-source/* ec2-api \\"},{"line_number":35,"context_line":"    \u0026\u0026 {{ macros.install_pip(ec2_api_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":36,"context_line":"    \u0026\u0026 mkdir -p /etc/ec2api \\"},{"line_number":37,"context_line":"    \u0026\u0026 cp -r /ec2-api/etc/ec2api/* /etc/ec2api \\"},{"line_number":38,"context_line":"    \u0026\u0026 chown -R ec2api: /etc/ec2api"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df140735_211e600c","line":35,"in_reply_to":"ff0f0b1f_84188075","updated":"2017-05-29 11:29:24.000000000","message":"I started with the tacker image as the basis. I don\u0027t mind, what ever I did, I did it because tacker did it. :-)","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"183782aa24ccb8e175989b08e4f5218c56532979","unresolved":false,"context_lines":[{"line_number":32,"context_line":"] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"RUN ln -s ec2-api-source/* ec2-api \\"},{"line_number":35,"context_line":"    \u0026\u0026 {{ macros.install_pip(ec2_api_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":36,"context_line":"    \u0026\u0026 mkdir -p /etc/ec2api \\"},{"line_number":37,"context_line":"    \u0026\u0026 cp -r /ec2-api/etc/ec2api/* /etc/ec2api \\"},{"line_number":38,"context_line":"    \u0026\u0026 chown -R ec2api: /etc/ec2api"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df140735_e74be0ad","line":35,"in_reply_to":"ff0f0b1f_84188075","updated":"2017-05-29 08:07:07.000000000","message":"This is the new method included in macros.j2\n\nhttps://github.com/openstack/kolla/blob/master/docker/macros.j2#L19","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"}],"kolla/common/config.py":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"d4bb51d9f56b6cb9e1c20a09794125e8ca2341cd","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":311,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/dragonflow/\u0027"},{"line_number":312,"context_line":"                     \u0027dragonflow-master.tar.gz\u0027)},"},{"line_number":313,"context_line":"    \u0027ec2-api\u0027: {"},{"line_number":314,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":315,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/ec2-api/\u0027"},{"line_number":316,"context_line":"                     \u0027ec2-api-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_ed461f50","line":313,"updated":"2017-05-29 09:01:52.000000000","message":"@Eduardo: I don\u0027t think it applies here, since there is no ec2-api-base image but just ec2-api image. See for instance tacker image that uses the same naming scheme.","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"183782aa24ccb8e175989b08e4f5218c56532979","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":311,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/dragonflow/\u0027"},{"line_number":312,"context_line":"                     \u0027dragonflow-master.tar.gz\u0027)},"},{"line_number":313,"context_line":"    \u0027ec2-api\u0027: {"},{"line_number":314,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":315,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/ec2-api/\u0027"},{"line_number":316,"context_line":"                     \u0027ec2-api-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_879e6405","line":313,"range":{"start_line":313,"start_character":5,"end_line":313,"end_character":12},"updated":"2017-05-29 08:07:07.000000000","message":"to maintain consistency with other declaration use, ec2-api-base. and in the dockerfile use\nADD ec2-api-base-archive","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"221d11b6f4eab78fe21fb6eb10980f487e510ed8","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":311,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/dragonflow/\u0027"},{"line_number":312,"context_line":"                     \u0027dragonflow-master.tar.gz\u0027)},"},{"line_number":313,"context_line":"    \u0027ec2-api\u0027: {"},{"line_number":314,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":315,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/ec2-api/\u0027"},{"line_number":316,"context_line":"                     \u0027ec2-api-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_cd9a3bc4","line":313,"in_reply_to":"df140735_ed461f50","updated":"2017-05-29 09:03:14.000000000","message":"You are right, my bad. Please ignore my previous suggestion.","commit_id":"945b4e0cb8e228340963cc1bcd6839ea017dcf89"}]}