)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"ef3ec7df03d2b11bf9c859cfdb554768da80e14b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xinliang Liu \u003cxinliang.liu@linaro.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-03 10:16:00 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Consume centos-pike-testing mariadb version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"centos-pike-testing recieves far more testing and qualification"},{"line_number":10,"context_line":"than any other mariadb package on CentOS.  Lets use that instead"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"9f91af0f_efdcd647","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":19},"updated":"2018-01-03 10:13:16.000000000","message":"nit: this is now centos-queens-testing. You could just say RDO packaged mariadb instead.","commit_id":"a172845f618e0deb8084ac1fd3d12e9a166d01d6"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"3ab2402f3deb3b274690a83299296b122c8fcfcf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xinliang Liu \u003cxinliang.liu@linaro.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-03 10:16:00 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Consume centos-pike-testing mariadb version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"centos-pike-testing recieves far more testing and qualification"},{"line_number":10,"context_line":"than any other mariadb package on CentOS.  Lets use that instead"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"9f91af0f_6a5434cb","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":19},"in_reply_to":"9f91af0f_efdcd647","updated":"2018-01-03 10:44:45.000000000","message":"Done.","commit_id":"a172845f618e0deb8084ac1fd3d12e9a166d01d6"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"a48436f9e7779c69ed7e933c1595e14ef50da3f6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"COPY {{ repo_file }} /etc/yum.repos.d/{{ repo_file }}"},{"line_number":79,"context_line":"{%- endfor %}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"#{{ macros.install_packages(base_yum_url_packages | customizable(\"yum_url_packages\")) }}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{% for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}"},{"line_number":84,"context_line":"{%- if loop.first %}RUN {% else %}    \u0026\u0026 {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"df140735_3519f478","line":81,"updated":"2017-05-29 19:49:09.000000000","message":"No need to comment it out, base_yum_url_packages is defined on line 47.","commit_id":"00f7679fabc38ce7ed698a0825272005d82a4c5a"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3e2b71af2d4247c80552183d136114f667672615","unresolved":false,"context_lines":[{"line_number":91,"context_line":"COPY {{ repo_file }} /etc/yum.repos.d/{{ repo_file }}"},{"line_number":92,"context_line":"{%- endfor %}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"{{ macros.install_packages(base_yum_url_packages | customizable(\"yum_url_packages\")) }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}"},{"line_number":97,"context_line":"{%- if loop.first %}RUN {% else %}    \u0026\u0026 {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_ef186d82","side":"PARENT","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":87},"updated":"2018-01-02 08:29:37.000000000","message":"What if someone has custom list in yum_url_packages?","commit_id":"86afa1417aa5a45de9d71b640719a03801c7b107"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"237bc3887e9201aa6648117ef1163cd99591344e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"COPY {{ repo_file }} /etc/yum.repos.d/{{ repo_file }}"},{"line_number":92,"context_line":"{%- endfor %}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"{{ macros.install_packages(base_yum_url_packages | customizable(\"yum_url_packages\")) }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}"},{"line_number":97,"context_line":"{%- if loop.first %}RUN {% else %}    \u0026\u0026 {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_01355846","side":"PARENT","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":87},"in_reply_to":"9f91af0f_ef186d82","updated":"2018-01-03 02:20:41.000000000","message":"OK, we can reserve this line.","commit_id":"86afa1417aa5a45de9d71b640719a03801c7b107"}],"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a117e3952957bfd09f244671c492c5fd03d55f2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        \u0027python-devel\u0027,"},{"line_number":25,"context_line":"        \u0027mariadb\u0027,"},{"line_number":26,"context_line":"        \u0027mariadb-devel\u0027,"},{"line_number":27,"context_line":"        \u0027-x \"Percona*[Cluster|Server]*\"\u0027"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"df140735_9d4fb1bc","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":40},"updated":"2017-05-30 17:12:51.000000000","message":"ah when i tried to disable the upstream mariadb repo i was getting percona conflicts i did not think of excluding percona here.","commit_id":"35f1ff8a5d7caf2ce7d3d29f6c351c88722a02d7"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"e4e31802f6e7dd941ccf8673d0af57c6b0b1c5d7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        \u0027python-devel\u0027,"},{"line_number":25,"context_line":"        \u0027mariadb\u0027,"},{"line_number":26,"context_line":"        \u0027mariadb-devel\u0027,"},{"line_number":27,"context_line":"        \u0027-x \"Percona*[Cluster|Server]*\"\u0027"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"df140735_6c19cc77","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":40},"in_reply_to":"df140735_9d4fb1bc","updated":"2017-05-30 17:30:25.000000000","message":"actually this can be removed because percona has been removed int his patch.  xtradb-v2 is now integrated in mariadb10.1","commit_id":"35f1ff8a5d7caf2ce7d3d29f6c351c88722a02d7"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3e2b71af2d4247c80552183d136114f667672615","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        \u0027make\u0027,"},{"line_number":23,"context_line":"        \u0027openssh-clients\u0027,"},{"line_number":24,"context_line":"        \u0027openssl-devel\u0027,"},{"line_number":25,"context_line":"        \u0027python-devel\u0027,"},{"line_number":26,"context_line":"        \u0027mariadb\u0027,"},{"line_number":27,"context_line":"        \u0027mariadb-devel\u0027"},{"line_number":28,"context_line":"     ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_ea0dbb37","line":27,"range":{"start_line":25,"start_character":6,"end_line":27,"end_character":23},"updated":"2018-01-02 08:29:37.000000000","message":"alphabetic order please","commit_id":"d53094ce8b0b19ea7a905f7f475457b6b57df1cb"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"237bc3887e9201aa6648117ef1163cd99591344e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        \u0027make\u0027,"},{"line_number":23,"context_line":"        \u0027openssh-clients\u0027,"},{"line_number":24,"context_line":"        \u0027openssl-devel\u0027,"},{"line_number":25,"context_line":"        \u0027python-devel\u0027,"},{"line_number":26,"context_line":"        \u0027mariadb\u0027,"},{"line_number":27,"context_line":"        \u0027mariadb-devel\u0027"},{"line_number":28,"context_line":"     ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_21ef3c85","line":27,"range":{"start_line":25,"start_character":6,"end_line":27,"end_character":23},"in_reply_to":"9f91af0f_ea0dbb37","updated":"2018-01-03 02:20:41.000000000","message":"done.","commit_id":"d53094ce8b0b19ea7a905f7f475457b6b57df1cb"}],"docker/mariadb/Dockerfile.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a117e3952957bfd09f244671c492c5fd03d55f2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027expect\u0027,"},{"line_number":13,"context_line":"        \u0027galera\u0027,"},{"line_number":14,"context_line":"        \u0027hostname\u0027,"},{"line_number":15,"context_line":"        \u0027percona-xtrabackup\u0027,"},{"line_number":16,"context_line":"        \u0027pv\u0027,"},{"line_number":17,"context_line":"        \u0027rsync\u0027,"},{"line_number":18,"context_line":"        \u0027socat\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"df140735_984a1f53","side":"PARENT","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":27},"updated":"2017-05-30 17:12:51.000000000","message":"is this all we are using form the percona repo?\nwe are not using their version of inodb/xtradb as the storage engine?","commit_id":"328acb02a0adf0d7d173a8cc606c4401f67b9d93"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"e4e31802f6e7dd941ccf8673d0af57c6b0b1c5d7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027expect\u0027,"},{"line_number":13,"context_line":"        \u0027galera\u0027,"},{"line_number":14,"context_line":"        \u0027hostname\u0027,"},{"line_number":15,"context_line":"        \u0027percona-xtrabackup\u0027,"},{"line_number":16,"context_line":"        \u0027pv\u0027,"},{"line_number":17,"context_line":"        \u0027rsync\u0027,"},{"line_number":18,"context_line":"        \u0027socat\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"df140735_ec26fcb7","side":"PARENT","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":27},"in_reply_to":"df140735_984a1f53","updated":"2017-05-30 17:30:25.000000000","message":"we were not, i am not sure with 10.1 as its integrated into mariadb now.","commit_id":"328acb02a0adf0d7d173a8cc606c4401f67b9d93"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"95beaf189cfbde6215cd08ffb16fc665efd4c219","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027expect\u0027,"},{"line_number":13,"context_line":"        \u0027galera\u0027,"},{"line_number":14,"context_line":"        \u0027hostname\u0027,"},{"line_number":15,"context_line":"        \u0027percona-xtrabackup\u0027,"},{"line_number":16,"context_line":"        \u0027pv\u0027,"},{"line_number":17,"context_line":"        \u0027rsync\u0027,"},{"line_number":18,"context_line":"        \u0027socat\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bf8cb3f7_623a0f35","side":"PARENT","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":27},"in_reply_to":"df140735_ec26fcb7","updated":"2017-12-25 06:57:29.000000000","message":"10.1 has mariadb-backup replace of percona-xtrabackup[1].\nSo we don\u0027t need to this package.\n\n[1] https://mariadb.com/kb/en/library/mariadb-backup-overview/","commit_id":"328acb02a0adf0d7d173a8cc606c4401f67b9d93"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"95beaf189cfbde6215cd08ffb16fc665efd4c219","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        \u0027mariadb\u0027,"},{"line_number":21,"context_line":"        \u0027mariadb-devel\u0027,"},{"line_number":22,"context_line":"        \u0027mariadb-server\u0027,"},{"line_number":23,"context_line":"        \u0027mariadb-server-galera\u0027,"},{"line_number":24,"context_line":"    ] %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bf8cb3f7_e217ffa2","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":30},"updated":"2017-12-25 06:57:29.000000000","message":"And galera has integrated into mariadb-server[2]. We don\u0027t need to install this pacakge either.\n[2] https://mariadb.com/kb/en/library/getting-started-with-mariadb-galera-cluster/","commit_id":"35f1ff8a5d7caf2ce7d3d29f6c351c88722a02d7"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3e2b71af2d4247c80552183d136114f667672615","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027pv\u0027,"},{"line_number":17,"context_line":"        \u0027rsync\u0027,"},{"line_number":18,"context_line":"        \u0027socat\u0027,"},{"line_number":19,"context_line":"        \u0027tar\u0027,"},{"line_number":20,"context_line":"        \u0027mariadb\u0027,"},{"line_number":21,"context_line":"        \u0027mariadb-server\u0027"},{"line_number":22,"context_line":"    ] %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_8a12ef57","line":21,"range":{"start_line":19,"start_character":8,"end_line":21,"end_character":24},"updated":"2018-01-02 08:29:37.000000000","message":"alphabetic order please","commit_id":"d53094ce8b0b19ea7a905f7f475457b6b57df1cb"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"237bc3887e9201aa6648117ef1163cd99591344e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027pv\u0027,"},{"line_number":17,"context_line":"        \u0027rsync\u0027,"},{"line_number":18,"context_line":"        \u0027socat\u0027,"},{"line_number":19,"context_line":"        \u0027tar\u0027,"},{"line_number":20,"context_line":"        \u0027mariadb\u0027,"},{"line_number":21,"context_line":"        \u0027mariadb-server\u0027"},{"line_number":22,"context_line":"    ] %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_81fde83b","line":21,"range":{"start_line":19,"start_character":8,"end_line":21,"end_character":24},"in_reply_to":"9f91af0f_8a12ef57","updated":"2018-01-03 02:20:41.000000000","message":"done.","commit_id":"d53094ce8b0b19ea7a905f7f475457b6b57df1cb"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"18a340b7bbb1db367f56543e3fee7b33978bcfa0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u0027galera\u0027,"},{"line_number":14,"context_line":"        \u0027hostname\u0027,"},{"line_number":15,"context_line":"        \u0027mariadb\u0027,"},{"line_number":16,"context_line":"        \u0027mariadb-server\u0027,"},{"line_number":17,"context_line":"        \u0027percona-xtrabackup\u0027,"},{"line_number":18,"context_line":"        \u0027pv\u0027,"},{"line_number":19,"context_line":"        \u0027rsync\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"7f96bb07_2121924e","line":16,"updated":"2018-01-11 10:05:42.000000000","message":"wait a minute, shouldn\u0027t this be mariadb-galera-server?","commit_id":"3dcca3fa55baacde6df504be1c5f170a52449dd0"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"b6422abc3644bd7dc56727653d40d23119b405dd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u0027galera\u0027,"},{"line_number":14,"context_line":"        \u0027hostname\u0027,"},{"line_number":15,"context_line":"        \u0027mariadb\u0027,"},{"line_number":16,"context_line":"        \u0027mariadb-server\u0027,"},{"line_number":17,"context_line":"        \u0027percona-xtrabackup\u0027,"},{"line_number":18,"context_line":"        \u0027pv\u0027,"},{"line_number":19,"context_line":"        \u0027rsync\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"7f96bb07_3fff5102","line":16,"in_reply_to":"7f96bb07_2121924e","updated":"2018-01-12 07:38:05.000000000","message":"yes, it should be mariadb-server-galera.","commit_id":"3dcca3fa55baacde6df504be1c5f170a52449dd0"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"9f8a51cb989d0c0be7687ef377c7788ba843abb2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u0027galera\u0027,"},{"line_number":14,"context_line":"        \u0027hostname\u0027,"},{"line_number":15,"context_line":"        \u0027mariadb\u0027,"},{"line_number":16,"context_line":"        \u0027mariadb-server\u0027,"},{"line_number":17,"context_line":"        \u0027percona-xtrabackup\u0027,"},{"line_number":18,"context_line":"        \u0027pv\u0027,"},{"line_number":19,"context_line":"        \u0027rsync\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"7f96bb07_3f28b184","line":16,"in_reply_to":"7f96bb07_3fff5102","updated":"2018-01-12 07:40:02.000000000","message":"yes. please fix this.","commit_id":"3dcca3fa55baacde6df504be1c5f170a52449dd0"}],"docker/mariadb/extend_start.sh":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"75c5cb7495a287db11143dec3a633ede34524bba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function bootstrap_db {"},{"line_number":4,"context_line":"    mysqld_safe --wsrep-new-cluster --skip-networking --wsrep-on\u003dOFF \u0026"},{"line_number":5,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":6,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":7,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."}],"source_content_type":"text/x-sh","patch_set":12,"id":"df140735_7e406436","side":"PARENT","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":53},"updated":"2017-05-30 08:32:12.000000000","message":"I think leaving this is OK in the mysql_safe","commit_id":"328acb02a0adf0d7d173a8cc606c4401f67b9d93"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"dfeb04780e53cef77d8182faa7187a452d7e5895","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function bootstrap_db {"},{"line_number":4,"context_line":"    mysqld_safe --wsrep-new-cluster --skip-networking --wsrep-on\u003dOFF \u0026"},{"line_number":5,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":6,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":7,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."}],"source_content_type":"text/x-sh","patch_set":12,"id":"df140735_57621a40","side":"PARENT","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":53},"in_reply_to":"df140735_7e406436","updated":"2017-05-30 15:54:48.000000000","message":"with --wsrep-on\u003dOFF, the loop condition below was never met.","commit_id":"328acb02a0adf0d7d173a8cc606c4401f67b9d93"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"75c5cb7495a287db11143dec3a633ede34524bba","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        CLUSTER_READY\u003d$(mysql -u root --exec\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON)"},{"line_number":23,"context_line":"        TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":24,"context_line":"        while [[ -z \"${CLUSTER_READY}\" ]]; do"},{"line_number":25,"context_line":"            CLUSTER_READY\u003d$(mysql -u root --exec\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON)"}],"source_content_type":"text/x-sh","patch_set":12,"id":"df140735_fe835455","side":"PARENT","line":22,"range":{"start_line":22,"start_character":80,"end_line":22,"end_character":87},"updated":"2017-05-30 08:32:12.000000000","message":"For what I saw yesterday, I think this grep wasn\u0027t really working as expected waiting for an ON.\n\nIn my tests, this was not failing while server was starting with error messages as: Unable to connect..\nBut, once something appear(OFF) the loop failed instead of wait for the ON. Weird","commit_id":"328acb02a0adf0d7d173a8cc606c4401f67b9d93"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"dfeb04780e53cef77d8182faa7187a452d7e5895","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        CLUSTER_READY\u003d$(mysql -u root --exec\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON)"},{"line_number":23,"context_line":"        TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":24,"context_line":"        while [[ -z \"${CLUSTER_READY}\" ]]; do"},{"line_number":25,"context_line":"            CLUSTER_READY\u003d$(mysql -u root --exec\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON)"}],"source_content_type":"text/x-sh","patch_set":12,"id":"df140735_b7d736c0","side":"PARENT","line":22,"range":{"start_line":22,"start_character":80,"end_line":22,"end_character":87},"in_reply_to":"df140735_fe835455","updated":"2017-05-30 15:54:48.000000000","message":"this exited because grep returned an error code of 1(the man page states anytime something is not found, an error code of 1 is returned, which causes the script to exit immediately from start.sh\u0027s set errexit.","commit_id":"328acb02a0adf0d7d173a8cc606c4401f67b9d93"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"75c5cb7495a287db11143dec3a633ede34524bba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function bootstrap_db {"},{"line_number":4,"context_line":"    mysqld_safe --wsrep-new-cluster --wsrep-on\u003dON \u0026"},{"line_number":5,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":6,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":7,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."}],"source_content_type":"text/x-sh","patch_set":12,"id":"df140735_7e6984bc","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":49},"updated":"2017-05-30 08:32:12.000000000","message":"Actually, i\u0027m not sure if enabling wsrep during bootsrap is safe since it will create the cluster","commit_id":"35f1ff8a5d7caf2ce7d3d29f6c351c88722a02d7"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"dfeb04780e53cef77d8182faa7187a452d7e5895","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function bootstrap_db {"},{"line_number":4,"context_line":"    mysqld_safe --wsrep-new-cluster --wsrep-on\u003dON \u0026"},{"line_number":5,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":6,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":7,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."}],"source_content_type":"text/x-sh","patch_set":12,"id":"df140735_974f92bc","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":49},"in_reply_to":"df140735_7e6984bc","updated":"2017-05-30 15:54:48.000000000","message":"i think the intent is to create the cluster, then securify it.  However, I am far  from a mariadb expert, so I really don\u0027t know.","commit_id":"35f1ff8a5d7caf2ce7d3d29f6c351c88722a02d7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"75c5cb7495a287db11143dec3a633ede34524bba","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"},{"line_number":23,"context_line":"        TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":24,"context_line":"        while [[ -z \"${CLUSTER_READY}\" ]]; do"},{"line_number":25,"context_line":"            CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"}],"source_content_type":"text/x-sh","patch_set":12,"id":"df140735_fee8f416","line":22,"range":{"start_line":22,"start_character":83,"end_line":22,"end_character":98},"updated":"2017-05-30 08:32:12.000000000","message":"awk return correct status code, awk \u0027/ON/ {print $4}\u0027","commit_id":"35f1ff8a5d7caf2ce7d3d29f6c351c88722a02d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a117e3952957bfd09f244671c492c5fd03d55f2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"},{"line_number":23,"context_line":"        TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":24,"context_line":"        while [[ -z \"${CLUSTER_READY}\" ]]; do"},{"line_number":25,"context_line":"            CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"}],"source_content_type":"text/x-sh","patch_set":12,"id":"df140735_58bc87db","line":22,"range":{"start_line":22,"start_character":83,"end_line":22,"end_character":98},"in_reply_to":"df140735_379a0614","updated":"2017-05-30 17:12:51.000000000","message":"if grep retrun 1 here it mans \u0027ON\u0027 was not found in the output of the mysql expression.\n\ngrep uses the exit code to signal if the term you were searching for was found.\n\nThe more typical pattern is to pip the output of grep to /dev/null and use the return code  in an if to determing if the predicate is true or false like this\n\nhttps://github.com/openstack/networking-ovs-dpdk/blob/master/devstack/ovs-dpdk/ovs-dpdk-init#L163-L169","commit_id":"35f1ff8a5d7caf2ce7d3d29f6c351c88722a02d7"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"dfeb04780e53cef77d8182faa7187a452d7e5895","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"},{"line_number":23,"context_line":"        TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":24,"context_line":"        while [[ -z \"${CLUSTER_READY}\" ]]; do"},{"line_number":25,"context_line":"            CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"}],"source_content_type":"text/x-sh","patch_set":12,"id":"df140735_379a0614","line":22,"range":{"start_line":22,"start_character":83,"end_line":22,"end_character":98},"in_reply_to":"df140735_fee8f416","updated":"2017-05-30 15:54:48.000000000","message":"awk may be viable.  This works as well, as it ignores the 1 result form grep and always returns 0.","commit_id":"35f1ff8a5d7caf2ce7d3d29f6c351c88722a02d7"}],"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3e2b71af2d4247c80552183d136114f667672615","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            \u0027postgresql-devel\u0027,"},{"line_number":214,"context_line":"            \u0027python-devel\u0027,"},{"line_number":215,"context_line":"            \u0027sqlite-devel\u0027,"},{"line_number":216,"context_line":"            \u0027zip\u0027,"},{"line_number":217,"context_line":"            \u0027mariadb-devel\u0027"},{"line_number":218,"context_line":"        ] %}"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_4a1ce769","line":217,"range":{"start_line":216,"start_character":8,"end_line":217,"end_character":27},"updated":"2018-01-02 08:29:37.000000000","message":"alphabetic order please","commit_id":"d53094ce8b0b19ea7a905f7f475457b6b57df1cb"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"237bc3887e9201aa6648117ef1163cd99591344e","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            \u0027postgresql-devel\u0027,"},{"line_number":214,"context_line":"            \u0027python-devel\u0027,"},{"line_number":215,"context_line":"            \u0027sqlite-devel\u0027,"},{"line_number":216,"context_line":"            \u0027zip\u0027,"},{"line_number":217,"context_line":"            \u0027mariadb-devel\u0027"},{"line_number":218,"context_line":"        ] %}"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_a1fa6c3f","line":217,"range":{"start_line":216,"start_character":8,"end_line":217,"end_character":27},"in_reply_to":"9f91af0f_4a1ce769","updated":"2018-01-03 02:20:41.000000000","message":"done.","commit_id":"d53094ce8b0b19ea7a905f7f475457b6b57df1cb"}],"docker/sensu/sensu-client/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3e2b71af2d4247c80552183d136114f667672615","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":10,"context_line":"        \u0027mariadb\u0027,"},{"line_number":11,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":12,"context_line":"        \u0027cyrus-sasl-devel\u0027,"},{"line_number":13,"context_line":"        \u0027docker-client\u0027,"},{"line_number":14,"context_line":"        \u0027gcc-c++\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_6a19ab77","line":11,"range":{"start_line":10,"start_character":7,"end_line":11,"end_character":22},"updated":"2018-01-02 08:29:37.000000000","message":"alphabetic order please","commit_id":"d53094ce8b0b19ea7a905f7f475457b6b57df1cb"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"237bc3887e9201aa6648117ef1163cd99591344e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":10,"context_line":"        \u0027mariadb\u0027,"},{"line_number":11,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":12,"context_line":"        \u0027cyrus-sasl-devel\u0027,"},{"line_number":13,"context_line":"        \u0027docker-client\u0027,"},{"line_number":14,"context_line":"        \u0027gcc-c++\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f91af0f_01ea3874","line":11,"range":{"start_line":10,"start_character":7,"end_line":11,"end_character":22},"in_reply_to":"9f91af0f_6a19ab77","updated":"2018-01-03 02:20:41.000000000","message":"Done.","commit_id":"d53094ce8b0b19ea7a905f7f475457b6b57df1cb"}],"releasenotes/upgrage-to-mariadb-10.1.20-for-redhat-family-93df8bf63da25659.yaml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b85349ba984a4faba47dac41f45d444253d5f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Upgrade to MariaDB 10.1.20 for RHEL/CentOS/Oracle Linux."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9f91af0f_37e21003","line":4,"updated":"2018-01-03 14:34:03.000000000","message":"missing ubuntu *I would say, mariadb is upgraded to 10.1 as all distros are being upgraded","commit_id":"5c41c617200b921f84f2ace73b183789102455df"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"c67b2d12d5b3d1d8793f4101f522f6b4d3c2762b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Upgrade to MariaDB 10.1.20 for RHEL/CentOS/Oracle Linux."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9f91af0f_ea6352b0","line":4,"in_reply_to":"9f91af0f_37e21003","updated":"2018-01-04 03:07:38.000000000","message":"Yes, we need another path to handle ubuntu mariadb updating.","commit_id":"5c41c617200b921f84f2ace73b183789102455df"}]}