)]}'
{"docker/ironic/ironic-api/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15dd3aee17373311994f3f54939fa7a739c9141c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u0027openstack-ironic-api\u0027,"},{"line_number":12,"context_line":"            \u0027httpd\u0027,"},{"line_number":13,"context_line":"            \u0027mod_wsgi\u0027"},{"line_number":14,"context_line":"        ] %}"},{"line_number":15,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":"        {% set ironic_api_packages \u003d ["},{"line_number":17,"context_line":"            \u0027ironic-api\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f231b9d_5aad6086","line":14,"updated":"2017-06-14 09:43:38.000000000","message":"missing file cleanup. check this change as reference https://review.openstack.org/#/c/461779/","commit_id":"77ce24e28126c6424979a482e06db98e04396812"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15dd3aee17373311994f3f54939fa7a739c9141c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{ macros.install_packages(ironic_api_packages | customizable(\"packages\")) }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_ironic_extend_start"},{"line_number":28,"context_line":"RUN chmod 755 /usr/local/bin/kolla_ironic_extend_start"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f231b9d_3ac1842f","line":26,"updated":"2017-06-14 09:43:38.000000000","message":"also, please add the same for source images as have to be equivalent as binary images.","commit_id":"77ce24e28126c6424979a482e06db98e04396812"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15dd3aee17373311994f3f54939fa7a739c9141c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_ironic_extend_start"},{"line_number":28,"context_line":"RUN chmod 755 /usr/local/bin/kolla_ironic_extend_start"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% block ironic_api_footer %}{% endblock %}"},{"line_number":31,"context_line":"{% block footer %}{% endblock %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f231b9d_fa2e6cf8","line":29,"updated":"2017-06-14 09:43:38.000000000","message":"in extend_start need to do some cleanups, use referenced change before and change this part which was wrong https://review.openstack.org/#/c/464181/2/docker/zaqar/extend_start.sh","commit_id":"77ce24e28126c6424979a482e06db98e04396812"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"fd09c4fd229d511eea659488c4d6b8acdae9e8c2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    {% set ironic_api_packages \u003d ["},{"line_number":12,"context_line":"        \u0027openstack-ironic-api\u0027,"},{"line_number":13,"context_line":"        \u0027httpd\u0027,"},{"line_number":14,"context_line":"        \u0027mod_wsgi\u0027"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    {{ macros.install_packages(ironic_api_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7f231b9d_da6965f9","line":14,"updated":"2017-06-14 15:34:27.000000000","message":"Can you also make sure mod_ssl is installed? It is not by pulled by default for rpm based distros when installing apache (but it is for deb).","commit_id":"911c9274dcfe765523692638b4b03099af4635f2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb43e71adca85ea17c37b0c4e07038a81ed26e2d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    {% set ironic_api_packages \u003d ["},{"line_number":12,"context_line":"        \u0027openstack-ironic-api\u0027,"},{"line_number":13,"context_line":"        \u0027httpd\u0027,"},{"line_number":14,"context_line":"        \u0027mod_wsgi\u0027"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    {{ macros.install_packages(ironic_api_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7f231b9d_95adfe9c","line":14,"in_reply_to":"7f231b9d_da6965f9","updated":"2017-06-14 15:48:43.000000000","message":"Ok","commit_id":"911c9274dcfe765523692638b4b03099af4635f2"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"fd09c4fd229d511eea659488c4d6b8acdae9e8c2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RUN echo \u003e /etc/apache2/ports.conf"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7f231b9d_ba6a29ea","line":33,"updated":"2017-06-14 15:34:27.000000000","message":"Have you considered the source install type? Probably you\u0027ll want to install apache there too.","commit_id":"911c9274dcfe765523692638b4b03099af4635f2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb43e71adca85ea17c37b0c4e07038a81ed26e2d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RUN echo \u003e /etc/apache2/ports.conf"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7f231b9d_359cea68","line":33,"in_reply_to":"7f231b9d_ba6a29ea","updated":"2017-06-14 15:48:43.000000000","message":"Yeah, I guess we need it now.","commit_id":"911c9274dcfe765523692638b4b03099af4635f2"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c91021e6eb61c8ebaac8184a400de2239b8c185c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"        {% set ironic_api_packages \u003d ["},{"line_number":11,"context_line":"            \u0027openstack-ironic-api\u0027,"},{"line_number":12,"context_line":"            \u0027httpd\u0027,"},{"line_number":13,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":14,"context_line":"            \u0027mod_ssl\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7f231b9d_39d3a7d7","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":35},"updated":"2017-06-15 13:41:12.000000000","message":"please, alphabetize package names in lists","commit_id":"64763adbf6138f7fb92ef26de76e636cb08a1df0"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c91021e6eb61c8ebaac8184a400de2239b8c185c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":17,"context_line":"        {% set ironic_api_packages \u003d ["},{"line_number":18,"context_line":"            \u0027ironic-api\u0027,"},{"line_number":19,"context_line":"            \u0027apache2\u0027,"},{"line_number":20,"context_line":"            \u0027libapache2-mod-wsgi\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7f231b9d_99f19b6e","line":19,"range":{"start_line":19,"start_character":12,"end_line":19,"end_character":22},"updated":"2017-06-15 13:41:12.000000000","message":"ditto","commit_id":"64763adbf6138f7fb92ef26de76e636cb08a1df0"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c91021e6eb61c8ebaac8184a400de2239b8c185c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":26,"context_line":"        {% set ironic_api_packages \u003d ["},{"line_number":27,"context_line":"            \u0027httpd\u0027,"},{"line_number":28,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":29,"context_line":"            \u0027mod_ssl\u0027"},{"line_number":30,"context_line":"        ] %}"},{"line_number":31,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":32,"context_line":"        {% set ironic_api_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7f231b9d_59e783ad","line":29,"range":{"start_line":28,"start_character":12,"end_line":29,"end_character":21},"updated":"2017-06-15 13:41:12.000000000","message":"ditto","commit_id":"64763adbf6138f7fb92ef26de76e636cb08a1df0"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d1d79937b5f14e3de92718844719f5149bec5f2e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"        {% set ironic_api_packages \u003d ["},{"line_number":11,"context_line":"            \u0027httpd\u0027,"},{"line_number":12,"context_line":"            \u0027mod_ssl\u0027"},{"line_number":13,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":14,"context_line":"            \u0027openstack-ironic-api\u0027,"},{"line_number":15,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"7f231b9d_24993ac3","line":12,"updated":"2017-06-15 13:52:07.000000000","message":"missing comma","commit_id":"6444ce7a620052c287836eb8388344febb98961c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d1d79937b5f14e3de92718844719f5149bec5f2e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":26,"context_line":"        {% set ironic_api_packages \u003d ["},{"line_number":27,"context_line":"            \u0027httpd\u0027,"},{"line_number":28,"context_line":"            \u0027mod_ssl\u0027"},{"line_number":29,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":30,"context_line":"        ] %}"},{"line_number":31,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"7f231b9d_e48ea277","line":28,"updated":"2017-06-15 13:52:07.000000000","message":"ditto","commit_id":"6444ce7a620052c287836eb8388344febb98961c"}]}