)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"75d81e7d60ecb3fb46638a68afafc158206476b3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to override defaults with local build configuration file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added passing of a configuration file when using a local build environment. The"},{"line_number":10,"context_line":"local config file will be used first (PROJECT_ROOT/etc/kolla/kolla-build.conf),"},{"line_number":11,"context_line":"then the global file if found (/etc/kolla/kolla-build.conf). If neither are"},{"line_number":12,"context_line":"found then the normal default values will be used."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4e3ede7b1b18dbdabdc279331597c95e2fe254b1"},{"line_number":15,"context_line":"Closes-bug: #1699324"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f6a8fd7_b9494933","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":50},"updated":"2018-04-29 13:56:31.000000000","message":"Please follow proper formatting for commit messages\nTitle of commit \u003c less then 50 characters \u003cCR\u003e \nDescription of commit (wrapped at 71 characters) may be mulltiline\nCloses-Bug: #X or TrivialFix or Implements:","commit_id":"c98cd81773edd2f1c73fdaeddbbb7fbbd4647a86"}],"kolla/image/build.py":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a6a7ab512e2bece399b42a1d4f549c51d67f1512","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    are found."},{"line_number":1074,"context_line":"    \"\"\""},{"line_number":1075,"context_line":"    config_file \u003d None"},{"line_number":1076,"context_line":"    if \u0027build.py\u0027 in EXEC_FILENAME:"},{"line_number":1077,"context_line":"        if os.path.isfile(os.path.join(PROJECT_ROOT,"},{"line_number":1078,"context_line":"                                       \u0027etc/kolla/kolla-build.conf\u0027)):"},{"line_number":1079,"context_line":"            config_file \u003d [\u0027../../etc/kolla/kolla-build.conf\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_adf24799","line":1076,"range":{"start_line":1076,"start_character":4,"end_line":1076,"end_character":35},"updated":"2017-07-10 13:17:53.000000000","message":"Will this work when using the pip installed command, \u0027kolla-build\u0027 ?","commit_id":"3410c915c610f8b9c222855d4d89dc8c362a7c37"},{"author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"change_message_id":"73c2cd9f66d740378c07b011af567d2b56a6c65d","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    are found."},{"line_number":1074,"context_line":"    \"\"\""},{"line_number":1075,"context_line":"    config_file \u003d None"},{"line_number":1076,"context_line":"    if \u0027build.py\u0027 in EXEC_FILENAME:"},{"line_number":1077,"context_line":"        if os.path.isfile(os.path.join(PROJECT_ROOT,"},{"line_number":1078,"context_line":"                                       \u0027etc/kolla/kolla-build.conf\u0027)):"},{"line_number":1079,"context_line":"            config_file \u003d [\u0027../../etc/kolla/kolla-build.conf\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_3be8a214","line":1076,"range":{"start_line":1076,"start_character":4,"end_line":1076,"end_character":35},"in_reply_to":"3f1d235d_adf24799","updated":"2017-07-10 19:04:49.000000000","message":"Yes, because the first condition will be false since the path is incorrect, so the second condition will work iff a conf file is copied/customized. Else it will use the static default values like always. I also tested passing in a conf file via the command line and it works as expected.","commit_id":"3410c915c610f8b9c222855d4d89dc8c362a7c37"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0101c4373e1f2898e7ee314b0d301993da850c99","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                                       \u0027etc/kolla/kolla-build.conf\u0027)):"},{"line_number":1079,"context_line":"            config_file \u003d [\u0027../../etc/kolla/kolla-build.conf\u0027]"},{"line_number":1080,"context_line":"        elif os.path.isfile(\u0027/etc/kolla/kolla-build.conf\u0027):"},{"line_number":1081,"context_line":"            config_file \u003d [\u0027/etc/kolla/kolla-build.conf\u0027]"},{"line_number":1082,"context_line":"    return config_file"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_d52cd148","line":1081,"updated":"2017-08-09 19:24:29.000000000","message":"Just a nit. I personally would prefer a else: config_file \u003d None here - rather than setting it above. Reads cleaner and makes it obvious that the default case is None...","commit_id":"3410c915c610f8b9c222855d4d89dc8c362a7c37"},{"author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"change_message_id":"7c77cad4353ca9eb84359831983a4524674904c0","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                                       \u0027etc/kolla/kolla-build.conf\u0027)):"},{"line_number":1079,"context_line":"            config_file \u003d [\u0027../../etc/kolla/kolla-build.conf\u0027]"},{"line_number":1080,"context_line":"        elif os.path.isfile(\u0027/etc/kolla/kolla-build.conf\u0027):"},{"line_number":1081,"context_line":"            config_file \u003d [\u0027/etc/kolla/kolla-build.conf\u0027]"},{"line_number":1082,"context_line":"    return config_file"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_cb2c3249","line":1081,"in_reply_to":"9f436f4f_d52cd148","updated":"2017-08-09 20:40:50.000000000","message":"That sounds perfectly reasonable.","commit_id":"3410c915c610f8b9c222855d4d89dc8c362a7c37"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0101c4373e1f2898e7ee314b0d301993da850c99","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"    default_config_files \u003d get_local_conf()"},{"line_number":1092,"context_line":"    conf \u003d cfg.ConfigOpts()"},{"line_number":1093,"context_line":"    common_config.parse(conf, sys.argv[1:], prog\u003d\u0027kolla-build\u0027,"},{"line_number":1094,"context_line":"                        default_config_files\u003ddefault_config_files)"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    if conf.debug:"},{"line_number":1097,"context_line":"        LOG.setLevel(logging.DEBUG)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_95708974","line":1094,"range":{"start_line":1094,"start_character":44,"end_line":1094,"end_character":65},"updated":"2017-08-09 19:24:29.000000000","message":"Why not call get_local_conf() directly - as you only use this var 1x?","commit_id":"3410c915c610f8b9c222855d4d89dc8c362a7c37"},{"author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"change_message_id":"7c77cad4353ca9eb84359831983a4524674904c0","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"    default_config_files \u003d get_local_conf()"},{"line_number":1092,"context_line":"    conf \u003d cfg.ConfigOpts()"},{"line_number":1093,"context_line":"    common_config.parse(conf, sys.argv[1:], prog\u003d\u0027kolla-build\u0027,"},{"line_number":1094,"context_line":"                        default_config_files\u003ddefault_config_files)"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    if conf.debug:"},{"line_number":1097,"context_line":"        LOG.setLevel(logging.DEBUG)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_ebdc9647","line":1094,"range":{"start_line":1094,"start_character":44,"end_line":1094,"end_character":65},"in_reply_to":"9f436f4f_95708974","updated":"2017-08-09 20:40:50.000000000","message":"That is probably an artifact of a few revs of this in my sandbox - I agree. I\u0027ll push a new patchset for these changes","commit_id":"3410c915c610f8b9c222855d4d89dc8c362a7c37"},{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"9cefa681873dfb12f7fb01e301a4b5a8cda26661","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"    order (allowing for local override), or None if no configuration files"},{"line_number":1073,"context_line":"    are found."},{"line_number":1074,"context_line":"    \"\"\""},{"line_number":1075,"context_line":"    if \u0027build.py\u0027 in EXEC_FILENAME:"},{"line_number":1076,"context_line":"        if os.path.isfile(os.path.join(PROJECT_ROOT,"},{"line_number":1077,"context_line":"                                       \u0027etc/kolla/kolla-build.conf\u0027)):"},{"line_number":1078,"context_line":"            config_file \u003d [\u0027../../etc/kolla/kolla-build.conf\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_f93fc184","line":1075,"range":{"start_line":1075,"start_character":4,"end_line":1075,"end_character":35},"updated":"2018-04-29 13:55:16.000000000","message":"In my opinion, the if condition make no sense,  it always return true,\n\nbesides that even if it false, the config_file will be not defined, the fuction raise error","commit_id":"c98cd81773edd2f1c73fdaeddbbb7fbbd4647a86"},{"author":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"change_message_id":"1bb883b69effb3431cd8e5def7068e3b5d798b86","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"    order (allowing for local override), or None if no configuration files"},{"line_number":1073,"context_line":"    are found."},{"line_number":1074,"context_line":"    \"\"\""},{"line_number":1075,"context_line":"    if \u0027build.py\u0027 in EXEC_FILENAME:"},{"line_number":1076,"context_line":"        if os.path.isfile(os.path.join(PROJECT_ROOT,"},{"line_number":1077,"context_line":"                                       \u0027etc/kolla/kolla-build.conf\u0027)):"},{"line_number":1078,"context_line":"            config_file \u003d [\u0027../../etc/kolla/kolla-build.conf\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_c29cea0f","line":1075,"range":{"start_line":1075,"start_character":4,"end_line":1075,"end_character":35},"in_reply_to":"9f6a8fd7_f93fc184","updated":"2018-05-10 23:09:34.000000000","message":"\u003e In my opinion, the if condition make no sense,  it always return\n \u003e true,\n \u003e \n \u003e besides that even if it false, the config_file will be not defined,\n \u003e the fuction raise error","commit_id":"c98cd81773edd2f1c73fdaeddbbb7fbbd4647a86"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"bc1db76970b913e5b05675ffbfc29735016a50be","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"                                       \u0027etc/kolla/kolla-build.conf\u0027)):"},{"line_number":1078,"context_line":"            config_file \u003d [\u0027../../etc/kolla/kolla-build.conf\u0027]"},{"line_number":1079,"context_line":"        elif os.path.isfile(\u0027/etc/kolla/kolla-build.conf\u0027):"},{"line_number":1080,"context_line":"            config_file \u003d [\u0027/etc/kolla/kolla-build.conf\u0027]"},{"line_number":1081,"context_line":"        else:"},{"line_number":1082,"context_line":"            config_file \u003d None"},{"line_number":1083,"context_line":"    return config_file"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_539d5555","line":1080,"updated":"2017-11-02 01:29:25.000000000","message":"if we fix wanna to fix the kolla-build.conf in code base, this elif is not necessary. oslo.config loads this path already. \n\noslo.config also load the file from other paths.","commit_id":"c98cd81773edd2f1c73fdaeddbbb7fbbd4647a86"},{"author":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"change_message_id":"1bb883b69effb3431cd8e5def7068e3b5d798b86","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"                                       \u0027etc/kolla/kolla-build.conf\u0027)):"},{"line_number":1078,"context_line":"            config_file \u003d [\u0027../../etc/kolla/kolla-build.conf\u0027]"},{"line_number":1079,"context_line":"        elif os.path.isfile(\u0027/etc/kolla/kolla-build.conf\u0027):"},{"line_number":1080,"context_line":"            config_file \u003d [\u0027/etc/kolla/kolla-build.conf\u0027]"},{"line_number":1081,"context_line":"        else:"},{"line_number":1082,"context_line":"            config_file \u003d None"},{"line_number":1083,"context_line":"    return config_file"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_e2a1e647","line":1080,"in_reply_to":"3f4b6375_539d5555","updated":"2018-05-10 23:09:34.000000000","message":"\u003e if we fix wanna to fix the kolla-build.conf in code base, this elif\n \u003e is not necessary. oslo.config loads this path already.\n \u003e \n \u003e oslo.config also load the file from other paths.","commit_id":"c98cd81773edd2f1c73fdaeddbbb7fbbd4647a86"},{"author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"change_message_id":"a64288adfbc84e289bb33035df18a5741e712a3c","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"                                       \u0027etc/kolla/kolla-build.conf\u0027)):"},{"line_number":1078,"context_line":"            config_file \u003d [\u0027../../etc/kolla/kolla-build.conf\u0027]"},{"line_number":1079,"context_line":"        elif os.path.isfile(\u0027/etc/kolla/kolla-build.conf\u0027):"},{"line_number":1080,"context_line":"            config_file \u003d [\u0027/etc/kolla/kolla-build.conf\u0027]"},{"line_number":1081,"context_line":"        else:"},{"line_number":1082,"context_line":"            config_file \u003d None"},{"line_number":1083,"context_line":"    return config_file"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_cfc6279b","line":1080,"in_reply_to":"3f4b6375_539d5555","updated":"2017-11-02 15:11:37.000000000","message":"I think you will find that this doesn\u0027t work if you test it. See the bug listed in the comments. Configs are not loaded from /etc or local etc at all.","commit_id":"c98cd81773edd2f1c73fdaeddbbb7fbbd4647a86"}]}