)]}'
{"docker/macros.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b81bb73ebbe6f11b702a1341f46efe1834a84c46","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{% macro debian_opendaylight_existing_user_fix() %}"},{"line_number":53,"context_line":"{# NOTE(egonzalez): The postinst script breaks if the user \u0027odl\u0027 already exists #}"},{"line_number":54,"context_line":"RUN apt-get update \\"},{"line_number":55,"context_line":"    \u0026\u0026 apt-get -y install --no-install-recommends opendaylight \\"},{"line_number":56,"context_line":"    || sed -i \u0027/[^:]adduser/,+1 d\u0027 /var/lib/dpkg/info/opendaylight.postinst \\"},{"line_number":57,"context_line":"    \u0026\u0026 apt-get -y install -f \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f201791_10e567dc","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":18},"updated":"2017-06-26 13:38:07.000000000","message":"macros install do update, this is needed since the macro is not used and has not refreshed new repo info","commit_id":"53f5d6cfbf3bba4e1f3cb56938799d4562456a69"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b81bb73ebbe6f11b702a1341f46efe1834a84c46","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{# NOTE(egonzalez): The postinst script breaks if the user \u0027odl\u0027 already exists #}"},{"line_number":54,"context_line":"RUN apt-get update \\"},{"line_number":55,"context_line":"    \u0026\u0026 apt-get -y install --no-install-recommends opendaylight \\"},{"line_number":56,"context_line":"    || sed -i \u0027/[^:]adduser/,+1 d\u0027 /var/lib/dpkg/info/opendaylight.postinst \\"},{"line_number":57,"context_line":"    \u0026\u0026 apt-get -y install -f \\"},{"line_number":58,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":59,"context_line":"{% endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f201791_10b0c7dc","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":20},"updated":"2017-06-26 13:38:07.000000000","message":"this catches indentation https://github.com/opendaylight/integration-packaging/blob/master/deb/templates/opendaylight.postinst#L7","commit_id":"53f5d6cfbf3bba4e1f3cb56938799d4562456a69"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"e89986f1b2610e4deb4ae25b81431e05991b00bc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{# NOTE(egonzalez): The postinst script breaks if the user \u0027odl\u0027 already exists #}"},{"line_number":54,"context_line":"RUN apt-get update \\"},{"line_number":55,"context_line":"    \u0026\u0026 apt-get -y install --no-install-recommends opendaylight \\"},{"line_number":56,"context_line":"    || sed -i \u0027/[^:]adduser/,+1 d\u0027 /var/lib/dpkg/info/opendaylight.postinst \\"},{"line_number":57,"context_line":"    \u0026\u0026 apt-get -y install -f \\"},{"line_number":58,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":59,"context_line":"{% endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f201791_8c3825ee","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":20},"in_reply_to":"5f201791_10b0c7dc","updated":"2017-06-27 08:12:28.000000000","message":"If I read correctly, this regex matches adduser when it starts with a character that is not \u0027:\u0027.\n\nIMO, it should be:\n sed -i \u0027/^(\\s)*adduser/,+1 d\u0027 /var/lib/dpkg/info/opendaylight.postinst","commit_id":"53f5d6cfbf3bba4e1f3cb56938799d4562456a69"}],"docker/opendaylight/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"e89986f1b2610e4deb4ae25b81431e05991b00bc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# existing odl user. First install odl and then allow usage of"},{"line_number":31,"context_line":"# install_packages macro for custom configs."},{"line_number":32,"context_line":"        {% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":33,"context_line":"          {{ macros.debian_opendaylight_existing_user_fix() }}"},{"line_number":34,"context_line":"        {% endif %}"},{"line_number":35,"context_line":"    {% endif %}"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f201791_e05d5d15","line":33,"updated":"2017-06-27 08:12:28.000000000","message":"The problem I see with this approach, is that it makes package customization on deb distros a little bit confusing.\nIt makes the opendaylight deb package a mandatory install, which can\u0027t be opt out. I guess there is no way around it, and it\u0027s ok, because we can still provide a different source repo for opendaylight, or install a package that forces removal of opendaylight.","commit_id":"53f5d6cfbf3bba4e1f3cb56938799d4562456a69"}]}