)]}'
{"docker/openvswitch/openvswitch-db-server/ovs_ensure_configured.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"09a87193608479cd4ae9fb19014b81c37775b2fe","unresolved":false,"context_lines":[{"line_number":12,"context_line":"ip link show $port"},{"line_number":13,"context_line":"if [[ $? \u003d\u003d 0 \u0026\u0026 ! $(ovs-vsctl list-ports $bridge) \u003d~ $(echo \"\\\u003c$port\\\u003e\") ]]; then"},{"line_number":14,"context_line":"    changed\u003dchanged"},{"line_number":15,"context_line":"    ovs-vsctl --no-wait add-port $bridge $port"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $changed"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f1d235d_998334cd","line":15,"updated":"2017-07-01 15:14:44.000000000","message":"will this skip when port does not exist?\ni do not think this is expected.","commit_id":"b04113608e21dea2a2a2e57d8e0d96ab8e3fb88d"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"fd11e9dc7ec8f06651fbb151f62987c3d532189f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"ip link show $port"},{"line_number":13,"context_line":"if [[ $? \u003d\u003d 0 \u0026\u0026 ! $(ovs-vsctl list-ports $bridge) \u003d~ $(echo \"\\\u003c$port\\\u003e\") ]]; then"},{"line_number":14,"context_line":"    changed\u003dchanged"},{"line_number":15,"context_line":"    ovs-vsctl --no-wait add-port $bridge $port"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $changed"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f1d235d_adbec7fc","line":15,"in_reply_to":"3f1d235d_4fe135d0","updated":"2017-07-10 13:04:01.000000000","message":"This script will only be run on compute nodes in the case the external bridge is needed (https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/openvswitch/handlers/main.yml#L39)\n\nSo I think I agree with Jeffrey here, when this script is run the interface should exist, if it doesn\u0027t we don\u0027t want to fail silently.","commit_id":"b04113608e21dea2a2a2e57d8e0d96ab8e3fb88d"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"598a94cdcdf921905d9e992fc52e4821f2f43a5a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"ip link show $port"},{"line_number":13,"context_line":"if [[ $? \u003d\u003d 0 \u0026\u0026 ! $(ovs-vsctl list-ports $bridge) \u003d~ $(echo \"\\\u003c$port\\\u003e\") ]]; then"},{"line_number":14,"context_line":"    changed\u003dchanged"},{"line_number":15,"context_line":"    ovs-vsctl --no-wait add-port $bridge $port"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $changed"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f1d235d_c4bad108","line":15,"in_reply_to":"3f1d235d_998334cd","updated":"2017-07-03 09:00:26.000000000","message":"no, see linked bug","commit_id":"b04113608e21dea2a2a2e57d8e0d96ab8e3fb88d"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"99c4d31ae4808b37f1a06fed167863d463381f60","unresolved":false,"context_lines":[{"line_number":12,"context_line":"ip link show $port"},{"line_number":13,"context_line":"if [[ $? \u003d\u003d 0 \u0026\u0026 ! $(ovs-vsctl list-ports $bridge) \u003d~ $(echo \"\\\u003c$port\\\u003e\") ]]; then"},{"line_number":14,"context_line":"    changed\u003dchanged"},{"line_number":15,"context_line":"    ovs-vsctl --no-wait add-port $bridge $port"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo $changed"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f1d235d_4fe135d0","line":15,"in_reply_to":"3f1d235d_c4bad108","updated":"2017-07-03 13:17:10.000000000","message":"We can\u0027t throw an error if interface doesn\u0027t exist, because i.e. on compute node neutron_external_interface may not exist.\nInstead of that we just ensure, that we are not adding non-existent interface in OVS bridge.","commit_id":"b04113608e21dea2a2a2e57d8e0d96ab8e3fb88d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"479bafd66da7f8c4dff0d840495fbacb3045051b","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"ip link show $port"},{"line_number":7,"context_line":"if [[ $? -ne 0 ]]; then"},{"line_number":8,"context_line":"   # fail when device doesn\u0027t exist"},{"line_number":9,"context_line":"   exit 1"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f1a1f67_5e76b3a6","line":8,"updated":"2017-07-13 13:10:52.000000000","message":"styles checks failed in gates, add one space more. need 4","commit_id":"6265d279ca2522d296249fa91f1db7381fcddf97"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"479bafd66da7f8c4dff0d840495fbacb3045051b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ip link show $port"},{"line_number":7,"context_line":"if [[ $? -ne 0 ]]; then"},{"line_number":8,"context_line":"   # fail when device doesn\u0027t exist"},{"line_number":9,"context_line":"   exit 1"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ovs-vsctl br-exists $bridge"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f1a1f67_3e7bf78c","line":9,"updated":"2017-07-13 13:10:52.000000000","message":"ditto","commit_id":"6265d279ca2522d296249fa91f1db7381fcddf97"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"bf5ba7fd6697a77098112b5f0153654addafa504","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"ip link show $port"},{"line_number":7,"context_line":"if [[ $? -ne 0 ]]; then"},{"line_number":8,"context_line":"    # fail when device doesn\u0027t exist"},{"line_number":9,"context_line":"    exit 1"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff346bd7_70d4b748","line":8,"updated":"2017-07-27 03:30:24.000000000","message":"could u echo the error message here, before exit.","commit_id":"4489bf24d84dc8a4a2489e65117a55857c0b8ade"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"70a4bf32a22ff443ccb69ddd6f8d3ede12430198","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"ip link show $port"},{"line_number":7,"context_line":"if [[ $? -ne 0 ]]; then"},{"line_number":8,"context_line":"    # fail when device doesn\u0027t exist"},{"line_number":9,"context_line":"    exit 1"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9f436f4f_2201fcaf","line":8,"in_reply_to":"df3967d1_73b8a129","updated":"2017-08-16 14:35:36.000000000","message":"There is no need for that. `ip link show` already prints meaningful message when device doesn\u0027t exist.\n\n$ ip link show dummy\nDevice \"dummy\" does not exist.","commit_id":"4489bf24d84dc8a4a2489e65117a55857c0b8ade"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"053ef8c338ec6d628b08c94ee821f881754c825c","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"ip link show $port"},{"line_number":7,"context_line":"if [[ $? -ne 0 ]]; then"},{"line_number":8,"context_line":"    # fail when device doesn\u0027t exist"},{"line_number":9,"context_line":"    exit 1"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_73b8a129","line":8,"in_reply_to":"ff346bd7_70d4b748","updated":"2017-08-01 00:45:17.000000000","message":"Agreed, comment should be printed","commit_id":"4489bf24d84dc8a4a2489e65117a55857c0b8ade"}]}