)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a9605261630723a4e26ffbb304aaab60c6bee4f3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \u0027MariaDB.repo\u0027,"},{"line_number":69,"context_line":"        \u0027td.repo\u0027,"},{"line_number":70,"context_line":"        \u0027zookeeper.repo\u0027,"},{"line_number":71,"context_line":"        \u0027sensu.repo\u0027,"},{"line_number":72,"context_line":"    ] %}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    {% set base_yum_url_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff346bd7_4b01cfae","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":21},"updated":"2017-09-20 22:03:01.000000000","message":"please, alphabetize","commit_id":"71ad2e237cdc0317a4415a15e6dca6c55af1d7f1"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"572dabfcdd16456c7346b9dd6f90312b6133b582","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u0027opendaylight.repo\u0027,"},{"line_number":70,"context_line":"        \u0027td.repo\u0027,"},{"line_number":71,"context_line":"        \u0027zookeeper.repo\u0027,"},{"line_number":72,"context_line":"        \u0027sensu.repo\u0027,"},{"line_number":73,"context_line":"    ] %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    {% set base_yum_url_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7f515b1d_ae0489c7","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":21},"updated":"2017-09-22 11:17:03.000000000","message":"please, alphabetize","commit_id":"b274505344d47e36d0fb28925af3b482eebdcbb8"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"44e2373d2c7b25e6a688e598b9598c09ce09e5b7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u0027opendaylight.repo\u0027,"},{"line_number":70,"context_line":"        \u0027sensu.repo\u0027,"},{"line_number":71,"context_line":"        \u0027td.repo\u0027,"},{"line_number":72,"context_line":"        \u0027zookeeper.repo\u0027,"},{"line_number":73,"context_line":"    ] %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    {% set base_yum_url_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"df87a7cf_9aaa38d0","line":72,"range":{"start_line":72,"start_character":24,"end_line":72,"end_character":25},"updated":"2017-12-14 06:17:17.000000000","message":"remove extra commas","commit_id":"bfbc1c902757dfba1367fe307e280cb4ccf386b7"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"a6d9da971727789ff3b50e76c744c4c30af7c158","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u0027opendaylight.repo\u0027,"},{"line_number":70,"context_line":"        \u0027sensu.repo\u0027,"},{"line_number":71,"context_line":"        \u0027td.repo\u0027,"},{"line_number":72,"context_line":"        \u0027zookeeper.repo\u0027,"},{"line_number":73,"context_line":"    ] %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    {% set base_yum_url_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"df87a7cf_8bc18883","line":72,"range":{"start_line":72,"start_character":24,"end_line":72,"end_character":25},"updated":"2017-12-14 09:05:16.000000000","message":"ditto","commit_id":"69bcf3f690513270f90ada8e4fcf359210b8987a"}],"docker/sensu/sensu-client/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bd51f2e9da8850002e42ccd6bfeccd424d29fbd3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set sensu_client_packages \u003d [\u0027docker-client\u0027, \u0027osops-tools-monitoring-oschecks\u0027, \u0027gcc-c++\u0027] %}"},{"line_number":10,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":11,"context_line":"    {% set sensu_client_packages \u003d [\u0027docker.io\u0027, \u0027gcc\u0027, \u0027build-essential\u0027, \u0027libsasl2-dev\u0027] %}"},{"line_number":12,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff346bd7_e2085229","line":9,"range":{"start_line":9,"start_character":36,"end_line":9,"end_character":97},"updated":"2017-07-24 09:23:12.000000000","message":"please, split in multilines for multiple packages","commit_id":"6a78c2d214ee1e8022b6fded7a566f353f711887"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bd51f2e9da8850002e42ccd6bfeccd424d29fbd3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set sensu_client_packages \u003d [\u0027docker-client\u0027, \u0027osops-tools-monitoring-oschecks\u0027, \u0027gcc-c++\u0027] %}"},{"line_number":10,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":11,"context_line":"    {% set sensu_client_packages \u003d [\u0027docker.io\u0027, \u0027gcc\u0027, \u0027build-essential\u0027, \u0027libsasl2-dev\u0027] %}"},{"line_number":12,"context_line":"{% else %}"},{"line_number":13,"context_line":"RUN echo \u0027{{ image_name }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":14,"context_line":"    \u0026\u0026 /bin/false"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff346bd7_c20d4e38","line":11,"range":{"start_line":11,"start_character":35,"end_line":11,"end_character":90},"updated":"2017-07-24 09:23:12.000000000","message":"ditto","commit_id":"6a78c2d214ee1e8022b6fded7a566f353f711887"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bd51f2e9da8850002e42ccd6bfeccd424d29fbd3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  \u0027disk-checks\u0027,"},{"line_number":26,"context_line":"  \u0027dns\u0027,"},{"line_number":27,"context_line":"  \u0027docker\u0027,"},{"line_number":28,"context_line":"  \u0027elasticsearch\u0027,"},{"line_number":29,"context_line":"  \u0027filesystem-checks\u0027,"},{"line_number":30,"context_line":"  \u0027haproxy\u0027,"},{"line_number":31,"context_line":"  \u0027http\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff346bd7_02891674","line":28,"range":{"start_line":28,"start_character":3,"end_line":28,"end_character":16},"updated":"2017-07-24 09:23:12.000000000","message":"http://logs.openstack.org/79/486379/1/check/gate-kolla-dsvm-build-centos-binary-centos-7-nv/087692e/logs/build/sensu-client.txt.gz","commit_id":"6a78c2d214ee1e8022b6fded7a566f353f711887"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"44179d41ac1a95909a12202fc636cdf2e3ff9f21","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  \u0027redis\u0027,"},{"line_number":44,"context_line":"  \u0027uptime-checks\u0027,"},{"line_number":45,"context_line":"  \u0027vmstats\u0027,"},{"line_number":46,"context_line":"] %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"RUN sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff346bd7_17639a1c","line":46,"updated":"2017-07-24 09:11:15.000000000","message":"You missed ruby-dev.","commit_id":"6a78c2d214ee1e8022b6fded7a566f353f711887"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bd51f2e9da8850002e42ccd6bfeccd424d29fbd3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{% block sensu_client_footer %}{% endblock %}"},{"line_number":20,"context_line":"{% block footer %}{% endblock %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":23,"context_line":"  \u0027ceph\u0027,"},{"line_number":24,"context_line":"  \u0027cpu-checks\u0027,"},{"line_number":25,"context_line":"  \u0027disk-checks\u0027,"},{"line_number":26,"context_line":"  \u0027dns\u0027,"},{"line_number":27,"context_line":"  \u0027docker\u0027,"},{"line_number":28,"context_line":"  \u0027elasticsearch\u0027,"},{"line_number":29,"context_line":"  \u0027filesystem-checks\u0027,"},{"line_number":30,"context_line":"  \u0027haproxy\u0027,"},{"line_number":31,"context_line":"  \u0027http\u0027,"},{"line_number":32,"context_line":"  \u0027io-checks\u0027,"},{"line_number":33,"context_line":"  \u0027load-checks\u0027,"},{"line_number":34,"context_line":"  \u0027memcached\u0027,"},{"line_number":35,"context_line":"  \u0027memory-checks\u0027,"},{"line_number":36,"context_line":"  \u0027mongodb\u0027,"},{"line_number":37,"context_line":"  \u0027mysql\u0027,"},{"line_number":38,"context_line":"  \u0027network-checks\u0027,"},{"line_number":39,"context_line":"  \u0027ntp\u0027,"},{"line_number":40,"context_line":"  \u0027openstack\u0027,"},{"line_number":41,"context_line":"  \u0027process-checks\u0027,"},{"line_number":42,"context_line":"  \u0027rabbitmq\u0027,"},{"line_number":43,"context_line":"  \u0027redis\u0027,"},{"line_number":44,"context_line":"  \u0027uptime-checks\u0027,"},{"line_number":45,"context_line":"  \u0027vmstats\u0027,"},{"line_number":46,"context_line":"] %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"RUN sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff346bd7_22289a84","line":46,"range":{"start_line":22,"start_character":0,"end_line":46,"end_character":4},"updated":"2017-07-24 09:23:12.000000000","message":"use 4 spaces for indent","commit_id":"6a78c2d214ee1e8022b6fded7a566f353f711887"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bd51f2e9da8850002e42ccd6bfeccd424d29fbd3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{% block sensu_client_footer %}{% endblock %}"},{"line_number":20,"context_line":"{% block footer %}{% endblock %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":23,"context_line":"  \u0027ceph\u0027,"},{"line_number":24,"context_line":"  \u0027cpu-checks\u0027,"},{"line_number":25,"context_line":"  \u0027disk-checks\u0027,"},{"line_number":26,"context_line":"  \u0027dns\u0027,"},{"line_number":27,"context_line":"  \u0027docker\u0027,"},{"line_number":28,"context_line":"  \u0027elasticsearch\u0027,"},{"line_number":29,"context_line":"  \u0027filesystem-checks\u0027,"},{"line_number":30,"context_line":"  \u0027haproxy\u0027,"},{"line_number":31,"context_line":"  \u0027http\u0027,"},{"line_number":32,"context_line":"  \u0027io-checks\u0027,"},{"line_number":33,"context_line":"  \u0027load-checks\u0027,"},{"line_number":34,"context_line":"  \u0027memcached\u0027,"},{"line_number":35,"context_line":"  \u0027memory-checks\u0027,"},{"line_number":36,"context_line":"  \u0027mongodb\u0027,"},{"line_number":37,"context_line":"  \u0027mysql\u0027,"},{"line_number":38,"context_line":"  \u0027network-checks\u0027,"},{"line_number":39,"context_line":"  \u0027ntp\u0027,"},{"line_number":40,"context_line":"  \u0027openstack\u0027,"},{"line_number":41,"context_line":"  \u0027process-checks\u0027,"},{"line_number":42,"context_line":"  \u0027rabbitmq\u0027,"},{"line_number":43,"context_line":"  \u0027redis\u0027,"},{"line_number":44,"context_line":"  \u0027uptime-checks\u0027,"},{"line_number":45,"context_line":"  \u0027vmstats\u0027,"},{"line_number":46,"context_line":"] %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"RUN sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"USER sensu"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff346bd7_c25b0e2c","line":48,"range":{"start_line":22,"start_character":0,"end_line":48,"end_character":119},"updated":"2017-07-24 09:23:12.000000000","message":"this should go before footer blocks.\n\nAlso, please add a block sensu_clients_install, to allow disable this part for people behind proxy who does not have access to sensu plugin repos","commit_id":"6a78c2d214ee1e8022b6fded7a566f353f711887"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"f3a888338987285fc695c1355bf6466b9de83d40","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(sensu_client_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":32,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% block sensu_clients_install %}"},{"line_number":36,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":37,"context_line":"    \u0027ceph\u0027,"},{"line_number":38,"context_line":"    \u0027cpu-checks\u0027,"},{"line_number":39,"context_line":"    \u0027disk-checks\u0027,"},{"line_number":40,"context_line":"    \u0027dns\u0027,"},{"line_number":41,"context_line":"    \u0027docker\u0027,"},{"line_number":42,"context_line":"    \u0027elasticsearch\u0027,"},{"line_number":43,"context_line":"    \u0027filesystem-checks\u0027,"},{"line_number":44,"context_line":"    \u0027haproxy\u0027,"},{"line_number":45,"context_line":"    \u0027http\u0027,"},{"line_number":46,"context_line":"    \u0027io-checks\u0027,"},{"line_number":47,"context_line":"    \u0027load-checks\u0027,"},{"line_number":48,"context_line":"    \u0027mailer\u0027,"},{"line_number":49,"context_line":"    \u0027memcached\u0027,"},{"line_number":50,"context_line":"    \u0027memory-checks\u0027,"},{"line_number":51,"context_line":"    \u0027mongodb\u0027,"},{"line_number":52,"context_line":"    \u0027mysql\u0027,"},{"line_number":53,"context_line":"    \u0027network-checks\u0027,"},{"line_number":54,"context_line":"    \u0027ntp\u0027,"},{"line_number":55,"context_line":"    \u0027openstack\u0027,"},{"line_number":56,"context_line":"    \u0027process-checks\u0027,"},{"line_number":57,"context_line":"    \u0027rabbitmq\u0027,"},{"line_number":58,"context_line":"    \u0027redis\u0027,"},{"line_number":59,"context_line":"    \u0027slack\u0027,"},{"line_number":60,"context_line":"    \u0027uptime-checks\u0027,"},{"line_number":61,"context_line":"    \u0027vmstats\u0027,"},{"line_number":62,"context_line":"] %}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"RUN /opt/sensu/embedded/bin/gem install vmstat --no-rdoc --no-ri \\"},{"line_number":65,"context_line":"    \u0026\u0026 sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":66,"context_line":"{% endblock %}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"{% block sensu_client_footer %}{% endblock %}"},{"line_number":69,"context_line":"{% block footer %}{% endblock %}"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ff346bd7_d8c98c78","line":67,"range":{"start_line":31,"start_character":0,"end_line":67,"end_character":0},"updated":"2017-07-25 15:23:18.000000000","message":"Can we please make all of this wrapped to sensu_clients_install block? Installing the whole development tools group in the container is not a good thing from my point of view, so it would be great if it could be overridable.","commit_id":"00eca5ad313b5df45b85c366fb419b9ec20868b4"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"811e5ab79f2b330da5b7da04609c80a03206b66d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(sensu_client_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":32,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% block sensu_clients_install %}"},{"line_number":36,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":37,"context_line":"    \u0027ceph\u0027,"},{"line_number":38,"context_line":"    \u0027cpu-checks\u0027,"},{"line_number":39,"context_line":"    \u0027disk-checks\u0027,"},{"line_number":40,"context_line":"    \u0027dns\u0027,"},{"line_number":41,"context_line":"    \u0027docker\u0027,"},{"line_number":42,"context_line":"    \u0027elasticsearch\u0027,"},{"line_number":43,"context_line":"    \u0027filesystem-checks\u0027,"},{"line_number":44,"context_line":"    \u0027haproxy\u0027,"},{"line_number":45,"context_line":"    \u0027http\u0027,"},{"line_number":46,"context_line":"    \u0027io-checks\u0027,"},{"line_number":47,"context_line":"    \u0027load-checks\u0027,"},{"line_number":48,"context_line":"    \u0027mailer\u0027,"},{"line_number":49,"context_line":"    \u0027memcached\u0027,"},{"line_number":50,"context_line":"    \u0027memory-checks\u0027,"},{"line_number":51,"context_line":"    \u0027mongodb\u0027,"},{"line_number":52,"context_line":"    \u0027mysql\u0027,"},{"line_number":53,"context_line":"    \u0027network-checks\u0027,"},{"line_number":54,"context_line":"    \u0027ntp\u0027,"},{"line_number":55,"context_line":"    \u0027openstack\u0027,"},{"line_number":56,"context_line":"    \u0027process-checks\u0027,"},{"line_number":57,"context_line":"    \u0027rabbitmq\u0027,"},{"line_number":58,"context_line":"    \u0027redis\u0027,"},{"line_number":59,"context_line":"    \u0027slack\u0027,"},{"line_number":60,"context_line":"    \u0027uptime-checks\u0027,"},{"line_number":61,"context_line":"    \u0027vmstats\u0027,"},{"line_number":62,"context_line":"] %}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"RUN /opt/sensu/embedded/bin/gem install vmstat --no-rdoc --no-ri \\"},{"line_number":65,"context_line":"    \u0026\u0026 sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":66,"context_line":"{% endblock %}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"{% block sensu_client_footer %}{% endblock %}"},{"line_number":69,"context_line":"{% block footer %}{% endblock %}"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ff346bd7_3b2f56a2","line":67,"range":{"start_line":31,"start_character":0,"end_line":67,"end_character":0},"in_reply_to":"ff346bd7_d8c98c78","updated":"2017-07-26 09:32:58.000000000","message":"I am going to add it to the block, sure! I am sure there\u0027s a better way than installing the group but since I am not very good with CentOS I can either remove CentOS support or we wait for someone else to improve it later on.","commit_id":"00eca5ad313b5df45b85c366fb419b9ec20868b4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"cc4e88dabc6d30d4786b825552f1d48fd7ae483e","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(sensu_client_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block sensu_clients_install %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":34,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff346bd7_3e9f4460","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":22},"updated":"2017-07-26 10:12:25.000000000","message":"Maybe sensu_plugins_install might be a better name for this block?","commit_id":"71ad2e237cdc0317a4415a15e6dca6c55af1d7f1"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"cc4e88dabc6d30d4786b825552f1d48fd7ae483e","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block sensu_clients_install %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":34,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":38,"context_line":"    \u0027ceph\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff346bd7_316415e4","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":11},"updated":"2017-07-26 10:12:25.000000000","message":"Regarding your comment. I tried to sensu-install all plugins below just by installing above dependencies (line 12-15) on clean CentOS image and was successful (https://paste.fedoraproject.org/paste/EcPAP--oPFiFJ-LZy~uZXQ)\n\nNot sure what are you trying to succeed by installing the group.","commit_id":"71ad2e237cdc0317a4415a15e6dca6c55af1d7f1"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"56180367b1dd697461f5e4628c1e79adf39019e8","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block sensu_clients_install %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":34,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":38,"context_line":"    \u0027ceph\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff346bd7_b15a45f0","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":11},"in_reply_to":"ff346bd7_316415e4","updated":"2017-07-26 10:15:34.000000000","message":"Can you fire up an instance of the sensu-base container and try to run the sensu-install commands again? It didnt work for me.","commit_id":"71ad2e237cdc0317a4415a15e6dca6c55af1d7f1"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"5a7698d418833cc9f930e09749a0870e7770fad4","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block sensu_clients_install %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":34,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":38,"context_line":"    \u0027ceph\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff346bd7_af22dca2","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":11},"in_reply_to":"ff346bd7_341d2366","updated":"2017-07-26 11:19:17.000000000","message":"So even with the sensu-base image I didn\u0027t have a problem: \nhttps://paste.fedoraproject.org/paste/hb0T3QNRdjvFCvEGn8PQoA","commit_id":"71ad2e237cdc0317a4415a15e6dca6c55af1d7f1"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"338bb63bfd4b50f56c11f9fec5e9024de4bae326","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block sensu_clients_install %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":34,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":38,"context_line":"    \u0027ceph\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff346bd7_cf02c009","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":11},"in_reply_to":"ff346bd7_341d2366","updated":"2017-07-26 11:18:18.000000000","message":"Understood. Yeah that would be much better than the group install for sure!","commit_id":"71ad2e237cdc0317a4415a15e6dca6c55af1d7f1"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"f87214111fce7ead7791ea4810873cd96a7cb115","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block sensu_clients_install %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":34,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":38,"context_line":"    \u0027ceph\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff346bd7_d198291c","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":11},"in_reply_to":"ff346bd7_5168b91f","updated":"2017-07-26 10:35:02.000000000","message":"The Centos version of sensu is way to old to be useful","commit_id":"71ad2e237cdc0317a4415a15e6dca6c55af1d7f1"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"8db1b0e430edc598b78b40e4316de369859e1f4e","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block sensu_clients_install %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":34,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":38,"context_line":"    \u0027ceph\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff346bd7_5168b91f","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":11},"in_reply_to":"ff346bd7_b15a45f0","updated":"2017-07-26 10:32:38.000000000","message":"The reason, why it does not work for you is that you are using Sensuapp.org provided RPM instead of the community RPM from CentOS repository (this is caused by adding sensuapp repo in this patch). It might be possible that the third party RPM is missing some important dependency. Will try to figure it out.","commit_id":"71ad2e237cdc0317a4415a15e6dca6c55af1d7f1"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"f0a66215698572cba3a168ea8fe05cc4db7662e0","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block sensu_clients_install %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":34,"context_line":"RUN yum groupinstall -y \u0027Development Tools\u0027"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":38,"context_line":"    \u0027ceph\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff346bd7_341d2366","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":11},"in_reply_to":"ff346bd7_d198291c","updated":"2017-07-26 10:45:12.000000000","message":"I\u0027m not arguing for not using the package from Sensuapp. Let\u0027s just find the missing dependency, so the group does not have to be installed.","commit_id":"71ad2e237cdc0317a4415a15e6dca6c55af1d7f1"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a2b872b624c711ce88efe1743c6fc751389bd1b2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":10,"context_line":"        \u0027docker-client\u0027, "},{"line_number":11,"context_line":"        \u0027osops-tools-monitoring-oschecks\u0027,"},{"line_number":12,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":13,"context_line":"        \u0027make\u0027,"},{"line_number":14,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":15,"context_line":"        \u0027cyrus-sasl-devel\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_8ac24358","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":18},"updated":"2017-09-15 17:07:30.000000000","message":"why those dev packages  are needed?","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"4c0f705c3acc2251edea0df6529be2066d3cf5ab","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":10,"context_line":"        \u0027docker-client\u0027, "},{"line_number":11,"context_line":"        \u0027osops-tools-monitoring-oschecks\u0027,"},{"line_number":12,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":13,"context_line":"        \u0027make\u0027,"},{"line_number":14,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":15,"context_line":"        \u0027cyrus-sasl-devel\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_999cdac0","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":18},"in_reply_to":"5f2577a7_8ac24358","updated":"2017-09-16 09:56:19.000000000","message":"The packages are required to build the sensu_plugins below. Many of them need to compiled and/or require libraries to be available. I found these packages to be their dependencies","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a2b872b624c711ce88efe1743c6fc751389bd1b2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":10,"context_line":"        \u0027docker-client\u0027, "},{"line_number":11,"context_line":"        \u0027osops-tools-monitoring-oschecks\u0027,"},{"line_number":12,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":13,"context_line":"        \u0027make\u0027,"},{"line_number":14,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":15,"context_line":"        \u0027cyrus-sasl-devel\u0027,"},{"line_number":16,"context_line":"        \u0027MariaDB-client\u0027,"},{"line_number":17,"context_line":"        \u0027ntp\u0027,"},{"line_number":18,"context_line":"        \u0027python-pymongo\u0027,"},{"line_number":19,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":22,"context_line":"    {% set sensu_client_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_4adfbb39","line":19,"range":{"start_line":12,"start_character":0,"end_line":19,"end_character":22},"updated":"2017-09-15 17:07:30.000000000","message":"please, alphabetize packages","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a2b872b624c711ce88efe1743c6fc751389bd1b2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":22,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":23,"context_line":"        \u0027docker.io\u0027,"},{"line_number":24,"context_line":"        \u0027gcc\u0027,"},{"line_number":25,"context_line":"        \u0027build-essential\u0027,"},{"line_number":26,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":27,"context_line":"        \u0027mysql-client\u0027,"},{"line_number":28,"context_line":"        \u0027ntp\u0027,"},{"line_number":29,"context_line":"        \u0027python-pymongo\u0027,"},{"line_number":30,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":31,"context_line":"        \u0027inetutils-ping\u0027,"},{"line_number":32,"context_line":"    ] %}"},{"line_number":33,"context_line":"{% else %}"},{"line_number":34,"context_line":"RUN echo \u0027{{ image_name }} not yet available for {{ base_distro }}\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_4ab8dbe3","line":31,"range":{"start_line":24,"start_character":0,"end_line":31,"end_character":25},"updated":"2017-09-15 17:07:30.000000000","message":"ditto","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a2b872b624c711ce88efe1743c6fc751389bd1b2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \u0027vmstats\u0027,"},{"line_number":66,"context_line":"] %}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"RUN /opt/sensu/embedded/bin/gem install vmstat --no-rdoc --no-ri \\"},{"line_number":69,"context_line":"    \u0026\u0026 sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":70,"context_line":"{% endblock %}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_0a93f35c","line":68,"range":{"start_line":68,"start_character":3,"end_line":68,"end_character":28},"updated":"2017-09-15 17:07:30.000000000","message":"is this always the path in all distros?","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a2b872b624c711ce88efe1743c6fc751389bd1b2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"{% block sensu_client_footer %}{% endblock %}"},{"line_number":73,"context_line":"{% block footer %}{% endblock %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"USER root"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_2a7fcf15","line":75,"range":{"start_line":75,"start_character":5,"end_line":75,"end_character":9},"updated":"2017-09-15 17:07:30.000000000","message":"why, for set root just remove USER  sensu, sensu-base images already comes from root user","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"9608ff7557cbc8c255dcf9e9e141c543da5df7a1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027docker-client\u0027,"},{"line_number":13,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":14,"context_line":"        \u0027make\u0027,"},{"line_number":15,"context_line":"        \u0027mariadb-client\u0027,"},{"line_number":16,"context_line":"        \u0027ntp\u0027,"},{"line_number":17,"context_line":"        \u0027osops-tools-monitoring-oschecks\u0027,"},{"line_number":18,"context_line":"        \u0027python-pymongo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"5f2577a7_3b8dc731","line":15,"updated":"2017-09-18 12:44:55.000000000","message":"sensu-client image fails to build with:\n\nINFO:kolla.image.build.sensu-client:No package mariadb-client available.\nINFO:kolla.image.build.sensu-client:  * Maybe you meant: MariaDB-client\nINFO:kolla.image.build.sensu-client:\u001b[91mError: Not tolerating missing names on install, stopping.\n\nUntil we switch to RDO for mariadb you need to stick with MariaDB-client.","commit_id":"07fdcec11cb7d538543b4acf5329a4ae06048b07"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"0d2378f3df63c212cd0872b75a2a50faeb7ee139","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027docker-client\u0027,"},{"line_number":13,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":14,"context_line":"        \u0027make\u0027,"},{"line_number":15,"context_line":"        \u0027mariadb-client\u0027,"},{"line_number":16,"context_line":"        \u0027ntp\u0027,"},{"line_number":17,"context_line":"        \u0027osops-tools-monitoring-oschecks\u0027,"},{"line_number":18,"context_line":"        \u0027python-pymongo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"bf8cb3f7_0b27b0b5","line":15,"in_reply_to":"5f2577a7_3b8dc731","updated":"2017-12-22 20:15:57.000000000","message":"\u003e Until we switch to RDO for mariadb you need to stick with\n \u003e MariaDB-client.\n\nWhere is MariaDB coming from?\nThis doesn\u0027t work in RDO where we do not have MariaDB-client, so this will need to be overriden in tripleo-common.","commit_id":"07fdcec11cb7d538543b4acf5329a4ae06048b07"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"2863a7bfb6a6b817c60718468a17641fd64cd25e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027docker-client\u0027,"},{"line_number":13,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":14,"context_line":"        \u0027make\u0027,"},{"line_number":15,"context_line":"        \u0027mariadb-client\u0027,"},{"line_number":16,"context_line":"        \u0027ntp\u0027,"},{"line_number":17,"context_line":"        \u0027osops-tools-monitoring-oschecks\u0027,"},{"line_number":18,"context_line":"        \u0027python-pymongo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"5f2577a7_1e7c3981","line":15,"in_reply_to":"5f2577a7_3b8dc731","updated":"2017-09-18 12:54:49.000000000","message":"Done","commit_id":"07fdcec11cb7d538543b4acf5329a4ae06048b07"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6cb12c76994ac10c6d185cddeb34e45835fb1275","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \u0027vmstats\u0027,"},{"line_number":66,"context_line":"] %}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"RUN /opt/sensu/embedded/bin/gem install vmstat --no-rdoc --no-ri \\"},{"line_number":69,"context_line":"    \u0026\u0026 sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":70,"context_line":"{% endblock %}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f515b1d_78901bee","line":68,"range":{"start_line":68,"start_character":4,"end_line":68,"end_character":64},"updated":"2017-09-27 14:55:42.000000000","message":"why is this needed, sensu-server does not need it for its plugin install?","commit_id":"e7ddc3c59b087598970d62c9b888efb16366b4c6"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"84e6e8f6e3b500666f385a777f1634c89b7ebb08","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \u0027vmstats\u0027,"},{"line_number":66,"context_line":"] %}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"RUN /opt/sensu/embedded/bin/gem install vmstat --no-rdoc --no-ri \\"},{"line_number":69,"context_line":"    \u0026\u0026 sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":70,"context_line":"{% endblock %}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f515b1d_982de5a9","line":68,"range":{"start_line":68,"start_character":4,"end_line":68,"end_character":64},"in_reply_to":"7f515b1d_78901bee","updated":"2017-09-29 07:28:40.000000000","message":"This file is for sensu-client which needs this gem to execute the \"vmstats\" sensu plugin.","commit_id":"e7ddc3c59b087598970d62c9b888efb16366b4c6"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6cb12c76994ac10c6d185cddeb34e45835fb1275","unresolved":false,"context_lines":[{"line_number":72,"context_line":"{% block sensu_client_footer %}{% endblock %}"},{"line_number":73,"context_line":"{% block footer %}{% endblock %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"USER root"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f515b1d_b8dc53e4","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":9},"updated":"2017-09-27 14:55:42.000000000","message":"can be removed, sensu-base comes with root user","commit_id":"e7ddc3c59b087598970d62c9b888efb16366b4c6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b905707ba8a9b372d0494177ddfd66defed76ea3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":23,"context_line":"        \u0027build-essential\u0027,"},{"line_number":24,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":25,"context_line":"        \u0027docker.io\u0027,"},{"line_number":26,"context_line":"        \u0027gcc\u0027,"},{"line_number":27,"context_line":"        \u0027inetutils-ping\u0027,"},{"line_number":28,"context_line":"        \u0027libsasl2-dev\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"df87a7cf_8e0d2cea","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":20},"updated":"2017-12-13 15:30:15.000000000","message":"For Debian it will be \u0027docker-ce\u0027","commit_id":"220978cb289076a342dcb79ba3351ac57f648d6d"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"92056f29b688f06038174ed0f7e936e07324664c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":23,"context_line":"        \u0027build-essential\u0027,"},{"line_number":24,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":25,"context_line":"        \u0027docker.io\u0027,"},{"line_number":26,"context_line":"        \u0027gcc\u0027,"},{"line_number":27,"context_line":"        \u0027inetutils-ping\u0027,"},{"line_number":28,"context_line":"        \u0027libsasl2-dev\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"df87a7cf_0e7fdcab","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":20},"in_reply_to":"df87a7cf_8e0d2cea","updated":"2017-12-13 15:42:30.000000000","message":"will fix","commit_id":"220978cb289076a342dcb79ba3351ac57f648d6d"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5e96438311f58028dc48cbe40f907c8d924e5251","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        \u0027python-pymongo\u0027,"},{"line_number":19,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":22,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":23,"context_line":"        \u0027build-essential\u0027,"},{"line_number":24,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":25,"context_line":"        \u0027docker.io\u0027,"},{"line_number":26,"context_line":"        \u0027gcc\u0027,"},{"line_number":27,"context_line":"        \u0027inetutils-ping\u0027,"},{"line_number":28,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":29,"context_line":"        \u0027mysql-client\u0027,"},{"line_number":30,"context_line":"        \u0027ntp\u0027,"},{"line_number":31,"context_line":"        \u0027python-pymongo\u0027,"},{"line_number":32,"context_line":"    ] %}"},{"line_number":33,"context_line":"{% elif base_distro in [\u0027debian\u0027] %}"},{"line_number":34,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":35,"context_line":"        \u0027build-essential\u0027,"},{"line_number":36,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":37,"context_line":"        \u0027docker-ce\u0027,"},{"line_number":38,"context_line":"        \u0027gcc\u0027,"},{"line_number":39,"context_line":"        \u0027inetutils-ping\u0027,"},{"line_number":40,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":41,"context_line":"        \u0027mysql-client\u0027,"},{"line_number":42,"context_line":"        \u0027ntp\u0027,"},{"line_number":43,"context_line":"        \u0027python-pymongo\u0027,"},{"line_number":44,"context_line":"    ] %}"},{"line_number":45,"context_line":"{% else %}"},{"line_number":46,"context_line":"RUN echo \u0027{{ image_name }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":47,"context_line":"    \u0026\u0026 /bin/false"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"df87a7cf_f13a9d96","line":44,"range":{"start_line":21,"start_character":0,"end_line":44,"end_character":8},"updated":"2017-12-13 15:51:46.000000000","message":"merge those two and handle just docker inside as debian/ubuntu difference - check https://review.openstack.org/#/c/527712/ for example","commit_id":"46cd5eb9214d1ad8b0201832eeda08f904cf9512"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"4c153b2e9f86e9f966247bdc62a01e1cae8bade5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":22,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":23,"context_line":"        \u0027build-essential\u0027,"},{"line_number":24,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":25,"context_line":"        \u0027docker.io\u0027,"},{"line_number":26,"context_line":"        \u0027gcc\u0027,"},{"line_number":27,"context_line":"        \u0027inetutils-ping\u0027,"},{"line_number":28,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":29,"context_line":"        \u0027mysql-client\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"df87a7cf_425e1546","line":26,"range":{"start_line":23,"start_character":8,"end_line":26,"end_character":14},"updated":"2017-12-13 17:50:48.000000000","message":"build-essential depends on gcc already","commit_id":"36fb57c1ede2ea9d2777009dc13c04534e8772d7"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"4c153b2e9f86e9f966247bdc62a01e1cae8bade5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027ntp\u0027,"},{"line_number":31,"context_line":"        \u0027python-pymongo\u0027,"},{"line_number":32,"context_line":"    ] %}"},{"line_number":33,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":34,"context_line":"        {% set sensu_client_packages \u003d sensu_client_packages + ["},{"line_number":35,"context_line":"            \u0027docker.io\u0027,"},{"line_number":36,"context_line":"        ] %}"},{"line_number":37,"context_line":"    {% elif base_distro in [\u0027debian\u0027] %}"},{"line_number":38,"context_line":"        {% set sensu_client_packages \u003d sensu_client_packages + ["},{"line_number":39,"context_line":"            \u0027docker-ce\u0027,"},{"line_number":40,"context_line":"        ] %}"},{"line_number":41,"context_line":"    {% endif %}"},{"line_number":42,"context_line":"{% else %}"},{"line_number":43,"context_line":"RUN echo \u0027{{ image_name }} not yet available for {{ base_distro }}\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"df87a7cf_c2eea58a","line":40,"range":{"start_line":33,"start_character":0,"end_line":40,"end_character":12},"updated":"2017-12-13 17:50:48.000000000","message":"if debian\nelse\nendif\n\nalphabetical order and no need for elif","commit_id":"36fb57c1ede2ea9d2777009dc13c04534e8772d7"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"4c153b2e9f86e9f966247bdc62a01e1cae8bade5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027vmstats\u0027,"},{"line_number":75,"context_line":"] %}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"RUN /opt/sensu/embedded/bin/gem install vmstat --no-rdoc --no-ri \\"},{"line_number":78,"context_line":"    \u0026\u0026 sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":79,"context_line":"{% endblock %}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"df87a7cf_c261c513","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":31},"updated":"2017-12-13 17:50:48.000000000","message":"does this path exists in all supported distros? centos/debian/ubuntu","commit_id":"36fb57c1ede2ea9d2777009dc13c04534e8772d7"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"44e2373d2c7b25e6a688e598b9598c09ce09e5b7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027ntp\u0027,"},{"line_number":17,"context_line":"        \u0027osops-tools-monitoring-oschecks\u0027,"},{"line_number":18,"context_line":"        \u0027python-pymongo\u0027,"},{"line_number":19,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":22,"context_line":"    {% set sensu_client_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"df87a7cf_1a88686f","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":21},"updated":"2017-12-14 06:17:17.000000000","message":"ditto","commit_id":"bfbc1c902757dfba1367fe307e280cb4ccf386b7"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"44e2373d2c7b25e6a688e598b9598c09ce09e5b7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":28,"context_line":"        \u0027mysql-client\u0027,"},{"line_number":29,"context_line":"        \u0027ntp\u0027,"},{"line_number":30,"context_line":"        \u0027python-pymongo\u0027,"},{"line_number":31,"context_line":"    ] %}"},{"line_number":32,"context_line":"    {% if base_distro in [\u0027debian\u0027] %}"},{"line_number":33,"context_line":"        {% set sensu_client_packages \u003d sensu_client_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"df87a7cf_ba7cdc72","line":30,"range":{"start_line":30,"start_character":24,"end_line":30,"end_character":25},"updated":"2017-12-14 06:17:17.000000000","message":"ditto","commit_id":"bfbc1c902757dfba1367fe307e280cb4ccf386b7"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"44e2373d2c7b25e6a688e598b9598c09ce09e5b7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    ] %}"},{"line_number":32,"context_line":"    {% if base_distro in [\u0027debian\u0027] %}"},{"line_number":33,"context_line":"        {% set sensu_client_packages \u003d sensu_client_packages + ["},{"line_number":34,"context_line":"            \u0027docker-ce\u0027,"},{"line_number":35,"context_line":"        ] %}"},{"line_number":36,"context_line":"    {% else %}"},{"line_number":37,"context_line":"        {% set sensu_client_packages \u003d sensu_client_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"df87a7cf_7a965497","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":24},"updated":"2017-12-14 06:17:17.000000000","message":"ditto","commit_id":"bfbc1c902757dfba1367fe307e280cb4ccf386b7"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"44e2373d2c7b25e6a688e598b9598c09ce09e5b7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        ] %}"},{"line_number":36,"context_line":"    {% else %}"},{"line_number":37,"context_line":"        {% set sensu_client_packages \u003d sensu_client_packages + ["},{"line_number":38,"context_line":"            \u0027docker.io\u0027,"},{"line_number":39,"context_line":"        ] %}"},{"line_number":40,"context_line":"    {% endif %}"},{"line_number":41,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"df87a7cf_7adbb47c","line":38,"range":{"start_line":38,"start_character":23,"end_line":38,"end_character":24},"updated":"2017-12-14 06:17:17.000000000","message":"ditto","commit_id":"bfbc1c902757dfba1367fe307e280cb4ccf386b7"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"242e5d6105bb342c574eb4369ffd339a4daa05bb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"] %}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"RUN /opt/sensu/embedded/bin/gem install vmstat --no-rdoc --no-ri \\"},{"line_number":77,"context_line":"    \u0026\u0026 sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":78,"context_line":"{% endblock %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% block sensu_client_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"df87a7cf_69f774d6","line":77,"updated":"2017-12-14 02:59:58.000000000","message":"ditto with sensu-server","commit_id":"bfbc1c902757dfba1367fe307e280cb4ccf386b7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b45d1fd537d9c8fd8eb8fe5ef16e3e3f3ea4b8d9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    {% set sensu_client_packages \u003d ["},{"line_number":23,"context_line":"        \u0027build-essential\u0027,"},{"line_number":24,"context_line":"        \u0027ceph-common\u0027,"},{"line_number":25,"context_line":"        \u0027docker.io\u0027,"},{"line_number":26,"context_line":"        \u0027inetutils-ping\u0027,"},{"line_number":27,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":28,"context_line":"        \u0027mysql-client\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"df87a7cf_4be2a031","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":20},"updated":"2017-12-14 09:03:52.000000000","message":"debian case wont work as package is defined first here","commit_id":"69bcf3f690513270f90ada8e4fcf359210b8987a"}],"docker/sensu/sensu-server/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a2b872b624c711ce88efe1743c6fc751389bd1b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set sensu_server_packages \u003d ["},{"line_number":10,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":11,"context_line":"        \u0027make\u0027,"},{"line_number":12,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":13,"context_line":"        \u0027cyrus-sasl-devel\u0027,"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":"    {% set sensu_server_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_0a7c131d","line":13,"range":{"start_line":10,"start_character":0,"end_line":13,"end_character":27},"updated":"2017-09-15 17:07:30.000000000","message":"many  packages  duplicated in client  and server, maybe  is better put them in sensu-base.\n\nAlso alphabetize","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"4c0f705c3acc2251edea0df6529be2066d3cf5ab","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set sensu_server_packages \u003d ["},{"line_number":10,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":11,"context_line":"        \u0027make\u0027,"},{"line_number":12,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":13,"context_line":"        \u0027cyrus-sasl-devel\u0027,"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":"    {% set sensu_server_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_59a2f2fd","line":13,"range":{"start_line":10,"start_character":0,"end_line":13,"end_character":27},"in_reply_to":"5f2577a7_0a7c131d","updated":"2017-09-16 09:56:19.000000000","message":"They\u0027re not needed in sensu-api so putting them into sensu-base would be unnecessary. Do you still want them in sensu-base?","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a2b872b624c711ce88efe1743c6fc751389bd1b2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":"    {% set sensu_server_packages \u003d ["},{"line_number":17,"context_line":"        \u0027gcc\u0027,"},{"line_number":18,"context_line":"        \u0027build-essential\u0027,"},{"line_number":19,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% else %}"},{"line_number":22,"context_line":"RUN echo \u0027{{ image_name }} not yet available for {{ base_distro }}\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_ca716b46","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":23},"updated":"2017-09-15 17:07:30.000000000","message":"ditto","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a2b872b624c711ce88efe1743c6fc751389bd1b2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        \u0027build-essential\u0027,"},{"line_number":19,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% else %}"},{"line_number":22,"context_line":"RUN echo \u0027{{ image_name }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":23,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(sensu_server_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f2577a7_4a9b3b65","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":11},"updated":"2017-09-15 17:07:30.000000000","message":"what distro catch this else? all distros are installed atm","commit_id":"00f6bfdaa98d754cf07ced36f02e127371565232"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6cb12c76994ac10c6d185cddeb34e45835fb1275","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        \u0027gcc\u0027,"},{"line_number":19,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% else %}"},{"line_number":22,"context_line":"RUN echo \u0027{{ image_name }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":23,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(sensu_server_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7f515b1d_9802b73c","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":11},"updated":"2017-09-27 14:55:42.000000000","message":"no image match this condition, can be removed","commit_id":"e7ddc3c59b087598970d62c9b888efb16366b4c6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b905707ba8a9b372d0494177ddfd66defed76ea3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":"    {% set sensu_server_packages \u003d ["},{"line_number":17,"context_line":"        \u0027build-essential\u0027,"},{"line_number":18,"context_line":"        \u0027gcc\u0027,"},{"line_number":19,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ macros.install_packages(sensu_server_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"df87a7cf_ced1f431","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":8},"updated":"2017-12-13 15:30:15.000000000","message":"no need for ruby-dev?","commit_id":"220978cb289076a342dcb79ba3351ac57f648d6d"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"92056f29b688f06038174ed0f7e936e07324664c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":"    {% set sensu_server_packages \u003d ["},{"line_number":17,"context_line":"        \u0027build-essential\u0027,"},{"line_number":18,"context_line":"        \u0027gcc\u0027,"},{"line_number":19,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ macros.install_packages(sensu_server_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"df87a7cf_8e6becef","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":8},"in_reply_to":"df87a7cf_ced1f431","updated":"2017-12-13 15:42:30.000000000","message":"I didn\u0027t need it in my testing and I tested on Ubuntu. I built on CentOS months ago and had to add ruby-devel","commit_id":"220978cb289076a342dcb79ba3351ac57f648d6d"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"4c153b2e9f86e9f966247bdc62a01e1cae8bade5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":"    {% set sensu_server_packages \u003d ["},{"line_number":17,"context_line":"        \u0027build-essential\u0027,"},{"line_number":18,"context_line":"        \u0027gcc\u0027,"},{"line_number":19,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"df87a7cf_627239e6","line":18,"range":{"start_line":17,"start_character":7,"end_line":18,"end_character":14},"updated":"2017-12-13 17:50:48.000000000","message":"build-essential depends on gcc already","commit_id":"36fb57c1ede2ea9d2777009dc13c04534e8772d7"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"242e5d6105bb342c574eb4369ffd339a4daa05bb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \u0027slack\u0027,"},{"line_number":29,"context_line":"] %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RUN sensu-install --plugins {% for plugin in sensu_plugins %}{{ plugin }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":32,"context_line":"{% endblock %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block sensu_server_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"df87a7cf_c9e000fe","line":31,"updated":"2017-12-14 02:59:58.000000000","message":"thinking, better way is\n\n{% set sensu_server_plugins \u003d [xxx] %}\n{{ sensu_plugins | customizable(\u0027plugins\u0027) | join (\u0027,\u0027) }}","commit_id":"bfbc1c902757dfba1367fe307e280cb4ccf386b7"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"a6d9da971727789ff3b50e76c744c4c30af7c158","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        \u0027cyrus-sasl-devel\u0027,"},{"line_number":11,"context_line":"        \u0027gcc-c++\u0027,"},{"line_number":12,"context_line":"        \u0027make\u0027,"},{"line_number":13,"context_line":"        \u0027ruby-devel\u0027,"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":"    {% set sensu_server_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"df87a7cf_cbf6b0fa","line":13,"range":{"start_line":13,"start_character":20,"end_line":13,"end_character":21},"updated":"2017-12-14 09:05:16.000000000","message":"remove extra commas","commit_id":"69bcf3f690513270f90ada8e4fcf359210b8987a"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"a6d9da971727789ff3b50e76c744c4c30af7c158","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":"    {% set sensu_server_packages \u003d ["},{"line_number":17,"context_line":"        \u0027build-essential\u0027,"},{"line_number":18,"context_line":"        \u0027libsasl2-dev\u0027,"},{"line_number":19,"context_line":"    ] %}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"df87a7cf_8bd8a87f","line":18,"range":{"start_line":18,"start_character":22,"end_line":18,"end_character":23},"updated":"2017-12-14 09:05:16.000000000","message":"ditto","commit_id":"69bcf3f690513270f90ada8e4fcf359210b8987a"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"a6d9da971727789ff3b50e76c744c4c30af7c158","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% set sensu_plugins \u003d ["},{"line_number":27,"context_line":"    \u0027mailer\u0027,"},{"line_number":28,"context_line":"    \u0027slack\u0027,"},{"line_number":29,"context_line":"] %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RUN sensu-install --plugins {{ sensu_plugins | customizable(\u0027plugins\u0027) | join (\u0027,\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"df87a7cf_2be5dc38","line":28,"range":{"start_line":28,"start_character":11,"end_line":28,"end_character":12},"updated":"2017-12-14 09:05:16.000000000","message":"ditto","commit_id":"69bcf3f690513270f90ada8e4fcf359210b8987a"}]}