)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e1aac1efc9c9a95baffc4465d17dc34c0985afd7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Change-Id: Ic65c838af8a432ac02f3141fc9665b9ccd59877f"},{"line_number":30,"context_line":"Signed-off-by: Taeha Kim \u003ckthguru@gmail.com\u003e"},{"line_number":31,"context_line":"Signed-off-by: heetae82.ahn \u003cheetae82.ahn@samsung.com\u003e"},{"line_number":32,"context_line":"(cherry picked from commit e0b50bd61fc5665b5602640e708baae51f552ffb)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":55,"id":"5fc1f717_b778c3c3","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":68},"updated":"2019-03-27 09:43:32.000000000","message":"master does not have backports","commit_id":"6f6c06a0d8aa3f3e85678c71c1f854a6dfd0e835"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"65bb41a06641869eb7b5e74a5ede47e1c398bc4a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Change-Id: Ic65c838af8a432ac02f3141fc9665b9ccd59877f"},{"line_number":30,"context_line":"Signed-off-by: Taeha Kim \u003ckthguru@gmail.com\u003e"},{"line_number":31,"context_line":"Signed-off-by: heetae82.ahn \u003cheetae82.ahn@samsung.com\u003e"},{"line_number":32,"context_line":"(cherry picked from commit e0b50bd61fc5665b5602640e708baae51f552ffb)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":55,"id":"5fc1f717_72cca088","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":68},"in_reply_to":"5fc1f717_b778c3c3","updated":"2019-03-27 16:06:15.000000000","message":"Done. Thank you very much.","commit_id":"6f6c06a0d8aa3f3e85678c71c1f854a6dfd0e835"}],"doc/source/admin/image-building.rst":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"2419800277290bbcab831daecfeace43f4cea6b7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"To build RHEL containers, it is necessary to include registration with RHN"},{"line_number":151,"context_line":"of the container runtime operating system.  To obtain a RHN"},{"line_number":152,"context_line":"username/password/pool id, contact Red Hat.  Set variables in"},{"line_number":153,"context_line":"``etc/kolla/kolla-build.conf`` to register with RHN as follows::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    [DEFAULT]"},{"line_number":156,"context_line":"    rhel_username \u003d your_username"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_13bab6dd","line":153,"range":{"start_line":153,"start_character":2,"end_line":153,"end_character":23},"updated":"2017-10-18 09:10:03.000000000","message":"/etc/kolla/kolla-build.conf is better","commit_id":"6c7bcb98af1c927d1809f596f5e2ddecdee47dba"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"9f49d62e84bcdfab96533d0bceb5a74cbdb2a634","unresolved":false,"context_lines":[{"line_number":150,"context_line":"To build RHEL containers, it is necessary to include registration with RHN"},{"line_number":151,"context_line":"of the container runtime operating system.  To obtain a RHN"},{"line_number":152,"context_line":"username/password/pool id, contact Red Hat.  Set variables in"},{"line_number":153,"context_line":"``etc/kolla/kolla-build.conf`` to register with RHN as follows::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    [DEFAULT]"},{"line_number":156,"context_line":"    rhel_username \u003d your_username"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_eb904251","line":153,"range":{"start_line":153,"start_character":2,"end_line":153,"end_character":23},"in_reply_to":"3f4b6375_13bab6dd","updated":"2017-10-18 11:15:04.000000000","message":"In consistency of previous section, I think it is better to remain as ``etc/kolla/kolla-build.conf``","commit_id":"6c7bcb98af1c927d1809f596f5e2ddecdee47dba"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"da63ff47a4db4b23eb3aee081854d3c1600a94f5","unresolved":false,"context_lines":[{"line_number":150,"context_line":"To build RHEL containers, it is necessary to include registration with RHN"},{"line_number":151,"context_line":"of the container runtime operating system.  To obtain a RHN"},{"line_number":152,"context_line":"username/password/pool id, contact Red Hat.  Set variables in"},{"line_number":153,"context_line":"``etc/kolla/kolla-build.conf`` to register with RHN as follows::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    [DEFAULT]"},{"line_number":156,"context_line":"    rhel_username \u003d your_username"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_8d906250","line":153,"range":{"start_line":153,"start_character":2,"end_line":153,"end_character":23},"in_reply_to":"3f4b6375_af057dc4","updated":"2017-10-23 04:40:22.000000000","message":"Done","commit_id":"6c7bcb98af1c927d1809f596f5e2ddecdee47dba"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"3a9e9bde8e82c97fa0f8d4172023be19c0bf9904","unresolved":false,"context_lines":[{"line_number":150,"context_line":"To build RHEL containers, it is necessary to include registration with RHN"},{"line_number":151,"context_line":"of the container runtime operating system.  To obtain a RHN"},{"line_number":152,"context_line":"username/password/pool id, contact Red Hat.  Set variables in"},{"line_number":153,"context_line":"``etc/kolla/kolla-build.conf`` to register with RHN as follows::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    [DEFAULT]"},{"line_number":156,"context_line":"    rhel_username \u003d your_username"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_af057dc4","line":153,"range":{"start_line":153,"start_character":2,"end_line":153,"end_character":23},"in_reply_to":"3f4b6375_eb904251","updated":"2017-10-20 05:04:35.000000000","message":"Heetae,\n\nIf the kolla-build.conf does not exists in /etc/kolla, kolla-build uses default values, vice versa.\n\nThat is the reason why previous reviewers mention that /etc/kolla/kolla-build.conf is more suitable than etc/kolla/kolla-build.conf.\n\nIf you really want to use etc/kolla/kolla-build.conf, you should copy it first to /etc/kolla before running kolla-build. Subsequently, you need to add those things into image-building.rst in this patch.","commit_id":"6c7bcb98af1c927d1809f596f5e2ddecdee47dba"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"de761dc8577a20385254350fc363d2bae2770139","unresolved":false,"context_lines":[{"line_number":150,"context_line":"To build RHEL containers, it is necessary to include registration with RHN"},{"line_number":151,"context_line":"of the container runtime operating system.  To obtain a RHN"},{"line_number":152,"context_line":"username/password/pool id, contact Red Hat.  Set variables in"},{"line_number":153,"context_line":"``etc/kolla/kolla-build.conf`` to register with RHN as follows::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    [DEFAULT]"},{"line_number":156,"context_line":"    rhel_username \u003d your_username"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3f4b6375_2eb52f32","line":153,"range":{"start_line":153,"start_character":2,"end_line":153,"end_character":28},"updated":"2017-10-19 05:53:32.000000000","message":"\"/etc/kolla/kolla-build.conf\" is better. \"etc/kolla/kolla-build.conf\" is a sample file, we\u0027d better not hint reader to configure this file.","commit_id":"4319322972bbad7a254abdcf94b3b753fa456b32"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"da63ff47a4db4b23eb3aee081854d3c1600a94f5","unresolved":false,"context_lines":[{"line_number":150,"context_line":"To build RHEL containers, it is necessary to include registration with RHN"},{"line_number":151,"context_line":"of the container runtime operating system.  To obtain a RHN"},{"line_number":152,"context_line":"username/password/pool id, contact Red Hat.  Set variables in"},{"line_number":153,"context_line":"``etc/kolla/kolla-build.conf`` to register with RHN as follows::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    [DEFAULT]"},{"line_number":156,"context_line":"    rhel_username \u003d your_username"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3f4b6375_cdae5a97","line":153,"range":{"start_line":153,"start_character":2,"end_line":153,"end_character":28},"in_reply_to":"3f4b6375_2eb52f32","updated":"2017-10-23 04:40:22.000000000","message":"Done","commit_id":"4319322972bbad7a254abdcf94b3b753fa456b32"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"e126d26f35e9aaff2e9b0755d367b112ed18a16d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"      --rhel-password your_password \\"},{"line_number":164,"context_line":"      --rhel-poolid your_poolid"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"If pool id is not specifed then auto attach option will be applied."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Dockerfile Customisation"},{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f4b6375_f037b44c","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":67},"updated":"2017-11-01 05:26:27.000000000","message":"add the command line too for same information.","commit_id":"df95cb7275b45de5a61289da1b3b1f21d9d2a665"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"a469fc0a08fe25d0b4e747f2c9ed6ba293353b5a","unresolved":false,"context_lines":[{"line_number":163,"context_line":"      --rhel-password your_password \\"},{"line_number":164,"context_line":"      --rhel-poolid your_poolid"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"If pool id is not specifed then auto attach option will be applied."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Dockerfile Customisation"},{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f4b6375_5337b2b1","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":67},"in_reply_to":"3f4b6375_f037b44c","updated":"2017-11-01 05:44:26.000000000","message":"OK, I\u0027ll add that.","commit_id":"df95cb7275b45de5a61289da1b3b1f21d9d2a665"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3113a10393496fd60d097cee30979a3161e3c146","unresolved":false,"context_lines":[{"line_number":206,"context_line":"   [ironic-base]"},{"line_number":207,"context_line":"   type \u003d local"},{"line_number":208,"context_line":"   location \u003d /tmp/ironic.tar.gz"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"To build RHEL containers, it is necessary to include registration with RHN"},{"line_number":211,"context_line":"of the container runtime operating system. To obtain a RHN"},{"line_number":212,"context_line":"username/password/pool id, contact Red Hat. Set variables in"}],"source_content_type":"text/x-rst","patch_set":69,"id":"dfbec78f_4b461124","line":209,"updated":"2019-05-07 17:36:08.000000000","message":"This section is \u0027Build OpenStack from source\u0027, which does not really apply to RHEL.\n\nCan you add a new heading, e.g.\n\nBuilding RHEL Containers\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d","commit_id":"461590495bf6bbc9d4e00c0165fea59ba6ff1a43"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"b27ceef85d2bbca6b40de30ce631422d07551453","unresolved":false,"context_lines":[{"line_number":206,"context_line":"   [ironic-base]"},{"line_number":207,"context_line":"   type \u003d local"},{"line_number":208,"context_line":"   location \u003d /tmp/ironic.tar.gz"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"To build RHEL containers, it is necessary to include registration with RHN"},{"line_number":211,"context_line":"of the container runtime operating system. To obtain a RHN"},{"line_number":212,"context_line":"username/password/pool id, contact Red Hat. Set variables in"}],"source_content_type":"text/x-rst","patch_set":69,"id":"dfbec78f_abbead62","line":209,"in_reply_to":"dfbec78f_4b461124","updated":"2019-05-07 18:10:15.000000000","message":"Done","commit_id":"461590495bf6bbc9d4e00c0165fea59ba6ff1a43"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3113a10393496fd60d097cee30979a3161e3c146","unresolved":false,"context_lines":[{"line_number":212,"context_line":"username/password/pool id, contact Red Hat. Set variables in"},{"line_number":213,"context_line":"``/etc/kolla/kolla-build.conf`` to register with RHN as follows:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. path etc/kolla/kolla-build.conf"},{"line_number":216,"context_line":".. code-block:: ini"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":69,"id":"dfbec78f_ebbfc5f8","line":215,"range":{"start_line":215,"start_character":0,"end_line":215,"end_character":34},"updated":"2019-05-07 17:36:08.000000000","message":"I don\u0027t think this has any effect. Remove it?","commit_id":"461590495bf6bbc9d4e00c0165fea59ba6ff1a43"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"b27ceef85d2bbca6b40de30ce631422d07551453","unresolved":false,"context_lines":[{"line_number":212,"context_line":"username/password/pool id, contact Red Hat. Set variables in"},{"line_number":213,"context_line":"``/etc/kolla/kolla-build.conf`` to register with RHN as follows:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. path etc/kolla/kolla-build.conf"},{"line_number":216,"context_line":".. code-block:: ini"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":69,"id":"dfbec78f_cbc1a1e6","line":215,"range":{"start_line":215,"start_character":0,"end_line":215,"end_character":34},"in_reply_to":"dfbec78f_ebbfc5f8","updated":"2019-05-07 18:10:15.000000000","message":"Done","commit_id":"461590495bf6bbc9d4e00c0165fea59ba6ff1a43"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"aa6945f5448e42db3fa5560332c9cf5923df3d39","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    {% if base_distro \u003d\u003d \u0027rhel\u0027 %}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":162,"context_line":"# Register RHEL subscription of each containers for all RHEL builds"},{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None and rhel_poolid !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":165,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7f287b81_f81613a8","line":162,"range":{"start_line":162,"start_character":32,"end_line":162,"end_character":47},"updated":"2017-08-30 08:11:20.000000000","message":"nope, this will register the base image only, not all images.\n\nI\u0027m not sure about how redhat works with this subscription in containers, we use headers to add subscription into each image\n\nhttps://github.com/openstack/kolla/blob/master/doc/image-building.rst#build-openstack-from-source","commit_id":"715bdf913e7f747f7c3d2ea17038770cf83e3543"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"9f49d62e84bcdfab96533d0bceb5a74cbdb2a634","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    {% if base_distro \u003d\u003d \u0027rhel\u0027 %}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":162,"context_line":"# Register RHEL subscription of each containers for all RHEL builds"},{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None and rhel_poolid !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":165,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7f287b81_7e97ab49","line":162,"range":{"start_line":162,"start_character":32,"end_line":162,"end_character":47},"in_reply_to":"7f287b81_f81613a8","updated":"2017-10-18 11:15:04.000000000","message":"I changed the comment","commit_id":"715bdf913e7f747f7c3d2ea17038770cf83e3543"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"27b63db597a1a3d1ebab8ad240725146a8f42455","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":162,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None and rhel_poolid !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":165,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""},{"line_number":166,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"3f4b6375_41aed8e7","line":163,"range":{"start_line":163,"start_character":58,"end_line":163,"end_character":77},"updated":"2017-10-31 10:28:51.000000000","message":"I think pool id is not necessary in registration, so we have modify the condition accordingly","commit_id":"bc2b40e1bddb425f0654c028a5f00d35bec98665"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"ef224bd343728f632349c271a6332ca2c891bd66","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":162,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None and rhel_poolid !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":165,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""},{"line_number":166,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"3f4b6375_39809e46","line":163,"range":{"start_line":163,"start_character":58,"end_line":163,"end_character":77},"in_reply_to":"3f4b6375_41aed8e7","updated":"2017-11-01 01:19:03.000000000","message":"Done","commit_id":"bc2b40e1bddb425f0654c028a5f00d35bec98665"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"27b63db597a1a3d1ebab8ad240725146a8f42455","unresolved":false,"context_lines":[{"line_number":162,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None and rhel_poolid !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":165,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""},{"line_number":166,"context_line":"{% else %}"},{"line_number":167,"context_line":"RUN echo \"No RHEL subscription to build RHEL container images.\"; false;"},{"line_number":168,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"3f4b6375_41dc9873","line":165,"range":{"start_line":165,"start_character":28,"end_line":165,"end_character":61},"updated":"2017-10-31 10:28:51.000000000","message":"in case pool_id is not available then `--auto-attach` can also work. Please check.\n\nReference:\nhttps://access.redhat.com/solutions/253273\n\nThanks","commit_id":"bc2b40e1bddb425f0654c028a5f00d35bec98665"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"ef224bd343728f632349c271a6332ca2c891bd66","unresolved":false,"context_lines":[{"line_number":162,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None and rhel_poolid !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":165,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""},{"line_number":166,"context_line":"{% else %}"},{"line_number":167,"context_line":"RUN echo \"No RHEL subscription to build RHEL container images.\"; false;"},{"line_number":168,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"3f4b6375_f991e69b","line":165,"range":{"start_line":165,"start_character":28,"end_line":165,"end_character":61},"in_reply_to":"3f4b6375_41dc9873","updated":"2017-11-01 01:19:03.000000000","message":"Done","commit_id":"bc2b40e1bddb425f0654c028a5f00d35bec98665"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"0baea3c00cab79a30fb4e117bfd259c500490225","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":162,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" --auto-attach"},{"line_number":165,"context_line":"    {% if rhel_poolid !\u003dNone %}"},{"line_number":166,"context_line":"RUN subscription-manager attach --pool \"{{ rhel_poolid }}\""}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"3f4b6375_6a78768e","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":56},"updated":"2017-11-01 03:58:14.000000000","message":"Recall that the reviewer\u0027s intention is to allow to attach pool id manually or automatically.","commit_id":"3534ad69dbaad2927b1a1bcf9e6536ddd5e52166"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"57deffa9524ca844180963fea2648f73f392ca94","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":162,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" --auto-attach"},{"line_number":165,"context_line":"    {% if rhel_poolid !\u003dNone %}"},{"line_number":166,"context_line":"RUN subscription-manager attach --pool \"{{ rhel_poolid }}\""}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"3f4b6375_4af25a08","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":56},"in_reply_to":"3f4b6375_6a78768e","updated":"2017-11-01 04:07:27.000000000","message":"Thanks for check. I\u0027ll fix this.","commit_id":"3534ad69dbaad2927b1a1bcf9e6536ddd5e52166"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"305117f1a32990aaaccf4b94e88663b27e9f04f4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" --auto-attach"},{"line_number":165,"context_line":"    {% if rhel_poolid !\u003dNone %}"},{"line_number":166,"context_line":"RUN subscription-manager attach --pool \"{{ rhel_poolid }}\""},{"line_number":167,"context_line":"    {% endif %}"},{"line_number":168,"context_line":"{% else %}"},{"line_number":169,"context_line":"RUN echo \"No RHEL subscription to build RHEL container images.\"; false;"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"3f4b6375_cffc1c40","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":58},"updated":"2017-11-01 03:47:41.000000000","message":"The kolla-build fails to build the images because prior to this code it has been already registered. You need to re-design the logic.","commit_id":"3534ad69dbaad2927b1a1bcf9e6536ddd5e52166"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"57deffa9524ca844180963fea2648f73f392ca94","unresolved":false,"context_lines":[{"line_number":163,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None %}"},{"line_number":164,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" --auto-attach"},{"line_number":165,"context_line":"    {% if rhel_poolid !\u003dNone %}"},{"line_number":166,"context_line":"RUN subscription-manager attach --pool \"{{ rhel_poolid }}\""},{"line_number":167,"context_line":"    {% endif %}"},{"line_number":168,"context_line":"{% else %}"},{"line_number":169,"context_line":"RUN echo \"No RHEL subscription to build RHEL container images.\"; false;"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"3f4b6375_2a803e46","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":58},"in_reply_to":"3f4b6375_cffc1c40","updated":"2017-11-01 04:07:27.000000000","message":"Thanks for check. I\u0027ll fix this.","commit_id":"3534ad69dbaad2927b1a1bcf9e6536ddd5e52166"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"efb66e32cd113088b49b738dc58c511101419bf0","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":165,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":166,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None %}"},{"line_number":167,"context_line":"    {% if rhel_poolid !\u003d None %}"},{"line_number":168,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":169,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""}],"source_content_type":"text/x-jinja2","patch_set":77,"id":"9fb8cfa7_aec94859","line":166,"updated":"2019-06-13 17:55:39.000000000","message":"Prefer \"is not None\"","commit_id":"88b73167a4000c4de6e463f2b65d986e1768615c"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"767f0ab39c6d4c71afa828148df57e31cfa709a3","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":165,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":166,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None %}"},{"line_number":167,"context_line":"    {% if rhel_poolid !\u003d None %}"},{"line_number":168,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":169,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""}],"source_content_type":"text/x-jinja2","patch_set":77,"id":"9fb8cfa7_8fcf9927","line":166,"in_reply_to":"9fb8cfa7_aec94859","updated":"2019-06-14 03:53:29.000000000","message":"Done","commit_id":"88b73167a4000c4de6e463f2b65d986e1768615c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"efb66e32cd113088b49b738dc58c511101419bf0","unresolved":false,"context_lines":[{"line_number":164,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":165,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":166,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None %}"},{"line_number":167,"context_line":"    {% if rhel_poolid !\u003d None %}"},{"line_number":168,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":169,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""},{"line_number":170,"context_line":"    {% else %}"}],"source_content_type":"text/x-jinja2","patch_set":77,"id":"9fb8cfa7_2ee318db","line":167,"updated":"2019-06-13 17:55:39.000000000","message":"Again \"is not None\"","commit_id":"88b73167a4000c4de6e463f2b65d986e1768615c"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"767f0ab39c6d4c71afa828148df57e31cfa709a3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"{% block base_rhel_package_installation %}"},{"line_number":165,"context_line":"# Register RHEL subscription of base image for all containers to be derived"},{"line_number":166,"context_line":"{% if rhel_username !\u003d None and rhel_password !\u003d None %}"},{"line_number":167,"context_line":"    {% if rhel_poolid !\u003d None %}"},{"line_number":168,"context_line":"RUN subscription-manager register --user\u003d\"{{ rhel_username }}\" --password\u003d\"{{ rhel_password }}\" \\"},{"line_number":169,"context_line":"    \u0026\u0026 subscription-manager attach --pool \"{{ rhel_poolid }}\""},{"line_number":170,"context_line":"    {% else %}"}],"source_content_type":"text/x-jinja2","patch_set":77,"id":"9fb8cfa7_4fdd21de","line":167,"in_reply_to":"9fb8cfa7_2ee318db","updated":"2019-06-14 03:53:29.000000000","message":"Done","commit_id":"88b73167a4000c4de6e463f2b65d986e1768615c"}],"kolla/common/config.py":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"b50fa6de207b334f9d89704862e417976639b1b5","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    cfg.StrOpt(\u0027rhel-password\u0027, secret\u003dTrue,"},{"line_number":264,"context_line":"               help\u003d\u0027Password for RHEL subscription\u0027),"},{"line_number":265,"context_line":"    cfg.StrOpt(\u0027rhel-poolid\u0027, secret\u003dTrue,"},{"line_number":266,"context_line":"               help\u003d\u0027Pool ID for RHEL subscription\u0027),"},{"line_number":267,"context_line":"]"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":30,"id":"3f4b6375_1c0c4292","line":266,"range":{"start_line":266,"start_character":52,"end_line":266,"end_character":53},"updated":"2017-11-06 04:43:28.000000000","message":"no need of comma in the end, please check, though it will work with comma too but would be better to remove.","commit_id":"d307e0e19a9656865c4da4bb12d2f62c774dab3f"},{"author":{"_account_id":22745,"name":"Heetae Ahn","email":"heetae82.ahn@samsung.com","username":"heetae82.ahn"},"change_message_id":"7091365a3b3c84a7c8435681b91b5567e04f420c","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    cfg.StrOpt(\u0027rhel-password\u0027, secret\u003dTrue,"},{"line_number":264,"context_line":"               help\u003d\u0027Password for RHEL subscription\u0027),"},{"line_number":265,"context_line":"    cfg.StrOpt(\u0027rhel-poolid\u0027, secret\u003dTrue,"},{"line_number":266,"context_line":"               help\u003d\u0027Pool ID for RHEL subscription\u0027),"},{"line_number":267,"context_line":"]"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":30,"id":"3f4b6375_77334f15","line":266,"range":{"start_line":266,"start_character":52,"end_line":266,"end_character":53},"in_reply_to":"3f4b6375_1c0c4292","updated":"2017-11-06 05:46:49.000000000","message":"Done","commit_id":"d307e0e19a9656865c4da4bb12d2f62c774dab3f"}],"kolla/image/build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3113a10393496fd60d097cee30979a3161e3c146","unresolved":false,"context_lines":[{"line_number":948,"context_line":"                      \u0027distro_package_manager\u0027: self.distro_package_manager,"},{"line_number":949,"context_line":"                      \u0027rpm_setup\u0027: self.rpm_setup,"},{"line_number":950,"context_line":"                      \u0027build_date\u0027: build_date,"},{"line_number":951,"context_line":"                      \u0027clean_package_cache\u0027: self.clean_package_cache}"},{"line_number":952,"context_line":"            env \u003d jinja2.Environment(  # nosec: not used to render HTML"},{"line_number":953,"context_line":"                loader\u003djinja2.FileSystemLoader(self.working_dir))"},{"line_number":954,"context_line":"            env.filters.update(self._get_filters())"}],"source_content_type":"text/x-python","patch_set":69,"id":"dfbec78f_eb0265b4","line":951,"updated":"2019-05-07 17:36:08.000000000","message":"Don\u0027t you need to add the rhel_* variables here?","commit_id":"461590495bf6bbc9d4e00c0165fea59ba6ff1a43"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"b27ceef85d2bbca6b40de30ce631422d07551453","unresolved":false,"context_lines":[{"line_number":948,"context_line":"                      \u0027distro_package_manager\u0027: self.distro_package_manager,"},{"line_number":949,"context_line":"                      \u0027rpm_setup\u0027: self.rpm_setup,"},{"line_number":950,"context_line":"                      \u0027build_date\u0027: build_date,"},{"line_number":951,"context_line":"                      \u0027clean_package_cache\u0027: self.clean_package_cache}"},{"line_number":952,"context_line":"            env \u003d jinja2.Environment(  # nosec: not used to render HTML"},{"line_number":953,"context_line":"                loader\u003djinja2.FileSystemLoader(self.working_dir))"},{"line_number":954,"context_line":"            env.filters.update(self._get_filters())"}],"source_content_type":"text/x-python","patch_set":69,"id":"dfbec78f_6bb8b575","line":951,"in_reply_to":"dfbec78f_eb0265b4","updated":"2019-05-07 18:10:15.000000000","message":"Done","commit_id":"461590495bf6bbc9d4e00c0165fea59ba6ff1a43"}]}