)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"209bc162f343c262e7d44541f120fb5179fb36ef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     naichuans \u003cnaichuan.sun@citrix.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-07 02:45:37 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XenServer-Support: Add packages for support XenServer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add package `XenAPI`, `os-xenapi` to support xenserver in neutron, add"},{"line_number":10,"context_line":"`parted` to support xenserver in nova."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_4ebeb2b4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":17},"updated":"2017-10-09 10:38:37.000000000","message":"Just a comment that this line includes dupliocation... I would suggest\nXenServer: Add packages for initial support","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"}],"docker/neutron/neutron-openvswitch-agent/Dockerfile.j2":[{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"3b1bb924af3bdf95f6bd29326b9e44d7d8cac7c9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027,"},{"line_number":30,"context_line":"        \u0027os-xenapi\u0027,"},{"line_number":31,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f515b1d_00909749","line":28,"updated":"2017-10-08 10:20:55.000000000","message":"Will these packages belong to this variable be automatically installed? Please double check if that works in your test.\nFYI: In Nova-compute, it uses macros.install_pip to install the packages.\nhttps://github.com/openstack/kolla/blob/master/docker/nova/nova-compute/Dockerfile.j2#L138","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"fab990be29499bc94e49297fe9c3b194705575c0","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027,"},{"line_number":30,"context_line":"        \u0027os-xenapi\u0027,"},{"line_number":31,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_88ebeeae","line":28,"in_reply_to":"7f515b1d_00909749","updated":"2017-10-11 02:24:19.000000000","message":"Will fix XenAPI installation.","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"3b1bb924af3bdf95f6bd29326b9e44d7d8cac7c9","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027,"},{"line_number":30,"context_line":"        \u0027os-xenapi\u0027,"},{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":"%}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f515b1d_e080dbf9","line":30,"updated":"2017-10-08 10:20:55.000000000","message":"I guess we don\u0027t have to include os-xenapi, as:\n1. for Ocata or previous releases of neutron, it doesn\u0027t use os-xenapi;\n2. for Pike or later releases of neutron, it includes os-xenapi in its requirements:\nthe:https://github.com/openstack/neutron/blob/master/requirements.txt#L53","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"fab990be29499bc94e49297fe9c3b194705575c0","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027,"},{"line_number":30,"context_line":"        \u0027os-xenapi\u0027,"},{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":"%}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_68d0b2f8","line":30,"in_reply_to":"7f515b1d_e080dbf9","updated":"2017-10-11 02:24:19.000000000","message":"will remove it.","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f28b62040f968362d4d937d1ad0b54b8db45762b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027,"},{"line_number":30,"context_line":"        \u0027os-xenapi\u0027,"},{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":"%}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block neutron_openvswitch_agent_footer %}{% endblock %}"},{"line_number":35,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f515b1d_007f77e0","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":2},"updated":"2017-10-08 10:51:48.000000000","message":"this install packages with pip in binary installs which is not allowed. Also, missing macro to install packages, this only set the variable but not uses it","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"8ac6ba48ae52b3f54d5c8f574f411fd1031d4282","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027,"},{"line_number":30,"context_line":"        \u0027os-xenapi\u0027,"},{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":"%}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block neutron_openvswitch_agent_footer %}{% endblock %}"},{"line_number":35,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_06b6c6fb","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":2},"in_reply_to":"5f4e5783_c052d667","updated":"2017-10-11 09:24:57.000000000","message":"I think the problem is that XenAPI is not included yet in any OS distribution\u0027s package repository. But we need install it as neutron-openvswitch-agent depends on it regardless that\u0027s a source installation or binary installation. So either we push this python package into OS distribution\u0027s repository or install it via pip.\n\nOr any other suggestions?","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"fab990be29499bc94e49297fe9c3b194705575c0","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027,"},{"line_number":30,"context_line":"        \u0027os-xenapi\u0027,"},{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":"%}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block neutron_openvswitch_agent_footer %}{% endblock %}"},{"line_number":35,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_28daba16","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":2},"in_reply_to":"7f515b1d_007f77e0","updated":"2017-10-11 02:24:19.000000000","message":"Got it, thank you very much.","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"33c54bb4004d775821f5c0bc4a0434f384b06e64","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027,"},{"line_number":30,"context_line":"        \u0027os-xenapi\u0027,"},{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":"%}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block neutron_openvswitch_agent_footer %}{% endblock %}"},{"line_number":35,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_26366205","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":2},"in_reply_to":"7f515b1d_007f77e0","updated":"2017-10-11 09:42:43.000000000","message":"Hi, Eduardo, I think jianghua\u0027s comment is reasonable, so I rolled back the patch to the version 2.\nPlease check if it is OK.","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"7e9a44ee0a21e0ebeb25480a4af0f1dd7f9f9ed1","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027,"},{"line_number":30,"context_line":"        \u0027os-xenapi\u0027,"},{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":"%}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block neutron_openvswitch_agent_footer %}{% endblock %}"},{"line_number":35,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_c052d667","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":2},"in_reply_to":"7f515b1d_007f77e0","updated":"2017-10-11 08:35:20.000000000","message":"Hi, Eduardo. The XenAPI only support source install, how about adding a judgment to ensure the package would only be installed in source install?","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"ad6ec87ec8e6a024073ef33f4ed14bae75796b30","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027"},{"line_number":30,"context_line":"    ]"},{"line_number":31,"context_line":"%}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN {{ macros.install_pip(neutron_pip_packages }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% block neutron_openvswitch_agent_footer %}{% endblock %}"},{"line_number":36,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f4e5783_6c4c39c7","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":49},"updated":"2017-10-11 10:49:25.000000000","message":"pip packages are not allowed in binary images, even is not installed pip nor virtualenv","commit_id":"f1fdebf1fea76410d4e632612c8fd82ac582c5fd"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"ad6ec87ec8e6a024073ef33f4ed14bae75796b30","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ]"},{"line_number":31,"context_line":"%}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN {{ macros.install_pip(neutron_pip_packages }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% block neutron_openvswitch_agent_footer %}{% endblock %}"},{"line_number":36,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f4e5783_0cea6574","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":3},"updated":"2017-10-11 10:49:25.000000000","message":"the macro already includes the RUN statement","commit_id":"f1fdebf1fea76410d4e632612c8fd82ac582c5fd"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"8fdeecedc5cb2683d524a52074071efc54957a94","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set neutron_pip_packages \u003d ["},{"line_number":29,"context_line":"        \u0027XenAPI\u0027"},{"line_number":30,"context_line":"    ]"},{"line_number":31,"context_line":"%}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RUN {{ macros.install_pip(neutron_pip_packages }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% block neutron_openvswitch_agent_footer %}{% endblock %}"},{"line_number":36,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f4e5783_9b8d55d5","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":49},"in_reply_to":"5f4e5783_6c4c39c7","updated":"2017-10-12 03:15:53.000000000","message":"Will remove it here and add it to ocata.\nThe package will only be used in ocata.","commit_id":"f1fdebf1fea76410d4e632612c8fd82ac582c5fd"}],"docker/nova/nova-compute/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f28b62040f968362d4d937d1ad0b54b8db45762b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027nfs-utils\u0027,"},{"line_number":18,"context_line":"            \u0027openstack-nova-compute\u0027,"},{"line_number":19,"context_line":"            \u0027openvswitch\u0027,"},{"line_number":20,"context_line":"\t    \u0027parted\u0027,"},{"line_number":21,"context_line":"            \u0027python-libguestfs\u0027,"},{"line_number":22,"context_line":"            \u0027python-oslo-vmware\u0027,"},{"line_number":23,"context_line":"            \u0027python-rtslib\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f515b1d_a06d4333","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":1},"updated":"2017-10-08 10:51:48.000000000","message":"remove this character created by tabs in you IDE","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"fab990be29499bc94e49297fe9c3b194705575c0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027nfs-utils\u0027,"},{"line_number":18,"context_line":"            \u0027openstack-nova-compute\u0027,"},{"line_number":19,"context_line":"            \u0027openvswitch\u0027,"},{"line_number":20,"context_line":"\t    \u0027parted\u0027,"},{"line_number":21,"context_line":"            \u0027python-libguestfs\u0027,"},{"line_number":22,"context_line":"            \u0027python-oslo-vmware\u0027,"},{"line_number":23,"context_line":"            \u0027python-rtslib\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_e88ee225","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":1},"in_reply_to":"7f515b1d_a06d4333","updated":"2017-10-11 02:24:19.000000000","message":"will remove it","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f28b62040f968362d4d937d1ad0b54b8db45762b","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{ macros.install_packages(nova_compute_packages | customizable(\"packages\")) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        # ironic as workaround https://bugs.launchpad.net/packstack/+bug/1430388"},{"line_number":33,"context_line":"        {% set nova_compute_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f515b1d_4070cf08","line":30,"range":{"start_line":30,"start_character":7,"end_line":30,"end_character":47},"updated":"2017-10-08 10:51:48.000000000","message":"what about deb distros?","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"fab990be29499bc94e49297fe9c3b194705575c0","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{ macros.install_packages(nova_compute_packages | customizable(\"packages\")) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        # ironic as workaround https://bugs.launchpad.net/packstack/+bug/1430388"},{"line_number":33,"context_line":"        {% set nova_compute_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_c8e1e6d2","line":30,"range":{"start_line":30,"start_character":7,"end_line":30,"end_character":47},"in_reply_to":"7f515b1d_4070cf08","updated":"2017-10-11 02:24:19.000000000","message":"Will add it in debian.","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f28b62040f968362d4d937d1ad0b54b8db45762b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027libosinfo\u0027,"},{"line_number":79,"context_line":"            \u0027nfs-utils\u0027,"},{"line_number":80,"context_line":"            \u0027openvswitch\u0027,"},{"line_number":81,"context_line":"\t    \u0027parted\u0027,"},{"line_number":82,"context_line":"            \u0027python-libguestfs\u0027,"},{"line_number":83,"context_line":"            \u0027python-rtslib\u0027,"},{"line_number":84,"context_line":"            \u0027qemu-img\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f515b1d_806a4717","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":1},"updated":"2017-10-08 10:51:48.000000000","message":"ditto","commit_id":"98132e3a81d5546c9568acd8b3ac71018c10050a"}]}