)]}'
{"docker/neutron/neutron-metadata-agent-ovn/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"5cf8af3e724aebc27950ac15ffc78621023c5033","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        {% set neutron_metadata_agent_ovn_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_16671350","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":38},"updated":"2017-10-11 12:52:19.000000000","message":"missing oraclelinux","commit_id":"80266f44b299e6d945a0afee1916ff0cb4096501"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"6747023c2207ad47e82d4a170e44ae3ccd0c3cf9","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        {% set neutron_metadata_agent_ovn_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_f96c6809","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":38},"in_reply_to":"5f4e5783_16671350","updated":"2017-10-11 14:06:00.000000000","message":"will do","commit_id":"80266f44b299e6d945a0afee1916ff0cb4096501"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"5cf8af3e724aebc27950ac15ffc78621023c5033","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        {% set neutron_metadata_agent_ovn_packages \u003d ["},{"line_number":12,"context_line":"            \u0027python-networking-ovn-metadata-agent\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_764f67bd","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":4},"updated":"2017-10-11 12:52:19.000000000","message":"missing ubuntu and debian distros","commit_id":"80266f44b299e6d945a0afee1916ff0cb4096501"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"6747023c2207ad47e82d4a170e44ae3ccd0c3cf9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        {% set neutron_metadata_agent_ovn_packages \u003d ["},{"line_number":12,"context_line":"            \u0027python-networking-ovn-metadata-agent\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_f9458871","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":4},"in_reply_to":"5f4e5783_764f67bd","updated":"2017-10-11 14:06:00.000000000","message":"Yes, the package is not ready in ubuntu and debian AFAIK. It should be available in centos today or tomorrow as soon as OVS 2.8 comes out in RDO.","commit_id":"80266f44b299e6d945a0afee1916ff0cb4096501"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"5cf8af3e724aebc27950ac15ffc78621023c5033","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% endif %}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{ macros.install_packages(neutron_metadata_agent_ovn_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block neutron_metadata_agent_ovn_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_36632f1d","line":17,"updated":"2017-10-11 12:52:19.000000000","message":"missing source builds","commit_id":"80266f44b299e6d945a0afee1916ff0cb4096501"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"fdd9b6f1a63008f9a38807dfbd11deb6249a763b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% endif %}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{ macros.install_packages(neutron_metadata_agent_ovn_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block neutron_metadata_agent_ovn_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_b04dde73","line":17,"in_reply_to":"5f4e5783_2fa18eaa","updated":"2017-10-11 15:55:20.000000000","message":"Just like it\u0027s done for the rest of neutron agents, in this case neutron-server-ovn will take care of it when installed from sources. See [0][1], neutron-base takes care of it as well. THanks!\n[0] https://github.com/openstack/kolla/blob/master/docker/neutron/neutron-dhcp-agent/Dockerfile.j2\n[1] https://github.com/openstack/kolla/blob/master/docker/neutron/neutron-metadata-agent/Dockerfile.j2","commit_id":"80266f44b299e6d945a0afee1916ff0cb4096501"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"6747023c2207ad47e82d4a170e44ae3ccd0c3cf9","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% endif %}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{ macros.install_packages(neutron_metadata_agent_ovn_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block neutron_metadata_agent_ovn_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f4e5783_2fa18eaa","line":17,"in_reply_to":"5f4e5783_36632f1d","updated":"2017-10-11 14:06:00.000000000","message":"Sorry it\u0027s my first contact with Kolla. Not sure how to handle the build from source in this case. This metadata agent is part of networking-ovn (https://github.com/openstack/networking-ovn). So installing it from source should suffice.","commit_id":"80266f44b299e6d945a0afee1916ff0cb4096501"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"73750b7b9412228bd5fbd4f167b75be8d7cbb08e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server-ovn:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_metadata_agent_ovn_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f4e5783_ead0edf9","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"updated":"2017-10-12 07:50:24.000000000","message":"why does this image come from neutron-server-ovn? is adding many useless layers and packages on it.\n\n\nMetatada has nothing to do with neutron-server\n, also packages in metadata are not installed","commit_id":"c16cf015c4c3abc7ee3d864961d1667d3fc4473f"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"33051addab3a24f928d1afdad491f7758562b2a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server-ovn:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_metadata_agent_ovn_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f4e5783_4717f752","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"in_reply_to":"5f4e5783_27775bd7","updated":"2017-10-12 10:20:22.000000000","message":"Agree. Thanks.","commit_id":"c16cf015c4c3abc7ee3d864961d1667d3fc4473f"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"989347cc2dc61b3e354ac526fac796a6ae3fd687","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server-ovn:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_metadata_agent_ovn_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f4e5783_da917e9b","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"in_reply_to":"5f4e5783_4717f752","updated":"2017-10-12 10:26:58.000000000","message":"This is done for all agents in Neutron so far. Plus when installed from sources it will be done automatically.","commit_id":"c16cf015c4c3abc7ee3d864961d1667d3fc4473f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7606eb07a6a56b0c163217cb8b2d3288bb80e153","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server-ovn:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_metadata_agent_ovn_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f4e5783_cc47364c","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"in_reply_to":"5f4e5783_da917e9b","updated":"2017-10-16 10:48:43.000000000","message":"We could follow this:\n\nhttps://github.com/openstack/kolla/blob/master/docker/neutron/neutron-server-ovn/Dockerfile.j2\n\nif we want, but that depends from neutron-server, and that into neutron-base in the end too,","commit_id":"c16cf015c4c3abc7ee3d864961d1667d3fc4473f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3a8ce053f19bd1b68c214b0ca304cfd21bd436cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server-ovn:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_metadata_agent_ovn_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f4e5783_27775bd7","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"in_reply_to":"5f4e5783_e79263f6","updated":"2017-10-12 10:15:58.000000000","message":"yeah, but i dont see a reaason to depend on neutron-server-ovn, networking-ovn code can be installed in this image","commit_id":"c16cf015c4c3abc7ee3d864961d1667d3fc4473f"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"1972ba41d709faf84b772d82d0e15d642211dc78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server-ovn:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_metadata_agent_ovn_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f4e5783_e79263f6","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"in_reply_to":"5f4e5783_ead0edf9","updated":"2017-10-12 10:14:12.000000000","message":"networking-ovn metadata agent code is part of networking-ovn [1] and the code actually imports some of networking_ovn code (for example - [2])\n\n[1] - https://github.com/openstack/networking-ovn/tree/master/networking_ovn/agent\n\n[2] - https://github.com/openstack/networking-ovn/blob/master/networking_ovn/agent/metadata/ovsdb.py#L21","commit_id":"c16cf015c4c3abc7ee3d864961d1667d3fc4473f"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"cc7b0a08b7cbc3c5387445d17d2538f468fb15d3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        {% set neutron_metadata_agent_ovn_packages \u003d ["},{"line_number":12,"context_line":"            \u0027python-networking-ovn-metadata-agent\u0027"},{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":"        {% set neutron_metadata_agent_ovn_packages \u003d ["},{"line_number":16,"context_line":"            \u0027python-networking-ovn\u0027"},{"line_number":17,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f4e5783_cf71c3e0","line":14,"updated":"2017-10-12 07:21:34.000000000","message":"You don\u0027t need to do anything for debian and ubuntu distros because the neutron-server-ovn Dockerfile installs the package \u0027python-networking-ovn\u0027.","commit_id":"c16cf015c4c3abc7ee3d864961d1667d3fc4473f"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"989347cc2dc61b3e354ac526fac796a6ae3fd687","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        {% set neutron_metadata_agent_ovn_packages \u003d ["},{"line_number":12,"context_line":"            \u0027python-networking-ovn-metadata-agent\u0027"},{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":"        {% set neutron_metadata_agent_ovn_packages \u003d ["},{"line_number":16,"context_line":"            \u0027python-networking-ovn\u0027"},{"line_number":17,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f4e5783_ca0d3136","line":14,"in_reply_to":"5f4e5783_cf71c3e0","updated":"2017-10-12 10:26:58.000000000","message":"Done","commit_id":"c16cf015c4c3abc7ee3d864961d1667d3fc4473f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d6ffda5fb1417a04441dd93c15d983d3a0afa789","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server-ovn:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_metadata_agent_ovn_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f4e5783_55660fc3","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"updated":"2017-10-17 10:51:19.000000000","message":"still thinking that deriving from neutron-server-ovn is adding useless dependencies and bigger image sizes. All agents derive from neutron-base","commit_id":"87cee931f50c79ef51ecc3a6547cea368f7cae32"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5a9725dd5b0b5b8ffccf44dafb2bfffee5bcac19","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server-ovn:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_metadata_agent_ovn_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f4b6375_aef9384e","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"in_reply_to":"3f4b6375_b8be21fd","updated":"2017-10-18 12:12:37.000000000","message":"Thanks for the feedback guys.\nI could derive from neutron-base but then, when installing from sources, I would have to do something like:\nADD neutron-server-ovn-plugin-networking-ovn-archive /networking-ovn-source\nAnd add the networking-ovn-source to the list of installed packages through pip. This will end up installing neutron-server so it\u0027s not adding any overhead. Networking-metadata-agent will be installed from sources when installing networking-ovn and installing networking-ovn will also install neutron-server.\nI could agree that since neutron-server-ovn derives also from neutron-base, this will add unnecessary overhead for the metadata agent since we\u0027re adding some other binaries such as keepalived, etc. which aren\u0027t really needed. \nWhat I want to highlight here is that there\u0027s no gain from not deriving from neutron-server-ovn and doing it from neutron-base unless I\u0027m missing something.\nThanks a lot!","commit_id":"87cee931f50c79ef51ecc3a6547cea368f7cae32"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"2ad4c64b23fed434f400cea6f5be2813b080210f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server-ovn:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_metadata_agent_ovn_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f4b6375_b8be21fd","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"in_reply_to":"5f4e5783_55660fc3","updated":"2017-10-18 08:32:59.000000000","message":"agree","commit_id":"87cee931f50c79ef51ecc3a6547cea368f7cae32"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"cfa9c5d8e6fdd43d44fad7bb7a1995dbf3aa8b14","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    ADD plugins-archive /"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    {% set neutron_server_ovn_plugins_pip_packages \u003d ["},{"line_number":27,"context_line":"        \u0027/plugins/*\u0027"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3f4b6375_80712379","line":26,"updated":"2017-11-02 13:17:17.000000000","message":"AFAIK this needs to match the image name otherwise the customization will not take effect, i.e. you\u0027ll need to rename the variable to neutron_metadata_agent_ovn_plugins_pip_packages","commit_id":"49512e8f088f608575be6bdb9e07fbaadb9495fc"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"cfa9c5d8e6fdd43d44fad7bb7a1995dbf3aa8b14","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":31,"context_line":"            {{ macros.install_pip(neutron_server_ovn_plugins_pip_packages | customizable(\"pip_packages\")) }}; \\"},{"line_number":32,"context_line":"        fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3f4b6375_606aa781","line":31,"updated":"2017-11-02 13:17:17.000000000","message":"same here","commit_id":"49512e8f088f608575be6bdb9e07fbaadb9495fc"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"26a9247c5de116452be829b178b2c609a626de98","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    ADD plugins-archive /"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    {% set neutron_metadata_agent_ovn_plugins_pip_packages \u003d ["},{"line_number":27,"context_line":"        \u0027/plugins/*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"df87a7cf_73f3c80b","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":3},"updated":"2017-12-05 07:55:11.000000000","message":"remove indent, docker commands should be at the left","commit_id":"2a79cd926d4a2b08c02fba31d86828740c6050da"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"03fe3c600258e58f252fb911f7878c6cd72e2946","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    ADD plugins-archive /"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    {% set neutron_metadata_agent_ovn_plugins_pip_packages \u003d ["},{"line_number":27,"context_line":"        \u0027/plugins/*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"df87a7cf_7ddcb2e3","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":3},"in_reply_to":"df87a7cf_73f3c80b","updated":"2017-12-07 10:15:33.000000000","message":"Done","commit_id":"2a79cd926d4a2b08c02fba31d86828740c6050da"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5c61327e093c0de8b2908f72ebd12a4db32a4d74","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    ADD plugins-archive /"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    {% set neutron_metadata_agent_ovn_plugins_pip_packages \u003d ["},{"line_number":27,"context_line":"        \u0027/plugins/*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"df87a7cf_65ff7934","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":3},"in_reply_to":"df87a7cf_73f3c80b","updated":"2017-12-05 09:56:53.000000000","message":"Eduardo, this if for you ;-) https://review.openstack.org/#/c/525516/","commit_id":"2a79cd926d4a2b08c02fba31d86828740c6050da"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"26a9247c5de116452be829b178b2c609a626de98","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    ADD plugins-archive /"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    {% set neutron_metadata_agent_ovn_plugins_pip_packages \u003d ["},{"line_number":27,"context_line":"        \u0027/plugins/*\u0027"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    RUN if [ \"$(ls /plugins)\" ]; then \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"df87a7cf_5346c423","line":27,"range":{"start_line":27,"start_character":9,"end_line":27,"end_character":19},"updated":"2017-12-05 07:55:11.000000000","message":"Nothing here, is just an empty image with no ovn package on it.\n\novn plugin is installed on neutron-server-ovn image, but this image does not have such plugin on its list.\n\nA new entry https://github.com/openstack/kolla/blob/master/kolla/common/config.py#L576:\n\n    \u0027neutron-metadata-agent-ovn-plugin-networking-ovn\u0027: {\n        \u0027type\u0027: \u0027url\u0027,\n        \u0027location\u0027: (\u0027$tarballs_base/networking-ovn/\u0027\n\u0027networking-ovn-master.tar.gz\u0027)},","commit_id":"2a79cd926d4a2b08c02fba31d86828740c6050da"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"03fe3c600258e58f252fb911f7878c6cd72e2946","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    ADD plugins-archive /"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    {% set neutron_metadata_agent_ovn_plugins_pip_packages \u003d ["},{"line_number":27,"context_line":"        \u0027/plugins/*\u0027"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    RUN if [ \"$(ls /plugins)\" ]; then \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"df87a7cf_b0a261fb","line":27,"range":{"start_line":27,"start_character":9,"end_line":27,"end_character":19},"in_reply_to":"df87a7cf_5346c423","updated":"2017-12-07 10:15:33.000000000","message":"Done","commit_id":"2a79cd926d4a2b08c02fba31d86828740c6050da"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"26a9247c5de116452be829b178b2c609a626de98","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027/plugins/*\u0027"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":31,"context_line":"            {{ macros.install_pip(neutron_metadata_agent_ovn_plugins_pip_packages | customizable(\"pip_packages\")) }}; \\"},{"line_number":32,"context_line":"        fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"df87a7cf_f391189b","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":10},"updated":"2017-12-05 07:55:11.000000000","message":"remove RUNs indent","commit_id":"2a79cd926d4a2b08c02fba31d86828740c6050da"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"03fe3c600258e58f252fb911f7878c6cd72e2946","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027/plugins/*\u0027"},{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":31,"context_line":"            {{ macros.install_pip(neutron_metadata_agent_ovn_plugins_pip_packages | customizable(\"pip_packages\")) }}; \\"},{"line_number":32,"context_line":"        fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"df87a7cf_d0a7e50a","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":10},"in_reply_to":"df87a7cf_f391189b","updated":"2017-12-07 10:15:33.000000000","message":"Done","commit_id":"2a79cd926d4a2b08c02fba31d86828740c6050da"}],"kolla/common/config.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"262d08d9d3145e7651874b6ae3a4401025a18da7","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    \u0027neutron-metadata-agent-ovn-plugin-networking-ovn\u0027: {"},{"line_number":569,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":570,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/networking-ovn/\u0027"},{"line_number":571,"context_line":"                      \u0027networking-ovn-master.tar.gz\u0027)},"},{"line_number":572,"context_line":"    \u0027nova-base\u0027: {"},{"line_number":573,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":574,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/nova/\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_8e7ffa13","line":571,"range":{"start_line":571,"start_character":21,"end_line":571,"end_character":22},"updated":"2017-12-07 12:07:28.000000000","message":"tox failed with over indent here, one space less","commit_id":"f40abd988dc043f838223f08ff99b9cddcbda12f"}]}