)]}'
{"kolla/common/config.py":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"72f7fdb39a150d1e7b18b8dd67e07a6032e3805b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027squash\u0027, default\u003dFalse,"},{"line_number":262,"context_line":"                help\u003d(\u0027Squash the image layers. WARNING: it will consume lots\u0027"},{"line_number":263,"context_line":"                      \u0027 of disk IO. \"docker-squash\" tool is required, install\u0027"},{"line_number":264,"context_line":"                      \u0027 it by \"pip install docker-squash\"\u0027)),"},{"line_number":265,"context_line":"]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_2bc7f047","line":264,"range":{"start_line":264,"start_character":60,"end_line":264,"end_character":61},"updated":"2018-01-14 14:00:58.000000000","message":"not needed","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"30a6f9d1ab5eefa01ad8924501a745fb360bd95c","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027squash\u0027, default\u003dFalse,"},{"line_number":262,"context_line":"                help\u003d(\u0027Squash the image layers. WARNING: it will consume lots\u0027"},{"line_number":263,"context_line":"                      \u0027 of disk IO. \"docker-squash\" tool is required, install\u0027"},{"line_number":264,"context_line":"                      \u0027 it by \"pip install docker-squash\"\u0027)),"},{"line_number":265,"context_line":"]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_92b5c534","line":264,"updated":"2018-01-17 03:12:47.000000000","message":"what is not needed?","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"1a914c3f93de4e0e04a41e7a94a4dc5642dad203","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027squash\u0027, default\u003dFalse,"},{"line_number":262,"context_line":"                help\u003d(\u0027Squash the image layers. WARNING: it will consume lots\u0027"},{"line_number":263,"context_line":"                      \u0027 of disk IO. \"docker-squash\" tool is required, install\u0027"},{"line_number":264,"context_line":"                      \u0027 it by \"pip install docker-squash\"\u0027)),"},{"line_number":265,"context_line":"]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_b2e00128","line":264,"updated":"2018-01-17 03:16:49.000000000","message":"what is not needed?","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"b9c34ce922c0178eaa01e5286f7df74f83d85adc","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027squash\u0027, default\u003dFalse,"},{"line_number":262,"context_line":"                help\u003d(\u0027Squash the image layers. WARNING: it will consume lots\u0027"},{"line_number":263,"context_line":"                      \u0027 of disk IO. \"docker-squash\" tool is required, install\u0027"},{"line_number":264,"context_line":"                      \u0027 it by \"pip install docker-squash\"\u0027)),"},{"line_number":265,"context_line":"]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_c34fd668","line":264,"in_reply_to":"7f96bb07_4dba3e6e","updated":"2018-01-18 04:32:04.000000000","message":"i do not think it is a problem. if it is, we need adjust pep8 to ensure this in all script.","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"dc2e5a6a12273fdba2ed4fa72097789c7344ac2b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    cfg.BoolOpt(\u0027squash\u0027, default\u003dFalse,"},{"line_number":262,"context_line":"                help\u003d(\u0027Squash the image layers. WARNING: it will consume lots\u0027"},{"line_number":263,"context_line":"                      \u0027 of disk IO. \"docker-squash\" tool is required, install\u0027"},{"line_number":264,"context_line":"                      \u0027 it by \"pip install docker-squash\"\u0027)),"},{"line_number":265,"context_line":"]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_4dba3e6e","line":264,"in_reply_to":"7f96bb07_b2e00128","updated":"2018-01-17 05:07:14.000000000","message":"comma in the end, i understand keeping it also not a problem","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"}],"kolla/common/utils.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"30a6f9d1ab5eefa01ad8924501a745fb360bd95c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":"import os"},{"line_number":15,"context_line":"import subprocess  # nosec"},{"line_number":16,"context_line":"import sys"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_b2b24148","line":15,"updated":"2018-01-17 03:12:47.000000000","message":"# nosec","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"1a914c3f93de4e0e04a41e7a94a4dc5642dad203","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":"import os"},{"line_number":15,"context_line":"import subprocess  # nosec"},{"line_number":16,"context_line":"import sys"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_52d3bd60","line":15,"updated":"2018-01-17 03:16:49.000000000","message":"bandit will prevent to use subprocess. then pep8 job will be failed.","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"72f7fdb39a150d1e7b18b8dd67e07a6032e3805b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":"import os"},{"line_number":15,"context_line":"import subprocess  # nosec"},{"line_number":16,"context_line":"import sys"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_8b064486","line":15,"range":{"start_line":15,"start_character":19,"end_line":15,"end_character":26},"updated":"2018-01-14 14:00:58.000000000","message":"nice work @jeffrey just curious to know is it resembling something meaningful ?","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"}],"kolla/image/build.py":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"72f7fdb39a150d1e7b18b8dd67e07a6032e3805b","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            image.status \u003d STATUS_BUILT"},{"line_number":581,"context_line":"            self.logger.info(\u0027Built\u0027)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def squash(self):"},{"line_number":584,"context_line":"        image_tag \u003d self.image.canonical_name"},{"line_number":585,"context_line":"        image_id \u003d self.dc.inspect_image(image_tag)[\u0027Id\u0027]"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_eb1ca8c2","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":14},"updated":"2018-01-14 14:00:58.000000000","message":"IMO, this should has different name, as we already have the same in utils.py, or we can add some doc string about the purpose of the function at both places to make the difference.\n\nthanks","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"1a914c3f93de4e0e04a41e7a94a4dc5642dad203","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            image.status \u003d STATUS_BUILT"},{"line_number":581,"context_line":"            self.logger.info(\u0027Built\u0027)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def squash(self):"},{"line_number":584,"context_line":"        image_tag \u003d self.image.canonical_name"},{"line_number":585,"context_line":"        image_id \u003d self.dc.inspect_image(image_tag)[\u0027Id\u0027]"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_72d8397a","line":583,"updated":"2018-01-17 03:16:49.000000000","message":"this function is located in DockerBuild","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"dc2e5a6a12273fdba2ed4fa72097789c7344ac2b","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            image.status \u003d STATUS_BUILT"},{"line_number":581,"context_line":"            self.logger.info(\u0027Built\u0027)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def squash(self):"},{"line_number":584,"context_line":"        image_tag \u003d self.image.canonical_name"},{"line_number":585,"context_line":"        image_id \u003d self.dc.inspect_image(image_tag)[\u0027Id\u0027]"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_8d6926fa","line":583,"in_reply_to":"7f96bb07_72d8397a","updated":"2018-01-17 05:07:14.000000000","message":"@Jeffrey sorry if i couldn\u0027t get, would be great if you elaborate this. I just wanted a different name for this fun.","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"11395f708a10918d4158ddd68740e0956ffab285","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            image.status \u003d STATUS_BUILT"},{"line_number":581,"context_line":"            self.logger.info(\u0027Built\u0027)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def squash(self):"},{"line_number":584,"context_line":"        image_tag \u003d self.image.canonical_name"},{"line_number":585,"context_line":"        image_id \u003d self.dc.inspect_image(image_tag)[\u0027Id\u0027]"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7f96bb07_e0530c16","line":583,"in_reply_to":"7f96bb07_8d6926fa","updated":"2018-01-17 07:28:33.000000000","message":"Is not a problem, each function is a different object called from a different parent class.\n\na.squash()\nb.squash()","commit_id":"bfc7bee02c4b95a45faa27d74093b9b656df8af1"}]}