)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"32d66aad240d45e050614e855a49947654fa4d11","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xinliang Liu \u003cxinliang.liu@linaro.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-20 10:47:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix MariaDB bootstrap failed on Debian aarch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently Debian Stretch is lacking of MariaDB-Galera-server package for"},{"line_number":10,"context_line":"AArch64, so it will always get timeout exit and bootstrap MariaDB failed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In this case, It might has problem on cluster deployment, but at least make"},{"line_number":13,"context_line":"one MariaDB deployment work."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_fdbe50ac","line":10,"range":{"start_line":7,"start_character":39,"end_line":10,"end_character":7},"updated":"2017-12-20 09:08:37.000000000","message":"It is generic for Debian even. Not only for AArch64.","commit_id":"0244124222f333909598e1482b6be0c99538f159"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e69148fd0b41af9c686f0b40f3eb4570f5995d47","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xinliang Liu \u003cxinliang.liu@linaro.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-03 14:28:23 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix MariaDB bootstrap failed on Debian"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current Debian Stretch use MariaDB 10.1."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Option \"wsrep_on\" behaves different between 10.0 and 10.1 [2]:"},{"line_number":12,"context_line":"\"Before MariaDB 10.1, even though this variable is ON by default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9f91af0f_f74348ae","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":40},"updated":"2018-01-03 14:43:24.000000000","message":"\"Fix MariaDB bootstrap for 10.1 version.\" instead of both lines as we move all distros to 10.1","commit_id":"c8b13f579164eef7265fa604140284eac3cb8ed2"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"2ccd75d31877c3a57bef226b0068704d8cacbe99","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xinliang Liu \u003cxinliang.liu@linaro.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-03 14:28:23 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix MariaDB bootstrap failed on Debian"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current Debian Stretch use MariaDB 10.1."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Option \"wsrep_on\" behaves different between 10.0 and 10.1 [2]:"},{"line_number":12,"context_line":"\"Before MariaDB 10.1, even though this variable is ON by default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9f91af0f_af5a3c27","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":40},"in_reply_to":"9f91af0f_f74348ae","updated":"2018-01-04 01:37:00.000000000","message":"done.","commit_id":"c8b13f579164eef7265fa604140284eac3cb8ed2"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"612210d60c5a981deb5a1b511a408df63310cd2b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current Debian Stretch use MariaDB 10.1."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Option \"wsrep_on\" behaves different between 10.0 and 10.1 [2]:"},{"line_number":12,"context_line":"\"Before MariaDB 10.1, even though this variable is ON by default,"},{"line_number":13,"context_line":"its value get automatically adjusted based on whether mandatory"},{"line_number":14,"context_line":"configurations to turn on Galera replication have been specified."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9f91af0f_8fe3ca33","line":11,"updated":"2018-01-03 10:01:01.000000000","message":"Thanks for figuring this one out. In TripleO we\u0027ve exported the KOLLA_KUBERNETES variable to bypass the wsrep_ready check, but this was a dirty hack. Thanks to this patch we\u0027ll be able to cleanup a little bit in tripleo.","commit_id":"c8b13f579164eef7265fa604140284eac3cb8ed2"}],"docker/mariadb/extend_start.sh":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"32d66aad240d45e050614e855a49947654fa4d11","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        # NOTE(xinliang): Currently debian stretch is lacking of MariaDB-Galera-server"},{"line_number":23,"context_line":"        # package for aarch64, so it will always get timeout exit. In this case, It"},{"line_number":24,"context_line":"        # might has problem on cluster deployment, but at least make one MariaDB"},{"line_number":25,"context_line":"        # deployment work."},{"line_number":26,"context_line":"        if [[ ! \"${KOLLA_BASE_DISTRO}\" \u003d~ debian  \u0026\u0026 \"$(uname -m)\" \u003d\u003d \"aarch64\" ]] ; then"},{"line_number":27,"context_line":"            CLUSTER_READY\u003d$(mysql -u root --exec\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON)"},{"line_number":28,"context_line":"            TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":29,"context_line":"            while [[ -z \"${CLUSTER_READY}\" ]]; do"}],"source_content_type":"text/x-sh","patch_set":3,"id":"df87a7cf_fd8ad061","line":26,"range":{"start_line":22,"start_character":8,"end_line":26,"end_character":89},"updated":"2017-12-20 09:08:37.000000000","message":"It is generic for Debian even. Not only for AArch64.","commit_id":"0244124222f333909598e1482b6be0c99538f159"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"60d54711bc9c904addd462f87e424bcba60cf75b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    done"},{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        # TODO: Current Debian Stretch use mariadb 10.1, we need to fix the"},{"line_number":23,"context_line":"        # configuration to support Galera feature for 10.1."},{"line_number":24,"context_line":"        if [[ ! \"${KOLLA_BASE_DISTRO}\" \u003d~ debian ]] ; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bf8cb3f7_604b3287","line":21,"updated":"2017-12-20 13:53:24.000000000","message":"this code (was) defective.  Pleae take over this review and make sure we are not making matters worse.  https://review.openstack.org/#/c/468632/12/docker/mariadb/extend_start.sh","commit_id":"c9963ab7c986b0e2faae65dd1a2aec74417459e2"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"cffa4a32ee2c1fe0e9840550f319b84951524f12","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    done"},{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        # TODO: Current Debian Stretch use mariadb 10.1, we need to fix the"},{"line_number":23,"context_line":"        # configuration to support Galera feature for 10.1."},{"line_number":24,"context_line":"        if [[ ! \"${KOLLA_BASE_DISTRO}\" \u003d~ debian ]] ; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bf8cb3f7_e1497260","line":21,"in_reply_to":"bf8cb3f7_604b3287","updated":"2017-12-21 05:54:35.000000000","message":"Yes, your patch is fixing new version mariadb deployment issue. \nWill test that patch. Thanks.","commit_id":"c9963ab7c986b0e2faae65dd1a2aec74417459e2"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"cbfd8aefbcd6b095ad53f5eb53a2818d4a49af15","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"},{"line_number":23,"context_line":"        TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":24,"context_line":"        while [[ -z \"${CLUSTER_READY}\" ]]; do"},{"line_number":25,"context_line":"            CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9f91af0f_a5c86a74","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":80},"updated":"2017-12-28 05:02:19.000000000","message":"1) I think the following is more better: mysql -u root -e \"SHOW STATUS LIKE \u0027wsrep_ready\u0027\"\n2) How about haproxy instead of root? Could it be referenced from any configuration?","commit_id":"8ee5444637b2d5d457db3ea199e1373788e96d57"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"d66d6e215fd4a266fda69ad4a05d630a4caf4a93","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# NOTE(sbezverk): Currently kolla-kubernetes does not use Galera and disables wsrep driver."},{"line_number":20,"context_line":"# This check will run only for non kolla-kubernetes bootstrap deployments."},{"line_number":21,"context_line":"    if [[ ! \"${!KOLLA_KUBERNETES[@]}\" ]]; then"},{"line_number":22,"context_line":"        CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"},{"line_number":23,"context_line":"        TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":24,"context_line":"        while [[ -z \"${CLUSTER_READY}\" ]]; do"},{"line_number":25,"context_line":"            CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9f91af0f_c873434d","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":80},"in_reply_to":"9f91af0f_a5c86a74","updated":"2017-12-28 06:53:37.000000000","message":"1) Done.\n2) You mean haproxy user. At this stage I think haproxy user is not created.","commit_id":"8ee5444637b2d5d457db3ea199e1373788e96d57"},{"author":{"_account_id":12882,"name":"Taeha Kim","email":"kthguru@gmail.com","username":"kthguru"},"change_message_id":"cbfd8aefbcd6b095ad53f5eb53a2818d4a49af15","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"},{"line_number":23,"context_line":"        TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":24,"context_line":"        while [[ -z \"${CLUSTER_READY}\" ]]; do"},{"line_number":25,"context_line":"            CLUSTER_READY\u003d$(mysql -u root --execute\u003d\"SHOW STATUS LIKE \u0027wsrep_ready\u0027\" | grep ON || true)"},{"line_number":26,"context_line":"            if [[ ${TIMEOUT} -gt 0 ]]; then"},{"line_number":27,"context_line":"                let TIMEOUT-\u003d1"},{"line_number":28,"context_line":"                sleep 1"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9f91af0f_65a022a7","line":25,"range":{"start_line":25,"start_character":34,"end_line":25,"end_character":84},"updated":"2017-12-28 05:02:19.000000000","message":"1) I think the following is more better: mysql -u root -e \"SHOW STATUS LIKE \u0027wsrep_ready\u0027\"\n2) How about haproxy instead of root? Could it be referenced from any configuration?","commit_id":"8ee5444637b2d5d457db3ea199e1373788e96d57"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"d5da990fa300aa9f849daf1dd8d4fd14105a7d7b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function bootstrap_db {"},{"line_number":4,"context_line":"    mysqld_safe --wsrep-new-cluster --skip-networking --wsrep-on\u003dON --pid-file\u003d/var/lib/mysql/mariadb.pid \u0026"},{"line_number":5,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":6,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":7,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."}],"source_content_type":"text/x-sh","patch_set":9,"id":"9f91af0f_53733b16","line":4,"updated":"2018-01-02 17:51:31.000000000","message":"why do we need clustering in boostrap?","commit_id":"e9181fd33fc4e00b96f0f90e863bd07d720354d9"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"bd739c1d2d6398e1b29c9eb1cc8d3dc782acd97c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function bootstrap_db {"},{"line_number":4,"context_line":"    mysqld_safe --wsrep-new-cluster --skip-networking --wsrep-on\u003dON --pid-file\u003d/var/lib/mysql/mariadb.pid \u0026"},{"line_number":5,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":6,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":7,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."}],"source_content_type":"text/x-sh","patch_set":9,"id":"9f91af0f_e1ccf48a","line":4,"in_reply_to":"9f91af0f_53733b16","updated":"2018-01-03 01:45:14.000000000","message":"That\u0027s also confused me before. I found that it introduce in commit efbfd791. I have tested removing \u0027--wsrep-new-cluster\u0027 but it failed at line 9-18 check part. \n\nMy understanding is that at bootstrap stage it only do two things creating some required system db( at mysql_install_db) and securing the mariadb after Galera provider is ready (at bootstrap_db).\n\nAnyway, I will dig this more a bit.","commit_id":"e9181fd33fc4e00b96f0f90e863bd07d720354d9"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"4e6c67fc4ec3386575beac57fb04d0713da4fb3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function bootstrap_db {"},{"line_number":4,"context_line":"    mysqld_safe --wsrep-new-cluster --skip-networking --wsrep-on\u003dON --pid-file\u003d/var/lib/mysql/mariadb.pid \u0026"},{"line_number":5,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":6,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":7,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."}],"source_content_type":"text/x-sh","patch_set":9,"id":"9f91af0f_e2ccf28a","line":4,"in_reply_to":"9f91af0f_e1ae342d","updated":"2018-01-03 07:25:18.000000000","message":"According to the testing, it seems, the cluster bits are no need at bootstrap. I\u0027ve tested one node and mutinode works on debian aarch64 mariadb 10.1.26.","commit_id":"e9181fd33fc4e00b96f0f90e863bd07d720354d9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"42f77411ebec30cc9d9a4342da19295fa777c887","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function bootstrap_db {"},{"line_number":4,"context_line":"    mysqld_safe --wsrep-new-cluster --skip-networking --wsrep-on\u003dON --pid-file\u003d/var/lib/mysql/mariadb.pid \u0026"},{"line_number":5,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":6,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":7,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."}],"source_content_type":"text/x-sh","patch_set":9,"id":"9f91af0f_e1ae342d","line":4,"in_reply_to":"9f91af0f_e1ccf48a","updated":"2018-01-03 02:24:43.000000000","message":"i guess when using \u0027--wspep-on\u003dOFF\u0027, \u0027--wsrep-new-cluster\u0027 is useless. So two solution should both work\n\n1. --wsrep-on\u003dOFF\n2. --wsrep-on\u003dON --wsrep-new-cluster","commit_id":"e9181fd33fc4e00b96f0f90e863bd07d720354d9"}]}