)]}'
{"docker/fluentd/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8c917b8d5d6f4cb33edd497d3d4c67d5d8858466","unresolved":false,"context_lines":[{"line_number":56,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{% set fluentd_plugins \u003d ["},{"line_number":60,"context_line":"    \u0027fluent-plugin-parser\u0027,"},{"line_number":61,"context_line":"    \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":62,"context_line":"    \u0027fluent-plugin-grep\u0027,"},{"line_number":63,"context_line":"    \u0027fluent-plugin-secure-forward\u0027"},{"line_number":64,"context_line":"] %}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"{% if base_distro in  [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":67,"context_line":"    # NOTE: We use fluentd version is v12.0 so fluent-plugin-grok-parse version should be \u003c 1.0.0."},{"line_number":68,"context_line":"    # https://github.com/fluent/fluent-plugin-grok-parser"},{"line_number":69,"context_line":"    {% set fluentd_plugins \u003d [ ] %}"},{"line_number":70,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":71,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":72,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":73,"context_line":"        \u0027fluent-plugin-grok-parser:2.1.4\u0027,"},{"line_number":74,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027"},{"line_number":75,"context_line":"    ] + fluentd_plugins %}"},{"line_number":76,"context_line":"{% endif %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f91af0f_f11cb06b","line":76,"range":{"start_line":59,"start_character":0,"end_line":76,"end_character":11},"updated":"2018-01-03 18:31:05.000000000","message":"if you install all fluentd plugins from packages then maybe move that common part into debian/ubuntu part?\n\nAlso drop comments from rpm distros part.","commit_id":"58ce92e70946c5e78026acb0958fe3a904e6f2cf"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"4d4bb931c98edd5653ee6ff6ba26542e9adc5747","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    {% set fluentd_plugins \u003d [ ] %}"},{"line_number":60,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":61,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":62,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":63,"context_line":"        \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":64,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":65,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":66,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":67,"context_line":"        \u0027fluent-plugin-grok-parser:2.1.4\u0027,"},{"line_number":68,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027"},{"line_number":69,"context_line":"    ] %}"},{"line_number":70,"context_line":"{% endif %}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f91af0f_5cea3aac","line":68,"range":{"start_line":62,"start_character":6,"end_line":68,"end_character":48},"updated":"2018-01-04 18:25:32.000000000","message":"alphabetic order please","commit_id":"3745cca80305e3dec7e87e7311dfdf3c1878d9e6"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"cfc8e40266c1de1a604e399eb00ce80bfe576cb9","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"{% if base_distro in  [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":59,"context_line":"    {% set fluentd_plugins \u003d [ ] %}"},{"line_number":60,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":61,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":62,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f91af0f_41a565b4","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":35},"updated":"2018-01-05 11:58:09.000000000","message":"remove","commit_id":"3f7e979ddf5dfc102f43717403db3240d0e87649"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"cfc8e40266c1de1a604e399eb00ce80bfe576cb9","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"{% if base_distro in  [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":59,"context_line":"    {% set fluentd_plugins \u003d [ ] %}"},{"line_number":60,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":61,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":62,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":63,"context_line":"        \u0027fluent-plugin-grep\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f91af0f_e1ab5986","line":60,"range":{"start_line":60,"start_character":3,"end_line":60,"end_character":5},"updated":"2018-01-05 11:58:09.000000000","message":"if","commit_id":"3f7e979ddf5dfc102f43717403db3240d0e87649"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"cfc8e40266c1de1a604e399eb00ce80bfe576cb9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \u0027fluent-plugin-grok-parser:2.1.4\u0027,"},{"line_number":65,"context_line":"        \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":66,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":67,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027"},{"line_number":68,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":69,"context_line":"    ] %}"},{"line_number":70,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f91af0f_01e19dfe","line":67,"updated":"2018-01-05 11:58:09.000000000","message":"add a \",\"","commit_id":"3f7e979ddf5dfc102f43717403db3240d0e87649"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"9fbf81ac251001d7ece4c98aefa6fea23c89d88c","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"{% set fluentd_plugins \u003d ["},{"line_number":58,"context_line":"    \u0027fluent-plugin-parser\u0027,"},{"line_number":59,"context_line":"    \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":60,"context_line":"    \u0027fluent-plugin-grep\u0027,"},{"line_number":61,"context_line":"    \u0027fluent-plugin-secure-forward\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7f96bb07_b388991f","side":"PARENT","line":58,"range":{"start_line":58,"start_character":5,"end_line":58,"end_character":25},"updated":"2018-01-11 11:00:52.000000000","message":"Just to confirm, fluent-plugin-parser and fluent-plugin-grep gems don\u0027t seem to have equivalents rpms in opstools. Is it ok to leave them out? Or should we add comment with a LP bug to track their inclusion?","commit_id":"d568df9bccccf78d92276ac3be98dc2f0a61fb79"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"507a5e9e0e4342697b51b3d83a30f6234a424a7f","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"{% set fluentd_plugins \u003d ["},{"line_number":58,"context_line":"    \u0027fluent-plugin-parser\u0027,"},{"line_number":59,"context_line":"    \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":60,"context_line":"    \u0027fluent-plugin-grep\u0027,"},{"line_number":61,"context_line":"    \u0027fluent-plugin-secure-forward\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7f96bb07_d361a53b","side":"PARENT","line":58,"range":{"start_line":58,"start_character":5,"end_line":58,"end_character":25},"in_reply_to":"7f96bb07_b388991f","updated":"2018-01-11 11:22:41.000000000","message":"The rpm fluentd version is 0.12.39.\nNo packages are needed for those plugins:\n - filter_parser is included in Fluentd’s core since v0.12.29 --\u003e https://docs.fluentd.org/v0.12/articles/filter_parser\n\n - filter_grep is included in Fluentd’s core --\u003e https://docs.fluentd.org/v0.12/articles/filter_grep","commit_id":"d568df9bccccf78d92276ac3be98dc2f0a61fb79"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"e01d8a369678aca7d086b8cf6aa7c3d296aa2811","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"{% set fluentd_plugins \u003d ["},{"line_number":58,"context_line":"    \u0027fluent-plugin-parser\u0027,"},{"line_number":59,"context_line":"    \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":60,"context_line":"    \u0027fluent-plugin-grep\u0027,"},{"line_number":61,"context_line":"    \u0027fluent-plugin-secure-forward\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7f96bb07_b69de75a","side":"PARENT","line":58,"range":{"start_line":58,"start_character":5,"end_line":58,"end_character":25},"in_reply_to":"7f96bb07_d361a53b","updated":"2018-01-11 12:04:34.000000000","message":"Perfect, that\u0027s what I wanted to confirm. Thanks!","commit_id":"d568df9bccccf78d92276ac3be98dc2f0a61fb79"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"9fbf81ac251001d7ece4c98aefa6fea23c89d88c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":64,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":65,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027,"},{"line_number":66,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":67,"context_line":"    ] %}"},{"line_number":68,"context_line":"{% endif %}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7f96bb07_f3c06153","line":66,"range":{"start_line":66,"start_character":38,"end_line":66,"end_character":39},"updated":"2018-01-11 11:00:52.000000000","message":"nit: the comma is not strictly necessary.","commit_id":"ee127b9e76c6e0673ab183bba9b27302645d2b27"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"76dea81f724be896f59ae20f81c628f7210ce7e3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":64,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":65,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027,"},{"line_number":66,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":67,"context_line":"    ] %}"},{"line_number":68,"context_line":"{% endif %}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7f96bb07_0409e82a","line":66,"range":{"start_line":66,"start_character":38,"end_line":66,"end_character":39},"in_reply_to":"7f96bb07_f3c06153","updated":"2018-01-12 06:52:35.000000000","message":"agree, other lgtm too","commit_id":"ee127b9e76c6e0673ab183bba9b27302645d2b27"}]}