)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2236290b4d83578f41211f793969a7b195a86a2a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Include building python-tempestconf from source in Tempest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* python-tempestconf is the automatic tempest config generator."},{"line_number":10,"context_line":"  Currently it is used in RefStack and Tripleo projects and"},{"line_number":11,"context_line":"  installed directly RDO shipped tempest RPM package. It would"},{"line_number":12,"context_line":"  be good to include in Tempest container so that it can be while"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_0aeaf1aa","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":28},"updated":"2018-01-08 10:58:08.000000000","message":"I would use \"an automatic Tempest config generator\".\nWe don\u0027t have the monopoly on the config generation.","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9aaa2a6ec3982110b67ca5c6ef8ce2b8d535cf89","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Include building python-tempestconf from source in Tempest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* python-tempestconf is the automatic tempest config generator."},{"line_number":10,"context_line":"  Currently it is used in RefStack and Tripleo projects and"},{"line_number":11,"context_line":"  installed directly RDO shipped tempest RPM package. It would"},{"line_number":12,"context_line":"  be good to include in Tempest container so that it can be while"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_d6c910ac","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":28},"in_reply_to":"9f91af0f_0aeaf1aa","updated":"2018-01-08 14:02:11.000000000","message":"Done","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"}],"docker/tempest/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"52a7c9bb0e2b3d8235cb4755faa4b13c27bd5f6f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"] %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% set tempestconf_pip_packages \u003d ["},{"line_number":34,"context_line":"    \u0027/python-tempestconf\u0027"},{"line_number":35,"context_line":"] %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# NOTE(Jeffrey4l): remove the tempest version constraint in the"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f91af0f_db1ff958","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":24},"updated":"2018-01-08 13:34:19.000000000","message":"This needs to be moved in the tempest_pip_packages variable above. The xxx in xxx_pip_package comes from the image name.","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9aaa2a6ec3982110b67ca5c6ef8ce2b8d535cf89","unresolved":false,"context_lines":[{"line_number":31,"context_line":"] %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% set tempestconf_pip_packages \u003d ["},{"line_number":34,"context_line":"    \u0027/python-tempestconf\u0027"},{"line_number":35,"context_line":"] %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# NOTE(Jeffrey4l): remove the tempest version constraint in the"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f91af0f_d63ef089","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":24},"in_reply_to":"9f91af0f_db1ff958","updated":"2018-01-08 14:02:11.000000000","message":"Done","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"52a7c9bb0e2b3d8235cb4755faa4b13c27bd5f6f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \u0026\u0026 {{ macros.install_pip(tempest_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":42,"context_line":"    \u0026\u0026 mkdir -p /etc/tempest /var/log/tempest /etc/tempest/tempest_lock"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"RUN ln -s tempestconf-source/* python-tempestconf \\"},{"line_number":45,"context_line":"    \u0026\u0026 {{ macros.install_pip(tempestconf_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f91af0f_7be10d2a","line":44,"updated":"2018-01-08 13:34:19.000000000","message":"You\u0027ll need to run the \"ln -s tempestconf-source/* python-tempestconf\" before calling the install_pip macro on line 41.","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9aaa2a6ec3982110b67ca5c6ef8ce2b8d535cf89","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \u0026\u0026 {{ macros.install_pip(tempest_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":42,"context_line":"    \u0026\u0026 mkdir -p /etc/tempest /var/log/tempest /etc/tempest/tempest_lock"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"RUN ln -s tempestconf-source/* python-tempestconf \\"},{"line_number":45,"context_line":"    \u0026\u0026 {{ macros.install_pip(tempestconf_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f91af0f_f643f411","line":44,"in_reply_to":"9f91af0f_7be10d2a","updated":"2018-01-08 14:02:11.000000000","message":"Done","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"52a7c9bb0e2b3d8235cb4755faa4b13c27bd5f6f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \u0026\u0026 mkdir -p /etc/tempest /var/log/tempest /etc/tempest/tempest_lock"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"RUN ln -s tempestconf-source/* python-tempestconf \\"},{"line_number":45,"context_line":"    \u0026\u0026 {{ macros.install_pip(tempestconf_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"WORKDIR /tempest"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f91af0f_7b8cad7e","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":88},"updated":"2018-01-08 13:34:19.000000000","message":"Not needed, this will automatically be taken care of by line 41 once you use the right tempest_pip_packages variable.","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9aaa2a6ec3982110b67ca5c6ef8ce2b8d535cf89","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \u0026\u0026 mkdir -p /etc/tempest /var/log/tempest /etc/tempest/tempest_lock"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"RUN ln -s tempestconf-source/* python-tempestconf \\"},{"line_number":45,"context_line":"    \u0026\u0026 {{ macros.install_pip(tempestconf_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"WORKDIR /tempest"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f91af0f_5652e0df","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":88},"in_reply_to":"9f91af0f_7b8cad7e","updated":"2018-01-08 14:02:11.000000000","message":"Done","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"e1cff0c5c268be0db07d700be4c47ae60e2e3a33","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0026\u0026 {{ macros.install_pip(tempest_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":37,"context_line":"    \u0026\u0026 mkdir -p /etc/tempest /var/log/tempest /etc/tempest/tempest_lock"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{% endif %}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"WORKDIR /tempest"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f91af0f_967f0814","side":"PARENT","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":11},"updated":"2018-01-08 14:11:21.000000000","message":"oops, you deleted too much.","commit_id":"56f35234eb236a5cafff391a17b4b491a2d2bcee"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"2bde119f4ced28079d4cbd71106dee5bf895683a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ADD tempest-archive /tempest-source"},{"line_number":26,"context_line":"ADD tempestconf-archive /tempestconf-source"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set tempest_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027/tempest\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9f91af0f_5e91924d","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":23},"updated":"2018-01-08 16:39:39.000000000","message":"Hmm, I wrongly assumed this would work. I forgot that with the current logic in kolla-build, the xxx in xxx-archive also comes from the image name and hence we can\u0027t pull sources from more than one location.\n\nWe need to use the plugins mechanism [1] instead.\n\n[1] https://docs.openstack.org/kolla/latest/admin/image-building.html#plugin-functionality","commit_id":"f52d09fee0c85e3c5d3e23c05ee8c6ce479f615a"}],"kolla/common/config.py":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"52a7c9bb0e2b3d8235cb4755faa4b13c27bd5f6f","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":614,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":615,"context_line":"                     \u0027panko-master.tar.gz\u0027)},"},{"line_number":616,"context_line":"    \u0027python-tempestconf\u0027: {"},{"line_number":617,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":618,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":619,"context_line":"                     \u0027python-tempestconf-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_1b86c167","line":616,"range":{"start_line":616,"start_character":5,"end_line":616,"end_character":23},"updated":"2018-01-08 13:34:19.000000000","message":"Needs to be tempestconf to match the archive name you set in https://review.openstack.org/#/c/531714/1/docker/tempest/Dockerfile.j2@26","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9aaa2a6ec3982110b67ca5c6ef8ce2b8d535cf89","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":614,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":615,"context_line":"                     \u0027panko-master.tar.gz\u0027)},"},{"line_number":616,"context_line":"    \u0027python-tempestconf\u0027: {"},{"line_number":617,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":618,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":619,"context_line":"                     \u0027python-tempestconf-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_f6ce94b2","line":616,"range":{"start_line":616,"start_character":5,"end_line":616,"end_character":23},"in_reply_to":"9f91af0f_1b86c167","updated":"2018-01-08 14:02:11.000000000","message":"Done","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"e1cff0c5c268be0db07d700be4c47ae60e2e3a33","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":614,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":615,"context_line":"                     \u0027panko-master.tar.gz\u0027)},"},{"line_number":616,"context_line":"    \u0027python-tempestconf\u0027: {"},{"line_number":617,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":618,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":619,"context_line":"                     \u0027python-tempestconf-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_36963c41","line":616,"range":{"start_line":616,"start_character":5,"end_line":616,"end_character":23},"in_reply_to":"9f91af0f_f6ce94b2","updated":"2018-01-08 14:11:21.000000000","message":"Looks like you missed this one","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"52a7c9bb0e2b3d8235cb4755faa4b13c27bd5f6f","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                     \u0027panko-master.tar.gz\u0027)},"},{"line_number":616,"context_line":"    \u0027python-tempestconf\u0027: {"},{"line_number":617,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":618,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":619,"context_line":"                     \u0027python-tempestconf-master.tar.gz\u0027)},"},{"line_number":620,"context_line":"    \u0027rally\u0027: {"},{"line_number":621,"context_line":"        \u0027type\u0027: \u0027url\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_fba75d0a","line":618,"range":{"start_line":618,"start_character":37,"end_line":618,"end_character":42},"updated":"2018-01-08 13:34:19.000000000","message":"python-tempestconf","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9aaa2a6ec3982110b67ca5c6ef8ce2b8d535cf89","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                     \u0027panko-master.tar.gz\u0027)},"},{"line_number":616,"context_line":"    \u0027python-tempestconf\u0027: {"},{"line_number":617,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":618,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":619,"context_line":"                     \u0027python-tempestconf-master.tar.gz\u0027)},"},{"line_number":620,"context_line":"    \u0027rally\u0027: {"},{"line_number":621,"context_line":"        \u0027type\u0027: \u0027url\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_b6c48c92","line":618,"range":{"start_line":618,"start_character":37,"end_line":618,"end_character":42},"in_reply_to":"9f91af0f_fba75d0a","updated":"2018-01-08 14:02:11.000000000","message":"Done","commit_id":"8ade05ca3dc4bbdae580610c0cb71f44204c4c8d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"40d8853e706154573cbb5a553b3235f8005f9ea3","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":622,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":623,"context_line":"                     \u0027panko-master.tar.gz\u0027)},"},{"line_number":624,"context_line":"    \u0027tempest-base-plugin-tempest-conf\u0027: {"},{"line_number":625,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":626,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/python-tempestconf/\u0027"},{"line_number":627,"context_line":"                     \u0027python-tempestconf-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_c9dc4976","line":624,"range":{"start_line":624,"start_character":5,"end_line":624,"end_character":37},"updated":"2018-01-23 15:48:10.000000000","message":"This should be \u0027tempest-plugin-tempest-conf\u0027, as the image is currently named \u0027tempest\u0027.\n\nThis causes it to ignore the plugin while building the image:\n\nDEBUG:kolla.common.utils.tempest:Turned 0 plugins into plugins archive\n\nhttp://logs.openstack.org/14/531714/4/check/kolla-build-centos-source/da8f529/logs/build/tempest.txt.gz","commit_id":"5eb78e677661b4d2b6213a96255d32ae374d0b07"}]}