)]}'
{"docker/glance/glance-api/extend_start.sh":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"422381e0cd19f6313ffee844bee0c0925a488bdb","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases"},{"line_number":12,"context_line":"# of the KOLLA_UPGRADE variable being set, including empty."},{"line_number":13,"context_line":"if [[ \"${!KOLLA_UPGRADE[@]}\" ]]; then"},{"line_number":14,"context_line":"    if [[ \"${!GLANCE_DB_EXPAND[@]}\" ]]; then"},{"line_number":15,"context_line":"        echo \"Expanding database\""},{"line_number":16,"context_line":"        glance-manage db expand"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf659307_d175119a","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":37},"updated":"2018-03-25 13:27:19.000000000","message":"This means that if KOLLA_BOOTSTRAP or KOLLA_UPGRADE variable appears first, the other one will be ignored. So, better be adding some notes to the user guide.","commit_id":"94eb2540a4ffccfc8663a6a7b340c7c3cf446f88"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"e04ee14c1ad3c1d893cc4bf2113add783eff6b9f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases"},{"line_number":12,"context_line":"# of the KOLLA_UPGRADE variable being set, including empty."},{"line_number":13,"context_line":"if [[ \"${!KOLLA_UPGRADE[@]}\" ]]; then"},{"line_number":14,"context_line":"    if [[ \"${!GLANCE_DB_EXPAND[@]}\" ]]; then"},{"line_number":15,"context_line":"        echo \"Expanding database\""},{"line_number":16,"context_line":"        glance-manage db expand"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf659307_8b511adc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":37},"in_reply_to":"bf659307_3925c75c","updated":"2018-03-30 05:42:33.000000000","message":"Adding the document is one thing. There\u0027re still chances that user may get into trouble because of misplacing the two variables. IMO, we should use an action switch instead of separate vars like this. For example:\n\n# actions could be KOLLA_BOOTSTRAP, KOLLA_UPGRADE\nACTION\u003d\u0027KOLLA_UPGRADE\u0027\n\nand then in extend_start.sh\n\nif [[ \"${!ACTION[@]}\" ]]; then\n    if [[ \"$ACTION\" \u003d\u003d \"KOLLA_BOOTSTRAP\" ]]; then\n        ...\n    elif [[ \"$ACTION\" \u003d\u003d \"KOLLA_UPGRADE\" ]]; then\n        ...\n    fi\nfi","commit_id":"94eb2540a4ffccfc8663a6a7b340c7c3cf446f88"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"cb3ab36ddc1a3621b46efce5d5c563ef8d647936","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases"},{"line_number":12,"context_line":"# of the KOLLA_UPGRADE variable being set, including empty."},{"line_number":13,"context_line":"if [[ \"${!KOLLA_UPGRADE[@]}\" ]]; then"},{"line_number":14,"context_line":"    if [[ \"${!GLANCE_DB_EXPAND[@]}\" ]]; then"},{"line_number":15,"context_line":"        echo \"Expanding database\""},{"line_number":16,"context_line":"        glance-manage db expand"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf659307_b30b1a28","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":37},"in_reply_to":"bf659307_8b511adc","updated":"2018-04-02 02:55:36.000000000","message":"I\u0027m very appreciate your recommendation, but it\u0027s feature adding patch, we should not and cannot make it different to existing code base, this kind of change should be addressed by bug or bp for code refactoring.\n\nIn other word, the refactoring should be done in current code base before apply to this patch.","commit_id":"94eb2540a4ffccfc8663a6a7b340c7c3cf446f88"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"34152ed9b794c74398e43acf588fc322f71390db","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases"},{"line_number":12,"context_line":"# of the KOLLA_UPGRADE variable being set, including empty."},{"line_number":13,"context_line":"if [[ \"${!KOLLA_UPGRADE[@]}\" ]]; then"},{"line_number":14,"context_line":"    if [[ \"${!GLANCE_DB_EXPAND[@]}\" ]]; then"},{"line_number":15,"context_line":"        echo \"Expanding database\""},{"line_number":16,"context_line":"        glance-manage db expand"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf659307_3925c75c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":37},"in_reply_to":"bf659307_d175119a","updated":"2018-03-30 04:23:14.000000000","message":"Kolla does not document the implementation details, actually, Kolla doesn\u0027t have any user guide about this (iirc), you can file a bug about this.","commit_id":"94eb2540a4ffccfc8663a6a7b340c7c3cf446f88"}]}