)]}'
{"kolla/image/build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4d67d88638a08f4be72f645178fc25726451a366","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                self.success \u003d False"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def push_image(self, image):"},{"line_number":235,"context_line":"        args \u003d None"},{"line_number":236,"context_line":"        if (self.dc.version()[\u0027Version\u0027] \u003c \u00273.0.0\u0027):"},{"line_number":237,"context_line":"             args\u003d{\u0027insecure_registry\u0027:True}"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_1c80a8f4","line":235,"updated":"2018-02-02 13:05:39.000000000","message":"*None will break - set args \u003d {}","commit_id":"37911b2d72da019d8428d2b880f9b009f00c3d3f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4d67d88638a08f4be72f645178fc25726451a366","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def push_image(self, image):"},{"line_number":235,"context_line":"        args \u003d None"},{"line_number":236,"context_line":"        if (self.dc.version()[\u0027Version\u0027] \u003c \u00273.0.0\u0027):"},{"line_number":237,"context_line":"             args\u003d{\u0027insecure_registry\u0027:True}"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        for response in self.dc.push(image.canonical_name, stream\u003dTrue, *args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_dc756033","line":236,"updated":"2018-02-02 13:05:39.000000000","message":"Better to use something like distutils.version.StrictVersion for version comparison than strings.","commit_id":"37911b2d72da019d8428d2b880f9b009f00c3d3f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4d67d88638a08f4be72f645178fc25726451a366","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    def push_image(self, image):"},{"line_number":235,"context_line":"        args \u003d None"},{"line_number":236,"context_line":"        if (self.dc.version()[\u0027Version\u0027] \u003c \u00273.0.0\u0027):"},{"line_number":237,"context_line":"             args\u003d{\u0027insecure_registry\u0027:True}"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        for response in self.dc.push(image.canonical_name, stream\u003dTrue, *args):"},{"line_number":240,"context_line":"            stream \u003d json.loads(response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_7c9a0c62","line":237,"updated":"2018-02-02 13:05:39.000000000","message":"args[\u0027insecure_registry\u0027] \u003d True\n\nAlso, this will break pep8 due to missing spaces.","commit_id":"37911b2d72da019d8428d2b880f9b009f00c3d3f"}]}
