)]}'
{"kolla/image/build.py":[{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"868ad46affff03d814dc7d8c2b6753d83c9750ce","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def push_image(self, image):"},{"line_number":332,"context_line":"        args \u003d {}"},{"line_number":333,"context_line":"        if (StrictVersion(self.dc.version()[\u0027Version\u0027])"},{"line_number":334,"context_line":"                \u003c StrictVersion(\u00273.0.0\u0027)):"},{"line_number":335,"context_line":"            args[\u0027insecure_registry\u0027] \u003d True"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_0f3ffa86","line":333,"range":{"start_line":333,"start_character":30,"end_line":333,"end_character":55},"updated":"2018-02-03 03:12:10.000000000","message":"I believe this is not the version for the package of docker but docker engine\u0027s version.","commit_id":"4b8d1fe4d8e4b6e622775595c909cbc0ed59af13"}],"kolla/tests/test_build.py":[{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"868ad46affff03d814dc7d8c2b6753d83c9750ce","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.dc \u003d mock_client"},{"line_number":65,"context_line":"        pusher \u003d build.PushTask(self.conf, self.image)"},{"line_number":66,"context_line":"        pusher.run()"},{"line_number":67,"context_line":"        if (StrictVersion(self.dc.version()[\u0027Version\u0027])"},{"line_number":68,"context_line":"                \u003c StrictVersion(\u00273.0.0\u0027)):"},{"line_number":69,"context_line":"            mock_client().push.assert_called_once_with("},{"line_number":70,"context_line":"                self.image.canonical_name, stream\u003dTrue, insecure_registry\u003dTrue)"},{"line_number":71,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_4f62e2af","line":68,"range":{"start_line":67,"start_character":12,"end_line":68,"end_character":40},"updated":"2018-02-03 03:12:10.000000000","message":"self.dc at here is just a mock object. It won\u0027t have a string typed version at here. I think this is not the correct way for unit test.","commit_id":"4b8d1fe4d8e4b6e622775595c909cbc0ed59af13"}]}
