)]}'
{"docker/networking-baremetal/ironic-neutron-agent/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"231dd5773945e07d96ff877d583bb3512a5f84f8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \u0026\u0026 /bin/false"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    {% endif %}"},{"line_number":22,"context_line":"{% endif %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{ macros.install_packages(ironic_neutron_agent_packages | customizable(\"packages\")) }}"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa0c359_a0e9b980","line":22,"updated":"2018-02-20 15:33:35.000000000","message":"Are source builds supported for this image? I think that would require some additional support in here, and entries in kolla/common/config.py.","commit_id":"ebe43fd5591921c091aba853ea8e9e7d01cae1d8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a02da230ae55393b41d89a020fcb005136177676","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ADD ironic-neutron-agent /networking-baremetal-source"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027/networking_baremetal\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa0c359_6522aebb","line":26,"updated":"2018-02-22 10:51:01.000000000","message":"s/ironic-neutron-agent/ironic-neutron-agent-archive/","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d79de7f2247c3b4d7fad0206303f38a2c2a1ae2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ADD ironic-neutron-agent /networking-baremetal-source"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027/networking_baremetal\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa0c359_c9d87854","line":26,"in_reply_to":"3fa0c359_17eaf8d6","updated":"2018-02-22 15:04:03.000000000","message":"I think it is required, otherwise the tarball will not be added to the image, and the ironic_neutron_agent_pip_packages Jinja variable won\u0027t be set. Let\u0027s see what zuul says.","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4df3c65118ab9828af22dccded6652b2223ef439","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ADD ironic-neutron-agent /networking-baremetal-source"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027/networking_baremetal\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa0c359_7fa9c021","line":26,"in_reply_to":"3fa0c359_58318c58","updated":"2018-02-23 10:09:44.000000000","message":"I see. We do lose a few things by not using the neutron-base image.\n\n* Addition of the neutron user: https://github.com/openstack/kolla/blob/master/docker/neutron/neutron-base/Dockerfile.j2#L8\n* API paste.ini config: https://github.com/openstack/kolla/blob/master/docker/neutron/neutron-base/Dockerfile.j2#L71\n* Setup of config files in /etc/neutron \u0026 others: https://github.com/openstack/kolla/blob/master/docker/neutron/neutron-base/Dockerfile.j2#L129\n* sudoers \u0026 extend_start (for log directory creation): https://github.com/openstack/kolla/blob/master/docker/neutron/neutron-base/Dockerfile.j2#L142\n\nI think we\u0027ll need to add at least some of these here if not using neutron-base. Or just use neutron-base...","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b2d4b6407ae458be4a63d6a6e0f717cdde5c4e43","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ADD ironic-neutron-agent /networking-baremetal-source"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027/networking_baremetal\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa0c359_17eaf8d6","line":26,"in_reply_to":"3fa0c359_6522aebb","updated":"2018-02-22 14:48:33.000000000","message":"I removed this, I don\u0027t think we need it.","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e3c6fe1e7f4a0810b010caa7cb044c149b204819","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ADD ironic-neutron-agent /networking-baremetal-source"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027/networking_baremetal\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa0c359_95e90be4","line":26,"in_reply_to":"3fa0c359_7fa9c021","updated":"2018-02-23 11:16:15.000000000","message":"Ok, lets lust use neutron-base then.","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1dca9366e8decdb5363fbe40df66f01fccbffc01","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ADD ironic-neutron-agent /networking-baremetal-source"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027/networking_baremetal\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa0c359_58318c58","line":26,"in_reply_to":"3fa0c359_9f95bee6","updated":"2018-02-22 18:09:25.000000000","message":"Your are right Mark.\nI was tricked because it build on \"neutron-base\". Since the baremetal ml2 plug-in is in the same python package, the agent was available when I started a container from the image. Cause neutron plugin magic in kolla/common/config.py ...\n\nI changed it to base it of openstack-base instead when building the ironic-agent-image.","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c1ae10e6cafe223fb1642b3a998293a74e3e0b26","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ADD ironic-neutron-agent /networking-baremetal-source"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":29,"context_line":"    \u0027/networking_baremetal\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa0c359_9f95bee6","line":26,"in_reply_to":"3fa0c359_c9d87854","updated":"2018-02-22 16:27:23.000000000","message":"Although the source jobs have passed for PS 5, they don\u0027t install the networking-baremetal package: http://logs.openstack.org/73/546173/5/check/kolla-build-centos-source/b00baf6/logs/build/ironic-neutron-agent.txt.gz","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a02da230ae55393b41d89a020fcb005136177676","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{{ macros.install_packages(ironic_neutron_agent_packages | customizable(\"packages\")) }}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{% block ironic_neutron_agent_footer %}{% endblock %}"},{"line_number":39,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa0c359_05faca41","line":36,"updated":"2018-02-22 10:51:01.000000000","message":"I think we need to move this to L23.","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b2d4b6407ae458be4a63d6a6e0f717cdde5c4e43","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{{ macros.install_packages(ironic_neutron_agent_packages | customizable(\"packages\")) }}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{% block ironic_neutron_agent_footer %}{% endblock %}"},{"line_number":39,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa0c359_eb368f03","line":36,"in_reply_to":"3fa0c359_05faca41","updated":"2018-02-22 14:48:33.000000000","message":"ahh, yes.","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4df3c65118ab9828af22dccded6652b2223ef439","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ADD ironic-neutron-agent-archive /ironic-neutron-agent-source"},{"line_number":29,"context_line":"{% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":30,"context_line":"    \u0027/ironic-neutron-agent\u0027,"},{"line_number":31,"context_line":"    \u0027neutron\u0027"},{"line_number":32,"context_line":"] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"RUN ln -s ironic-neutron-agent-source/* ironic-neutron-agent \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa0c359_5f516435","line":31,"updated":"2018-02-23 10:09:44.000000000","message":"If installing neutron like this, we really ought to use the configured source tarball rather than pulling from PyPI. I guess this isn\u0027t required if we go back to neutron-base though.","commit_id":"c7e50963f4285f5c5e6c0754ce934ccb23bde428"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c48bc8d660c57d4888fc3b7e78682f46f6cfff05","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"        {% set ironic_neutron_agent_packages \u003d ["},{"line_number":13,"context_line":"            \u0027python2-networking-baremetal\u0027,"},{"line_number":14,"context_line":"            \u0027python2-ironic-neutron-agent\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3fa0c359_6ad9f980","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":41},"updated":"2018-02-23 16:21:58.000000000","message":"python2-ironic-neutron-agent is not yet in RDO current-passed-ci, it is causing the binary builds to fail.\n\nThe package is in current, though, so we just need a little bit of patience.","commit_id":"1d616072098ce2f9de9f39c733d2e1298ab1a7b1"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0ed22721c5fdd69c04f89055df8320f8c993f548","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"        {% set ironic_neutron_agent_packages \u003d ["},{"line_number":13,"context_line":"            \u0027python2-networking-baremetal\u0027,"},{"line_number":14,"context_line":"            \u0027python2-ironic-neutron-agent\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3fa0c359_afbccf05","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":41},"in_reply_to":"3fa0c359_6ad9f980","updated":"2018-02-26 15:32:04.000000000","message":"Hopefully soon ...","commit_id":"1d616072098ce2f9de9f39c733d2e1298ab1a7b1"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c48bc8d660c57d4888fc3b7e78682f46f6cfff05","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {{ macros.install_packages(ironic_neutron_agent_packages | customizable(\"packages\")) }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ADD ironic-neutron-agent-archive /ironic-neutron-agent-source"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":31,"context_line":"        \u0027/ironic-neutron-agent\u0027,"},{"line_number":32,"context_line":"    ] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"RUN ln -s ironic-neutron-agent-source/* ironic-neutron-agent \\"},{"line_number":35,"context_line":"    \u0026\u0026 {{ macros.install_pip(ironic_neutron_agent_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3fa0c359_0ad8751b","line":35,"range":{"start_line":26,"start_character":0,"end_line":35,"end_character":97},"updated":"2018-02-23 16:21:58.000000000","message":"Now that you\u0027re based on neutron-base, all this part is unnecessary since you\u0027re already installing networking-baremetal there.","commit_id":"1d616072098ce2f9de9f39c733d2e1298ab1a7b1"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0ed22721c5fdd69c04f89055df8320f8c993f548","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {{ macros.install_packages(ironic_neutron_agent_packages | customizable(\"packages\")) }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ADD ironic-neutron-agent-archive /ironic-neutron-agent-source"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% set ironic_neutron_agent_pip_packages \u003d ["},{"line_number":31,"context_line":"        \u0027/ironic-neutron-agent\u0027,"},{"line_number":32,"context_line":"    ] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"RUN ln -s ironic-neutron-agent-source/* ironic-neutron-agent \\"},{"line_number":35,"context_line":"    \u0026\u0026 {{ macros.install_pip(ironic_neutron_agent_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3fa0c359_2f3e7f8a","line":35,"range":{"start_line":26,"start_character":0,"end_line":35,"end_character":97},"in_reply_to":"3fa0c359_0ad8751b","updated":"2018-02-26 15:32:04.000000000","message":"ack, I removed this. And one the part in common/config.py as well.","commit_id":"1d616072098ce2f9de9f39c733d2e1298ab1a7b1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"218feb2f14241666456edd617fdfddb0d4a511d7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":20,"context_line":"            \u0026\u0026 /bin/false"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% endif %}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"df7087c5_7c036c10","line":20,"updated":"2018-03-12 09:33:12.000000000","message":"Do we need to prevent the tests from building this image for ubuntu/debian binary? See SKIPPED_IMAGES in kolla/image/build.py.","commit_id":"6cbe89eb87c06205208aec44cb4066b57e4559a8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f623c6e307d9a326eec9507d02855481811d3b10","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":20,"context_line":"            \u0026\u0026 /bin/false"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {% endif %}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"df7087c5_1a74b098","line":20,"in_reply_to":"df7087c5_7c036c10","updated":"2018-03-12 10:13:03.000000000","message":"Thanks Mark! Makes sense.","commit_id":"6cbe89eb87c06205208aec44cb4066b57e4559a8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f8a19d6012572f8fd2ba8ae1cad6a459fc2084b7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"        {% set ironic_neutron_agent_packages \u003d ["},{"line_number":13,"context_line":"            \u0027python2-networking-baremetal\u0027,"},{"line_number":14,"context_line":"            \u0027python2-ironic-neutron-agent\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"df7087c5_a80c3eec","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":41},"updated":"2018-03-13 07:46:15.000000000","message":"package is python-networking-baremetal, python2 names usually are alias","commit_id":"761406c74909567e2a4943c44881b58079fba8f8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8d8055416c2134b216a944236ac1ac1e0b451150","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"        {% set ironic_neutron_agent_packages \u003d ["},{"line_number":13,"context_line":"            \u0027python2-networking-baremetal\u0027,"},{"line_number":14,"context_line":"            \u0027python2-ironic-neutron-agent\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"df7087c5_06a3dbb3","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":41},"in_reply_to":"df7087c5_a80c3eec","updated":"2018-03-13 08:42:00.000000000","message":"Done","commit_id":"761406c74909567e2a4943c44881b58079fba8f8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f8a19d6012572f8fd2ba8ae1cad6a459fc2084b7","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% block ironic_neutron_agent_footer %}{% endblock %}"},{"line_number":30,"context_line":"{% block footer %}{% endblock %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"df7087c5_e8a236ae","line":28,"updated":"2018-03-13 07:46:15.000000000","message":"source is not installed","commit_id":"761406c74909567e2a4943c44881b58079fba8f8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8d8055416c2134b216a944236ac1ac1e0b451150","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% block ironic_neutron_agent_footer %}{% endblock %}"},{"line_number":30,"context_line":"{% block footer %}{% endblock %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"df7087c5_26961f41","line":28,"in_reply_to":"df7087c5_e8a236ae","updated":"2018-03-13 08:42:00.000000000","message":"Actually it is. Read the commit message. And previous review comments: https://review.openstack.org/#/c/546173/7/docker/networking-baremetal/ironic-neutron-agent/Dockerfile.j2@35","commit_id":"761406c74909567e2a4943c44881b58079fba8f8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b3f72ea1e70b15e6cf3905ead8f14e2c8c3612e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block ironic_neutron_agent_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"df7087c5_11c5898e","line":1,"updated":"2018-03-21 09:40:19.000000000","message":"If the image is to be moved to a different directory, neutron would make the most sense IMO since we\u0027re inheriting from the neutron-base image. That said, I don\u0027t think it\u0027s necessary.","commit_id":"2d79bfa5a5c9dd44d74b6563a736de54ed8baee1"}],"kolla/common/config.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a02da230ae55393b41d89a020fcb005136177676","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    \u0027gnocchi\u0027,"},{"line_number":109,"context_line":"                    \u0027influxdb\u0027,"},{"line_number":110,"context_line":"                    \u0027ironic\u0027,"},{"line_number":111,"context_line":"                    \u0027ironic-neutron-agent\u0027,"},{"line_number":112,"context_line":"                    \u0027kafka\u0027,"},{"line_number":113,"context_line":"                    \u0027karbor\u0027,"},{"line_number":114,"context_line":"                    \u0027kuryr\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_057deab0","line":111,"updated":"2018-02-22 10:51:01.000000000","message":"I think these are regexes, so might be matched by ironic. Perhaps someone else could confirm?","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b2d4b6407ae458be4a63d6a6e0f717cdde5c4e43","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    \u0027gnocchi\u0027,"},{"line_number":109,"context_line":"                    \u0027influxdb\u0027,"},{"line_number":110,"context_line":"                    \u0027ironic\u0027,"},{"line_number":111,"context_line":"                    \u0027ironic-neutron-agent\u0027,"},{"line_number":112,"context_line":"                    \u0027kafka\u0027,"},{"line_number":113,"context_line":"                    \u0027karbor\u0027,"},{"line_number":114,"context_line":"                    \u0027kuryr\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_8b802bf9","line":111,"in_reply_to":"3fa0c359_057deab0","updated":"2018-02-22 14:48:33.000000000","message":"Yeah, would be good to have confirmation.\n\nEither they are regexes or they match on kolla/docker/\u003cfoldername\u003e? (In that case this should be \"networking-baremetal\" in this case).\n\nI decided to remove this, as there is no entry for \u0027ironic-inspector\u0027. So I guess the agent is picked up by the \u0027ironic\u0027 entry.","commit_id":"76c141c0dd4eef3398bb608f80a75fa199a3b937"}],"releasenotes/notes/add-networking-baremtal-ed44e0fc04371eb8.yaml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f8a19d6012572f8fd2ba8ae1cad6a459fc2084b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add deployment of networking-baremetal. Networking Baremetal provide deep"},{"line_number":4,"context_line":"    integration between the Networking service and the Bare Metal service."},{"line_number":5,"context_line":"    Advanced networking features like notifications of port status changes and"},{"line_number":6,"context_line":"    routed networks support in clouds with Bare Metal service."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df7087c5_687f0615","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":18},"updated":"2018-03-13 07:46:15.000000000","message":"image, deployment is in other repositories or projects","commit_id":"761406c74909567e2a4943c44881b58079fba8f8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8d8055416c2134b216a944236ac1ac1e0b451150","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add deployment of networking-baremetal. Networking Baremetal provide deep"},{"line_number":4,"context_line":"    integration between the Networking service and the Bare Metal service."},{"line_number":5,"context_line":"    Advanced networking features like notifications of port status changes and"},{"line_number":6,"context_line":"    routed networks support in clouds with Bare Metal service."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df7087c5_66c41760","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":18},"in_reply_to":"df7087c5_687f0615","updated":"2018-03-13 08:42:00.000000000","message":"Done","commit_id":"761406c74909567e2a4943c44881b58079fba8f8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"276be2bf0a9cb2a2eeb4cf64f97613390addc8e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add networking-baremetal image. Networking Baremetal provide deep"},{"line_number":4,"context_line":"    integration between the Networking service and the Bare Metal service."},{"line_number":5,"context_line":"    Advanced networking features like notifications of port status changes and"},{"line_number":6,"context_line":"    routed networks support in clouds with Bare Metal service."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df7087c5_6ef6ee65","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":34},"updated":"2018-03-15 08:02:25.000000000","message":"Actually the image is called ironic-neutron-agent. Should this image go better inside neutron or ironic folder rather than having a networking-baremetal folder? I think is confusing","commit_id":"322846bd10967b476354a969064770801872ccbb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"04d4b1eaa0bf3e4dc601d74003d5ac47b6844f07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add networking-baremetal image. Networking Baremetal provide deep"},{"line_number":4,"context_line":"    integration between the Networking service and the Bare Metal service."},{"line_number":5,"context_line":"    Advanced networking features like notifications of port status changes and"},{"line_number":6,"context_line":"    routed networks support in clouds with Bare Metal service."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df7087c5_05314c5a","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":34},"in_reply_to":"df7087c5_6ef6ee65","updated":"2018-03-15 11:28:28.000000000","message":"I will make an update to the reno.\n\nI am open to discuss weather to keep this in the networking-baremtal folder or move it to the neutron folder. What does other reviewers think?","commit_id":"322846bd10967b476354a969064770801872ccbb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b3f72ea1e70b15e6cf3905ead8f14e2c8c3612e8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add networking-baremetal components: The ``baremetal`` ML2 mechanism driver"},{"line_number":5,"context_line":"    and the ``ironic-neutron-agnet`` L2 agent."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Networking Baremetal provide deep integration between the Networking"},{"line_number":8,"context_line":"    service and the Bare Metal service. Advanced networking features like"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df7087c5_915f59e4","line":5,"updated":"2018-03-21 09:40:19.000000000","message":"nit: spelling, -agent","commit_id":"2d79bfa5a5c9dd44d74b6563a736de54ed8baee1"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"867f8c3feb0fafd666a5a6f158b4177054abad8e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add networking-baremetal components: The ``baremetal`` ML2 mechanism driver"},{"line_number":5,"context_line":"    and the ``ironic-neutron-agnet`` L2 agent."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Networking Baremetal provide deep integration between the Networking"},{"line_number":8,"context_line":"    service and the Bare Metal service. Advanced networking features like"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df7087c5_c7f2ef9a","line":5,"in_reply_to":"df7087c5_915f59e4","updated":"2018-03-21 11:05:43.000000000","message":"Done","commit_id":"2d79bfa5a5c9dd44d74b6563a736de54ed8baee1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b3f72ea1e70b15e6cf3905ead8f14e2c8c3612e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add networking-baremetal components: The ``baremetal`` ML2 mechanism driver"},{"line_number":5,"context_line":"    and the ``ironic-neutron-agnet`` L2 agent."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Networking Baremetal provide deep integration between the Networking"},{"line_number":8,"context_line":"    service and the Bare Metal service. Advanced networking features like"},{"line_number":9,"context_line":"    notifications of port status changes and routed networks support in clouds"},{"line_number":10,"context_line":"    with Bare Metal service."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df7087c5_b1629dac","line":7,"updated":"2018-03-21 09:40:19.000000000","message":"nit: provides","commit_id":"2d79bfa5a5c9dd44d74b6563a736de54ed8baee1"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"867f8c3feb0fafd666a5a6f158b4177054abad8e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add networking-baremetal components: The ``baremetal`` ML2 mechanism driver"},{"line_number":5,"context_line":"    and the ``ironic-neutron-agnet`` L2 agent."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Networking Baremetal provide deep integration between the Networking"},{"line_number":8,"context_line":"    service and the Bare Metal service. Advanced networking features like"},{"line_number":9,"context_line":"    notifications of port status changes and routed networks support in clouds"},{"line_number":10,"context_line":"    with Bare Metal service."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df7087c5_c7474fbc","line":7,"in_reply_to":"df7087c5_b1629dac","updated":"2018-03-21 11:05:43.000000000","message":"Done","commit_id":"2d79bfa5a5c9dd44d74b6563a736de54ed8baee1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b3f72ea1e70b15e6cf3905ead8f14e2c8c3612e8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    notifications of port status changes and routed networks support in clouds"},{"line_number":10,"context_line":"    with Bare Metal service."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    The ML2 mechanism driver is built in the neutron-base image when building"},{"line_number":13,"context_line":"    from source. Binary users can use ``neutron_server_packages_append`` to"},{"line_number":14,"context_line":"    include the ``python-networking-baremetal`` package when building"},{"line_number":15,"context_line":"    neutron-server image. The ``ironic-neutron-agent`` L2 agent is in the"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df7087c5_71116504","line":12,"updated":"2018-03-21 09:40:19.000000000","message":"s/built/installed/ ?","commit_id":"2d79bfa5a5c9dd44d74b6563a736de54ed8baee1"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"867f8c3feb0fafd666a5a6f158b4177054abad8e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    notifications of port status changes and routed networks support in clouds"},{"line_number":10,"context_line":"    with Bare Metal service."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    The ML2 mechanism driver is built in the neutron-base image when building"},{"line_number":13,"context_line":"    from source. Binary users can use ``neutron_server_packages_append`` to"},{"line_number":14,"context_line":"    include the ``python-networking-baremetal`` package when building"},{"line_number":15,"context_line":"    neutron-server image. The ``ironic-neutron-agent`` L2 agent is in the"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df7087c5_e74293ab","line":12,"in_reply_to":"df7087c5_71116504","updated":"2018-03-21 11:05:43.000000000","message":"Done","commit_id":"2d79bfa5a5c9dd44d74b6563a736de54ed8baee1"}]}