)]}'
{"docker/zookeeper/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fdd3a0009a4a6ad650777ff5bcda7e0ca23cc305","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ macros.install_packages(zookeeper_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% block zookeeper_version %}"},{"line_number":23,"context_line":"ENV zookeeper_version\u003d3.4.10"},{"line_number":24,"context_line":"{% endblock %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% block zookeeper_binary_install %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df7087c5_0d67d84f","line":23,"updated":"2018-03-08 14:27:04.000000000","message":"nit: This limits us to using stable releases given the URL below, of which I can only see one. Could also do this:\n\nENV zookeeper_version\u003d3.4.10\nENV zookeeper_url\u003dhttp://apache.mirror.anlx.net/zookeeper/stable/zookeeper-${zookeeper_version}.tar.gz","commit_id":"d48647f0616ad1891378312a28cee395209b7b01"},{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"4d6f0faf5182fe473ea85f56d9da9a60688d9feb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{% endblock %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% block zookeeper_binary_install %}"},{"line_number":27,"context_line":"RUN curl -sSL -o /tmp/zookeeper.tar.gz http://apache.mirror.anlx.net/zookeeper/stable/zookeeper-${zookeeper_version}.tar.gz \\"},{"line_number":28,"context_line":"    \u0026\u0026 tar xvf /tmp/zookeeper.tar.gz -C /opt/ \\"},{"line_number":29,"context_line":"    \u0026\u0026 rm -f /tmp/zookeeper.tar.gz \\"},{"line_number":30,"context_line":"    \u0026\u0026 ln -s /opt/zookeeper* /opt/zookeeper"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df7087c5_8d7a0822","line":27,"updated":"2018-03-08 14:15:07.000000000","message":"Can we verify the integrity of this file?","commit_id":"d48647f0616ad1891378312a28cee395209b7b01"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fdd3a0009a4a6ad650777ff5bcda7e0ca23cc305","unresolved":false,"context_lines":[{"line_number":27,"context_line":"RUN curl -sSL -o /tmp/zookeeper.tar.gz http://apache.mirror.anlx.net/zookeeper/stable/zookeeper-${zookeeper_version}.tar.gz \\"},{"line_number":28,"context_line":"    \u0026\u0026 tar xvf /tmp/zookeeper.tar.gz -C /opt/ \\"},{"line_number":29,"context_line":"    \u0026\u0026 rm -f /tmp/zookeeper.tar.gz \\"},{"line_number":30,"context_line":"    \u0026\u0026 ln -s /opt/zookeeper* /opt/zookeeper"},{"line_number":31,"context_line":"{% endblock %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df7087c5_0d1918d6","line":30,"updated":"2018-03-08 14:27:04.000000000","message":"nit: You could use \u0027tar --strip 1\u0027 to avoid this.\n\nhttps://www.marksanborn.net/linux/extract-without-first-directory/","commit_id":"d48647f0616ad1891378312a28cee395209b7b01"},{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"d1971fdbcb5bb7d946eda2cfb08f6a6536d65f6f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% block zookeeper_binary_install %}"},{"line_number":30,"context_line":"RUN curl -sSL -o /tmp/zookeeper.tar.gz ${zookeeper_url} \\"},{"line_number":31,"context_line":"    \u0026\u0026 [ `sha1sum /tmp/zookeeper.tar.gz | awk \u0027{print $1}\u0027` \u003d\u003d ${zookeeper_pkg_sha1sum} ] \\"},{"line_number":32,"context_line":"    \u0026\u0026 mkdir -p /opt/zookeeper \\"},{"line_number":33,"context_line":"    \u0026\u0026 tar --strip 1 -xvf /tmp/zookeeper.tar.gz -C /opt/zookeeper \\"},{"line_number":34,"context_line":"    \u0026\u0026 rm -f /tmp/zookeeper.tar.gz"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df7087c5_28596a59","line":31,"updated":"2018-03-08 15:03:05.000000000","message":"Nice, this approach should be propagated elsewhere IMO.","commit_id":"20ba683d8f4da6dd2fa3b474132d8e9150a0a99f"}]}
