)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"94663eb7ee6a485863bc88623c667f5837fc5cd5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sandhya Dasu \u003csadasu@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-05 19:07:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changes required to support netwoking-cisco"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. container build using template-override"},{"line_number":10,"context_line":"2. container build using plugins-archive"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_b6296bf3","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":43},"updated":"2018-05-17 21:32:08.000000000","message":"s/netwoking-cisco/networking-cisco","commit_id":"4d211dfd08da342fb24ab9850a02f0e1a619458e"}],"contrib/template-override/networking-cisco.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e02defcf1e538e0ab3c917d91b5a89048b87da5b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN pip install --upgrade pip"},{"line_number":5,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":6,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5f7c97a3_7fa963dc","line":6,"updated":"2018-07-12 01:54:56.000000000","message":"please install from tarballs.openstack.org site. \nmore info please check config.py file and how networking-ovn is implemented.","commit_id":"51554babc541e9fc0b548c18794e08a3a5280355"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"bbe8818f134f85c648019257b07c71236a020f15","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN pip install --upgrade pip"},{"line_number":5,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":6,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5f7c97a3_eaa6010e","line":6,"in_reply_to":"5f7c97a3_7fa963dc","updated":"2018-07-12 14:08:20.000000000","message":"Images from 3rd party out-of-tree Neutron drivers are not part of \ntarballs.openstack.org. That is why I started this effort to figure out the best way to handle these drivers.","commit_id":"51554babc541e9fc0b548c18794e08a3a5280355"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"4b1940e554bbdfef636543de4eca51f7a53fa960","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN pip install --upgrade pip"},{"line_number":5,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":6,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5f7c97a3_2a5ab9f1","line":6,"in_reply_to":"5f7c97a3_eaa6010e","updated":"2018-07-12 14:10:16.000000000","message":"I was wrong. I see them here : http://tarballs.openstack.org/networking-cisco/.","commit_id":"51554babc541e9fc0b548c18794e08a3a5280355"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4098a594bacf53026019fdb1989cacda5c1b56a7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN pip install --upgrade pip"},{"line_number":5,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":6,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"3f79a3b5_a3043d19","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":29},"updated":"2018-08-13 10:36:52.000000000","message":"The latest version of pip is already installed in the base image","commit_id":"da1d4b709e61a4b096e6f6b9a8068f112c84fe63"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"22ede172375185455f0fdcc1392fa66fcb243527","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN pip install --upgrade pip"},{"line_number":5,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":6,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"3f79a3b5_e9075a17","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":29},"in_reply_to":"3f79a3b5_a3043d19","updated":"2018-08-14 14:43:37.000000000","message":"Done.","commit_id":"da1d4b709e61a4b096e6f6b9a8068f112c84fe63"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6f5925914d5b0f33b4ca4010bd46aadfaf6f832c","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":5,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":6,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f79a3b5_24ee17b5","line":5,"range":{"start_line":5,"start_character":3,"end_line":5,"end_character":50},"updated":"2018-09-17 11:57:53.000000000","message":"can you make use of the macro pip install_ so we can have an standard method of installation, using contrains file too.","commit_id":"36a71d1b74c2dd5652aeea22773f3caceb41874d"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"05d38b3837cafa44308c78ac6c761104c5915770","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":5,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":6,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f79a3b5_0a30bd06","line":5,"range":{"start_line":5,"start_character":3,"end_line":5,"end_character":50},"in_reply_to":"3f79a3b5_24ee17b5","updated":"2018-09-17 17:51:54.000000000","message":"Yes, will do. I have been following what was provided in https://docs.openstack.org/kolla/latest/admin/image-building.html#plugin-functionality.","commit_id":"36a71d1b74c2dd5652aeea22773f3caceb41874d"}],"docker/neutron/networking-cisco/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"24f3764769cce7fc3c27122d3efb264be0ad9bcb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% block neutron_server_footer %}"},{"line_number":2,"context_line":"ADD plugins-archive /"},{"line_number":3,"context_line":"pip --no-cache-dir install /plugins/*"},{"line_number":4,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_88db7a7a","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":37},"updated":"2018-03-13 07:39:02.000000000","message":"this will install all source plugins into neutron_server, even in binary images.","commit_id":"0209d58dcd28dbf35180ec09f11551b7a7225e2c"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"5ee62ff227796b5197f675950bf6faa3cd3329bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% block neutron_server_footer %}"},{"line_number":2,"context_line":"ADD plugins-archive /"},{"line_number":3,"context_line":"pip --no-cache-dir install /plugins/*"},{"line_number":4,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_ad971a3a","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":37},"in_reply_to":"df7087c5_88db7a7a","updated":"2018-03-15 18:05:54.000000000","message":"Yes,thx. Will fine tune approach in my subsequent patch.","commit_id":"0209d58dcd28dbf35180ec09f11551b7a7225e2c"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"622a9460fd7729e2c8f075b0dd449f576a023ee9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% block neutron_server_footer %}"},{"line_number":2,"context_line":"ADD plugins-archive /"},{"line_number":3,"context_line":"pip --no-cache-dir install /plugins/*"},{"line_number":4,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_60c39639","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":37},"in_reply_to":"df7087c5_88db7a7a","updated":"2018-03-13 12:29:08.000000000","message":"agree","commit_id":"0209d58dcd28dbf35180ec09f11551b7a7225e2c"}],"docker/neutron/networking-cisco/template-override.j2":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"622a9460fd7729e2c8f075b0dd449f576a023ee9","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN pip install --upgrade pip"},{"line_number":5,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":6,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_80d58ae7","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":55},"updated":"2018-03-13 12:29:08.000000000","message":"usually, we don\u0027t do as this, please refer to https://github.com/openstack/kolla/blob/master/kolla/common/config.py","commit_id":"0209d58dcd28dbf35180ec09f11551b7a7225e2c"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"5ee62ff227796b5197f675950bf6faa3cd3329bc","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN pip install --upgrade pip"},{"line_number":5,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":6,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_2d1a2a16","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":55},"in_reply_to":"df7087c5_80d58ae7","updated":"2018-03-15 18:05:54.000000000","message":"I think you are referring to adding this container image to tar balls.openstack.org. I think that is applicable to plugins/drivers that are in tree like Cinder and Ironic drivers. Networking-cisco is a set of multiple ML2 vendor drivers are like out of tree. Due to these drivers being out of tree, the container image built for these drivers cannot be uploaded to tarballs.openstack.org. \n\nAlso, from the last kolla weekly IRC meeting, it appears that Kolla is moving away from this model. Should the documentation link be updated to reflect that?","commit_id":"0209d58dcd28dbf35180ec09f11551b7a7225e2c"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"622a9460fd7729e2c8f075b0dd449f576a023ee9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN pip install --upgrade pip"},{"line_number":5,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":6,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_e00b267a","line":7,"range":{"start_line":1,"start_character":0,"end_line":7,"end_character":14},"updated":"2018-03-13 12:29:08.000000000","message":"how to use Dockerfile, please refer tohttps://github.com/openstack/kolla/blob/master/docker/neutron/neutron-server/Dockerfile.j2","commit_id":"0209d58dcd28dbf35180ec09f11551b7a7225e2c"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"5ee62ff227796b5197f675950bf6faa3cd3329bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN pip install --upgrade pip"},{"line_number":5,"context_line":"RUN git clone https://github.com/openstack/networking-cisco \\"},{"line_number":6,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-cisco"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_eda3d2b0","line":7,"range":{"start_line":1,"start_character":0,"end_line":7,"end_character":14},"in_reply_to":"df7087c5_e00b267a","updated":"2018-03-15 18:05:54.000000000","message":"Yes, I do have a version with plugin-archives working. Will upload the next version soon. I want to support both the template-override and the plugins-archive methodologies.","commit_id":"0209d58dcd28dbf35180ec09f11551b7a7225e2c"}],"docker/neutron/neutron-base/Dockerfile.j2":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"442a5dad232264fa1c698ef4f7e8befef3630e03","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \u0027python-openvswitch\u0027,"},{"line_number":61,"context_line":"            \u0027python-oslo.vmware\u0027,"},{"line_number":62,"context_line":"            \u0027python-vmware-nsx\u0027,"},{"line_number":63,"context_line":"            \u0027git\u0027,"},{"line_number":64,"context_line":"            \u0027python-setuptools\u0027"},{"line_number":65,"context_line":"        ] %}"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df7087c5_e9490f32","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":18},"updated":"2018-03-21 05:26:35.000000000","message":"move up by alphabet.","commit_id":"c9fc2b13335428dc6fea5bd68d8847e2ec3c9f53"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"0658793688368fb63ec96862832d139fa9b3f0ed","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \u0027python-openvswitch\u0027,"},{"line_number":61,"context_line":"            \u0027python-oslo.vmware\u0027,"},{"line_number":62,"context_line":"            \u0027python-vmware-nsx\u0027,"},{"line_number":63,"context_line":"            \u0027git\u0027,"},{"line_number":64,"context_line":"            \u0027python-setuptools\u0027"},{"line_number":65,"context_line":"        ] %}"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df7087c5_d5784b2c","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":18},"in_reply_to":"df7087c5_e9490f32","updated":"2018-03-21 20:33:37.000000000","message":"Done","commit_id":"c9fc2b13335428dc6fea5bd68d8847e2ec3c9f53"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4098a594bacf53026019fdb1989cacda5c1b56a7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        {% set neutron_base_packages \u003d ["},{"line_number":53,"context_line":"            \u0027git\u0027,"},{"line_number":54,"context_line":"            \u0027iproute2\u0027,"},{"line_number":55,"context_line":"            \u0027iputils-ping\u0027,"},{"line_number":56,"context_line":"            \u0027keepalived\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"3f79a3b5_3e0b6224","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":18},"updated":"2018-08-13 10:36:52.000000000","message":"This is already installed in openstack base","commit_id":"da1d4b709e61a4b096e6f6b9a8068f112c84fe63"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"22ede172375185455f0fdcc1392fa66fcb243527","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        {% set neutron_base_packages \u003d ["},{"line_number":53,"context_line":"            \u0027git\u0027,"},{"line_number":54,"context_line":"            \u0027iproute2\u0027,"},{"line_number":55,"context_line":"            \u0027iputils-ping\u0027,"},{"line_number":56,"context_line":"            \u0027keepalived\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"3f79a3b5_16167156","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":18},"in_reply_to":"3f79a3b5_26b0298a","updated":"2018-08-14 14:43:37.000000000","message":"Done.","commit_id":"da1d4b709e61a4b096e6f6b9a8068f112c84fe63"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"22ede172375185455f0fdcc1392fa66fcb243527","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        {% set neutron_base_packages \u003d ["},{"line_number":53,"context_line":"            \u0027git\u0027,"},{"line_number":54,"context_line":"            \u0027iproute2\u0027,"},{"line_number":55,"context_line":"            \u0027iputils-ping\u0027,"},{"line_number":56,"context_line":"            \u0027keepalived\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"3f79a3b5_562069ac","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":18},"in_reply_to":"3f79a3b5_3e0b6224","updated":"2018-08-14 14:43:37.000000000","message":"Done.","commit_id":"da1d4b709e61a4b096e6f6b9a8068f112c84fe63"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"89f81b38f67ee06e76bc5fa0df9d88d4ef2b7b57","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        {% set neutron_base_packages \u003d ["},{"line_number":53,"context_line":"            \u0027git\u0027,"},{"line_number":54,"context_line":"            \u0027iproute2\u0027,"},{"line_number":55,"context_line":"            \u0027iputils-ping\u0027,"},{"line_number":56,"context_line":"            \u0027keepalived\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"3f79a3b5_26b0298a","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":18},"in_reply_to":"3f79a3b5_3e0b6224","updated":"2018-08-14 03:39:32.000000000","message":"agree, but does python-setuptools packages have installed in openstack base ? and if no,when base_distro in centos  should install this too ?","commit_id":"da1d4b709e61a4b096e6f6b9a8068f112c84fe63"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"a8a4fdca597fc40d2ca98791ea5f11a6122aaf44","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027python-networking-vmware-nsx\u0027,"},{"line_number":47,"context_line":"            \u0027python-openvswitch\u0027,"},{"line_number":48,"context_line":"            \u0027python-oslo.vmware\u0027,"},{"line_number":49,"context_line":"            \u0027python-setuptools\u0027"},{"line_number":50,"context_line":"        ] %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3f79a3b5_321b6eca","line":49,"updated":"2018-08-14 22:13:23.000000000","message":"Are you sure is this needed? I would have thought since you are pulling in the python3 deb then you are already pulling in the python-setuptools pkg.","commit_id":"e6513ac3e5220a0b2a1c595fcf2d616d3272cbfa"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"90731585d46303ee3886b35148a563db1bb70bca","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027python-networking-vmware-nsx\u0027,"},{"line_number":47,"context_line":"            \u0027python-openvswitch\u0027,"},{"line_number":48,"context_line":"            \u0027python-oslo.vmware\u0027,"},{"line_number":49,"context_line":"            \u0027python-setuptools\u0027"},{"line_number":50,"context_line":"        ] %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3f79a3b5_978fa674","line":49,"in_reply_to":"3f79a3b5_321b6eca","updated":"2018-08-16 15:18:09.000000000","message":"This would be needed if the container issuing built in a python2 environment. As per my understanding, support for Python 2 is still ongoing.","commit_id":"e6513ac3e5220a0b2a1c595fcf2d616d3272cbfa"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"a8a4fdca597fc40d2ca98791ea5f11a6122aaf44","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027python-neutron-fwaas\u0027,"},{"line_number":66,"context_line":"            \u0027python-openvswitch\u0027,"},{"line_number":67,"context_line":"            \u0027python-oslo.vmware\u0027,"},{"line_number":68,"context_line":"            \u0027python-setuptools\u0027,"},{"line_number":69,"context_line":"            \u0027python-vmware-nsx\u0027"},{"line_number":70,"context_line":"        ] %}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3f79a3b5_72256608","line":68,"updated":"2018-08-14 22:13:23.000000000","message":"dito","commit_id":"e6513ac3e5220a0b2a1c595fcf2d616d3272cbfa"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6f5925914d5b0f33b4ca4010bd46aadfaf6f832c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            \u0027python2-networking-baremetal\u0027,"},{"line_number":29,"context_line":"            \u0027python2-openvswitch\u0027,"},{"line_number":30,"context_line":"            \u0027python2-oslo-vmware\u0027,"},{"line_number":31,"context_line":"            \u0027python-setuptools\u0027"},{"line_number":32,"context_line":"        ] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    {% elif base_distro in [\u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f79a3b5_042f5bf6","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":31},"updated":"2018-09-17 11:57:53.000000000","message":"could you move this to the template override, is not needed in every neutron base image.\nWe offer a mechanism to add or remove packages into a list using template overrides.\n\nhttps://docs.openstack.org/kolla/latest/admin/image-building.html#package-customisation\n\nSame comment for other packages in this file","commit_id":"36a71d1b74c2dd5652aeea22773f3caceb41874d"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"05d38b3837cafa44308c78ac6c761104c5915770","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            \u0027python2-networking-baremetal\u0027,"},{"line_number":29,"context_line":"            \u0027python2-openvswitch\u0027,"},{"line_number":30,"context_line":"            \u0027python2-oslo-vmware\u0027,"},{"line_number":31,"context_line":"            \u0027python-setuptools\u0027"},{"line_number":32,"context_line":"        ] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    {% elif base_distro in [\u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f79a3b5_aa20a9b1","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":31},"in_reply_to":"3f79a3b5_042f5bf6","updated":"2018-09-17 17:51:54.000000000","message":"Yes. Will do.","commit_id":"36a71d1b74c2dd5652aeea22773f3caceb41874d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6f5925914d5b0f33b4ca4010bd46aadfaf6f832c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            \u0027python-openvswitch\u0027,"},{"line_number":70,"context_line":"            \u0027python-oslo.vmware\u0027,"},{"line_number":71,"context_line":"            \u0027python-setuptools\u0027,"},{"line_number":72,"context_line":"            \u0027python-vmware-nsx\u0027"},{"line_number":73,"context_line":"        ] %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f79a3b5_843a8b31","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":31},"updated":"2018-09-17 11:57:53.000000000","message":"why this package_","commit_id":"36a71d1b74c2dd5652aeea22773f3caceb41874d"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"48bb2cddae0af9eac31fcf91de7608bacacfb7ed","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            \u0027python-openvswitch\u0027,"},{"line_number":70,"context_line":"            \u0027python-oslo.vmware\u0027,"},{"line_number":71,"context_line":"            \u0027python-setuptools\u0027,"},{"line_number":72,"context_line":"            \u0027python-vmware-nsx\u0027"},{"line_number":73,"context_line":"        ] %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f79a3b5_a5ff7a32","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":31},"in_reply_to":"3f79a3b5_843a8b31","updated":"2018-10-24 17:14:17.000000000","message":"I think this is left over from a previous rebase.","commit_id":"36a71d1b74c2dd5652aeea22773f3caceb41874d"}],"docker/neutron/neutron-server-networking-cisco/Dockerfile.j2":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"a23e193c5643ed4f64e2387b9ee58cc78c81d0c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"USER root"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block neutron_server_networking_cisco %}{% endblock %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df7087c5_29f2a707","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":9},"updated":"2018-03-21 05:22:37.000000000","message":"no need","commit_id":"c9fc2b13335428dc6fea5bd68d8847e2ec3c9f53"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"0658793688368fb63ec96862832d139fa9b3f0ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"USER root"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block neutron_server_networking_cisco %}{% endblock %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df7087c5_75acdf8b","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":9},"in_reply_to":"df7087c5_29f2a707","updated":"2018-03-21 20:33:37.000000000","message":"Done","commit_id":"c9fc2b13335428dc6fea5bd68d8847e2ec3c9f53"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"2ff3a87a187db8a74b527fb1532925ff87ee9329","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_server_networking_cisco %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f7c97a3_669dcab8","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":53},"updated":"2018-07-18 15:56:48.000000000","message":"The neutron-server image sets the user to be \u0027neutron\u0027, so if you base you image on neutron-server you won\u0027t be able to install any packages without first changing to root with:\n\n  USER root","commit_id":"9dcf4e1a4101f776b2c795a7eac955406177ca33"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"8806c36ad7b91e29b97278b0561972547bf82f74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block neutron_server_networking_cisco %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f7c97a3_e0ebfda1","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":53},"in_reply_to":"5f7c97a3_669dcab8","updated":"2018-07-18 18:47:12.000000000","message":"Done. Thanks!","commit_id":"9dcf4e1a4101f776b2c795a7eac955406177ca33"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6f5925914d5b0f33b4ca4010bd46aadfaf6f832c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"USER root"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block neutron_server_networking_cisco %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% set neutron_server_networking_cisco_packages \u003d ["},{"line_number":12,"context_line":"        \u0027python-networking-cisco\u0027,"},{"line_number":13,"context_line":"    ] %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{ macros.install_packages(neutron_server_networking_cisco_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD plugins-archive /"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% set neutron_server_networking_cisco_plugins_pip_packages \u003d ["},{"line_number":22,"context_line":"    \u0027/plugins/*\u0027"},{"line_number":23,"context_line":"] %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":26,"context_line":"        {{ macros.install_pip(neutron_server_networking_cisco_plugins_pip_packages | customizable(\"pip_packages\")) }}; \\"},{"line_number":27,"context_line":"    fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block neutron_server_networking_cisco_footer %}{% endblock %}"},{"line_number":32,"context_line":"{% block footer %}{% endblock %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"USER neutron"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f79a3b5_446eb32c","line":34,"range":{"start_line":1,"start_character":0,"end_line":34,"end_character":12},"updated":"2018-09-17 11:57:53.000000000","message":"can we use instead of a new docker image, use template overrides to add the needed content into the neutron-server image?","commit_id":"36a71d1b74c2dd5652aeea22773f3caceb41874d"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"05d38b3837cafa44308c78ac6c761104c5915770","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-server:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"USER root"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block neutron_server_networking_cisco %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% set neutron_server_networking_cisco_packages \u003d ["},{"line_number":12,"context_line":"        \u0027python-networking-cisco\u0027,"},{"line_number":13,"context_line":"    ] %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{ macros.install_packages(neutron_server_networking_cisco_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD plugins-archive /"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% set neutron_server_networking_cisco_plugins_pip_packages \u003d ["},{"line_number":22,"context_line":"    \u0027/plugins/*\u0027"},{"line_number":23,"context_line":"] %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"RUN if [ \"$(ls /plugins)\" ]; then \\"},{"line_number":26,"context_line":"        {{ macros.install_pip(neutron_server_networking_cisco_plugins_pip_packages | customizable(\"pip_packages\")) }}; \\"},{"line_number":27,"context_line":"    fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block neutron_server_networking_cisco_footer %}{% endblock %}"},{"line_number":32,"context_line":"{% block footer %}{% endblock %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"USER neutron"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3f79a3b5_4a4315b1","line":34,"range":{"start_line":1,"start_character":0,"end_line":34,"end_character":12},"in_reply_to":"3f79a3b5_446eb32c","updated":"2018-09-17 17:51:54.000000000","message":"Yes. Will do.","commit_id":"36a71d1b74c2dd5652aeea22773f3caceb41874d"}],"kolla/common/config.py":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4098a594bacf53026019fdb1989cacda5c1b56a7","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":632,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/networking-ovn/\u0027"},{"line_number":633,"context_line":"                     \u0027networking-ovn-master.tar.gz\u0027)},"},{"line_number":634,"context_line":"    \u0027neutron-server-plugin-networking-cisco\u0027: {"},{"line_number":635,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":636,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/networking-cisco/\u0027"},{"line_number":637,"context_line":"                     \u0027networking-cisco-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_de3caec9","line":634,"range":{"start_line":634,"start_character":5,"end_line":634,"end_character":43},"updated":"2018-08-13 10:36:52.000000000","message":"This will install this plugin in the default build. Maybe that\u0027s ok as we do it for lots of other plugins, though I don\u0027t think that was the intent of this patch?","commit_id":"da1d4b709e61a4b096e6f6b9a8068f112c84fe63"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"22ede172375185455f0fdcc1392fa66fcb243527","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":632,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/networking-ovn/\u0027"},{"line_number":633,"context_line":"                     \u0027networking-ovn-master.tar.gz\u0027)},"},{"line_number":634,"context_line":"    \u0027neutron-server-plugin-networking-cisco\u0027: {"},{"line_number":635,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":636,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/networking-cisco/\u0027"},{"line_number":637,"context_line":"                     \u0027networking-cisco-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_377cd91d","line":634,"range":{"start_line":634,"start_character":5,"end_line":634,"end_character":43},"in_reply_to":"3f79a3b5_de3caec9","updated":"2018-08-14 14:43:37.000000000","message":"Agreed. I think for now, the intent is the kolla container would not be built automatically but would be build by the cloud-admin/operator only when needed.\nWill remove this change from the patch-set.","commit_id":"da1d4b709e61a4b096e6f6b9a8068f112c84fe63"}]}
