)]}'
{"tox.ini":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7d1d402fb03e2a72dccb663e785b202fed90f4f9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"whitelist_externals \u003d find"},{"line_number":9,"context_line":"                      rm"},{"line_number":10,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":11,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":12,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":13,"context_line":"passenv \u003d http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY"},{"line_number":14,"context_line":"          OS_STDOUT_CAPTURE OS_STDERR_CAPTURE OS_LOG_CAPTURE OS_TEST_TIMEOUT"}],"source_content_type":"text/x-properties","patch_set":1,"id":"bf659307_135df045","line":11,"updated":"2018-04-04 08:39:06.000000000","message":"You need to add the upper constraints argument here (above requirements).","commit_id":"eefc605e47ac4d064c74e877c5480a997ddbe879"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"e04432453bd2b2a1c5b514e3974a34894567f74d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"whitelist_externals \u003d find"},{"line_number":9,"context_line":"                      rm"},{"line_number":10,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":11,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":12,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":13,"context_line":"passenv \u003d http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY"},{"line_number":14,"context_line":"          OS_STDOUT_CAPTURE OS_STDERR_CAPTURE OS_LOG_CAPTURE OS_TEST_TIMEOUT"}],"source_content_type":"text/x-properties","patch_set":1,"id":"bf659307_e5575357","line":11,"in_reply_to":"bf659307_135df045","updated":"2018-04-04 09:02:27.000000000","message":"Done","commit_id":"eefc605e47ac4d064c74e877c5480a997ddbe879"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7d1d402fb03e2a72dccb663e785b202fed90f4f9","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[testenv:docs]"},{"line_number":52,"context_line":"deps \u003d"},{"line_number":53,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h\u003dstable/queens}"},{"line_number":54,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"bf659307_1322d0b9","line":53,"updated":"2018-04-04 08:39:06.000000000","message":"Remove ?h\u003dstable/queens - this is master.\n\nAlso need requirements.txt here, above doc/requirements.txt.","commit_id":"eefc605e47ac4d064c74e877c5480a997ddbe879"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"e04432453bd2b2a1c5b514e3974a34894567f74d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[testenv:docs]"},{"line_number":52,"context_line":"deps \u003d"},{"line_number":53,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h\u003dstable/queens}"},{"line_number":54,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"bf659307_25cf8b29","line":53,"in_reply_to":"bf659307_1322d0b9","updated":"2018-04-04 09:02:27.000000000","message":"Done","commit_id":"eefc605e47ac4d064c74e877c5480a997ddbe879"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"738d93778dac31297f7ffcc685ca2176fb2c8c9d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[testenv:docs]"},{"line_number":52,"context_line":"deps \u003d"},{"line_number":53,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h\u003dstable/queens}"},{"line_number":54,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"bf659307_e5619306","line":53,"in_reply_to":"bf659307_25cf8b29","updated":"2018-04-04 09:08:24.000000000","message":"You need the upper constraints, but those for master, not queens.","commit_id":"eefc605e47ac4d064c74e877c5480a997ddbe879"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3b6d099cb4fff353edc0560ed146b44b465848a0","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[testenv:docs]"},{"line_number":53,"context_line":"deps \u003d"},{"line_number":54,"context_line":"    -r{toxinidir}/requirements.txt"},{"line_number":55,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"bf659307_4a5b9553","line":54,"updated":"2018-04-05 07:55:16.000000000","message":"I\u0027m saying that you need to add upper constraints here too. You had these in the first patch, but the URL was for stable/queens - not master.\n\ndeps \u003d\n    -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}\n    -r{toxinidir}/requirements.txt\n    -r{toxinidir}/doc/requirements.txt","commit_id":"c6bdbf8ceeaba4de45c52d4cea9ade143686fe86"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"1d3a5614e0708e5a6089e49a9ebab6744ec55e19","unresolved":false,"context_lines":[{"line_number":52,"context_line":"[testenv:docs]"},{"line_number":53,"context_line":"deps \u003d"},{"line_number":54,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":55,"context_line":"    -r{toxinidir}/requirements.txt"},{"line_number":56,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"bf659307_26bc03db","line":55,"updated":"2018-04-10 06:57:15.000000000","message":"kolla requirements should not be required here.","commit_id":"bc4a827ff36cabcd9e552bf5b83169363d4e1e4d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"448dfaf950fc2d5e7b2eea742bf32fa0f3728576","unresolved":false,"context_lines":[{"line_number":52,"context_line":"[testenv:docs]"},{"line_number":53,"context_line":"deps \u003d"},{"line_number":54,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":55,"context_line":"    -r{toxinidir}/requirements.txt"},{"line_number":56,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"bf659307_379bcbc9","line":55,"in_reply_to":"bf659307_26bc03db","updated":"2018-04-10 08:38:05.000000000","message":"This is the recommended set of deps from the email.","commit_id":"bc4a827ff36cabcd9e552bf5b83169363d4e1e4d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"205da554861eb5abfc72feac9affe95b6326e4d9","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[testenv:docs]"},{"line_number":53,"context_line":"deps \u003d"},{"line_number":54,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":55,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":4,"id":"bf659307_e3857908","line":54,"updated":"2018-04-11 08:19:03.000000000","message":"Perhaps I should have been more clear. The email [1] recommends to include the project requirements.txt here.\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2017-December/125710.html","commit_id":"1cde100fbc738e2ea422de9d7f9bca077c9b3aa7"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"19cb16df1d151a8c5738c4e9f3cb8385f123b085","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[testenv:docs]"},{"line_number":53,"context_line":"deps \u003d"},{"line_number":54,"context_line":"    -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":55,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":4,"id":"bf659307_01d96954","line":54,"in_reply_to":"bf659307_e3857908","updated":"2018-04-12 04:50:43.000000000","message":"Done","commit_id":"1cde100fbc738e2ea422de9d7f9bca077c9b3aa7"}]}
