)]}'
{"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5b6ddce3f69e6622c673758201fd6d67d7f3b367","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":73,"context_line":"        \u0027ansible\u003d\u003d2.2.0.0\u0027,"},{"line_number":74,"context_line":"        \u0027influxdb\u0027,"},{"line_number":75,"context_line":"        \u0027MySQL-python\u0027,"},{"line_number":76,"context_line":"        \u0027os-client-config\u003d\u003d1.29.0\u0027,"},{"line_number":77,"context_line":"        \u0027pbr\u003d\u003d4.0.0\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bf659307_70aee281","line":74,"range":{"start_line":74,"start_character":9,"end_line":74,"end_character":17},"updated":"2018-04-12 13:49:53.000000000","message":"This is used by kolla-ansible to create the influxdb database.","commit_id":"eea3f7046c8ba9a4e43d565895c19d727e03d275"}],"docker/monasca/monasca-api/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c2c2c14c58cd3b052ffbf4991153c98c2752fe0","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block footer %}{% endblock %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"USER monasca"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf659307_8cef69e8","side":"PARENT","line":30,"updated":"2018-04-06 16:13:38.000000000","message":"Which user is used now? Root?","commit_id":"0efc8ccfc259f1e9e870819a446acd892dd0ef29"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2373d07bbd5e3c44489c0b87baa7efb9986f65d7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block footer %}{% endblock %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"USER monasca"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf659307_8f58bb56","side":"PARENT","line":30,"in_reply_to":"bf659307_2cee5d88","updated":"2018-04-06 17:15:12.000000000","message":"I see.","commit_id":"0efc8ccfc259f1e9e870819a446acd892dd0ef29"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"97cc0d9056c05765bd49d0203ba491b502e2abc7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block footer %}{% endblock %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"USER monasca"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf659307_2cee5d88","side":"PARENT","line":30,"in_reply_to":"bf659307_8cef69e8","updated":"2018-04-06 16:29:58.000000000","message":"Yes, it is root. Apache needs to start as root, and then it switches to the monasca user. See other WSGI roles for example.","commit_id":"0efc8ccfc259f1e9e870819a446acd892dd0ef29"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5b6ddce3f69e6622c673758201fd6d67d7f3b367","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":16,"context_line":"        {% set monasca_api_packages \u003d ["},{"line_number":17,"context_line":"            \u0027mariadb\u0027,"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set monasca_api_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bf659307_10bf66aa","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":20},"updated":"2018-04-12 13:49:53.000000000","message":"This is used by when the monasca database schema is loaded during bootstrapping.","commit_id":"eea3f7046c8ba9a4e43d565895c19d727e03d275"},{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"a3e14f2257dc8961514231d96f4f44428f1f99d6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block footer %}{% endblock %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"USER monasca"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9f6a8fd7_39d1b958","side":"PARENT","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":12},"updated":"2018-04-29 13:35:47.000000000","message":"why remove this?","commit_id":"0efc8ccfc259f1e9e870819a446acd892dd0ef29"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6e42652fbc3bb03ad898e6ed1904313bb7474243","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block footer %}{% endblock %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"USER monasca"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9f6a8fd7_d11df10f","side":"PARENT","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":12},"in_reply_to":"9f6a8fd7_39d1b958","updated":"2018-04-30 09:00:00.000000000","message":"Apache starts as root and then serves the API as the monasca user.","commit_id":"0efc8ccfc259f1e9e870819a446acd892dd0ef29"},{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"4fdcf295ab83f44892462c21c570848735a51721","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":16,"context_line":"        {% set monasca_api_packages \u003d ["},{"line_number":17,"context_line":"            \u0027mariadb\u0027,"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set monasca_api_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f6a8fd7_38c20aeb","line":17,"range":{"start_line":17,"start_character":21,"end_line":17,"end_character":22},"updated":"2018-04-30 13:46:53.000000000","message":"the \",\" is ok for a list of cause,  but in my opinion, when the list have only one items, the \",\" better to remove, to keep consistence with the others","commit_id":"e961566881f6907ff2617a19b4766b9d63209330"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2837862c3935f5d6d0ecd0be74527ec733b059a8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":16,"context_line":"        {% set monasca_api_packages \u003d ["},{"line_number":17,"context_line":"            \u0027mariadb\u0027,"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set monasca_api_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f6a8fd7_cadc2f76","line":17,"updated":"2018-05-02 08:33:10.000000000","message":"this is not a big deal. i am OK with the \u0027,\u0027. and in fact the \u0027,\u0027 is good for diff when you add second item here.","commit_id":"e961566881f6907ff2617a19b4766b9d63209330"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9ec4d867e5e0acff051dbd8c420fbddbcb02ba2b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":16,"context_line":"        {% set monasca_api_packages \u003d ["},{"line_number":17,"context_line":"            \u0027mariadb\u0027,"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set monasca_api_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f6a8fd7_d22ddd46","line":17,"range":{"start_line":17,"start_character":21,"end_line":17,"end_character":22},"in_reply_to":"9f6a8fd7_38c20aeb","updated":"2018-05-01 08:46:50.000000000","message":"It\u0027s fairly common practice to add a comma to the last item in a list. This means that if another item is appended in future, we do not need to modify this line.","commit_id":"e961566881f6907ff2617a19b4766b9d63209330"},{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"4fdcf295ab83f44892462c21c570848735a51721","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set monasca_api_packages \u003d ["},{"line_number":21,"context_line":"            \u0027mariadb-client\u0027,"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":"    {% endif %}"},{"line_number":24,"context_line":"{{ macros.install_packages(monasca_api_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f6a8fd7_1862a617","line":21,"range":{"start_line":21,"start_character":28,"end_line":21,"end_character":29},"updated":"2018-04-30 13:46:53.000000000","message":"ditto","commit_id":"e961566881f6907ff2617a19b4766b9d63209330"}],"docker/monasca/monasca-api/extend_start.sh":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5b6ddce3f69e6622c673758201fd6d67d7f3b367","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Create log directory, with appropriate permissions"},{"line_number":16,"context_line":"MONASCA_API_LOG_DIR\u003d\"/var/log/kolla/monasca/${SERVICE}\""},{"line_number":17,"context_line":"if [[ ! -d \"$MONASCA_API_LOG_DIR\" ]]; then"},{"line_number":18,"context_line":"    mkdir -p $MONASCA_API_LOG_DIR"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf659307_50ce3e5a","line":15,"range":{"start_line":15,"start_character":41,"end_line":15,"end_character":52},"updated":"2018-04-12 13:49:53.000000000","message":"Log directory was flattened so all monasca logs are now in monasca/ rather than monasca/monasca-api/ etc.","commit_id":"23a89b151b9a9b2e42297c64aba4ebee1469b5ac"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"2dd3f9896d1c4aa9d03049779b28a9b4a6a54aa9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    sed \"s/USE \\`mon\\`;/USE \\`${MONASCA_DATABASE_NAME}\\`;/g\" \\"},{"line_number":10,"context_line":"    /monasca-api/devstack/files/schema/mon_mysql.sql \u003e /tmp/mon_mysql.sql"},{"line_number":11,"context_line":"    # Load the schema"},{"line_number":12,"context_line":"    mysql -h ${MONASCA_DATABASE_ADDRESS} \\"},{"line_number":13,"context_line":"        -P ${MONASCA_DATABASE_PORT} \\"},{"line_number":14,"context_line":"        -u ${MONASCA_DATABASE_USER} \\"},{"line_number":15,"context_line":"        -p${MONASCA_DATABASE_PASSWORD} \\"},{"line_number":16,"context_line":"        \u003c /tmp/mon_mysql.sql"},{"line_number":17,"context_line":"    exit 0"},{"line_number":18,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_050fb0e1","line":15,"range":{"start_line":12,"start_character":10,"end_line":15,"end_character":10},"updated":"2018-04-17 11:53:36.000000000","message":"Please, in scripts use long names of arguments. Short names are fine in cmd but let\u0027s make it easy for other users to read them fast in scripts (I know variable names provide hints but I would still prefer long names here).","commit_id":"668612d6e2c249d946809eec0536a2f3e52f7499"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6e42652fbc3bb03ad898e6ed1904313bb7474243","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    sed \"s/USE \\`mon\\`;/USE \\`${MONASCA_DATABASE_NAME}\\`;/g\" \\"},{"line_number":10,"context_line":"    /monasca-api/devstack/files/schema/mon_mysql.sql \u003e /tmp/mon_mysql.sql"},{"line_number":11,"context_line":"    # Load the schema"},{"line_number":12,"context_line":"    mysql -h ${MONASCA_DATABASE_ADDRESS} \\"},{"line_number":13,"context_line":"        -P ${MONASCA_DATABASE_PORT} \\"},{"line_number":14,"context_line":"        -u ${MONASCA_DATABASE_USER} \\"},{"line_number":15,"context_line":"        -p${MONASCA_DATABASE_PASSWORD} \\"},{"line_number":16,"context_line":"        \u003c /tmp/mon_mysql.sql"},{"line_number":17,"context_line":"    exit 0"},{"line_number":18,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_b1c4fd93","line":15,"range":{"start_line":12,"start_character":10,"end_line":15,"end_character":10},"in_reply_to":"9f6a8fd7_050fb0e1","updated":"2018-04-30 09:00:00.000000000","message":"Fair point - this also avoids the quirky -p arg which doesn\u0027t follow the pattern of having a space after it.","commit_id":"668612d6e2c249d946809eec0536a2f3e52f7499"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2837862c3935f5d6d0ecd0be74527ec733b059a8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        --port\u003d${MONASCA_DATABASE_PORT} \\"},{"line_number":14,"context_line":"        --user\u003d${MONASCA_DATABASE_USER} \\"},{"line_number":15,"context_line":"        --password\u003d${MONASCA_DATABASE_PASSWORD} \\"},{"line_number":16,"context_line":"        \u003c /tmp/mon_mysql.sql"},{"line_number":17,"context_line":"    exit 0"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"9f6a8fd7_2af60bfb","line":16,"updated":"2018-05-02 08:33:10.000000000","message":"can this run mutiple times? i prefer to move this into orchestration side(ansible)","commit_id":"e961566881f6907ff2617a19b4766b9d63209330"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2caa4cdfde6b31f60fb74279bed2145d5bac4e6d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        --port\u003d${MONASCA_DATABASE_PORT} \\"},{"line_number":14,"context_line":"        --user\u003d${MONASCA_DATABASE_USER} \\"},{"line_number":15,"context_line":"        --password\u003d${MONASCA_DATABASE_PASSWORD} \\"},{"line_number":16,"context_line":"        \u003c /tmp/mon_mysql.sql"},{"line_number":17,"context_line":"    exit 0"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5f7c97a3_cba099a8","line":16,"in_reply_to":"5f7c97a3_09c9f476","updated":"2018-06-08 15:11:02.000000000","message":"+1 for what Mark said. This only runs once during bootstrap. I know it\u0027s a bit clunky, but when alembic migrations are supported in Monasca (code is in review) we can update this. FWIW, I\u0027ve tested it a fair bit now and it works as it should for me at least.","commit_id":"e961566881f6907ff2617a19b4766b9d63209330"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ce382f8444f58633a5e40ce9833cd145b4c1d8bb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        --port\u003d${MONASCA_DATABASE_PORT} \\"},{"line_number":14,"context_line":"        --user\u003d${MONASCA_DATABASE_USER} \\"},{"line_number":15,"context_line":"        --password\u003d${MONASCA_DATABASE_PASSWORD} \\"},{"line_number":16,"context_line":"        \u003c /tmp/mon_mysql.sql"},{"line_number":17,"context_line":"    exit 0"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"9f6a8fd7_8a02b7b3","line":16,"in_reply_to":"9f6a8fd7_2af60bfb","updated":"2018-05-02 08:39:06.000000000","message":"This only happens when $KOLLA_BOOTSTRAP is set - so during bootstrap.yml. Doug would need to comment on whether it is idempotent, but hopefully so as it will be needed to perform DB migrations following an update.","commit_id":"e961566881f6907ff2617a19b4766b9d63209330"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"63c717fdeb5b5ad9522f7b907315a4be097bda64","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        --port\u003d${MONASCA_DATABASE_PORT} \\"},{"line_number":14,"context_line":"        --user\u003d${MONASCA_DATABASE_USER} \\"},{"line_number":15,"context_line":"        --password\u003d${MONASCA_DATABASE_PASSWORD} \\"},{"line_number":16,"context_line":"        \u003c /tmp/mon_mysql.sql"},{"line_number":17,"context_line":"    exit 0"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"9f6a8fd7_ca942f47","line":16,"in_reply_to":"9f6a8fd7_8a02b7b3","updated":"2018-05-02 08:49:00.000000000","message":"I believe it\u0027s idempotent, but Alembic migrations are in the pipeline with much better support for upgrades. Perhaps we should wait for this to get merged? \n\nhttps://review.openstack.org/#/c/563967/","commit_id":"e961566881f6907ff2617a19b4766b9d63209330"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"43ad1d753b2ad6c5bfc7ca096c9a6d30b0807e1a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        --port\u003d${MONASCA_DATABASE_PORT} \\"},{"line_number":14,"context_line":"        --user\u003d${MONASCA_DATABASE_USER} \\"},{"line_number":15,"context_line":"        --password\u003d${MONASCA_DATABASE_PASSWORD} \\"},{"line_number":16,"context_line":"        \u003c /tmp/mon_mysql.sql"},{"line_number":17,"context_line":"    exit 0"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5f7c97a3_09c9f476","line":16,"in_reply_to":"9f6a8fd7_ca942f47","updated":"2018-05-21 09:40:07.000000000","message":"I think we need something here until alembic migrations are supported, so I\u0027m happy to go with the SQL script approach.","commit_id":"e961566881f6907ff2617a19b4766b9d63209330"}],"docker/monasca/monasca-base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c2c2c14c58cd3b052ffbf4991153c98c2752fe0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 443),#\\1,\u0027 /etc/httpd/conf.d/ssl.conf"},{"line_number":27,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        {% set keystone_base_packages \u003d ["},{"line_number":30,"context_line":"            \u0027apache2\u0027,"},{"line_number":31,"context_line":"            \u0027libapache2-mod-wsgi\u0027,"},{"line_number":32,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf659307_8c76893e","line":29,"updated":"2018-04-06 16:13:38.000000000","message":"monasca_base_packages","commit_id":"ab91996c00ddd411cf3e46f1abf6db379c21f186"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"97cc0d9056c05765bd49d0203ba491b502e2abc7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 443),#\\1,\u0027 /etc/httpd/conf.d/ssl.conf"},{"line_number":27,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        {% set keystone_base_packages \u003d ["},{"line_number":30,"context_line":"            \u0027apache2\u0027,"},{"line_number":31,"context_line":"            \u0027libapache2-mod-wsgi\u0027,"},{"line_number":32,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf659307_ac558d1f","line":29,"in_reply_to":"bf659307_8c76893e","updated":"2018-04-06 16:29:58.000000000","message":"Done","commit_id":"ab91996c00ddd411cf3e46f1abf6db379c21f186"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c2c2c14c58cd3b052ffbf4991153c98c2752fe0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    {% endif %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{% block monasca_source_install %}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":42,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf659307_0caa7984","line":39,"updated":"2018-04-06 16:13:38.000000000","message":"Do we need a block here? Can\u0027t we customise the packages through other means?","commit_id":"ab91996c00ddd411cf3e46f1abf6db379c21f186"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"97cc0d9056c05765bd49d0203ba491b502e2abc7","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    {% endif %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{% block monasca_source_install %}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":42,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf659307_ec5b8551","line":39,"in_reply_to":"bf659307_0caa7984","updated":"2018-04-06 16:29:58.000000000","message":"Perhaps not. As you probably guessed from the typo above this change is based on keystone, which also has this section.","commit_id":"ab91996c00ddd411cf3e46f1abf6db379c21f186"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2373d07bbd5e3c44489c0b87baa7efb9986f65d7","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    {% endif %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{% block monasca_source_install %}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":42,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf659307_4f4b8386","line":39,"in_reply_to":"bf659307_ec5b8551","updated":"2018-04-06 17:15:12.000000000","message":"Ok, I\u0027m fine with keeping it then if others agree.","commit_id":"ab91996c00ddd411cf3e46f1abf6db379c21f186"}],"docker/monasca/monasca-base/extend_start.sh":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"2dd3f9896d1c4aa9d03049779b28a9b4a6a54aa9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ ! -d \"$MONASCA_LOG_DIR\" ]]; then"},{"line_number":6,"context_line":"    mkdir -p $MONASCA_LOG_DIR"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"if [[ $(stat -c %U:%G ${MONASCA_LOG_DIR}) !\u003d \"monasca:kolla\" ]]; then"},{"line_number":9,"context_line":"    chown monasca:kolla ${MONASCA_LOG_DIR}"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":"if [[ $(stat -c %a ${MONASCA_LOG_DIR}) !\u003d \"755\" ]]; then"},{"line_number":12,"context_line":"    chmod 755 ${MONASCA_LOG_DIR}"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":". /usr/local/bin/kolla_monasca_extend_start"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_05dd7041","line":13,"range":{"start_line":8,"start_character":0,"end_line":13,"end_character":2},"updated":"2018-04-17 11:53:36.000000000","message":"Do we need all this `if`s here? You are still forcing proper modes. And don\u0027t you need `recursive` switches?","commit_id":"668612d6e2c249d946809eec0536a2f3e52f7499"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6e42652fbc3bb03ad898e6ed1904313bb7474243","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ ! -d \"$MONASCA_LOG_DIR\" ]]; then"},{"line_number":6,"context_line":"    mkdir -p $MONASCA_LOG_DIR"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"if [[ $(stat -c %U:%G ${MONASCA_LOG_DIR}) !\u003d \"monasca:kolla\" ]]; then"},{"line_number":9,"context_line":"    chown monasca:kolla ${MONASCA_LOG_DIR}"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":"if [[ $(stat -c %a ${MONASCA_LOG_DIR}) !\u003d \"755\" ]]; then"},{"line_number":12,"context_line":"    chmod 755 ${MONASCA_LOG_DIR}"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":". /usr/local/bin/kolla_monasca_extend_start"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_9150d9d6","line":13,"range":{"start_line":8,"start_character":0,"end_line":13,"end_character":2},"in_reply_to":"9f6a8fd7_05dd7041","updated":"2018-04-30 09:00:00.000000000","message":"If we don\u0027t wrap these in if statements the time the folder was last changed will be updated every time the container (re)starts, even if the the permissions don\u0027t actually change. Since we don\u0027t want to modify the container after the initial one time configuration we need the `if`s.","commit_id":"668612d6e2c249d946809eec0536a2f3e52f7499"}],"docker/monasca/monasca-log-api/extend_start.sh":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"2dd3f9896d1c4aa9d03049779b28a9b4a6a54aa9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        touch ${MONASCA_LOG_API_LOG_DIR}/${SERVICE}-${LOG_TYPE}.log"},{"line_number":23,"context_line":"    fi"},{"line_number":24,"context_line":"    if [[ $(stat -c %U:%G ${MONASCA_LOG_API_LOG_DIR}/${SERVICE}-${LOG_TYPE}.log) !\u003d \"monasca:kolla\" ]]; then"},{"line_number":25,"context_line":"        chown monasca:kolla ${MONASCA_LOG_API_LOG_DIR}/${SERVICE}-${LOG_TYPE}.log"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_65a6acc4","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":81},"updated":"2018-04-17 11:53:36.000000000","message":"Why not moving it to previous `if` if you are forcing proper ownership.","commit_id":"668612d6e2c249d946809eec0536a2f3e52f7499"}]}