)]}'
{"docker/ceilometer/ceilometer-ipmi/Dockerfile.j2":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"16c0ae43b8a92151b39185907cc20910e6ce0581","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"        {% set ceilometer_ipmi_packages \u003d ["},{"line_number":11,"context_line":"            \u0027openstack-ceilometer-ipmi\u0027"},{"line_number":12,"context_line":"            \u0027ipmitool\u0027"},{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":"        {% set ceilometer_ipmi_packages \u003d ["},{"line_number":16,"context_line":"            \u0027ceilometer-agent-ipmi\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f6a8fd7_eecb796f","line":13,"range":{"start_line":10,"start_character":6,"end_line":13,"end_character":12},"updated":"2018-04-29 07:42:18.000000000","message":"this should be a  list,please add \u0027,\u0027","commit_id":"a6d9f0a3028ceb71f63ebb337233a2f81d57884c"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"8c68b191cbcf57487c4dca2d467e7b3f339d1f64","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(ceilometer_ipmi_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":24,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f6a8fd7_5f45636f","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":82},"updated":"2018-04-30 15:17:33.000000000","message":"If we move the call to install_packages on line 34 outside of the loop we can avoid the need for this","commit_id":"ef35fb5754535f68d276132db2a9bd72594587ab"},{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"5502e2256a1b5e0c58b031567324913a0e553d9a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(ceilometer_ipmi_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":24,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f6a8fd7_402a522c","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":82},"in_reply_to":"9f6a8fd7_5f45636f","updated":"2018-05-01 15:45:04.000000000","message":"done\nplease help review this ps again, thanks Paul","commit_id":"ef35fb5754535f68d276132db2a9bd72594587ab"}]}