)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"6253738016914a32db3e8691f68b10890fe72432","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tone Zhang \u003ctone.zhang@arm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-15 00:21:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"wip: allow Kolla Ceph to deploy bluestore OSDs in Kolla"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support Kolla Ceph to deploy blustore OSDs. With the patch, Kolla"},{"line_number":10,"context_line":"Ceph can deploy bluestore OSDs on ONE, TWO or THREE storage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_219d6065","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2018-05-15 02:02:51.000000000","message":"are you finished? if yes, please remove the wip","commit_id":"fc38bea9c74caf79abe5e16b8e66ef309f9d816e"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"3148083bcef3787dd26f570a338ab40e3d9b5142","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tone Zhang \u003ctone.zhang@arm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-15 00:21:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"wip: allow Kolla Ceph to deploy bluestore OSDs in Kolla"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support Kolla Ceph to deploy blustore OSDs. With the patch, Kolla"},{"line_number":10,"context_line":"Ceph can deploy bluestore OSDs on ONE, TWO or THREE storage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_c1858c08","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"in_reply_to":"5f7c97a3_219d6065","updated":"2018-05-15 04:11:04.000000000","message":"Yes, the blueprint has been finished. Will update the commit message.","commit_id":"fc38bea9c74caf79abe5e16b8e66ef309f9d816e"}],"docker/ceph/ceph-osd/extend_start.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3f8c13c71b8331e26ba96f71f9158e8a562af24d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ \"${USE_EXTERNAL_JOURNAL}\" \u003d\u003d \"False\" ]]; then"},{"line_number":23,"context_line":"        # Formatting disk for ceph"},{"line_number":24,"context_line":"        if [[ \"${OSD_STORETYPE}\" \u003d\u003d \"filestore\" ]]; then"},{"line_number":25,"context_line":"            sgdisk --zap-all -- \"${OSD_DEV}\""},{"line_number":26,"context_line":"            sgdisk --new\u003d2:1M:5G -- \"${JOURNAL_DEV}\""},{"line_number":27,"context_line":"            sgdisk --largest-new\u003d1 -- \"${OSD_DEV}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_30af5a95","line":24,"updated":"2018-05-09 07:33:33.000000000","message":"since this variable is added since this patch, i think the better logical is\n\nif OSD_STORETYPE \u003d\u003d bluestore ; then\n  xxx\n\nelse\n  xxx\n\nfi\n\n\nthen it will break the upgrade from old env. ( still using filestore)","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"ba4b96caf76d43cd51fc9ac25e39dd2ab3c0ccce","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    if [[ \"${USE_EXTERNAL_JOURNAL}\" \u003d\u003d \"False\" ]]; then"},{"line_number":23,"context_line":"        # Formatting disk for ceph"},{"line_number":24,"context_line":"        if [[ \"${OSD_STORETYPE}\" \u003d\u003d \"filestore\" ]]; then"},{"line_number":25,"context_line":"            sgdisk --zap-all -- \"${OSD_DEV}\""},{"line_number":26,"context_line":"            sgdisk --new\u003d2:1M:5G -- \"${JOURNAL_DEV}\""},{"line_number":27,"context_line":"            sgdisk --largest-new\u003d1 -- \"${OSD_DEV}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_b01daabe","line":24,"in_reply_to":"5f7c97a3_30af5a95","updated":"2018-05-10 05:22:09.000000000","message":"Thanks. Will update.","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3f8c13c71b8331e26ba96f71f9158e8a562af24d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_DB_DEV}\""},{"line_number":44,"context_line":"                sgdisk --new\u003d1:0:+1G --mbrtogpt -- \"${OSD_BS_DB_DEV}\""},{"line_number":45,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_DB_DEV}\"1"},{"line_number":46,"context_line":"            fi"},{"line_number":47,"context_line":"        fi"},{"line_number":48,"context_line":"        # NOTE(SamYaple): This command may throw errors that we can safely ignore"},{"line_number":49,"context_line":"        partprobe || true"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_5090d643","line":46,"updated":"2018-05-09 07:33:33.000000000","message":"when using internal journal, there is no need to create separate partition for wal and db. just put them on the block dev.","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"ba4b96caf76d43cd51fc9ac25e39dd2ab3c0ccce","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_DB_DEV}\""},{"line_number":44,"context_line":"                sgdisk --new\u003d1:0:+1G --mbrtogpt -- \"${OSD_BS_DB_DEV}\""},{"line_number":45,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_DB_DEV}\"1"},{"line_number":46,"context_line":"            fi"},{"line_number":47,"context_line":"        fi"},{"line_number":48,"context_line":"        # NOTE(SamYaple): This command may throw errors that we can safely ignore"},{"line_number":49,"context_line":"        partprobe || true"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_f051e263","line":46,"in_reply_to":"5f7c97a3_5090d643","updated":"2018-05-10 05:22:09.000000000","message":"Agree. You are right.\nThe patch set is the first step which deploy one OSD with 3 devices. In this case, block.wal, block.db and block are located among three disks.\nWhen using one or two disks, it is not needed to create block.db or block.wal. This part will be ready soon.","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3f8c13c71b8331e26ba96f71f9158e8a562af24d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    if [[ \"${OSD_STORETYPE}\" \u003d\u003d \"filestore\" ]]; then"},{"line_number":54,"context_line":"        OSD_ID\u003d$(ceph osd create)"},{"line_number":55,"context_line":"        OSD_DIR\u003d\"/var/lib/ceph/osd/ceph-${OSD_ID}\""},{"line_number":56,"context_line":"        mkdir -p \"${OSD_DIR}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_10857e08","line":53,"updated":"2018-05-09 07:33:33.000000000","message":"ditto.","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"ba4b96caf76d43cd51fc9ac25e39dd2ab3c0ccce","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    if [[ \"${OSD_STORETYPE}\" \u003d\u003d \"filestore\" ]]; then"},{"line_number":54,"context_line":"        OSD_ID\u003d$(ceph osd create)"},{"line_number":55,"context_line":"        OSD_DIR\u003d\"/var/lib/ceph/osd/ceph-${OSD_ID}\""},{"line_number":56,"context_line":"        mkdir -p \"${OSD_DIR}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_70cb921d","line":53,"in_reply_to":"5f7c97a3_10857e08","updated":"2018-05-10 05:22:09.000000000","message":"Will update.","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3f8c13c71b8331e26ba96f71f9158e8a562af24d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    ceph osd crush add \"${OSD_ID}\" \"${OSD_INITIAL_WEIGHT}\" host\u003d\"${HOSTNAME}${CEPH_ROOT_NAME:+-${CEPH_ROOT_NAME}}\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # Setting partition name based on ${OSD_ID}"},{"line_number":116,"context_line":"    if [[ \"${OSD_STORETYPE}\" \u003d\u003d \"filestore\" ]]; then"},{"line_number":117,"context_line":"        sgdisk \"--change-name\u003d${OSD_PARTITION_NUM}:KOLLA_CEPH_DATA_${OSD_ID}\" \"--typecode\u003d${OSD_PARTITION_NUM}:${CEPH_OSD_TYPE_CODE}\" -- \"${OSD_DEV}\""},{"line_number":118,"context_line":"        sgdisk \"--change-name\u003d${JOURNAL_PARTITION_NUM}:KOLLA_CEPH_DATA_${OSD_ID}_J\" \"--typecode\u003d${JOURNAL_PARTITION_NUM}:${CEPH_JOURNAL_TYPE_CODE}\" -- \"${JOURNAL_DEV}\""},{"line_number":119,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_109a5e62","line":116,"updated":"2018-05-09 07:33:33.000000000","message":"ditto.","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"ba4b96caf76d43cd51fc9ac25e39dd2ab3c0ccce","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    ceph osd crush add \"${OSD_ID}\" \"${OSD_INITIAL_WEIGHT}\" host\u003d\"${HOSTNAME}${CEPH_ROOT_NAME:+-${CEPH_ROOT_NAME}}\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # Setting partition name based on ${OSD_ID}"},{"line_number":116,"context_line":"    if [[ \"${OSD_STORETYPE}\" \u003d\u003d \"filestore\" ]]; then"},{"line_number":117,"context_line":"        sgdisk \"--change-name\u003d${OSD_PARTITION_NUM}:KOLLA_CEPH_DATA_${OSD_ID}\" \"--typecode\u003d${OSD_PARTITION_NUM}:${CEPH_OSD_TYPE_CODE}\" -- \"${OSD_DEV}\""},{"line_number":118,"context_line":"        sgdisk \"--change-name\u003d${JOURNAL_PARTITION_NUM}:KOLLA_CEPH_DATA_${OSD_ID}_J\" \"--typecode\u003d${JOURNAL_PARTITION_NUM}:${CEPH_JOURNAL_TYPE_CODE}\" -- \"${JOURNAL_DEV}\""},{"line_number":119,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_30d51aba","line":116,"in_reply_to":"5f7c97a3_109a5e62","updated":"2018-05-10 05:22:09.000000000","message":"Will update.","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3f8c13c71b8331e26ba96f71f9158e8a562af24d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"OSD_DIR\u003d\"/var/lib/ceph/osd/ceph-${OSD_ID}\""},{"line_number":128,"context_line":"if [[ \"${OSD_STORETYPE}\" \u003d\u003d \"filestore\" ]]; then"},{"line_number":129,"context_line":"    ARGS\u003d\"-i ${OSD_ID} --osd-journal ${JOURNAL_PARTITION} -k ${OSD_DIR}/keyring\""},{"line_number":130,"context_line":"else"},{"line_number":131,"context_line":"    ARGS\u003d\"-i ${OSD_ID}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_f09ec252","line":128,"updated":"2018-05-09 07:33:33.000000000","message":"ditto.","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"ba4b96caf76d43cd51fc9ac25e39dd2ab3c0ccce","unresolved":false,"context_lines":[{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"OSD_DIR\u003d\"/var/lib/ceph/osd/ceph-${OSD_ID}\""},{"line_number":128,"context_line":"if [[ \"${OSD_STORETYPE}\" \u003d\u003d \"filestore\" ]]; then"},{"line_number":129,"context_line":"    ARGS\u003d\"-i ${OSD_ID} --osd-journal ${JOURNAL_PARTITION} -k ${OSD_DIR}/keyring\""},{"line_number":130,"context_line":"else"},{"line_number":131,"context_line":"    ARGS\u003d\"-i ${OSD_ID}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_f0d6c2c3","line":128,"in_reply_to":"5f7c97a3_f09ec252","updated":"2018-05-10 05:22:09.000000000","message":"Will update.","commit_id":"fa591af428a416acd0220e560296d0e551196d3f"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"6f4f5560b709f108fd8480e9c05d65ed2b3e3860","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            if [ -n \"${OSD_BS_WAL_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_WAL_DEV}\" ]; then"},{"line_number":33,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_WAL_DEV}\""},{"line_number":34,"context_line":"                sgdisk --new\u003d1:0:+576M --mbrtogpt -- \"${OSD_BS_WAL_DEV}\""},{"line_number":35,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_WAL_DEV}\"1"},{"line_number":36,"context_line":"            fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"            if [ -n \"${OSD_BS_DB_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_DB_DEV}\" ]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_680a3920","line":35,"updated":"2018-05-16 08:45:07.000000000","message":"I think there is no need to initialize the wal and db partitions. We use the user-supplied disk partitions. The user can define the size of this corresponding partition.","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"3ff247124d902043a26ca6e7884cb906af04654a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            if [ -n \"${OSD_BS_WAL_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_WAL_DEV}\" ]; then"},{"line_number":33,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_WAL_DEV}\""},{"line_number":34,"context_line":"                sgdisk --new\u003d1:0:+576M --mbrtogpt -- \"${OSD_BS_WAL_DEV}\""},{"line_number":35,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_WAL_DEV}\"1"},{"line_number":36,"context_line":"            fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"            if [ -n \"${OSD_BS_DB_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_DB_DEV}\" ]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_b48f3974","line":35,"in_reply_to":"5f7c97a3_680a3920","updated":"2018-05-17 05:58:37.000000000","message":"Thanks a lot for the comments. :)\nInitialize block.db and block.wal by Kolla, it is the same as Ceph filestore OSD. In filestore Kolla creates 5G partition for OSD journal. 5G is the default size recommended in Ceph.\nIn bluestore, 576M is the default size of block.wal and 1G is the default size of block.db when block.wal and block.db are not in the same device as block.\nRegarding the above reasons, Kolla creates the block.wal and block.db partitions to avoid some risks.","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"326bdd0cb326130da4077290b3c751655b2b6e08","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            if [ -n \"${OSD_BS_WAL_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_WAL_DEV}\" ]; then"},{"line_number":33,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_WAL_DEV}\""},{"line_number":34,"context_line":"                sgdisk --new\u003d1:0:+576M --mbrtogpt -- \"${OSD_BS_WAL_DEV}\""},{"line_number":35,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_WAL_DEV}\"1"},{"line_number":36,"context_line":"            fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"            if [ -n \"${OSD_BS_DB_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_DB_DEV}\" ]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_f4a05194","line":35,"in_reply_to":"5f7c97a3_b48f3974","updated":"2018-05-17 06:28:12.000000000","message":"Thank you for your detailed reply ^^.\nIn the filestore, if users do not specify a jouranl partition, kolla will use the default partition size, which is 5G. If the user specifies a partition, kolla uses only the user-specified portion. In bluestore, db and wal are not necessarily selected, so if the user specifies the disk size, then we should use the user-specified disk partitions, such as a disk can be divided into multiple partitions for multiple osd use. Users who use db and wal should refer to ceph\u0027s documentation to determine the appropriate size.","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"6f4f5560b709f108fd8480e9c05d65ed2b3e3860","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            if [ -n \"${OSD_BS_DB_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_DB_DEV}\" ]; then"},{"line_number":39,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_DB_DEV}\""},{"line_number":40,"context_line":"                sgdisk --new\u003d1:0:+1G --mbrtogpt -- \"${OSD_BS_DB_DEV}\""},{"line_number":41,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_DB_DEV}\"1"},{"line_number":42,"context_line":"            fi"},{"line_number":43,"context_line":"        else"},{"line_number":44,"context_line":"            sgdisk --zap-all -- \"${OSD_DEV}\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_882a357c","line":41,"updated":"2018-05-16 08:45:07.000000000","message":"Same as above.","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"3ff247124d902043a26ca6e7884cb906af04654a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            if [ -n \"${OSD_BS_DB_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_DB_DEV}\" ]; then"},{"line_number":39,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_DB_DEV}\""},{"line_number":40,"context_line":"                sgdisk --new\u003d1:0:+1G --mbrtogpt -- \"${OSD_BS_DB_DEV}\""},{"line_number":41,"context_line":"                sgdisk --zap-all -- \"${OSD_BS_DB_DEV}\"1"},{"line_number":42,"context_line":"            fi"},{"line_number":43,"context_line":"        else"},{"line_number":44,"context_line":"            sgdisk --zap-all -- \"${OSD_DEV}\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_34f1e902","line":41,"in_reply_to":"5f7c97a3_882a357c","updated":"2018-05-17 05:58:37.000000000","message":"The same as the above.","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"6f4f5560b709f108fd8480e9c05d65ed2b3e3860","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # creates the key in the next step."},{"line_number":64,"context_line":"        ceph-osd -i \"${OSD_ID}\" --mkkey"},{"line_number":65,"context_line":"        echo \"bluestore\" \u003e \"${OSD_DIR}\"/type"},{"line_number":66,"context_line":"        sgdisk \"--change-name\u003d2:KOLLA_CEPH_DATA_BS_B_${OSD_ID}\" \"--typecode\u003d2:${CEPH_OSD_TYPE_CODE}\" -- \"${OSD_BS_BLOCK_DEV}\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if [ -n \"${OSD_BS_WAL_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_WAL_DEV}\" ]; then"},{"line_number":69,"context_line":"            sgdisk \"--change-name\u003d1:KOLLA_CEPH_DATA_BS_W_${OSD_ID}\" \"--typecode\u003d1:${CEPH_OSD_BS_WAL_TYPE_CODE}\" -- \"${OSD_BS_WAL_DEV}\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_8886b565","line":66,"updated":"2018-05-16 08:45:07.000000000","message":"In filestore, the disk name as this:\n```\n 1     10487808    209715166     95G  unknown         KOLLA_CEPH_DATA_1\n 2         2048     10487807      5G  unknown         KOLLA_CEPH_DATA_1_J\n```\nSo I think the best naming convention is:\n```\nKOLLA_CEPH_DATA_BS_${OSD_ID}_B\n```","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"6f4f5560b709f108fd8480e9c05d65ed2b3e3860","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        partprobe || true"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        ln -sf /dev/disk/by-partlabel/KOLLA_CEPH_DATA_BS_B_\"${OSD_ID}\" \"${OSD_DIR}\"/block"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if [ -n \"${OSD_BS_WAL_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_WAL_DEV}\" ]; then"},{"line_number":81,"context_line":"            ln -sf /dev/disk/by-partlabel/KOLLA_CEPH_DATA_BS_W_\"${OSD_ID}\" \"${OSD_DIR}\"/block.wal"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_a894d137","line":78,"updated":"2018-05-16 08:45:07.000000000","message":"Here you use by-partlabel to establish a symbolic links, and ceph-disk uses by-partuuid. If you use partuuid, the changes in find_disks.py may be easier.","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"3ff247124d902043a26ca6e7884cb906af04654a","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        partprobe || true"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        ln -sf /dev/disk/by-partlabel/KOLLA_CEPH_DATA_BS_B_\"${OSD_ID}\" \"${OSD_DIR}\"/block"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if [ -n \"${OSD_BS_WAL_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLOCK_DEV}\" !\u003d \"${OSD_BS_WAL_DEV}\" ]; then"},{"line_number":81,"context_line":"            ln -sf /dev/disk/by-partlabel/KOLLA_CEPH_DATA_BS_W_\"${OSD_ID}\" \"${OSD_DIR}\"/block.wal"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_5444a51b","line":78,"in_reply_to":"5f7c97a3_a894d137","updated":"2018-05-17 05:58:37.000000000","message":"In Ceph bluestore OSD, up to three disks can be allocated to one OSD. The label name is the only hint used to gather all disks belong to the same OSD (please refer to specs/kolla-ceph-bluestore.rst). \n\nThe functions in find_disks.py has to take partition label and process it. From this point, partlabel is better.\n\nIn fact, both partuuid and partlabel are supported in Ceph.","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"6f4f5560b709f108fd8480e9c05d65ed2b3e3860","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    # Setting partition name based on ${OSD_ID}"},{"line_number":129,"context_line":"    if [[ \"${OSD_STORETYPE}\" \u003d\u003d \"bluestore\" ]]; then"},{"line_number":130,"context_line":"        sgdisk \"--change-name\u003d1:KOLLA_CEPH_BSDATA_${OSD_ID}\" -- \"${OSD_BS_BLOCK_DEV}\""},{"line_number":131,"context_line":"    else"},{"line_number":132,"context_line":"        sgdisk \"--change-name\u003d${OSD_PARTITION_NUM}:KOLLA_CEPH_DATA_${OSD_ID}\" \"--typecode\u003d${OSD_PARTITION_NUM}:${CEPH_OSD_TYPE_CODE}\" -- \"${OSD_DEV}\""},{"line_number":133,"context_line":"        sgdisk \"--change-name\u003d${JOURNAL_PARTITION_NUM}:KOLLA_CEPH_DATA_${OSD_ID}_J\" \"--typecode\u003d${JOURNAL_PARTITION_NUM}:${CEPH_JOURNAL_TYPE_CODE}\" -- \"${JOURNAL_DEV}\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_28a0c18f","line":130,"updated":"2018-05-16 08:45:07.000000000","message":"I think the name of data is better like this:\nKOLLA_CEPH_DATA_BS_2","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"}],"docker/kolla-toolbox/find_disks.py":[{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"6f4f5560b709f108fd8480e9c05d65ed2b3e3860","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    yield kwargs"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"def extract_disk_info_bs(ct, dev, name, use_udev):"},{"line_number":192,"context_line":"    if not dev:"},{"line_number":193,"context_line":"        return"},{"line_number":194,"context_line":"    kwargs \u003d dict()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_a81931d7","line":191,"updated":"2018-05-16 08:45:07.000000000","message":"This part of the code I think is a bit complicated to implement, and is not the same as the filestore disk acquisition style. It can be done more simply.","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24574,"name":"Tone Zhang","email":"tone.zhang@arm.com","username":"tone.zhang"},"change_message_id":"3ff247124d902043a26ca6e7884cb906af04654a","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    yield kwargs"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"def extract_disk_info_bs(ct, dev, name, use_udev):"},{"line_number":192,"context_line":"    if not dev:"},{"line_number":193,"context_line":"        return"},{"line_number":194,"context_line":"    kwargs \u003d dict()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_d468b588","line":191,"in_reply_to":"5f7c97a3_a81931d7","updated":"2018-05-17 05:58:37.000000000","message":"Thanks for the comments.\n\nThe function is used to abstract disks\u0027 information. It is not the same as filestore because that we need to find up to three disks belong to the same bluestore OSD only according to the partition label name.","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"326bdd0cb326130da4077290b3c751655b2b6e08","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    yield kwargs"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"def extract_disk_info_bs(ct, dev, name, use_udev):"},{"line_number":192,"context_line":"    if not dev:"},{"line_number":193,"context_line":"        return"},{"line_number":194,"context_line":"    kwargs \u003d dict()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_14f5cd83","line":191,"in_reply_to":"5f7c97a3_d468b588","updated":"2018-05-17 06:28:12.000000000","message":"Yes, tags are the only way to collect all the information belonging to osd\u0027s disk. In my patch I use partuuid and keep the collection method consistent with the filestore.\n\nhttps://review.openstack.org/#/c/568407/2/docker/kolla-toolbox/find_disks.py","commit_id":"0d2caf777dc118fd967effae0aaac24d8f728cba"}]}