)]}'
{"docker/keystone/keystone/Dockerfile.j2":[{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"b2f022152edf68f416001a2f21df917256129f05","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":13,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":14,"context_line":"        {% set keystone_base_packages \u003d ["},{"line_number":15,"context_line":"            \u0027mod_auth_kerb\u0027,"},{"line_number":16,"context_line":"            \u0027python-requests-kerberos\u0027,"},{"line_number":17,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_7a78682a","line":14,"updated":"2018-05-21 13:55:22.000000000","message":"keystone_base_packages is used in ./docker/keystone/keystone-base/Dockerfile.j2, how about to use other var name?","commit_id":"45fb5b8df4fc7a32c5a170e2e1471300d15b0c29"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"89c615da3e91352e9e51e0e838bcbf92307b73ae","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":13,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":14,"context_line":"        {% set keystone_base_packages \u003d ["},{"line_number":15,"context_line":"            \u0027mod_auth_kerb\u0027,"},{"line_number":16,"context_line":"            \u0027python-requests-kerberos\u0027,"},{"line_number":17,"context_line":"        ] %}"},{"line_number":18,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"        {% set keystone_base_packages \u003d ["},{"line_number":20,"context_line":"            \u0027libapache2-mod-auth-kerb\u0027,"},{"line_number":21,"context_line":"            \u0027python-requests-kerberos\u0027,"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":"    {% endif %}"},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":26,"context_line":"        {% set keystone_base_packages \u003d ["},{"line_number":27,"context_line":"            \u0027mod_auth_kerb\u0027,"},{"line_number":28,"context_line":"        ] %}"},{"line_number":29,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":30,"context_line":"        {% set keystone_base_packages \u003d ["},{"line_number":31,"context_line":"            \u0027libapache2-mod-auth-kerb\u0027,"},{"line_number":32,"context_line":"        ] %}"},{"line_number":33,"context_line":"    {% endif %}"},{"line_number":34,"context_line":"ADD plugins-archive /"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% set keystone_plugins_pip_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_3abaf009","line":33,"range":{"start_line":14,"start_character":0,"end_line":33,"end_character":15},"updated":"2018-05-21 13:27:40.000000000","message":"packages are not installed in the macros.install_packages","commit_id":"45fb5b8df4fc7a32c5a170e2e1471300d15b0c29"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"a32b437f75ccb5a044e3e8d70026519f7f6d9d4e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027libapache2-mod-auth-kerb\u0027,"},{"line_number":33,"context_line":"        ] %}"},{"line_number":34,"context_line":"    {% endif %}"},{"line_number":35,"context_line":"{{ macros.install_packages(keystone_packages | customizable(\"packages\")) }}"},{"line_number":36,"context_line":"ADD plugins-archive /"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{% set keystone_plugins_pip_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_e5961095","line":35,"updated":"2018-05-22 05:37:00.000000000","message":"Looks like we just skip oracle distro here. Or maybe add TODO/FIXME notes.\n\n\nI tried install it in Oracle Distro:\n[root@905a76b5e068 oracle]# yum install mod_auth_kerb\nLoaded plugins: ovl, priorities\n6 packages excluded due to repository priority protections\nResolving Dependencies\n--\u003e Running transaction check\n---\u003e Package mod_auth_kerb.x86_64 0:5.4-28.el7 will be installed\n--\u003e Processing Dependency: httpd-mmn \u003d 20120211-x86-64 for package: mod_auth_kerb-5.4-28.el7.x86_64\n--\u003e Finished Dependency Resolution\nError: Package: mod_auth_kerb-5.4-28.el7.x86_64 (ol7_latest)\n           Requires: httpd-mmn \u003d 20120211-x86-64\n           Installed: httpd-2.4.6-80.0.1.el7.x86_64 (@ol7_latest)\n               httpd-mmn \u003d 20120211\n               httpd-mmn \u003d 20120211x8664\n               httpd-mmn \u003d 20120211-x86-64\n           Available: httpd-2.4.6-17.0.1.el7.x86_64 (ol7_latest)\n               httpd-mmn \u003d 20120211-x86-64\n\n\n\nBut very strange thing is if I yum install with full link , it could pass dependency problem:\n\n()[root@905a76b5e068 oracle]# yum install https://yum.oracle.com/repo/OracleLinux/OL7/latest/x86_64/getPackage/mod_auth_kerb-5.4-28.el7.x86_64.rpm\nLoaded plugins: ovl, priorities\nmod_auth_kerb-5.4-28.el7.x86_64.rpm                                         |  32 kB  00:00:00\nExamining /var/tmp/yum-root-CwCurS/mod_auth_kerb-5.4-28.el7.x86_64.rpm: mod_auth_kerb-5.4-28.el7.x86_64\nMarking /var/tmp/yum-root-CwCurS/mod_auth_kerb-5.4-28.el7.x86_64.rpm to be installed\nResolving Dependencies\n--\u003e Running transaction check\n---\u003e Package mod_auth_kerb.x86_64 0:5.4-28.el7 will be installed\n--\u003e Finished Dependency Resolution\n\nDependencies Resolved\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n Package             Arch         Version             Repository                              Size\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nInstalling:\n mod_auth_kerb       x86_64       5.4-28.el7          /mod_auth_kerb-5.4-28.el7.x86_64        66 k\n\nTransaction Summary\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nInstall  1 Package\n\nTotal size: 66 k\nInstalled size: 66 k\n\nI had not figured out why, but we need to support oracle here in my mind.","commit_id":"50f9c0cacd05069a6d3ef92f96c9160757363983"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"97ee44ed1e44c31ecbd7a069a8e6ec0f4f8b9e2a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"        {% set keystone_packages \u003d ["},{"line_number":16,"context_line":"            \u0027mod_auth_kerb\u0027,"},{"line_number":17,"context_line":"            \u0027python-requests-kerberos\u0027,"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set keystone_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_aa40d236","line":17,"updated":"2018-05-23 08:18:57.000000000","message":"How does requests-kerberos get installed for the source install type?","commit_id":"688fa8bcf739c8712214fb85cbe0766828e50356"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"865f370905305baee1393827d69d17f63da845e6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"        {% set keystone_packages \u003d ["},{"line_number":16,"context_line":"            \u0027mod_auth_kerb\u0027,"},{"line_number":17,"context_line":"            \u0027python-requests-kerberos\u0027,"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set keystone_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_6a54faca","line":17,"in_reply_to":"5f7c97a3_0a81c64a","updated":"2018-05-23 08:34:33.000000000","message":"It should be possible to add requests-kerberos to keystone_plugins_pip_packages below. That would make the binary and source images more consistent.","commit_id":"688fa8bcf739c8712214fb85cbe0766828e50356"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"12a2631ab75aff5abf18ab69252d43ada3e537ca","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"        {% set keystone_packages \u003d ["},{"line_number":16,"context_line":"            \u0027mod_auth_kerb\u0027,"},{"line_number":17,"context_line":"            \u0027python-requests-kerberos\u0027,"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set keystone_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_aa7692d7","line":17,"in_reply_to":"5f7c97a3_6a54faca","updated":"2018-05-23 09:24:55.000000000","message":"how\u0027s the syntax for that?","commit_id":"688fa8bcf739c8712214fb85cbe0766828e50356"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"28abd9f179579ce17a8c5bf2820fbf14556c22b7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"        {% set keystone_packages \u003d ["},{"line_number":16,"context_line":"            \u0027mod_auth_kerb\u0027,"},{"line_number":17,"context_line":"            \u0027python-requests-kerberos\u0027,"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set keystone_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_0a81c64a","line":17,"in_reply_to":"5f7c97a3_aa40d236","updated":"2018-05-23 08:26:19.000000000","message":"It CAN come from pip, so I didn\u0027t know what to do with it. I\u0027m not really using source installs :/","commit_id":"688fa8bcf739c8712214fb85cbe0766828e50356"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3f427e37cca803f76aae16f0fb59b3c0d6271e09","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"        {% set keystone_packages \u003d ["},{"line_number":16,"context_line":"            \u0027mod_auth_kerb\u0027,"},{"line_number":17,"context_line":"            \u0027python-requests-kerberos\u0027,"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set keystone_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_ea132a65","line":17,"in_reply_to":"5f7c97a3_aa7692d7","updated":"2018-05-23 09:30:21.000000000","message":"It\u0027s just a list of python packages to install, so:\n\n{% set keystone_plugins_pip_packages \u003d [\n    \u0027/plugins/*\u0027,\n    \u0027requests-kerberos\u0027,\n] %}","commit_id":"688fa8bcf739c8712214fb85cbe0766828e50356"}]}
