)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"91eb93f601f513abef4ecc4d40099eb67618adcd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The openstack-manila-ui package in RDO doesn\u0027t include the python plugin"},{"line_number":10,"context_line":"scripts in its enabled directory as they are moved rather than copied"},{"line_number":11,"context_line":"into /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change copies the plugins into the manila_ui python package"},{"line_number":14,"context_line":"directory before they are removed from /usr/share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_216e8996","line":11,"updated":"2018-06-04 09:07:12.000000000","message":"I\u0027m thinking it would be better (if possible) to have the rpm packaging to symlink the scripts to /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/ rather than moving them.","commit_id":"5180c5fae0bdc9ae6f52169788b578a267972b98"}],"docker/horizon/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"91eb93f601f513abef4ecc4d40099eb67618adcd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \u0026\u0026 sed -i \"s|WEBROOT \u003d \u0027/dashboard/\u0027|WEBROOT \u003d \u0027/\u0027|\" /etc/openstack-dashboard/local_settings \\"},{"line_number":43,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \\"},{"line_number":44,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_18*.py* /usr/lib/python2.7/site-packages/sahara_dashboard/enabled/ \\"},{"line_number":45,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_{80,90*}_manila_*.py* /usr/lib/python2.7/site-packages/manila_ui/local/enabled/ \\"},{"line_number":46,"context_line":"    \u0026\u0026 rm -f /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/?[^_]*.py* \\"},{"line_number":47,"context_line":"    \u0026\u0026 rm -f /usr/lib/python2.7/site-packages/openstack_dashboard/local/enabled/?[^_]*.py* \\"},{"line_number":48,"context_line":"    \u0026\u0026 for locale in /usr/lib/python2.7/site-packages/*/locale; do \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_41daa54b","line":45,"updated":"2018-06-04 09:07:12.000000000","message":"This will break if for some reason we chose to build horizon image without manila plugin. I\u0027m wondering if a better solution wouldn\u0027t be to change the openstack-manila-ui packaging instead. It seems it\u0027s not consistent with the other horizon plugins, sahara being another exception that needs to be fixed.\n\nWe should at the very least make sure the image can build without openstack-manila-ui.","commit_id":"5180c5fae0bdc9ae6f52169788b578a267972b98"}]}