)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a4f163c0a4d5cc5b16211a71959a5ad8d7e0dafe","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        \u0027grafana.repo\u0027,"},{"line_number":78,"context_line":"        \u0027influxdb.repo\u0027,"},{"line_number":79,"context_line":"        \u0027kibana.yum.repo\u0027,"},{"line_number":80,"context_line":"        \u0027logstash.repo\u0027,"},{"line_number":81,"context_line":"        \u0027nfs_ganesha.repo\u0027,"},{"line_number":82,"context_line":"        \u0027opendaylight.repo\u0027,"},{"line_number":83,"context_line":"        \u0027sensu.repo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_af43c9af","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":18},"updated":"2018-06-11 13:02:00.000000000","message":"logstash is noarch so please add it also to aarch64 block","commit_id":"ecb2d225f31087e004e6d7646389731b0b5383a6"}],"docker/logstash/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b65e4fd678e61500a757893bbd0fce8ac5842ba5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u0027java-1.8.0-openjdk\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":"        ENV JAVA_HOME /usr/lib/jvm/jre-1.8.0-openjdk/"},{"line_number":17,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"        RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":20,"context_line":"            \u0026\u0026 /bin/false"},{"line_number":21,"context_line":"    {% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":24,"context_line":"    RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_4be22ed7","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":15},"updated":"2018-06-11 07:55:29.000000000","message":"can we have a logstash build for debian distros?\npackages exists, kolla is a multi distro project. If packages exists please add supprot for other distros","commit_id":"9b24bb7dfbb55fc6392348ab4218b41cda7db65e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b65e4fd678e61500a757893bbd0fce8ac5842ba5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \u0026\u0026 /bin/false"},{"line_number":21,"context_line":"    {% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":24,"context_line":"    RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":25,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_6bc12a2f","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":17},"updated":"2018-06-11 07:55:29.000000000","message":"logsstash is not an openstack service, so binary builds are for both binary and source installs, this block can be removed and let  the difference only between distributions","commit_id":"9b24bb7dfbb55fc6392348ab4218b41cda7db65e"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"045dbb1164a5b643ec98c0eaaefc0932c06bfa38","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":"    {% set logstash_packages \u003d ["},{"line_number":12,"context_line":"        \u0027logstash\u0027,"},{"line_number":13,"context_line":"        \u0027java-1.8.0-openjdk\u0027"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ENV JAVA_HOME /usr/lib/jvm/jre-1.8.0-openjdk/"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_352b5a7c","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":27},"updated":"2018-07-09 10:46:49.000000000","message":"Have you considered using the headless JRE? This should help save space on the container image.","commit_id":"ecb2d225f31087e004e6d7646389731b0b5383a6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5dcbded512454492bbcc82b70ec824c5f200ff32","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        \u0027openjdk-8-jre\u0027"},{"line_number":22,"context_line":"    ] %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64/"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_1d69d723","line":24,"range":{"start_line":24,"start_character":48,"end_line":24,"end_character":48},"updated":"2018-06-11 13:08:21.000000000","message":"please take JAVA_HOME from elasticsearch/Dockerfile.j2 to take care of !x86 archs","commit_id":"ecb2d225f31087e004e6d7646389731b0b5383a6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5f89cf399edf27de8be7b087a4c9450f84c600e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ARG java_arch\u003d{{ base_arch }}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-${java_arch}/"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_f9105d51","line":32,"updated":"2018-07-10 13:29:03.000000000","message":"Just a thought: does it makes sense to add a java-base image now that we have a few of these?","commit_id":"843ac41c545e7ee726d6c50e0152f0aa753c9983"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e2c06cea7cd6e863ab7ed950bee7ad75e7aee976","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ARG java_arch\u003d{{ base_arch }}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-${java_arch}/"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_d9a00139","line":32,"in_reply_to":"5f7c97a3_f9105d51","updated":"2018-07-10 14:53:11.000000000","message":"+1, although i\u0027d be good to do an audit to make sure everything is version agnositic.","commit_id":"843ac41c545e7ee726d6c50e0152f0aa753c9983"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e508cdb4af3771e6867ae4f38731f7510a83bcb6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ARG java_arch\u003d{{ base_arch }}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-${java_arch}/"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_a8b92c16","line":32,"in_reply_to":"5f7c97a3_f9105d51","updated":"2018-07-11 10:22:38.000000000","message":"good idea","commit_id":"843ac41c545e7ee726d6c50e0152f0aa753c9983"}],"docker/logstash/extend_start.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0261060cc828f23c8b1b62efc2d7f928422f6cac","unresolved":false,"context_lines":[{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"if [[ $(stat -c %a /var/log/kolla/logstash) !\u003d \"755\" ]]; then"},{"line_number":7,"context_line":"    chmod 755 /var/log/kolla/logstash"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_ab467d7a","line":8,"updated":"2018-06-08 15:37:47.000000000","message":"Why this hasn\u0027t been factored out into a script yet I do not know...","commit_id":"0d784ded9e99cf53e84d0791c00cf321abcfac0c"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"55fa479e2b6ebeeac356426718efa53c188ed302","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    mkdir -p /var/log/kolla/logstash"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"if [[ $(stat -c %a /var/log/kolla/logstash) !\u003d \"755\" ]]; then"},{"line_number":7,"context_line":"    chmod 755 /var/log/kolla/logstash"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_398f192b","line":7,"updated":"2018-06-09 20:33:24.000000000","message":"Does the logstash user need to write to this directory as well?","commit_id":"9b24bb7dfbb55fc6392348ab4218b41cda7db65e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b65e4fd678e61500a757893bbd0fce8ac5842ba5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    mkdir -p /var/log/kolla/logstash"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"if [[ $(stat -c %a /var/log/kolla/logstash) !\u003d \"755\" ]]; then"},{"line_number":7,"context_line":"    chmod 755 /var/log/kolla/logstash"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_ebfbfa77","line":7,"in_reply_to":"5f7c97a3_398f192b","updated":"2018-06-11 07:55:29.000000000","message":"yes, all logs are written to kolla dir, where the volumes and permissions exists","commit_id":"9b24bb7dfbb55fc6392348ab4218b41cda7db65e"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2d0ad78f98a203183dab4842cab56e2c04b69122","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    mkdir -p /var/log/kolla/logstash"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"if [[ $(stat -c %a /var/log/kolla/logstash) !\u003d \"755\" ]]; then"},{"line_number":7,"context_line":"    chmod 755 /var/log/kolla/logstash"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f7c97a3_c1c85f56","line":7,"in_reply_to":"5f7c97a3_ebfbfa77","updated":"2018-06-11 09:09:07.000000000","message":"For example, here\u0027s where the permissions get set for Elasticsearch:\n\n\nhttps://github.com/openstack/kolla-ansible/blob/master/ansible/roles/elasticsearch/templates/elasticsearch.json.j2","commit_id":"9b24bb7dfbb55fc6392348ab4218b41cda7db65e"}],"kolla/image/build.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b65e4fd678e61500a757893bbd0fce8ac5842ba5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"zun-base\","},{"line_number":96,"context_line":"    ],"},{"line_number":97,"context_line":"    \u0027centos+source\u0027: ["},{"line_number":98,"context_line":"        \"logstash\","},{"line_number":99,"context_line":"        # TODO(spsurya): remove neutron-server-opendaylight fix below issue"},{"line_number":100,"context_line":"        # https://bugs.launchpad.net/kolla/+bug/1764621"},{"line_number":101,"context_line":"        \"neutron-server-opendaylight\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6befeab0","line":98,"range":{"start_line":98,"start_character":9,"end_line":98,"end_character":17},"updated":"2018-06-11 07:55:29.000000000","message":"can be removed based on previous comments, same for other lines in the file","commit_id":"9b24bb7dfbb55fc6392348ab4218b41cda7db65e"}]}