)]}'
{"docker/kolla-toolbox/find_disks.py":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"2a7e0c31f2e6a71a53bbbdf36bac5644047ac3af","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    if kwargs[\u0027store_type\u0027] \u003d\u003d \"bluestore\":"},{"line_number":168,"context_line":"        block_name \u003d dev_name + \u0027_B\u0027"},{"line_number":169,"context_line":"        if block_name.endswith(\"_B_B\") or block_name.endswith(\"_D_B\")\\"},{"line_number":170,"context_line":"                or block_name.endswith(\"_W_B\"):"},{"line_number":171,"context_line":"            return"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_9ba68f54","line":169,"range":{"start_line":169,"start_character":69,"end_line":169,"end_character":70},"updated":"2018-07-26 15:42:38.000000000","message":"put a space","commit_id":"49b1ab0023fd21e41e4615cf014ba9c5cf777999"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"6dcfaf51d70633e62e0a2d101d474c3e12bc51ce","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    if kwargs[\u0027store_type\u0027] \u003d\u003d \"bluestore\":"},{"line_number":168,"context_line":"        block_name \u003d dev_name + \u0027_B\u0027"},{"line_number":169,"context_line":"        if block_name.endswith(\"_B_B\") or block_name.endswith(\"_D_B\")\\"},{"line_number":170,"context_line":"                or block_name.endswith(\"_W_B\"):"},{"line_number":171,"context_line":"            return"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_5d06fd76","line":169,"range":{"start_line":169,"start_character":69,"end_line":169,"end_character":70},"in_reply_to":"5f7c97a3_9ba68f54","updated":"2018-08-03 07:57:07.000000000","message":"Thanks for reminding.","commit_id":"49b1ab0023fd21e41e4615cf014ba9c5cf777999"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"2a7e0c31f2e6a71a53bbbdf36bac5644047ac3af","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                or block_name.endswith(\"_W_B\"):"},{"line_number":171,"context_line":"            return"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        if is_dev_matched_by_name(dev, name, \u0027strict\u0027, use_udev):"},{"line_number":174,"context_line":"            exist_osd_suffix \u003d False"},{"line_number":175,"context_line":"            if int(kwargs[\u0027osd_partition_num\u0027]) !\u003d 1:"},{"line_number":176,"context_line":"                # NOTE(WangWei): If the partition label is KOLLA_CEPH_OSD_BOOT"},{"line_number":177,"context_line":"                # STRAP_BS, then kolla will automatically initialize the"},{"line_number":178,"context_line":"                # entire disk, please make sure the osd_partition_num is 1"},{"line_number":179,"context_line":"                return"},{"line_number":180,"context_line":"            kwargs[\u0027use_entire_disk\u0027] \u003d True"},{"line_number":181,"context_line":"            kwargs[\u0027bs_blk_partition\u0027] \u003d dev.device_node[:-1] + \u00272\u0027"},{"line_number":182,"context_line":"            kwargs[\u0027bs_blk_device\u0027] \u003d kwargs[\u0027osd_device\u0027]"},{"line_number":183,"context_line":"            kwargs[\u0027bs_blk_partition_num\u0027] \u003d 2"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            exist_osd_suffix \u003d True"},{"line_number":186,"context_line":"            for block in find_disk(ct, block_name, \u0027strict\u0027, use_udev):"},{"line_number":187,"context_line":"                kwargs[\u0027bs_blk_partition\u0027] \u003d block.device_node"},{"line_number":188,"context_line":"                kwargs[\u0027bs_blk_device\u0027] \u003d \\"},{"line_number":189,"context_line":"                    block.find_parent(\u0027block\u0027).device_node"},{"line_number":190,"context_line":"                kwargs[\u0027bs_blk_partition_num\u0027] \u003d \\"},{"line_number":191,"context_line":"                    re.sub(r\u0027.*[^\\d]\u0027, \u0027\u0027, block.device_node)"},{"line_number":192,"context_line":"                break"},{"line_number":193,"context_line":"            if \u0027bs_blk_partition\u0027 not in kwargs:"},{"line_number":194,"context_line":"                # NOTE(WangWei): If the partition label is KOLLA_CEPH_OSD_"},{"line_number":195,"context_line":"                # BOOTSTRAP_BS_xxx and no block partition was found, then"},{"line_number":196,"context_line":"                # kolla will automatically initialize the entire disk, so make"},{"line_number":197,"context_line":"                # sure the osd_partition_num is 1."},{"line_number":198,"context_line":"                if int(kwargs[\u0027osd_partition_num\u0027]) !\u003d 1:"},{"line_number":199,"context_line":"                    return"},{"line_number":200,"context_line":"                else:"},{"line_number":201,"context_line":"                    kwargs[\u0027use_entire_disk\u0027] \u003d True"},{"line_number":202,"context_line":"                    kwargs[\u0027bs_blk_partition\u0027] \u003d dev.device_node[:-1] + \u00272\u0027"},{"line_number":203,"context_line":"                    kwargs[\u0027bs_blk_device\u0027] \u003d kwargs[\u0027osd_device\u0027]"},{"line_number":204,"context_line":"                    kwargs[\u0027bs_blk_partition_num\u0027] \u003d 2"},{"line_number":205,"context_line":"            else:"},{"line_number":206,"context_line":"                kwargs[\u0027use_entire_disk\u0027] \u003d False"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        # NOTE(WangWei):If the partition label is KOLLA_CEPH_OSD_BOOTSTRAP_BS"},{"line_number":209,"context_line":"        # , it will assume that the wal and db devices are not used. It only"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_35b65edd","line":206,"range":{"start_line":173,"start_character":1,"end_line":206,"end_character":49},"updated":"2018-07-26 15:42:38.000000000","message":"if possible, break this part into into a function, overall function is getting bigger","commit_id":"49b1ab0023fd21e41e4615cf014ba9c5cf777999"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"6dcfaf51d70633e62e0a2d101d474c3e12bc51ce","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                or block_name.endswith(\"_W_B\"):"},{"line_number":171,"context_line":"            return"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        if is_dev_matched_by_name(dev, name, \u0027strict\u0027, use_udev):"},{"line_number":174,"context_line":"            exist_osd_suffix \u003d False"},{"line_number":175,"context_line":"            if int(kwargs[\u0027osd_partition_num\u0027]) !\u003d 1:"},{"line_number":176,"context_line":"                # NOTE(WangWei): If the partition label is KOLLA_CEPH_OSD_BOOT"},{"line_number":177,"context_line":"                # STRAP_BS, then kolla will automatically initialize the"},{"line_number":178,"context_line":"                # entire disk, please make sure the osd_partition_num is 1"},{"line_number":179,"context_line":"                return"},{"line_number":180,"context_line":"            kwargs[\u0027use_entire_disk\u0027] \u003d True"},{"line_number":181,"context_line":"            kwargs[\u0027bs_blk_partition\u0027] \u003d dev.device_node[:-1] + \u00272\u0027"},{"line_number":182,"context_line":"            kwargs[\u0027bs_blk_device\u0027] \u003d kwargs[\u0027osd_device\u0027]"},{"line_number":183,"context_line":"            kwargs[\u0027bs_blk_partition_num\u0027] \u003d 2"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            exist_osd_suffix \u003d True"},{"line_number":186,"context_line":"            for block in find_disk(ct, block_name, \u0027strict\u0027, use_udev):"},{"line_number":187,"context_line":"                kwargs[\u0027bs_blk_partition\u0027] \u003d block.device_node"},{"line_number":188,"context_line":"                kwargs[\u0027bs_blk_device\u0027] \u003d \\"},{"line_number":189,"context_line":"                    block.find_parent(\u0027block\u0027).device_node"},{"line_number":190,"context_line":"                kwargs[\u0027bs_blk_partition_num\u0027] \u003d \\"},{"line_number":191,"context_line":"                    re.sub(r\u0027.*[^\\d]\u0027, \u0027\u0027, block.device_node)"},{"line_number":192,"context_line":"                break"},{"line_number":193,"context_line":"            if \u0027bs_blk_partition\u0027 not in kwargs:"},{"line_number":194,"context_line":"                # NOTE(WangWei): If the partition label is KOLLA_CEPH_OSD_"},{"line_number":195,"context_line":"                # BOOTSTRAP_BS_xxx and no block partition was found, then"},{"line_number":196,"context_line":"                # kolla will automatically initialize the entire disk, so make"},{"line_number":197,"context_line":"                # sure the osd_partition_num is 1."},{"line_number":198,"context_line":"                if int(kwargs[\u0027osd_partition_num\u0027]) !\u003d 1:"},{"line_number":199,"context_line":"                    return"},{"line_number":200,"context_line":"                else:"},{"line_number":201,"context_line":"                    kwargs[\u0027use_entire_disk\u0027] \u003d True"},{"line_number":202,"context_line":"                    kwargs[\u0027bs_blk_partition\u0027] \u003d dev.device_node[:-1] + \u00272\u0027"},{"line_number":203,"context_line":"                    kwargs[\u0027bs_blk_device\u0027] \u003d kwargs[\u0027osd_device\u0027]"},{"line_number":204,"context_line":"                    kwargs[\u0027bs_blk_partition_num\u0027] \u003d 2"},{"line_number":205,"context_line":"            else:"},{"line_number":206,"context_line":"                kwargs[\u0027use_entire_disk\u0027] \u003d False"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        # NOTE(WangWei):If the partition label is KOLLA_CEPH_OSD_BOOTSTRAP_BS"},{"line_number":209,"context_line":"        # , it will assume that the wal and db devices are not used. It only"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_dd6e8d2c","line":206,"range":{"start_line":173,"start_character":1,"end_line":206,"end_character":49},"in_reply_to":"5f7c97a3_35b65edd","updated":"2018-08-03 07:57:07.000000000","message":"You are right, I rewrote this part of the code, please review it, thanks:-)","commit_id":"49b1ab0023fd21e41e4615cf014ba9c5cf777999"}]}