)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"e52aeefdb0f3527a1b84b066813dc3e4e6266b50","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the pre-commit-hook script run failed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. remove the not exists script task"},{"line_number":10,"context_line":"2. fix the dockerfile check script name[0],"},{"line_number":11,"context_line":"it should be validate-all-dockerfiles.sh"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_31206e49","line":9,"updated":"2018-06-24 07:53:03.000000000","message":"Script validate-all-json.sh existed in tools folder.\n\nLIMAO-M-H24G:tools limao$ ls -l validate-all-json.sh\n-rwxr-xr-x  1 limao  staff  219  6 12 15:15 validate-all-json.sh\nLIMAO-M-H24G:tools limao$ pwd\n/Users/limao/WorkSpace/Community/kolla/tools","commit_id":"f51e3a8103fa664a4de74c538c50f7028e903238"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f126d93b8af7a652adccdf3402caee70ab680a94","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the pre-commit-hook script run failed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. remove the not exists script task"},{"line_number":10,"context_line":"2. fix the dockerfile check script name[0],"},{"line_number":11,"context_line":"it should be validate-all-dockerfiles.sh"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_1d09a093","line":9,"updated":"2018-06-26 08:27:46.000000000","message":"The validate-all-json.sh file was indeed merged into validate-all-file.py in https://review.openstack.org/#/c/388851/. Thanks for updating.","commit_id":"f51e3a8103fa664a4de74c538c50f7028e903238"}],"tools/pre-commit-hook":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f126d93b8af7a652adccdf3402caee70ab680a94","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"${TOPLEVEL}/tools/validate-all-yaml.sh || RES\u003d1"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo \"\u003d\u003d\u003d json checks \u003d\u003d\u003d\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"${TOPLEVEL}/tools/validate-all-json.sh || RES\u003d1"},{"line_number":39,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_5dd158f7","side":"PARENT","line":36,"updated":"2018-06-26 08:27:46.000000000","message":"I\u0027m guessing you\u0027re looking at an old branch, in master it is effectively calling validate-all-file.py as it should https://github.com/openstack/kolla/blob/master/tox.ini#L42","commit_id":"b21350f9cb62bc387b883b63c7f0ec2a80708239"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"e52aeefdb0f3527a1b84b066813dc3e4e6266b50","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"${TOPLEVEL}/tools/validate-all-yaml.sh || RES\u003d1"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo \"\u003d\u003d\u003d json checks \u003d\u003d\u003d\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"${TOPLEVEL}/tools/validate-all-json.sh || RES\u003d1"},{"line_number":39,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_91270264","side":"PARENT","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":26},"updated":"2018-06-24 07:53:03.000000000","message":"if we do not need this in pre-commit-hook, do we still need it in tox.ini pep8 check(Line 28)? Thanks.\n\nkolla/tox.ini\n 24 [testenv:pep8]\n 25 commands \u003d\n 26   {toxinidir}/tools/run-bashate.sh\n 27   flake8 {posargs}\n 28   {toxinidir}/tools/validate-all-json.sh\n 29   {toxinidir}/tools/validate-all-yaml.sh\n 30   {toxinidir}/tools/validate-all-dockerfiles.sh","commit_id":"b21350f9cb62bc387b883b63c7f0ec2a80708239"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f126d93b8af7a652adccdf3402caee70ab680a94","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo \"\u003d\u003d\u003d json checks \u003d\u003d\u003d\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"${TOPLEVEL}/tools/validate-all-json.sh || RES\u003d1"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"echo \"\u003d\u003d\u003d dockerfile checks \u003d\u003d\u003d\""},{"line_number":41,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_fd05c47a","side":"PARENT","line":38,"updated":"2018-06-26 08:27:46.000000000","message":"This should now be calling validate-all-file.py","commit_id":"b21350f9cb62bc387b883b63c7f0ec2a80708239"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"4389610d47f4525c24d36ae820c1418acd3a4f51","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo \"\u003d\u003d\u003d json checks \u003d\u003d\u003d\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"${TOPLEVEL}/tools/validate-all-json.sh || RES\u003d1"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"echo \"\u003d\u003d\u003d dockerfile checks \u003d\u003d\u003d\""},{"line_number":41,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_7926386b","side":"PARENT","line":38,"in_reply_to":"5f7c97a3_fd05c47a","updated":"2018-08-31 03:12:22.000000000","message":"json validata has beed move into validate-all-file.py, here remove is ok","commit_id":"b21350f9cb62bc387b883b63c7f0ec2a80708239"}]}