)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3f2c0aca53abde748f1a88b1bc2229ce8c8473be","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin André \u003cm.andre@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-10 10:14:38 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch to headless jre"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3479ac9e74aa9e860cf01db20bd7ab5f5cfc9c1a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_6e04817e","line":7,"updated":"2018-07-10 13:20:14.000000000","message":"nit: commit message could be a little more helpful.","commit_id":"707f91cacfe5ffd119b3763b5cabcb802b122270"}],"docker/opendaylight/Dockerfile.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6a9c321f00849b4743bc447ce0897d04a5aa5fba","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"    {% set opendaylight_packages \u003d ["},{"line_number":14,"context_line":"        \u0027java-1.8.0-openjdk-headless\u0027,"},{"line_number":15,"context_line":"        \u0027opendaylight\u0027,"},{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_c4c6f59c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":8},"updated":"2018-07-09 12:47:36.000000000","message":"So before this change the JDK was implicitly pulled in when opendaylight was installed via the package manager? Was it pulling in the headless version? I\u0027m not very familiar with opendaylight requirements.","commit_id":"caeed4d3555e5da82e8f749fc279d04fcc5ab765"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1727153b1bb657f5210d791e7eea5f917f750076","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"    {% set opendaylight_packages \u003d ["},{"line_number":14,"context_line":"        \u0027java-1.8.0-openjdk-headless\u0027,"},{"line_number":15,"context_line":"        \u0027opendaylight\u0027,"},{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_3467bc26","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":8},"in_reply_to":"5f7c97a3_9407b081","updated":"2018-07-10 14:32:58.000000000","message":"Now I wonder if the other images are also implicitly pulling in the full-fat jdk :)","commit_id":"caeed4d3555e5da82e8f749fc279d04fcc5ab765"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"6d42d63731fe6e8b54aa44b689974f4bef499a44","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"    {% set opendaylight_packages \u003d ["},{"line_number":14,"context_line":"        \u0027java-1.8.0-openjdk-headless\u0027,"},{"line_number":15,"context_line":"        \u0027opendaylight\u0027,"},{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_9407b081","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":8},"in_reply_to":"5f7c97a3_baa512b6","updated":"2018-07-10 14:22:59.000000000","message":"I was wrong, java-1.8.0-openjdk-headless does not provide the  \"java \u003e\u003d 1:1.8.0\" dependency, so opendaylight package still pulls java-1.8.0-openjdk. It\u0027s not too bad since java-1.8.0-openjdk-headless is this time a dep of java-1.8.0-openjdk so we don\u0027t install anything extra. And at least we\u0027ll be ready if they lower their requirements :)","commit_id":"caeed4d3555e5da82e8f749fc279d04fcc5ab765"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"0d8c8f553c8af2a2e98dbbc48f7794ffcc95f26d","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"    {% set opendaylight_packages \u003d ["},{"line_number":14,"context_line":"        \u0027java-1.8.0-openjdk-headless\u0027,"},{"line_number":15,"context_line":"        \u0027opendaylight\u0027,"},{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_baa512b6","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":8},"in_reply_to":"5f7c97a3_c4c6f59c","updated":"2018-07-09 14:18:02.000000000","message":"The opendaylight package has a dependency on \"java \u003e\u003d 1:1.8.0\", and yum selected java-1.8.0-openjdk for it, I haven\u0027t checked the deb package but I suppose it was the same.\n\nSo with this change, we provide the java dep without the overhead of the full java-1.8.0-openjdk package.","commit_id":"caeed4d3555e5da82e8f749fc279d04fcc5ab765"}]}