)]}'
{"docker/elasticsearch/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6f809cee02c0057cf33fff63d1075eb8829fd8f2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    ] %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":25,"context_line":"ARG java_arch\u003damd64"},{"line_number":26,"context_line":"{% elif base_arch \u003d\u003d \u0027aarch64\u0027 %}"},{"line_number":27,"context_line":"ARG java_arch\u003darm64"},{"line_number":28,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_6b29ceef","line":25,"updated":"2018-07-10 15:43:02.000000000","message":"ARG is normally used for passing arguments to dockerfiles via --build-arg. It should be possible to reference a variable using ${var}. Tried this and it worked:\n\nFROM centos:7\nENV foo\u003dbar\nENV foo2\u003d$foo\nRUN echo $foo2","commit_id":"dfa43fab0aff00a67e28e1b9878e8a81282df8a9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"38eaac2def9d110e50e0a65800afb79da7aba973","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ARG java_arch\u003d{{ base_arch }}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-${java_arch}/"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_21c76968","line":32,"updated":"2018-07-11 06:19:33.000000000","message":"agree with mark.\nno need to move to ARG. ENV is more suitable for this cause. the only issue is we should use ${java_arch} rather than {{ java_arch }}","commit_id":"dfa43fab0aff00a67e28e1b9878e8a81282df8a9"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"704362a698418776fefeee9dedb152fcf4d6b99c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ARG java_arch\u003d{{ base_arch }}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-${java_arch}/"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_9e419839","line":32,"in_reply_to":"5f7c97a3_21c76968","updated":"2018-07-16 08:22:18.000000000","message":"Ok - i\u0027ve updated it. My thinking was that java_arch is a build time setting, and we don\u0027t want to set it at run time in the container, but I agree it\u0027s not required to fix the bug.","commit_id":"dfa43fab0aff00a67e28e1b9878e8a81282df8a9"}]}
