)]}'
{"docker/monasca/monasca-thresh/Dockerfile.j2":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"04ac5a42ae71d6d911fda04a81c9052f7a7b599b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}storm:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"USER root"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_df35eea8","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":44},"updated":"2018-07-13 14:23:50.000000000","message":"where is the base image \"storm\"?","commit_id":"d47a0b3a6796a2b78f07a30d51ef89e3f4e00fbf"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"04ac5a42ae71d6d911fda04a81c9052f7a7b599b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}storm:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"USER root"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block monasca_thresh_header %}{% endblock %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_bc5e004f","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":9},"updated":"2018-07-13 14:23:50.000000000","message":"here, do we need to appoint  root user ? i remember the default is \nroot user。","commit_id":"d47a0b3a6796a2b78f07a30d51ef89e3f4e00fbf"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1633a1cd3e83ab4e35fa91263205ecc5d9c821eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}storm:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"USER root"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block monasca_thresh_header %}{% endblock %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_d5014f6f","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":9},"in_reply_to":"5f7c97a3_bc5e004f","updated":"2018-07-13 14:28:10.000000000","message":"Thanks Wu Chunyang, good questions. This change depends on this change: https://review.openstack.org/#/c/580095 which isn\u0027t merged yet. That change provides the storm image. The last thing the storm image does is switch to the storm user. We need to switch back again to root to install stuff.","commit_id":"d47a0b3a6796a2b78f07a30d51ef89e3f4e00fbf"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3129019995d232578345cb444606a7f1f1094c94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}storm:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"USER root"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_8144e6b9","line":1,"updated":"2018-07-15 06:57:56.000000000","message":"since this image is not inherit from monasca-base, you need add this image name into the SKIPPED_IMAGE\n\nhttps://github.com/openstack/kolla/blob/1af3b61856ea564e02cb6e52877380fac3c380c8/kolla/image/build.py","commit_id":"1af3b61856ea564e02cb6e52877380fac3c380c8"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e568e866ac37982fa2ee6477692660d9310a2279","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}storm:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"USER root"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_39ec1e91","line":1,"in_reply_to":"5f7c97a3_8144e6b9","updated":"2018-07-16 09:40:58.000000000","message":"Thanks, done.","commit_id":"1af3b61856ea564e02cb6e52877380fac3c380c8"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c8fa84035b1476efe49d65bd8c56fe065a1e3619","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":18,"context_line":"    {% set monasca_thresh_packages \u003d ["},{"line_number":19,"context_line":"        \u0027maven\u0027,"},{"line_number":20,"context_line":"        \u0027git\u0027"},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ENV JAVA_HOME /usr/lib/jvm/jre-1.8.0-openjdk/"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_38b733da","line":20,"updated":"2018-07-16 14:05:04.000000000","message":"Isn\u0027t git already installed in the base image?","commit_id":"460a49e92787e245d572fd767b3f3093d04794c6"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f8101ee0b1f24acb06cc3f3fd2f4aaeedd551582","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":18,"context_line":"    {% set monasca_thresh_packages \u003d ["},{"line_number":19,"context_line":"        \u0027maven\u0027,"},{"line_number":20,"context_line":"        \u0027git\u0027"},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ENV JAVA_HOME /usr/lib/jvm/jre-1.8.0-openjdk/"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_9851a766","line":20,"in_reply_to":"5f7c97a3_38b733da","updated":"2018-07-16 14:09:27.000000000","message":"Thank Chuck, good spot. Even if it wasn\u0027t this shouldn\u0027t be here because I switched from cloning repos to using tar archives.","commit_id":"460a49e92787e245d572fd767b3f3093d04794c6"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"c8fa84035b1476efe49d65bd8c56fe065a1e3619","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    {% set monasca_thresh_packages \u003d ["},{"line_number":27,"context_line":"        \u0027openjdk-8-jdk-headless\u0027,"},{"line_number":28,"context_line":"        \u0027maven\u0027,"},{"line_number":29,"context_line":"        \u0027git\u0027"},{"line_number":30,"context_line":"    ] %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_d8addf84","line":29,"updated":"2018-07-16 14:05:04.000000000","message":"ditto","commit_id":"460a49e92787e245d572fd767b3f3093d04794c6"}]}