)]}'
{"docker/neutron/neutron-server-opendaylight/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"99c5672d41282cdb70674f74534a8a8d077ae00d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    {% set neutron_server_opendaylight_packages \u003d ["},{"line_number":12,"context_line":"        \u0027python-networking-odl\u0027,"},{"line_number":13,"context_line":"        \u0027python-networking-bgpvpn\u0027,"},{"line_number":14,"context_line":"        \u0027python-networking-bgpvpn-heat\u0027,"},{"line_number":15,"context_line":"        \u0027python-networking-l2gw\u0027"},{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_cb00cc6c","line":14,"updated":"2018-07-25 12:23:32.000000000","message":"need to add the source package for source builds https://github.com/openstack/kolla/blob/master/kolla/common/config.py#L590","commit_id":"e477429028b3ae473caff600ed38326807651861"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c511a098d206c287b74cbad72bafc75ded306523","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    {% set neutron_server_opendaylight_packages \u003d ["},{"line_number":12,"context_line":"        \u0027python-networking-odl\u0027,"},{"line_number":13,"context_line":"        \u0027python-networking-bgpvpn\u0027,"},{"line_number":14,"context_line":"        \u0027python-networking-bgpvpn-heat\u0027,"},{"line_number":15,"context_line":"        \u0027python-networking-l2gw\u0027"},{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_6e28a535","line":14,"in_reply_to":"5f7c97a3_abceb029","updated":"2018-07-25 13:56:05.000000000","message":"python-networking-bgpvpn-heat does not exist for ubuntu, you\u0027ll need to make a if/else branch for the different distros.\n\nTo answer your question, it\u0027s not necessary to do anything for the source install, we already install networking-bgpvpn-master.tar.gz in the source image.","commit_id":"e477429028b3ae473caff600ed38326807651861"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"200400603a5d2629439a2f1fcbbda5577e44af29","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    {% set neutron_server_opendaylight_packages \u003d ["},{"line_number":12,"context_line":"        \u0027python-networking-odl\u0027,"},{"line_number":13,"context_line":"        \u0027python-networking-bgpvpn\u0027,"},{"line_number":14,"context_line":"        \u0027python-networking-bgpvpn-heat\u0027,"},{"line_number":15,"context_line":"        \u0027python-networking-l2gw\u0027"},{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_abceb029","line":14,"in_reply_to":"5f7c97a3_cb00cc6c","updated":"2018-07-25 12:33:38.000000000","message":"Hola Eduardo! :-)\n\nThere is not an specific tar.gz for the bgpvpn heat plugin. We create a subpackage at building time via RPM spec files:\n\nhttp://tarballs.openstack.org/networking-bgpvpn/\n\nDo we need to add that config anyways? Something like this:\n\n     \u0027neutron-server-opendaylight-plugin-networking-bgpvpn-heat\u0027: {                                                                                                                                        \n         \u0027type\u0027: \u0027url\u0027,                                                                                                                                                                                    \n         \u0027location\u0027: (\u0027$tarballs_base/networking-bgpvpn/\u0027                                                                                                                                                  \n                      \u0027networking-bgpvpn-master.tar.gz\u0027)},","commit_id":"e477429028b3ae473caff600ed38326807651861"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8112752523abee4e4e8945d4897efbd2c9c11e64","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    {% set neutron_server_opendaylight_packages \u003d ["},{"line_number":12,"context_line":"        \u0027python-networking-odl\u0027,"},{"line_number":13,"context_line":"        \u0027python-networking-bgpvpn\u0027,"},{"line_number":14,"context_line":"        {% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"            \u0027python-networking-bgpvpn-heat\u0027,"},{"line_number":16,"context_line":"        {% endif %}"},{"line_number":17,"context_line":"        \u0027python-networking-l2gw\u0027"},{"line_number":18,"context_line":"    ] %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_6de1742b","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":19},"updated":"2018-07-26 09:53:27.000000000","message":"better use this layout for a native jinja package addition:\n\n    {% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}\n        {% set neutron_server_opendaylight_packages \u003d neutron_server_opendaylight_packages + [\n            \u0027python-networking-bgpvpn-heat\u0027\n] %}\n{% endif %}\n\nOutside the main {% set","commit_id":"ee964454a487ed1de44f104c3ab4860f1f8f2bdb"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"c72150f1ce2990368c76c17dcbf299e6a3192299","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    {% set neutron_server_opendaylight_packages \u003d ["},{"line_number":12,"context_line":"        \u0027python-networking-odl\u0027,"},{"line_number":13,"context_line":"        \u0027python-networking-bgpvpn\u0027,"},{"line_number":14,"context_line":"        {% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"            \u0027python-networking-bgpvpn-heat\u0027,"},{"line_number":16,"context_line":"        {% endif %}"},{"line_number":17,"context_line":"        \u0027python-networking-l2gw\u0027"},{"line_number":18,"context_line":"    ] %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_0db000dc","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":19},"in_reply_to":"5f7c97a3_6de1742b","updated":"2018-07-26 10:11:19.000000000","message":"Much more elegant, thanks!","commit_id":"ee964454a487ed1de44f104c3ab4860f1f8f2bdb"}]}
