)]}'
{"docker/skydive/skydive-agent/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7108d723b7c52ed8848d389eb7a6606e1a7c082d","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block skydive_agent_install %}"},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"    {% set skydive_agent_packages \u003d [\u0027skydive-agent\u0027, \u0027openvswitch\u0027] %}"},{"line_number":11,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"    {% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":13,"context_line":"RUN echo \u0027{{ install_type }} on {{ base_distro }} not yet available on non x86_64 platforms\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_3eafe92d","line":10,"updated":"2018-07-30 10:31:59.000000000","message":"please split into two lines to be more consistent with other package definition","commit_id":"d5ba6bc460cdc44ba62a1fde862c1f31c4780b94"},{"author":{"_account_id":8994,"name":"Sylvain Baubeau","email":"sbaubeau@redhat.com","username":"lebauce"},"change_message_id":"308daff0f073a6bcf266a499690d40f453f1f44e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block skydive_agent_install %}"},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"    {% set skydive_agent_packages \u003d [\u0027skydive-agent\u0027, \u0027openvswitch\u0027] %}"},{"line_number":11,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"    {% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":13,"context_line":"RUN echo \u0027{{ install_type }} on {{ base_distro }} not yet available on non x86_64 platforms\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_c8d71650","line":10,"in_reply_to":"5f7c97a3_3eafe92d","updated":"2018-07-30 12:41:13.000000000","message":"Done","commit_id":"d5ba6bc460cdc44ba62a1fde862c1f31c4780b94"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"992ecc69dd2e821a3f76fe69e8dc2abe8a6287c2","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block skydive_agent_install %}"},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"    {% set skydive_agent_packages \u003d [\u0027skydive-agent\u0027, \u0027openvswitch\u0027] %}"},{"line_number":11,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"    {% set skydive_agent_packages \u003d [\u0027openvswitch-common\u0027] %}"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_4ac3e88c","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":71},"updated":"2018-07-31 07:16:33.000000000","message":"please use multiline package definition and alphabetize the list:\n\n{% set skydive_agent_packages \u003d [\n     \u0027skydive-agent\u0027,\n     \u0027openvswitch\u0027\n ] %}","commit_id":"7c10f6aca768845ac6398ad96c99c87cbee61e6b"},{"author":{"_account_id":8994,"name":"Sylvain Baubeau","email":"sbaubeau@redhat.com","username":"lebauce"},"change_message_id":"28babe8a58ef68137c68fb442c49eace19e707d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block skydive_agent_install %}"},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"    {% set skydive_agent_packages \u003d [\u0027skydive-agent\u0027, \u0027openvswitch\u0027] %}"},{"line_number":11,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"    {% set skydive_agent_packages \u003d [\u0027openvswitch-common\u0027] %}"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5f7c97a3_8ac26001","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":71},"in_reply_to":"5f7c97a3_4ac3e88c","updated":"2018-07-31 07:44:39.000000000","message":"Done","commit_id":"7c10f6aca768845ac6398ad96c99c87cbee61e6b"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"a16ed44b0a9c8169b293530d146c00348667c741","unresolved":false,"context_lines":[{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"    {% set skydive_agent_packages \u003d ["},{"line_number":11,"context_line":"        \u0027openvswitch\u0027,"},{"line_number":12,"context_line":"        \u0027skydive-agent\u0027"},{"line_number":13,"context_line":"    ] %}"},{"line_number":14,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":"    {% set skydive_agent_packages \u003d [\u0027openvswitch-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_90b8de2a","line":12,"updated":"2018-08-07 12:20:41.000000000","message":"Both skydive-agent and skydive-analyser depend on the skydive package. We should install it in skydive-base image.","commit_id":"496f9771d90b3c090ce625603328f33abf62f4be"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"4f2265e88422549c7942d24afd858017468d3b1d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"    {% set skydive_agent_packages \u003d ["},{"line_number":11,"context_line":"        \u0027openvswitch\u0027,"},{"line_number":12,"context_line":"        \u0027skydive-agent\u0027"},{"line_number":13,"context_line":"    ] %}"},{"line_number":14,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":"    {% set skydive_agent_packages \u003d [\u0027openvswitch-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_f31efc0a","line":12,"in_reply_to":"3f79a3b5_70bd02b6","updated":"2018-08-07 13:15:53.000000000","message":"I\u0027d prefer we have the common packages installed in skydive-base. Think of it as an optimization made possible thanks to the packagers who split their packages into skydive and skydive-{agent,analyzer} packages. The package is quite big (12MB) so if we can install it and its dependency just once, it\u0027s a nice win.\n\nI\u0027m not too worried about skydive package being renamed skydive-common: if done correctly, it\u0027s transparent for us.","commit_id":"496f9771d90b3c090ce625603328f33abf62f4be"},{"author":{"_account_id":8994,"name":"Sylvain Baubeau","email":"sbaubeau@redhat.com","username":"lebauce"},"change_message_id":"ce7e302d6055bf9d7ba0ea0ba354f7558591c0ff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"    {% set skydive_agent_packages \u003d ["},{"line_number":11,"context_line":"        \u0027openvswitch\u0027,"},{"line_number":12,"context_line":"        \u0027skydive-agent\u0027"},{"line_number":13,"context_line":"    ] %}"},{"line_number":14,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":"    {% set skydive_agent_packages \u003d [\u0027openvswitch-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_70bd02b6","line":12,"in_reply_to":"3f79a3b5_90b8de2a","updated":"2018-08-07 12:37:59.000000000","message":"My understanding is that it is a packaging stuff : if you install skydive-agent, all the dependencies should be installed so that it runs properly. Right now, the binary is in the \"skydive\" package, but it could be in \"skydive-common\" some day. So I would prefer to simply install skydive-agent and skydive-analyzer. Is it ok for you ?","commit_id":"496f9771d90b3c090ce625603328f33abf62f4be"}],"docker/skydive/skydive-analyzer/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7108d723b7c52ed8848d389eb7a6606e1a7c082d","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block skydive_analyzer_install %}"},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"{{ macros.install_packages([\u0027skydive-analyzer\u0027] | customizable(\"packages\")) }}"},{"line_number":11,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"    {% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":13,"context_line":"RUN echo \u0027{{ install_type }} on {{ base_distro }} not yet available on non x86_64 platforms\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_5eb42581","line":10,"updated":"2018-07-30 10:31:59.000000000","message":"ditto","commit_id":"d5ba6bc460cdc44ba62a1fde862c1f31c4780b94"},{"author":{"_account_id":8994,"name":"Sylvain Baubeau","email":"sbaubeau@redhat.com","username":"lebauce"},"change_message_id":"308daff0f073a6bcf266a499690d40f453f1f44e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block skydive_analyzer_install %}"},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"{{ macros.install_packages([\u0027skydive-analyzer\u0027] | customizable(\"packages\")) }}"},{"line_number":11,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"    {% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":13,"context_line":"RUN echo \u0027{{ install_type }} on {{ base_distro }} not yet available on non x86_64 platforms\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_88dd9e6f","line":10,"in_reply_to":"5f7c97a3_5eb42581","updated":"2018-07-30 12:41:13.000000000","message":"Done","commit_id":"d5ba6bc460cdc44ba62a1fde862c1f31c4780b94"}],"docker/skydive/skydive-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7108d723b7c52ed8848d389eb7a6606e1a7c082d","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% block skydive_install %}"},{"line_number":13,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.18.0/skydive\" \\"},{"line_number":14,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":15,"context_line":"{% endblock %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":20,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_bea2193f","side":"PARENT","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":11},"updated":"2018-07-30 10:31:59.000000000","message":"could we keep this block for deb distros and remove the duplicated code in the other 2 images?","commit_id":"d7cd35ff9a521b31cb2f6f381cbe6cd78e354549"},{"author":{"_account_id":8994,"name":"Sylvain Baubeau","email":"sbaubeau@redhat.com","username":"lebauce"},"change_message_id":"308daff0f073a6bcf266a499690d40f453f1f44e","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% block skydive_install %}"},{"line_number":13,"context_line":"RUN curl -o /usr/bin/skydive -L \"https://github.com/skydive-project/skydive/releases/download/v0.18.0/skydive\" \\"},{"line_number":14,"context_line":"    \u0026\u0026 chmod +x /usr/bin/skydive"},{"line_number":15,"context_line":"{% endblock %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":20,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_a8dada72","side":"PARENT","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":11},"in_reply_to":"5f7c97a3_bea2193f","updated":"2018-07-30 12:41:13.000000000","message":"Done","commit_id":"d7cd35ff9a521b31cb2f6f381cbe6cd78e354549"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"65d19622e7a7054766aaed3ba1fa87a38cfaa58a","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block skydive_install %}"},{"line_number":11,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":12,"context_line":"    {% set skydive_base_packages \u003d [\u0027skydive\u0027] %}"},{"line_number":13,"context_line":"{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":"    {% if base_arch !\u003d \u0027x86_64\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_decc278b","line":12,"updated":"2018-08-07 13:52:46.000000000","message":"This should only be installed on binary type. Looks good to me otherwise.","commit_id":"bb3998803ac978443a75b5242a9c24b9b875c476"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"765490c674ac49064d8f1727a204fc913cab247d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027skydive\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block skydive_install %}"},{"line_number":11,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":12,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"        {% set skydive_base_packages \u003d [\u0027skydive\u0027] %}"},{"line_number":14,"context_line":"{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3f79a3b5_e72153a1","line":11,"updated":"2018-08-07 17:38:23.000000000","message":"There should be a else, otherwise nothing gets installed for source type builds.","commit_id":"d9444cdd5a054c5509bb0065c5cf83cdbb90e105"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"765490c674ac49064d8f1727a204fc913cab247d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"        {% set skydive_base_packages \u003d [\u0027skydive\u0027] %}"},{"line_number":14,"context_line":"{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":"    {% else %}"},{"line_number":16,"context_line":"        {% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":17,"context_line":"RUN echo \u0027{{ install_type }} on {{ base_distro }} not yet available on non x86_64 platforms\u0027 \\"},{"line_number":18,"context_line":"    \u0026\u0026 /bin/false"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3f79a3b5_673543da","line":15,"updated":"2018-08-07 17:38:23.000000000","message":"This part is really the else for the {% if install_type \u003d\u003d \u0027binary\u0027 %} condition.","commit_id":"d9444cdd5a054c5509bb0065c5cf83cdbb90e105"},{"author":{"_account_id":8994,"name":"Sylvain Baubeau","email":"sbaubeau@redhat.com","username":"lebauce"},"change_message_id":"78838c66f2705c4116a215e5090cc282ddf038e5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"        {% set skydive_base_packages \u003d [\u0027skydive\u0027] %}"},{"line_number":14,"context_line":"{{ macros.install_packages(skydive_base_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":"    {% else %}"},{"line_number":16,"context_line":"        {% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":17,"context_line":"RUN echo \u0027{{ install_type }} on {{ base_distro }} not yet available on non x86_64 platforms\u0027 \\"},{"line_number":18,"context_line":"    \u0026\u0026 /bin/false"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3f79a3b5_3128dae0","line":15,"in_reply_to":"3f79a3b5_673543da","updated":"2018-08-08 07:52:53.000000000","message":"Not sure to understand, this part is downloading the binary","commit_id":"d9444cdd5a054c5509bb0065c5cf83cdbb90e105"}]}