)]}'
{"docker/cinder/cinder-base/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5ad6ae8f5623a18ed1a09880f7f5e721605c7f0e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{ macros.install_packages(cinder_base_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":32,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":33,"context_line":"        {% set cinder_base_packages \u003d ["},{"line_number":34,"context_line":"                \u0027ceph-common\u0027,"},{"line_number":35,"context_line":"                \u0027lvm2\u0027,"},{"line_number":36,"context_line":"                \u0027cryptsetup\u0027,"},{"line_number":37,"context_line":"                \u0027qemu-img-ev\u0027"},{"line_number":38,"context_line":"        ] %}"},{"line_number":39,"context_line":"     {% elif base_distro \u003d\u003d \u0027rhel\u0027 %}"},{"line_number":40,"context_line":"        {% set cinder_base_packages \u003d ["},{"line_number":41,"context_line":"                \u0027ceph-common\u0027,"},{"line_number":42,"context_line":"                \u0027lvm2\u0027,"},{"line_number":43,"context_line":"                \u0027cryptsetup\u0027,"},{"line_number":44,"context_line":"                \u0027qemu-img\u0027"},{"line_number":45,"context_line":"        ] %}"},{"line_number":46,"context_line":"     {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":47,"context_line":"        {% set cinder_base_packages \u003d ["},{"line_number":48,"context_line":"                \u0027ceph-common\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_6fe9c37e","line":45,"range":{"start_line":32,"start_character":0,"end_line":45,"end_character":12},"updated":"2018-08-06 06:08:09.000000000","message":"IMO, this is cleaner not to repeat the common packages between all rpm based distros, something like:\n\n    {% set cinder_base_packages \u003d [\n            \u0027ceph-common\u0027,\n            \u0027lvm2\u0027,\n            \u0027cryptsetup\u0027\n    ] %}\n    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027] %}\n        {% set cinder_base_packages \u003d cinder_base_packages + [\n                \u0027qemu-img-ev\u0027\n        ] %}\n     {% elif base_distro \u003d\u003d \u0027rhel\u0027 %}\n        {% set cinder_base_packages \u003d cinder_base_packages + [\n                \u0027qemu-img\u0027\n        ] %}\n    {% endif %}","commit_id":"5548a3ff5231bf810cf52bae5a43382cb1649ed6"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"1ec15ba5c55fbf96c370cdc49f7fe5a45dcc70f1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            {% set cinder_base_packages \u003d cinder_base_packages + ["},{"line_number":44,"context_line":"                 \u0027qemu-img\u0027"},{"line_number":45,"context_line":"            ] %}"},{"line_number":46,"context_line":"     {% endif %}"},{"line_number":47,"context_line":"     {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":48,"context_line":"        {% set cinder_base_packages \u003d ["},{"line_number":49,"context_line":"                \u0027ceph-common\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_809d0c5b","line":46,"updated":"2018-08-06 09:01:22.000000000","message":"little forming issue,\n\nIs there any other issue, Do I need to spin up new change ?","commit_id":"54d8554756af6901a513ac38870623897f793f67"}],"docker/ironic/ironic-conductor/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5ad6ae8f5623a18ed1a09880f7f5e721605c7f0e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            \u0027util-linux\u0027,"},{"line_number":32,"context_line":"            \u0027xfsprogs\u0027,"},{"line_number":33,"context_line":"        ] %}"},{"line_number":34,"context_line":"    {% elif base_distro \u003d\u003d \u0027rhel\u0027 %}"},{"line_number":35,"context_line":"        # NOTE(afazekas): initially qemu-img differs only"},{"line_number":36,"context_line":"        {% set ironic_conductor_packages \u003d ["},{"line_number":37,"context_line":"            \u0027ansible\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_4f008735","line":34,"updated":"2018-08-06 06:08:09.000000000","message":"ditto","commit_id":"5548a3ff5231bf810cf52bae5a43382cb1649ed6"}],"docker/nova/nova-libvirt/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5ad6ae8f5623a18ed1a09880f7f5e721605c7f0e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027nova\u0027, groups\u003d\u0027qemu\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    {% set nova_libvirt_packages \u003d ["},{"line_number":13,"context_line":"        \u0027ceph-common\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_af94bbe9","line":10,"updated":"2018-08-06 06:08:09.000000000","message":"ditto","commit_id":"5548a3ff5231bf810cf52bae5a43382cb1649ed6"}]}