)]}'
{"docker/nova/nova-compute-ironic/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5ddd570f75893f75708c5ddb9f90cf15839c1e6c","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% set nova_compute_ironic_packages \u003d [\u0027genisoimage\u0027, \u0027nvme-cli\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_dde8e6e2","line":8,"updated":"2018-08-16 12:32:15.000000000","message":"Nit: simple formatting, could you put each package on a different line like it\u0027s done on line 14?","commit_id":"7eb200d2f850034253510cb8ea21d5605c2665fa"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"cfad6d06dacb6d7cd9a62e4924074eaeb4f39f86","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% set nova_compute_ironic_packages \u003d [\u0027genisoimage\u0027, \u0027nvme-cli\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_d878f4c4","line":8,"in_reply_to":"3f79a3b5_dde8e6e2","updated":"2018-08-16 13:30:41.000000000","message":"Done","commit_id":"7eb200d2f850034253510cb8ea21d5605c2665fa"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3030e361a05808747c719d4f714204f889044d12","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% set nova_compute_ironic_packages \u003d ["},{"line_number":9,"context_line":"    \u0027genisoimage\u0027,"},{"line_number":10,"context_line":"    \u0027nvme-cli\u0027"},{"line_number":11,"context_line":"] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_605550fa","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":14},"updated":"2018-08-17 07:38:04.000000000","message":"where do you install them ?","commit_id":"24e0f711c484cd3b903a06a3d06c8883cc57d170"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"d627c994c2712a3c8706549e9606f52bd47094f0","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% set nova_compute_ironic_packages \u003d ["},{"line_number":9,"context_line":"    \u0027genisoimage\u0027,"},{"line_number":10,"context_line":"    \u0027nvme-cli\u0027"},{"line_number":11,"context_line":"] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_3f1d24bd","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":14},"in_reply_to":"3f79a3b5_605550fa","updated":"2018-08-17 21:06:59.000000000","message":"Done","commit_id":"24e0f711c484cd3b903a06a3d06c8883cc57d170"}],"docker/nova/nova-compute/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5ddd570f75893f75708c5ddb9f90cf15839c1e6c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            \u0027python-rtslib\u0027,"},{"line_number":24,"context_line":"            \u0027sysfsutils\u0027,"},{"line_number":25,"context_line":"            \u0027targetcli\u0027,"},{"line_number":26,"context_line":"            \u0027nvme-cli\u0027"},{"line_number":27,"context_line":"        ] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(nova_compute_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_bde96ae3","line":26,"updated":"2018-08-16 12:32:15.000000000","message":"Please order the packages alphabetically.","commit_id":"7eb200d2f850034253510cb8ea21d5605c2665fa"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"cfad6d06dacb6d7cd9a62e4924074eaeb4f39f86","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            \u0027python-rtslib\u0027,"},{"line_number":24,"context_line":"            \u0027sysfsutils\u0027,"},{"line_number":25,"context_line":"            \u0027targetcli\u0027,"},{"line_number":26,"context_line":"            \u0027nvme-cli\u0027"},{"line_number":27,"context_line":"        ] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(nova_compute_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_987efcac","line":26,"in_reply_to":"3f79a3b5_bde96ae3","updated":"2018-08-16 13:30:41.000000000","message":"Done","commit_id":"7eb200d2f850034253510cb8ea21d5605c2665fa"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"dca4ca72cf841dab76ae0a3e4793e9320307ac82","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \u0027genisoimage\u0027,"},{"line_number":16,"context_line":"            \u0027iscsi-initiator-utils\u0027,"},{"line_number":17,"context_line":"            \u0027nfs-utils\u0027,"},{"line_number":18,"context_line":"            \u0027nvme-cli\u0027"},{"line_number":19,"context_line":"            \u0027openstack-nova-compute\u0027,"},{"line_number":20,"context_line":"            \u0027openvswitch\u0027,"},{"line_number":21,"context_line":"            \u0027parted\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_95d0ec55","line":18,"updated":"2018-08-17 07:24:28.000000000","message":"Missing a comma at the end of the line.","commit_id":"24e0f711c484cd3b903a06a3d06c8883cc57d170"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"2d473ef8c0012346a0e493a2076e88cf59641b1b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \u0027genisoimage\u0027,"},{"line_number":16,"context_line":"            \u0027iscsi-initiator-utils\u0027,"},{"line_number":17,"context_line":"            \u0027nfs-utils\u0027,"},{"line_number":18,"context_line":"            \u0027nvme-cli\u0027"},{"line_number":19,"context_line":"            \u0027openstack-nova-compute\u0027,"},{"line_number":20,"context_line":"            \u0027openvswitch\u0027,"},{"line_number":21,"context_line":"            \u0027parted\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_5f490030","line":18,"in_reply_to":"3f79a3b5_95d0ec55","updated":"2018-08-17 20:46:52.000000000","message":"Done","commit_id":"24e0f711c484cd3b903a06a3d06c8883cc57d170"}]}