)]}'
{"docker/tripleoclient/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"981cf33666a738491e89024de985ca5988c5ff91","unresolved":false,"context_lines":[{"line_number":17,"context_line":"                \u0027e2fsprogs\u0027,"},{"line_number":18,"context_line":"                \u0027xfsprogs\u0027,"},{"line_number":19,"context_line":"                \u0027openssh-clients\u0027,"},{"line_number":20,"context_line":"                \u0027vim-enhanced\u0027,"},{"line_number":21,"context_line":"                \u0027git\u0027"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_e48eb1cf","line":20,"range":{"start_line":20,"start_character":16,"end_line":20,"end_character":31},"updated":"2018-08-24 09:06:44.000000000","message":"While I understand it\u0027s convenient for developers to ship vim in containers, this shouldn\u0027t be here IMO.","commit_id":"2e836924daa2fc77d2b2909b43cb9196d2d1bdad"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"981cf33666a738491e89024de985ca5988c5ff91","unresolved":false,"context_lines":[{"line_number":18,"context_line":"                \u0027xfsprogs\u0027,"},{"line_number":19,"context_line":"                \u0027openssh-clients\u0027,"},{"line_number":20,"context_line":"                \u0027vim-enhanced\u0027,"},{"line_number":21,"context_line":"                \u0027git\u0027"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{ macros.install_packages(tripleoclient_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_048c0dd5","line":21,"range":{"start_line":21,"start_character":16,"end_line":21,"end_character":21},"updated":"2018-08-24 09:06:44.000000000","message":"What requires git?","commit_id":"2e836924daa2fc77d2b2909b43cb9196d2d1bdad"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"05cf27c5313281e306c61709967694807d5c0e18","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{ macros.install_packages(tripleoclient_packages | customizable(\"packages\")) }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"RUN sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf \\"},{"line_number":27,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 443),#\\1,\u0027 /etc/httpd/conf.d/ssl.conf"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    {% else %}"},{"line_number":30,"context_line":"RUN echo \u0027tripleoclient not yet available for {{ base_distro }}\u0027 \u0026\u0026 /bin/false"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_ef8d2f7c","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":66},"updated":"2018-08-24 06:42:39.000000000","message":"http is not being installed making this to fail","commit_id":"2e836924daa2fc77d2b2909b43cb9196d2d1bdad"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"981cf33666a738491e89024de985ca5988c5ff91","unresolved":false,"context_lines":[{"line_number":40,"context_line":"COPY create_super_user.sh /usr/local/bin/create_super_user.sh"},{"line_number":41,"context_line":"RUN chmod 750 /usr/local/bin/create_super_user.sh"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":44,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% block tripleoclient_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_c467f54c","line":43,"updated":"2018-08-24 09:06:44.000000000","message":"This isn\u0027t necessary to carry an empty extend_start file, we\u0027re already creating one in the base image:\n\nhttps://github.com/openstack/kolla/blob/b275e4a/docker/base/Dockerfile.j2#L416","commit_id":"2e836924daa2fc77d2b2909b43cb9196d2d1bdad"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"8739db022b85ca959d13b0feaab8230c29d2e87d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"COPY create_super_user.sh /usr/local/bin/create_super_user.sh"},{"line_number":37,"context_line":"RUN chmod 750 /usr/local/bin/create_super_user.sh"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":40,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{% block tripleoclient_footer %}{% endblock %}"},{"line_number":43,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_0e96263f","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":47},"updated":"2018-08-28 12:41:58.000000000","message":"You can remove this, unless you need a custom extend start.","commit_id":"935f21d77e7ba0244dcf7e9d599321075ffc896d"}],"docker/tripleoclient/create_super_user.sh":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"05cf27c5313281e306c61709967694807d5c0e18","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This is a useful entrypoint/cmd if you wish to run commands in a container"},{"line_number":3,"context_line":"# in an existing users $HOME directory"},{"line_number":4,"context_line":"# For example: docker run -ti -e USER\u003dstack -e UID\u003d1000 --privileged\u003dtrue --volume\u003d/home/stack/:/home/stack/ tripleoclient:latest /usr/local/bin/create_super_user.sh"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ -n \"$USER\" -a -n \"$UID\" ]; then"},{"line_number":7,"context_line":"  useradd \"$USER\" -u \"$UID\" -M"},{"line_number":8,"context_line":"cat \u003e\u003e /etc/sudoers \u003c\u003cEOF_CAT"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_cfee3321","line":5,"updated":"2018-08-24 06:42:39.000000000","message":"indents not multiple of 4 pep8 error\n\nhttp://logs.openstack.org/66/595866/1/check/openstack-tox-pep8/c456333/job-output.txt.gz#_2018-08-23_18_55_45_818695","commit_id":"2e836924daa2fc77d2b2909b43cb9196d2d1bdad"}],"kolla/common/config.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"05cf27c5313281e306c61709967694807d5c0e18","unresolved":false,"context_lines":[{"line_number":779,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":780,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/tempest/\u0027"},{"line_number":781,"context_line":"                     \u0027tempest-master.tar.gz\u0027)},"},{"line_number":782,"context_line":"    \u0027tripleoclient\u0027: {"},{"line_number":783,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":784,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/tripleoclient/\u0027"},{"line_number":785,"context_line":"                     \u0027tripleoclient-latest.tar.gz\u0027)},"},{"line_number":786,"context_line":"    \u0027tripleo-ui\u0027: {"},{"line_number":787,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":788,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/tripleo-ui/\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4fac63ec","line":785,"range":{"start_line":782,"start_character":0,"end_line":785,"end_character":53},"updated":"2018-08-24 06:42:39.000000000","message":"added to the downloaded source package list but not being installed in the source image.","commit_id":"2e836924daa2fc77d2b2909b43cb9196d2d1bdad"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"8739db022b85ca959d13b0feaab8230c29d2e87d","unresolved":false,"context_lines":[{"line_number":779,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":780,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/tempest/\u0027"},{"line_number":781,"context_line":"                     \u0027tempest-master.tar.gz\u0027)},"},{"line_number":782,"context_line":"    \u0027tripleoclient\u0027: {"},{"line_number":783,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":784,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/python-tripleoclient/\u0027"},{"line_number":785,"context_line":"                     \u0027tripleoclient-master.tar.gz\u0027)},"},{"line_number":786,"context_line":"    \u0027tripleo-ui\u0027: {"},{"line_number":787,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":788,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/tripleo-ui/\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6ebc7aba","line":785,"range":{"start_line":782,"start_character":0,"end_line":785,"end_character":53},"updated":"2018-08-28 12:41:58.000000000","message":"This is not needed unless you plan to make it possible to build source images for tripleoclient.","commit_id":"935f21d77e7ba0244dcf7e9d599321075ffc896d"}],"releasenotes/notes/add-tripleoclient-image-0341fb72fe27ba14.yaml":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"981cf33666a738491e89024de985ca5988c5ff91","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add tripleoclient image. This image can be used interactively for ad-hoc tripleoclient commands or automated to output Ansible playbooks from TripleO Heat Templates for TripleO deployment."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_84b33de9","line":3,"updated":"2018-08-24 09:06:44.000000000","message":"Nit: add line breaks","commit_id":"2e836924daa2fc77d2b2909b43cb9196d2d1bdad"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"8739db022b85ca959d13b0feaab8230c29d2e87d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add tripleoclient image. This image can be used interactively for ad-hoc"},{"line_number":4,"context_line":"tripleoclient commands or automated to output Ansible playbooks from TripleO"},{"line_number":5,"context_line":"Heat Templates for TripleO deployment."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_ceccae6b","line":4,"updated":"2018-08-28 12:41:58.000000000","message":"Needs to be indented","commit_id":"935f21d77e7ba0244dcf7e9d599321075ffc896d"}]}