)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"59dfe2e632b8c9518cc2ad81503948b1c1c6d108","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fails when we get a full SELinux separation enabled."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-on: 3d63d1df7496d3b8a5883b07e9d40aa21153c086"},{"line_number":12,"context_line":"Change-Id: Ieebb2564e816d83ec4111c211677f0a44488a224"},{"line_number":13,"context_line":"Related-Bug: 1794550"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_007e8769","line":11,"updated":"2018-09-27 15:15:53.000000000","message":"The change-id in the Depends-On is not valid.\n\nPlease also add a Depends-On on the kolla-ansible change.","commit_id":"4f28d1be2967aefab2d986fe7bf1f25ac994a469"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"60b03653415ee92d7de3344434a61faf0d15af85","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fails when we get a full SELinux separation enabled."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-on: 3d63d1df7496d3b8a5883b07e9d40aa21153c086"},{"line_number":12,"context_line":"Change-Id: Ieebb2564e816d83ec4111c211677f0a44488a224"},{"line_number":13,"context_line":"Related-Bug: 1794550"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_dc692123","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":52},"updated":"2018-11-07 09:29:11.000000000","message":"This change-id is invalid.","commit_id":"3604c5b5cb6add19fed8aa5a26d76fe26a34acbc"}],"docker/multipathd/extend_start.sh":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"59dfe2e632b8c9518cc2ad81503948b1c1c6d108","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_a094738d","line":2,"updated":"2018-09-27 15:15:53.000000000","message":"Yes agreed, please delete this file since it\u0027s not needed anymore and remove the related instructions in the Dockerfile.","commit_id":"4f28d1be2967aefab2d986fe7bf1f25ac994a469"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8c3974d57b121ef94dce64ad9a863872899f8fe7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_e7a125f9","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"updated":"2018-09-27 13:46:04.000000000","message":"if this is not longer used, better remove the file from the dockerfile","commit_id":"4f28d1be2967aefab2d986fe7bf1f25ac994a469"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"911f603b12d8acae8da7207dae5b384fa49fd836","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_0d3790b1","line":2,"in_reply_to":"3f79a3b5_5c19bcce","updated":"2018-09-28 08:20:46.000000000","message":"It\u0027s referenced in the Dockerfile.j2 in the same directory, those need to be removed.","commit_id":"4f28d1be2967aefab2d986fe7bf1f25ac994a469"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1d435dcfdec41d6079508cf88ee29527296da73b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_adc8dca7","line":2,"in_reply_to":"3f79a3b5_5c19bcce","updated":"2018-09-28 08:20:18.000000000","message":"need to remove lines 16-17 https://github.com/openstack/kolla/blob/master/docker/multipathd/Dockerfile.j2#L16","commit_id":"4f28d1be2967aefab2d986fe7bf1f25ac994a469"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"46d9bf7a426853c7c1e497ef4ff3e019d79a4053","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_5c19bcce","line":2,"in_reply_to":"3f79a3b5_a094738d","updated":"2018-09-28 06:04:24.000000000","message":"Ah, I wasn\u0027t sure about the startup process itself - does it check the presence of that file before running it? If so, I\u0027ll drop it of course. I\u0027m a bit conservative on those patches as I don\u0027t really know how the whole kolla works.","commit_id":"4f28d1be2967aefab2d986fe7bf1f25ac994a469"}],"releasenotes/notes/do-not-load-modules-9b651e40d3479c39.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3bd16b63454cb9cc3a2fd0a0afcd1ead2a77a17d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecated module loading from containers."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_9ee6af13","line":3,"updated":"2018-11-01 14:12:15.000000000","message":"Isn\u0027t this removed rather than deprecated?","commit_id":"41447683a92dd019c4d21aa658850d377aa58c8a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"901758066ac94bd74e170a1392e9225cb14067d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecated module loading from containers."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_4b192989","line":3,"in_reply_to":"3f79a3b5_4b5e0915","updated":"2018-11-02 07:27:22.000000000","message":"It\u0027s possible, but that\u0027s not really the point. The release note should say what has changed in this release, and what has changed is that images that previously loaded kernel modules on startup no longer do. It might be helpful to deployment tools to list those images and the modules also.","commit_id":"41447683a92dd019c4d21aa658850d377aa58c8a"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f2e4814bca3adea3c7f93e60ae6803afbc792182","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecated module loading from containers."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_4b5e0915","line":3,"in_reply_to":"3f79a3b5_9ee6af13","updated":"2018-11-02 06:43:04.000000000","message":"well, if one still wants to do it, it\u0027s still possible, but not really a good idea.. ?","commit_id":"41447683a92dd019c4d21aa658850d377aa58c8a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e384a066677f937552b8df1a7cc881971d6e20c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Remove kernel module loading from within containers. This is now done"},{"line_number":4,"context_line":"    directly from the host, in kolla-ansible."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_0667a3ba","line":3,"range":{"start_line":3,"start_character":62,"end_line":3,"end_character":68},"updated":"2018-11-02 10:12:11.000000000","message":"must now be","commit_id":"bddf84618ce522a1d468c3b7e21f1413e0f51215"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e384a066677f937552b8df1a7cc881971d6e20c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Remove kernel module loading from within containers. This is now done"},{"line_number":4,"context_line":"    directly from the host, in kolla-ansible."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_6668d788","line":4,"range":{"start_line":4,"start_character":26,"end_line":4,"end_character":44},"updated":"2018-11-02 10:12:11.000000000","message":"Kolla images are used by various deployment tools, so we shouldn\u0027t call out kolla ansible here.","commit_id":"bddf84618ce522a1d468c3b7e21f1413e0f51215"}]}
