)]}'
{"docker/zaqar/extend_start.sh":[{"author":{"_account_id":28176,"name":"Ha Manh Dong","email":"donghm@omzcloud.vn","username":"donghm"},"change_message_id":"c1e9b207f4ee97d957558c8a1dbab51fa735c89b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"if [[ ! -d \"${LOG_DIR}\" ]]; then"},{"line_number":7,"context_line":"    mkdir -p ${LOG_DIR}"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":"if [[ $(stat -c %a ${LOG_DIR}) !\u003d \"zaqar:kolla\" ]]; then"},{"line_number":10,"context_line":"    chown zaqar:kolla ${LOG_DIR}"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_4e03be76","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":18},"updated":"2018-10-17 03:32:46.000000000","message":"This should be %U:%G","commit_id":"97c5daec9756acf56a81bf7f88661d6a36571ef5"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"d1999f9db0b55b8e138d16bbf4b36db2d2c42c2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"if [[ ! -d \"${LOG_DIR}\" ]]; then"},{"line_number":7,"context_line":"    mkdir -p ${LOG_DIR}"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":"if [[ $(stat -c %a ${LOG_DIR}) !\u003d \"zaqar:kolla\" ]]; then"},{"line_number":10,"context_line":"    chown zaqar:kolla ${LOG_DIR}"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_d49bdc62","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":18},"in_reply_to":"3f79a3b5_4e03be76","updated":"2018-10-17 04:24:20.000000000","message":"Oops, my bad.","commit_id":"97c5daec9756acf56a81bf7f88661d6a36571ef5"}],"docker/zaqar/zaqar-base/Dockerfile.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f2d1c821e288cb20c52d36909e23ddc528bc563f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"        {% set zaqar_base_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":23,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"        {% set barbican_base_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":25,"context_line":"    {% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{ macros.install_packages(zaqar_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_fb0b6020","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":37},"updated":"2018-10-17 12:07:25.000000000","message":"Do you mean `zaqar_base_packages`?","commit_id":"232fa3d5081d2424ce170b11e93b49b1aa017ab8"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"7ece104404cd6f808908d80bf3ce1442a3aecbc0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"        {% set zaqar_base_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":23,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"        {% set barbican_base_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":25,"context_line":"    {% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{ macros.install_packages(zaqar_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_af184283","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":37},"in_reply_to":"3f79a3b5_fb0b6020","updated":"2018-10-17 15:03:21.000000000","message":"Bad copy-paste, thanks for catching it :D","commit_id":"232fa3d5081d2424ce170b11e93b49b1aa017ab8"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f2d1c821e288cb20c52d36909e23ddc528bc563f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"RUN ln -s zaqar-base-source/* zaqar \\"},{"line_number":40,"context_line":"    \u0026\u0026 {{ macros.install_pip(zaqar_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":41,"context_line":"    \u0026\u0026 mkdir -p /etc/zaqar \\"},{"line_number":42,"context_line":"    \u0026\u0026 cp -r /zaqar/etc/* /etc/zaqar/ \\"},{"line_number":43,"context_line":"    \u0026\u0026 chown -R zaqar: /etc/zaqar"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_9be7cc46","line":42,"updated":"2018-10-17 12:07:25.000000000","message":"Is it worth being a bit more selective about what gets copied here? It looks like this will copy the oslo config generator, and some config files which would normally be generated from templates in Kolla Ansible.","commit_id":"232fa3d5081d2424ce170b11e93b49b1aa017ab8"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"7ece104404cd6f808908d80bf3ce1442a3aecbc0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"RUN ln -s zaqar-base-source/* zaqar \\"},{"line_number":40,"context_line":"    \u0026\u0026 {{ macros.install_pip(zaqar_base_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":41,"context_line":"    \u0026\u0026 mkdir -p /etc/zaqar \\"},{"line_number":42,"context_line":"    \u0026\u0026 cp -r /zaqar/etc/* /etc/zaqar/ \\"},{"line_number":43,"context_line":"    \u0026\u0026 chown -R zaqar: /etc/zaqar"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_2f1bd284","line":42,"in_reply_to":"3f79a3b5_9be7cc46","updated":"2018-10-17 15:03:21.000000000","message":"IMO we could copy all so that we don\u0027t have to change in Kolla side if there are any changes in Zaqar side (for example, rename files in zaqar/etc).","commit_id":"232fa3d5081d2424ce170b11e93b49b1aa017ab8"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"311e732877d594789d9de55d16e6c2c7fe9dade7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{ macros.install_packages(zaqar_base_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":21,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"        {% set zaqar_base_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":23,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"        {% set zaqar_base_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_1cca9d6e","line":21,"updated":"2018-10-19 13:56:37.000000000","message":"This probably can be combined because they have the same package name.","commit_id":"c46e88d2bcc5c813ab03641751204c889efeb700"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"22a7ed0e7f6467e84ed8c102e035952a913e7711","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{ macros.install_packages(zaqar_base_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":21,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"        {% set zaqar_base_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":23,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"        {% set zaqar_base_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_a5226ca5","line":21,"in_reply_to":"3f79a3b5_1cca9d6e","updated":"2018-10-19 15:36:05.000000000","message":"Thank you, done.","commit_id":"c46e88d2bcc5c813ab03641751204c889efeb700"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"baed8687e5e376cfd5566460d64f55e7fc42fe7d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% set zaqar_base_pip_packages \u003d ["},{"line_number":26,"context_line":"    \u0027pymongo\u0027,"},{"line_number":27,"context_line":"    \u0027/zaqar\u0027,"},{"line_number":28,"context_line":"    \u0027python-zaqarclient\u0027,"},{"line_number":29,"context_line":"    \u0027uwsgi\u0027,"},{"line_number":30,"context_line":"    \u0027gevent\u0027"},{"line_number":31,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_d70afe1d","line":28,"range":{"start_line":28,"start_character":5,"end_line":28,"end_character":23},"updated":"2018-10-30 12:03:53.000000000","message":"isnt this library installed with zaqar requirements? if not, is the client a requirement to make zaqar work?","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f8923c55a99f5d41c8db5d2b29ac8bc10d76ccf9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(zaqar_base_packages | customizable(\"packages\")) }} \\"},{"line_number":22,"context_line":"    \u0026\u0026 mkdir -p /var/www/cgi-bin/zaqar \\"},{"line_number":23,"context_line":"    \u0026\u0026 chown -R zaqar: var/www/cgi-bin/zaqar \\"},{"line_number":24,"context_line":"    \u0026\u0026 cp -a /usr/lib/python2.7/site-packages/zaqar/transport/wsgi/app.py /var/www/cgi-bin/zaqar/ \\"},{"line_number":25,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf \\"},{"line_number":26,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 443),#\\1,\u0027 /etc/httpd/conf.d/ssl.conf"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3f79a3b5_eb046315","line":23,"updated":"2018-11-06 18:28:26.000000000","message":"missing /","commit_id":"3be9131ebc355eae0ae22fb39de1da52d90c40fb"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"4d634f6e213d44882f9896fda26d0a4315c6fb92","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(zaqar_base_packages | customizable(\"packages\")) }} \\"},{"line_number":22,"context_line":"    \u0026\u0026 mkdir -p /var/www/cgi-bin/zaqar \\"},{"line_number":23,"context_line":"    \u0026\u0026 chown -R zaqar: var/www/cgi-bin/zaqar \\"},{"line_number":24,"context_line":"    \u0026\u0026 cp -a /usr/lib/python2.7/site-packages/zaqar/transport/wsgi/app.py /var/www/cgi-bin/zaqar/ \\"},{"line_number":25,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf \\"},{"line_number":26,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 443),#\\1,\u0027 /etc/httpd/conf.d/ssl.conf"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3f79a3b5_02d97953","line":23,"in_reply_to":"3f79a3b5_eb046315","updated":"2018-11-07 02:34:26.000000000","message":"Done","commit_id":"3be9131ebc355eae0ae22fb39de1da52d90c40fb"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f8923c55a99f5d41c8db5d2b29ac8bc10d76ccf9","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{{ macros.install_packages(zaqar_base_packages | customizable(\"packages\")) }} \\"},{"line_number":37,"context_line":"    \u0026\u0026 mkdir -p /var/www/cgi-bin/zaqar \\"},{"line_number":38,"context_line":"    \u0026\u0026 chown -R zaqar: var/www/cgi-bin/zaqar \\"},{"line_number":39,"context_line":"    \u0026\u0026 cp -a /usr/lib/python2.7/dist-packages/zaqar/transport/wsgi/app.py /var/www/cgi-bin/zaqar/ \\"},{"line_number":40,"context_line":"    \u0026\u0026 echo \u003e /etc/apache2/ports.conf"},{"line_number":41,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3f79a3b5_ab0aeb1a","line":38,"updated":"2018-11-06 18:28:26.000000000","message":"ditto","commit_id":"3be9131ebc355eae0ae22fb39de1da52d90c40fb"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"4d634f6e213d44882f9896fda26d0a4315c6fb92","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{{ macros.install_packages(zaqar_base_packages | customizable(\"packages\")) }} \\"},{"line_number":37,"context_line":"    \u0026\u0026 mkdir -p /var/www/cgi-bin/zaqar \\"},{"line_number":38,"context_line":"    \u0026\u0026 chown -R zaqar: var/www/cgi-bin/zaqar \\"},{"line_number":39,"context_line":"    \u0026\u0026 cp -a /usr/lib/python2.7/dist-packages/zaqar/transport/wsgi/app.py /var/www/cgi-bin/zaqar/ \\"},{"line_number":40,"context_line":"    \u0026\u0026 echo \u003e /etc/apache2/ports.conf"},{"line_number":41,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3f79a3b5_a2e1a5ff","line":38,"in_reply_to":"3f79a3b5_ab0aeb1a","updated":"2018-11-07 02:34:26.000000000","message":"Done","commit_id":"3be9131ebc355eae0ae22fb39de1da52d90c40fb"}],"docker/zaqar/zaqar-base/zaqar_sudoers":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"baed8687e5e376cfd5566460d64f55e7fc42fe7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown -R zaqar\\: /var/lib/zaqar/, /bin/chown -R zaqar\\: /var/lib/zaqar/"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3f79a3b5_57202e9e","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":108},"updated":"2018-10-30 12:03:53.000000000","message":"why does it needs this part? the chowncan done at the base dockerfile as the same to /etc/zaqar (and should also be done in the rpm or .deb)","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"}],"docker/zaqar/zaqar-websocket/Dockerfile.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f2d1c821e288cb20c52d36909e23ddc528bc563f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027zaqar\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"        {% set zaqar_websocket_packages \u003d [\u0027zaqar-server\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.install_packages(zaqar_websocket_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_dbb5441b","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":21},"updated":"2018-10-17 12:07:25.000000000","message":"Is anything required for Centos etc or did you not add support here?","commit_id":"232fa3d5081d2424ce170b11e93b49b1aa017ab8"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6983aca2a9d5792927627669d681a819e480f510","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027zaqar\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"        {% set zaqar_websocket_packages \u003d [\u0027zaqar-server\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.install_packages(zaqar_websocket_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_3eb9ad15","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":21},"in_reply_to":"3f79a3b5_aa74b09c","updated":"2018-10-18 10:44:18.000000000","message":"Ok, thanks.","commit_id":"232fa3d5081d2424ce170b11e93b49b1aa017ab8"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"7ece104404cd6f808908d80bf3ce1442a3aecbc0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027zaqar\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"        {% set zaqar_websocket_packages \u003d [\u0027zaqar-server\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.install_packages(zaqar_websocket_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_aa74b09c","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":21},"in_reply_to":"3f79a3b5_dbb5441b","updated":"2018-10-17 15:03:21.000000000","message":"No, it isn\u0027t AFAIK. Because in debian/ubuntu, there are 2 packages (zaqar-common and zaqar-server), so we have to do an additional install. But in centos/rhel, we have just 1 package (openstack-zaqar).","commit_id":"232fa3d5081d2424ce170b11e93b49b1aa017ab8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"baed8687e5e376cfd5566460d64f55e7fc42fe7d","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027zaqar\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_174f166a","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":41},"updated":"2018-10-30 12:03:53.000000000","message":"not needed, already done at zaqar-base","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"baed8687e5e376cfd5566460d64f55e7fc42fe7d","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"        {% set zaqar_websocket_packages \u003d [\u0027zaqar-server\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.install_packages(zaqar_websocket_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_57458e49","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":56},"updated":"2018-10-30 12:03:53.000000000","message":"websocket installs the server package, is this expected?","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"16d5f59bacfda4eed61e8838cfbfe6d9f85da1ce","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"        {% set zaqar_websocket_packages \u003d [\u0027zaqar-server\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.install_packages(zaqar_websocket_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_884a2758","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":56},"in_reply_to":"3f79a3b5_57458e49","updated":"2018-10-30 14:32:11.000000000","message":"yeah, I think image\u0027s name should be changed to zaqar-server. I will update in new patch.","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"9ae0341c2f561461db56922ab96425f27e71b4b0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% block zaqar_websocket_footer %}{% endblock %}"},{"line_number":20,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_d7c8be4f","line":20,"updated":"2018-10-30 12:26:50.000000000","message":"will this image run as root? or should be zaqar? the wsgi usually runs as root due permissions on apache","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"}],"docker/zaqar/zaqar-wsgi/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"baed8687e5e376cfd5566460d64f55e7fc42fe7d","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027zaqar\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_375492fd","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":41},"updated":"2018-10-30 12:03:53.000000000","message":"ditto","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"baed8687e5e376cfd5566460d64f55e7fc42fe7d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \u0027httpd\u0027,"},{"line_number":14,"context_line":"            \u0027mod_ssl\u0027,"},{"line_number":15,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":16,"context_line":"            \u0027uwsgi-plugin-python\u0027"},{"line_number":17,"context_line":"       ] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{ macros.install_packages(zaqar_wsgi_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_176876ba","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":33},"updated":"2018-10-30 12:03:53.000000000","message":"we run others services from apache mod_wsgi, not directly with uwsgi, could we standarize this with other services.\n\nCheck aodh as example\nhttps://github.com/openstack/kolla/blob/master/docker/aodh/aodh-base/Dockerfile.j2","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"16d5f59bacfda4eed61e8838cfbfe6d9f85da1ce","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \u0027httpd\u0027,"},{"line_number":14,"context_line":"            \u0027mod_ssl\u0027,"},{"line_number":15,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":16,"context_line":"            \u0027uwsgi-plugin-python\u0027"},{"line_number":17,"context_line":"       ] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{ macros.install_packages(zaqar_wsgi_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_c8f25f6a","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":33},"in_reply_to":"3f79a3b5_176876ba","updated":"2018-10-30 14:32:11.000000000","message":"I\u0027m not sure that we could run zaqar with mod_wsgi. Zaqar doesn\u0027t have wsgi-scripts yet. Here is the patchset [1] implement it and it hasn\u0027t merged yet.\n\nIMO, I prefer to keep using uwsgi. We can use mod_wsgi later. WDYT?\n\n[1] https://review.openstack.org/#/c/520596/3/setup.cfg","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6168d780169e3f21b89087358444f0bacf1e09bf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \u0027httpd\u0027,"},{"line_number":14,"context_line":"            \u0027mod_ssl\u0027,"},{"line_number":15,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":16,"context_line":"            \u0027uwsgi-plugin-python\u0027"},{"line_number":17,"context_line":"       ] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{ macros.install_packages(zaqar_wsgi_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_e3bdfc04","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":33},"in_reply_to":"3f79a3b5_c8f25f6a","updated":"2018-10-30 14:43:48.000000000","message":"this is the script wsgi script https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/app.py ,\n\nthis can be used copying it to /var/www/cgi-bin/zaqar, and pointing to there in the apache wsgi file","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"07030bed29214ff870b3b89be9f05482356e5074","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \u0027httpd\u0027,"},{"line_number":14,"context_line":"            \u0027mod_ssl\u0027,"},{"line_number":15,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":16,"context_line":"            \u0027uwsgi-plugin-python\u0027"},{"line_number":17,"context_line":"       ] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{ macros.install_packages(zaqar_wsgi_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_038a781d","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":33},"in_reply_to":"3f79a3b5_e3bdfc04","updated":"2018-10-30 14:49:29.000000000","message":"Ack, thank you. I will update it.","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"baed8687e5e376cfd5566460d64f55e7fc42fe7d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    {% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_zaqar_extend_start"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"RUN chmod 755 /usr/local/bin/kolla_zaqar_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_d7a67e0f","line":38,"updated":"2018-10-30 12:03:53.000000000","message":"given the previous comment, for apache based mod_wsgi, the wsgi file need to be copied to /var/www (this is done in the base image for source builds)\n\nhttps://github.com/openstack/kolla/blob/master/docker/aodh/aodh-base/Dockerfile.j2#L79","commit_id":"40805006f89302158abc7d8d05cbfb54a07972b3"}]}