)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d1d4dff02c37fd7a1c29641d9fd8197854fe0ff4","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"RUN curl -sSL https://github.com/Yelp/dumb-init/releases/download/v1.1.3/dumb-init_1.1.3_amd64 -o /usr/local/bin/dumb-init \\"},{"line_number":402,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/dumb-init \\"},{"line_number":403,"context_line":"    \u0026\u0026 sed -i \u0027s|#!|#!/usr/local/bin/dumb-init |\u0027 /usr/local/bin/kolla_start"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"{% else %}"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_c0eb6878","side":"PARENT","line":403,"range":{"start_line":403,"start_character":7,"end_line":403,"end_character":76},"updated":"2018-10-26 05:43:31.000000000","message":"Removing the shebang results in kolla_start starting a shell","commit_id":"f613ff8a548accee65bd86209e4683539b66ffdb"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8468996602edec7f6743c6c868193a027027c4a0","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"RUN curl -sSL https://github.com/Yelp/dumb-init/releases/download/v1.1.3/dumb-init_1.1.3_amd64 -o /usr/local/bin/dumb-init \\"},{"line_number":402,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/dumb-init \\"},{"line_number":403,"context_line":"    \u0026\u0026 sed -i \u0027s|#!|#!/usr/local/bin/dumb-init |\u0027 /usr/local/bin/kolla_start"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"{% else %}"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_73701742","side":"PARENT","line":403,"range":{"start_line":403,"start_character":7,"end_line":403,"end_character":76},"in_reply_to":"3f79a3b5_46bc3eda","updated":"2018-10-26 08:22:15.000000000","message":"I fully support the proposed change for signalling, although this particular shebang change is nice to have explained in the commit message.","commit_id":"f613ff8a548accee65bd86209e4683539b66ffdb"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2ddbe36bc4d21d77400f4612bdb72dbfb0c58287","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"RUN curl -sSL https://github.com/Yelp/dumb-init/releases/download/v1.1.3/dumb-init_1.1.3_amd64 -o /usr/local/bin/dumb-init \\"},{"line_number":402,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/dumb-init \\"},{"line_number":403,"context_line":"    \u0026\u0026 sed -i \u0027s|#!|#!/usr/local/bin/dumb-init |\u0027 /usr/local/bin/kolla_start"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"{% else %}"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_9657e1f5","side":"PARENT","line":403,"range":{"start_line":403,"start_character":7,"end_line":403,"end_character":76},"in_reply_to":"3f79a3b5_73701742","updated":"2018-10-26 08:50:00.000000000","message":"You mean why it was moved from the shebang?\n\n\"shebang line can take a single argument\" is a known limitation. Though I can change the commit message if required.","commit_id":"f613ff8a548accee65bd86209e4683539b66ffdb"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4be6540d348de541060a82f38c472bb515cf3b0b","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"RUN curl -sSL https://github.com/Yelp/dumb-init/releases/download/v1.1.3/dumb-init_1.1.3_amd64 -o /usr/local/bin/dumb-init \\"},{"line_number":402,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/dumb-init \\"},{"line_number":403,"context_line":"    \u0026\u0026 sed -i \u0027s|#!|#!/usr/local/bin/dumb-init |\u0027 /usr/local/bin/kolla_start"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"{% else %}"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_46bc3eda","side":"PARENT","line":403,"range":{"start_line":403,"start_character":7,"end_line":403,"end_character":76},"in_reply_to":"3f79a3b5_c0eb6878","updated":"2018-10-26 05:44:50.000000000","message":"Ignore this comment!","commit_id":"f613ff8a548accee65bd86209e4683539b66ffdb"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"ad2ca1a349b33f90ea32f7d9e2bb5eb75eb16f98","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"{% block base_footer %}{% endblock %}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child, \"--\"]"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_76a03e37","line":427,"range":{"start_line":427,"start_character":25,"end_line":427,"end_character":41},"updated":"2018-10-24 07:13:20.000000000","message":"if i understand correctly what single child does, is the oposite as expected:\n\n -c, --single-child\n\n    Run in single-child mode. In this mode, signals are only proxied to the direct child and not any of its descendants.\n\n\nI understand that only the sigterm will be sent to the main child, so it wont be proxied to the children (immediate kill once pid 1 dies)","commit_id":"269a3fda0745827d30f40348924b57cb896b90ea"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"83525a9e67113d7d32e93079ebe2b5ce41e63e3f","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"{% block base_footer %}{% endblock %}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child, \"--\"]"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_96207ab3","line":427,"range":{"start_line":427,"start_character":25,"end_line":427,"end_character":41},"in_reply_to":"3f79a3b5_76a03e37","updated":"2018-10-24 07:19:52.000000000","message":"Though I\u0027m not an dumb-init expert, what do you mean by \u0027main child\u0027?\n\nWhat I see is processes like below in the container.\n\nheat           1       0  0 Oct23 ?        00:00:00 /usr/local/bin/dumb-init /bin/bash /usr/local/bin/kolla_start\nheat           7       1  0 Oct23 ?        00:09:20 /usr/bin/python2 /usr/bin/heat-engine --config-file /usr/share/heat/heat-dist.conf --config-file /etc/heat/heat.conf\nheat          26       7  1 Oct23 ?        00:20:33 /usr/bin/python2 /usr/bin/heat-engine --config-file /usr/share/heat/heat-dist.conf --config-file /etc/heat/heat.conf\nheat          27       7  1 Oct23 ?        00:20:28 /usr/bin/python2 /usr/bin/heat-engine --config-file /usr/share/heat/heat-dist.conf --config-file /etc/heat/heat.conf\nheat          28       7  1 Oct23 ?        00:20:29 /usr/bin/python2 /usr/bin/heat-engine --config-file /usr/share/heat/heat-dist.conf --config-file /etc/heat/heat.conf\nheat          29       7  1 Oct23 ?        00:20:31 /usr/bin/python2 /usr/bin/heat-engine --config-file /usr/share/heat/heat-dist.conf --config-file /etc/heat/heat.conf\n\nSo I would gess child of dumb-init(pid 1) would be pid 7, though I\u0027ve not validated how it works.","commit_id":"269a3fda0745827d30f40348924b57cb896b90ea"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"db636324f1f506490d2fa483eaf244f3051d7ef5","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"{% block base_footer %}{% endblock %}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_984cbc40","line":427,"updated":"2018-10-30 08:22:13.000000000","message":"The ENTRYPOINT directive should be part of the {% block dumb_init_installation %} block otherwise we can\u0027t disable dumb-init as it\u0027s done today.","commit_id":"c2abbb2282df91637146c7c2cbe089d2d336e378"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"2a48f741fb17b3f1bc3facbd4ef3f8849395d05b","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"{% block base_footer %}{% endblock %}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_bea39644","line":427,"in_reply_to":"3f79a3b5_38fb287a","updated":"2018-10-30 17:43:00.000000000","message":"Red Hat and possibly others override this block downstream.","commit_id":"c2abbb2282df91637146c7c2cbe089d2d336e378"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e557f838463205658dee6fb16681e6b03854dc64","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"{% block base_footer %}{% endblock %}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3f79a3b5_38fb287a","line":427,"in_reply_to":"3f79a3b5_984cbc40","updated":"2018-10-30 08:43:15.000000000","message":"OK, I could not find any instances where it\u0027s disabled though.","commit_id":"c2abbb2282df91637146c7c2cbe089d2d336e378"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d283055c7f8f5db0579c510ec1e2bdfe07f143af","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"{% endif %}"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"{% endblock %}"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_aa632dab","line":416,"updated":"2018-11-01 10:39:41.000000000","message":"Should we use the full path here?","commit_id":"2e2f0fb7b5160ee7b38a7039b15e40ffead426c3"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ef9d7a25a5bd871ab143ca12d209df6e90e3ccf9","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"{% endif %}"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"{% endblock %}"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_ca8d4937","line":416,"in_reply_to":"3f79a3b5_aa632dab","updated":"2018-11-01 10:44:21.000000000","message":"Would that make any difference? We don\u0027t do that for kolla_start below.","commit_id":"2e2f0fb7b5160ee7b38a7039b15e40ffead426c3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2ec2c99a41a3ec4d5d071aa93e5bf1f5eb16d2aa","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"{% endif %}"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"{% endblock %}"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_4ab139e3","line":416,"in_reply_to":"3f79a3b5_ca8d4937","updated":"2018-11-01 10:48:25.000000000","message":"I guess not, only we used the full path in the shebang. Probably not an issue.","commit_id":"2e2f0fb7b5160ee7b38a7039b15e40ffead426c3"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"2c5365a77af6b9fb0ed7e98249babc405235d6ce","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"{% block base_footer %}{% endblock %}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3f79a3b5_aabe94fe","line":427,"updated":"2018-11-20 09:11:46.000000000","message":"The change from PS6 was reverted in PS7.\n\nENTRYPOINT needs to be moved back to {% block dumb_init_installation %}","commit_id":"0973a222bd56c3b23c4dbd53a6aaa60c1924293f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ace21bbd5b8b2e7b7ae34eea08455111bbe8c5ed","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"{% block base_footer %}{% endblock %}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3f79a3b5_cadaf046","line":427,"in_reply_to":"3f79a3b5_aabe94fe","updated":"2018-11-20 09:19:00.000000000","message":"Duh.. That\u0027s the issue of editing from the UI:/","commit_id":"0973a222bd56c3b23c4dbd53a6aaa60c1924293f"}]}