)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"41e4460e81425f53bb76f9065807391ec3bd5498","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove tgtd and scsi-target-utils support in CentOS/RHEL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The package \u0027scsi-target-utils\u0027 is no longer supported in CentOS"},{"line_number":10,"context_line":"and RHEL. Furthermore Cinder have switched to use lioadm so there"},{"line_number":11,"context_line":"is no need to keep tgtd support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I56f230d66f75dd0546325676278f91579f08c822"},{"line_number":14,"context_line":"Signed-off-by: Maciej Kucia \u003cmaciej@kucia.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_a96229a6","line":11,"range":{"start_line":10,"start_character":10,"end_line":11,"end_character":32},"updated":"2018-11-03 14:32:48.000000000","message":"this is not true, remove it","commit_id":"15568bb10181620dd7117f4202c7285ea1f8afa5"}],"docker/cinder/cinder-volume/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"8f7cbc120f99b8ce88409996b926b96fdf1f1ed0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"{{ macros.install_packages(cinder_volume_packages | customizable(\"packages\")) }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block cinder_volume_redhat_setup %}"},{"line_number":19,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/tgtd.conf"},{"line_number":20,"context_line":"{% endblock %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":23,"context_line":"    {% set cinder_volume_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bfdaf3ff_a16f8590","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":14},"updated":"2019-01-16 15:53:01.000000000","message":"This too should now be removed.","commit_id":"ebc60859260121f9b3c74fd257988ea6a7f09765"}],"docker/tgtd/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6539bc85a98ceb1eb24026104016430fa3d585c0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":9,"context_line":"    {% set tgtd_packages \u003d [\u0027tgt\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(tgtd_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/targets.conf"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_1224e7c2","line":9,"updated":"2018-10-31 15:03:50.000000000","message":"If tgt isn\u0027t required, should we not remove this also?","commit_id":"15568bb10181620dd7117f4202c7285ea1f8afa5"},{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"173b40b87ece533a72ce579df53e5749328b5ce2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":9,"context_line":"    {% set tgtd_packages \u003d [\u0027tgt\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(tgtd_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/targets.conf"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_5fc90050","line":9,"in_reply_to":"3f79a3b5_1224e7c2","updated":"2018-10-31 21:18:11.000000000","message":"You mean in debian? I only know about RHEL familly.","commit_id":"15568bb10181620dd7117f4202c7285ea1f8afa5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b2299f4b29c6a38690e4ef75e64ad03514d6050f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":9,"context_line":"    {% set tgtd_packages \u003d [\u0027tgt\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(tgtd_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/targets.conf"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_a4dfe309","line":9,"in_reply_to":"3f79a3b5_5fc90050","updated":"2018-11-01 09:48:39.000000000","message":"I meant more generally really. If tgtd isn\u0027t used by Cinder, then we don\u0027t need to install it. In fact, we don\u0027t need this container image any more. With this change we\u0027ll have RHEL tgtd container images that do not include tgt...\n\nHowever, I have checked the latest Cinder source code and release notes, and I can\u0027t see anything about removing support for tgt. Can you show me somewhere this is announced?","commit_id":"15568bb10181620dd7117f4202c7285ea1f8afa5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ed191e9e5a9785dfd071ea686dcced94fc6f3c8b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":9,"context_line":"    {% set tgtd_packages \u003d [\u0027tgt\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(tgtd_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/targets.conf"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_84342749","line":9,"in_reply_to":"3f79a3b5_a4dfe309","updated":"2018-11-01 09:54:54.000000000","message":"Or are you saying that tgt is still supported by Cinder, but not supported by CentOS/RHEL? In which case could you provide a link to some info about that and include in the commit message?\n\nIf that is the case we\u0027d need to skip building this image for CentOS/RHEL, and make changes to downstream projects (TripleO, Kolla Ansible) to prevent them from enabling tgtd container on CentOS/RHEL, before this is merged.","commit_id":"15568bb10181620dd7117f4202c7285ea1f8afa5"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"78c6204d8345a895746a1ed0f01b0b2070a9c954","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if distro_package_manager \u003d\u003d \u0027dnf\u0027 %}"},{"line_number":11,"context_line":"RUN echo \u0027Not available for {{ base_distro }}\u0027 \\"},{"line_number":12,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/tgtd.conf"},{"line_number":15,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3fa7e38b_d5b8b812","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":17},"updated":"2020-01-10 05:01:48.000000000","message":"add an entry to UNBUILDABLE_IMAGES - otherwise it will be tried to build and fail","commit_id":"946749312f31c36d9dac8ff3a545894e9043190d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcd7354ae4764f77d4c3471b8340c99021fa8d18","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if distro_package_manager \u003d\u003d \u0027dnf\u0027 %}"},{"line_number":11,"context_line":"RUN echo \u0027Not available for {{ base_distro }}\u0027 \\"},{"line_number":12,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/tgtd.conf"},{"line_number":15,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3fa7e38b_d8a46f4e","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":17},"in_reply_to":"3fa7e38b_d5b8b812","updated":"2020-01-10 09:21:58.000000000","message":"This is based on top of the centos8 build job patch, so base is unbuildable.","commit_id":"946749312f31c36d9dac8ff3a545894e9043190d"}],"releasenotes/notes/deprecate-tgtd-scsi-target-utils-3ee002b832382f14.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"12d08e1d000c9f8fdd791db8559ad75ecb37dc41","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    instead of tgtd daemon. The package \u0027scsi-target-utils\u0027"},{"line_number":6,"context_line":"    is no longer directly supported in CentOS and RHEL."},{"line_number":7,"context_line":"    While package is still available in EPEL, there is no"},{"line_number":8,"context_line":"    need to use tgt container in rpm world."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfdaf3ff_8284ad0d","line":8,"updated":"2019-01-17 13:07:45.000000000","message":"This could be a little clearer in stating that the tgtd image has been removed for CentOS, OracleLinux and RHEL.","commit_id":"ebc60859260121f9b3c74fd257988ea6a7f09765"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"63e9ac2080ea2a41fbb54e7f7088080e32e4b18a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    is no longer directly supported in CentOS and RHEL."},{"line_number":7,"context_line":"    While package is still available in EPEL, there is no"},{"line_number":8,"context_line":"    need to use tgt container in rpm world."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bfdaf3ff_a640d0a6","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":0},"updated":"2019-01-18 10:23:23.000000000","message":"error    too many blank lines (1 \u003e 0)  (empty-lines)","commit_id":"5861d1360e59db9d59cb8599f1c1bd7e65cf8883"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1433006f1108ec7e5bb132009033831c97bce89f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In RHEL 7 and beyond LIO kernel subsystem can be used"},{"line_number":5,"context_line":"    instead of tgtd daemon. The package \u0027scsi-target-utils\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_1f57c628","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":13},"updated":"2019-11-15 07:34:37.000000000","message":"but this change completely drops it","commit_id":"2c9693aee3aaae4677cfd999cdc3552bf9792831"}]}