)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3997f7203c50d8a9ce183443af1da3731e91b31f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add cyborg to kolla."},{"line_number":8,"context_line":"Blueprint add-cyborg"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I497e67e3a754fccfd2ef5a82f13ccfaf890a6fcd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_e8769f40","line":10,"updated":"2018-11-23 01:53:03.000000000","message":"Add cyborg to kolla\n    \nImplements: blueprint add-cyborg","commit_id":"9c440d52d2d7be9203230c9baa010392151e5a12"},{"author":{"_account_id":29344,"name":"白永君","email":"bai.yongjun@99cloud.net","username":"yj.bai"},"change_message_id":"aeb76819d94e7bf6096e76e8c8c66cd4cb43d26f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add cyborg to kolla."},{"line_number":8,"context_line":"Blueprint add-cyborg"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I497e67e3a754fccfd2ef5a82f13ccfaf890a6fcd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_dd625441","line":10,"in_reply_to":"3f79a3b5_e8769f40","updated":"2018-11-27 09:27:14.000000000","message":"Done","commit_id":"9c440d52d2d7be9203230c9baa010392151e5a12"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"8808d3a49440dca4fe3a3887ac756c49ad485646","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-11-26 10:33:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add cyborg to kolla."},{"line_number":8,"context_line":"Blueprint add-cyborg"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I497e67e3a754fccfd2ef5a82f13ccfaf890a6fcd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_b704697e","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":20},"updated":"2018-11-26 09:02:16.000000000","message":"can you please update like `Implements: blueprint add-cyborg`","commit_id":"04a4d730f731e86bd0295fd0b6ff0a2b42f95406"}],"docker/cyborg/cyborg-agent/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6d0be41c66253f84b0fa7c54b4269955c642bf2d","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% set cyborg_agent_pip_packages \u003d ["},{"line_number":9,"context_line":"    \u0027cursive\u0027,"},{"line_number":10,"context_line":"    \u0027python-glanceclient\u0027"},{"line_number":11,"context_line":"] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_pip(cyborg_agent_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3f79a3b5_046c466a","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":24},"updated":"2018-12-05 09:51:39.000000000","message":"why cyborg needs glanceclient? if is a required library for cyborg to work, cyborg should add it to its requirements.txt file","commit_id":"c88ae02727892df03d11e6e75e8c1aab9d8a5188"},{"author":{"_account_id":29344,"name":"白永君","email":"bai.yongjun@99cloud.net","username":"yj.bai"},"change_message_id":"556f7f943e434392d9ca8a854075104cc784c4fe","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% set cyborg_agent_pip_packages \u003d ["},{"line_number":9,"context_line":"    \u0027cursive\u0027,"},{"line_number":10,"context_line":"    \u0027python-glanceclient\u0027"},{"line_number":11,"context_line":"] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_pip(cyborg_agent_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3f79a3b5_00947534","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":24},"in_reply_to":"3f79a3b5_046c466a","updated":"2019-01-05 02:26:24.000000000","message":"when i build image ，it prompts me need glanceclient","commit_id":"c88ae02727892df03d11e6e75e8c1aab9d8a5188"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"75bbc8f420f376b28aa7236e17a95f26bcca50c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block cyborg_agent_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# FIXME(Yongjun Bai): remove glanceclient until cyborg fix this bug:"},{"line_number":9,"context_line":"# https://storyboard.openstack.org/#!/story/2005097"},{"line_number":10,"context_line":"{% set cyborg_agent_pip_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"9fdfeff1_cac8f922","line":7,"updated":"2019-03-04 08:23:06.000000000","message":"missing source install block and failure for binary builds, there are no packages for binary.\n\n{% if install_type \u003d\u003d \u0027binary\u0027 %}\n\nRUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027  \\\n    \u0026\u0026 /bin/false\n\n{% elif install_type \u003d\u003d \u0027source\u0027 %}","commit_id":"55cf9e423dcd4095cd42083c7d763a7d6730daf9"},{"author":{"_account_id":29344,"name":"白永君","email":"bai.yongjun@99cloud.net","username":"yj.bai"},"change_message_id":"4eb94624708c62975dd2d2ad9e5c7f9734cc0e62","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block cyborg_agent_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# FIXME(Yongjun Bai): remove glanceclient until cyborg fix this bug:"},{"line_number":9,"context_line":"# https://storyboard.openstack.org/#!/story/2005097"},{"line_number":10,"context_line":"{% set cyborg_agent_pip_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"9fdfeff1_dbb44939","line":7,"in_reply_to":"9fdfeff1_cac8f922","updated":"2019-03-05 14:48:48.000000000","message":"thx. it is my negligence","commit_id":"55cf9e423dcd4095cd42083c7d763a7d6730daf9"}],"docker/cyborg/cyborg-api/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3997f7203c50d8a9ce183443af1da3731e91b31f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block cyborg_api_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block cyborg_api_footer %}{% endblock %}"},{"line_number":7,"context_line":"{% block footer %}{% endblock %}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_487eb31a","line":5,"updated":"2018-11-23 01:53:03.000000000","message":"Need install apache to load the wsgi applications in this container.","commit_id":"9c440d52d2d7be9203230c9baa010392151e5a12"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e787c79a4d313c383f062d1ad063a21abb14baed","unresolved":false,"context_lines":[{"line_number":39,"context_line":"{% block cyborg_api_footer %}{% endblock %}"},{"line_number":40,"context_line":"{% block footer %}{% endblock %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"USER cyborg"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_17919d9b","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":11},"updated":"2018-11-26 08:36:59.000000000","message":"is will run as apache process, cyborg user wont have permissions to write logs, usually this is run as root (not setting USER cyborg)","commit_id":"04a4d730f731e86bd0295fd0b6ff0a2b42f95406"},{"author":{"_account_id":29344,"name":"白永君","email":"bai.yongjun@99cloud.net","username":"yj.bai"},"change_message_id":"aeb76819d94e7bf6096e76e8c8c66cd4cb43d26f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"{% block cyborg_api_footer %}{% endblock %}"},{"line_number":40,"context_line":"{% block footer %}{% endblock %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"USER cyborg"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_d7f7a5d1","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":11},"in_reply_to":"3f79a3b5_17919d9b","updated":"2018-11-27 09:27:14.000000000","message":"Done","commit_id":"04a4d730f731e86bd0295fd0b6ff0a2b42f95406"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"870553a4fd9779ab023aa99b09a867a7c6125dfa","unresolved":false,"context_lines":[{"line_number":12,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":13,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":14,"context_line":"        {% set cyborg_api_packages \u003d ["},{"line_number":15,"context_line":"            \u0027httpd\u0027,"},{"line_number":16,"context_line":"            \u0027mod_ssl\u0027,"},{"line_number":17,"context_line":"            \u0027mod_wsgi\u0027"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"        {% set cyborg_api_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"dfd5e7cf_802e0d41","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":22},"updated":"2019-01-10 09:15:04.000000000","message":"why httpd is installed if the services run as binary?\n\n\"command\": \"cyborg-api --config-file /etc/cyborg/cyborg.conf\" at https://review.openstack.org/#/c/621409/5/ansible/roles/cyborg/templates/cyborg-api.json.j2","commit_id":"c7f664bf5d76f52516ed177c149aa90e2fa803d6"}],"docker/cyborg/cyborg-api/extend_start.sh":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"dda5198a9877ca24e17f72121f88bd9024e23ff1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    cyborg-dbsync"},{"line_number":7,"context_line":"    exit 0"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":11,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":12,"context_line":"    . /etc/apache2/envvars"},{"line_number":13,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":14,"context_line":"else"},{"line_number":15,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"},{"line_number":16,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"dfd5e7cf_40cca5bb","line":16,"range":{"start_line":1,"start_character":0,"end_line":16,"end_character":2},"updated":"2019-01-10 09:12:07.000000000","message":"this file isnt copied on the api image as kolla_cyborg_extend_start","commit_id":"c7f664bf5d76f52516ed177c149aa90e2fa803d6"},{"author":{"_account_id":29344,"name":"白永君","email":"bai.yongjun@99cloud.net","username":"yj.bai"},"change_message_id":"1673acf48410554efedba4c0c362815ff7a3d3ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    cyborg-dbsync"},{"line_number":7,"context_line":"    exit 0"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":11,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":12,"context_line":"    . /etc/apache2/envvars"},{"line_number":13,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":14,"context_line":"else"},{"line_number":15,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"},{"line_number":16,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9fdfeff1_2ac40e5f","line":16,"range":{"start_line":1,"start_character":0,"end_line":16,"end_character":2},"in_reply_to":"dfd5e7cf_40cca5bb","updated":"2019-02-27 06:34:01.000000000","message":"thx","commit_id":"c7f664bf5d76f52516ed177c149aa90e2fa803d6"}],"docker/cyborg/cyborg-base/Dockerfile.j2":[{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"2b34ad20601270fb601372c105df1f3144ec7ea3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u0027openstack-cyborg\u0027"},{"line_number":17,"context_line":"] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RUN {{ macros.install_pip(cyborg_pip_packages | customizable(\"pip_packages\")) }} "},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_8e9373ff","line":19,"updated":"2018-11-23 07:46:31.000000000","message":"Erroneous whitespace.","commit_id":"52283b5527396deaac51a7f9f9b968bbe7a1d874"},{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"2b34ad20601270fb601372c105df1f3144ec7ea3","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% block cybrog_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_4e99db1a","line":23,"updated":"2018-11-23 07:46:31.000000000","message":"cyborg_footer","commit_id":"52283b5527396deaac51a7f9f9b968bbe7a1d874"},{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"95631211ce03616dfdf949c778d8d2e36f408820","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% block cybrog_footer %}{% endblock %}"},{"line_number":24,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f79a3b5_1d6a3381","line":23,"updated":"2018-11-26 09:47:11.000000000","message":"cyborg_footer","commit_id":"5ba38e0be1e7d8c9db27d96d2becd880067b0b13"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e787c79a4d313c383f062d1ad063a21abb14baed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block cyborg_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027  \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_37d37965","line":7,"updated":"2018-11-26 08:36:59.000000000","message":"need to create cyborg user\n\nhttps://github.com/openstack/kolla/blob/master/kolla/common/config.py#L830\n\nhttps://github.com/openstack/kolla/blob/master/docker/aodh/aodh-base/Dockerfile.j2#L8","commit_id":"04a4d730f731e86bd0295fd0b6ff0a2b42f95406"},{"author":{"_account_id":29344,"name":"白永君","email":"bai.yongjun@99cloud.net","username":"yj.bai"},"change_message_id":"aeb76819d94e7bf6096e76e8c8c66cd4cb43d26f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block cyborg_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027  \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_d7bec5cd","line":7,"in_reply_to":"3f79a3b5_37d37965","updated":"2018-11-27 09:27:14.000000000","message":"thanks","commit_id":"04a4d730f731e86bd0295fd0b6ff0a2b42f95406"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e787c79a4d313c383f062d1ad063a21abb14baed","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% set cyborg_pip_packages \u003d ["},{"line_number":16,"context_line":"    \u0027openstack-cyborg\u0027"},{"line_number":17,"context_line":"] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RUN {{ macros.install_pip(cyborg_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_17d67d55","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":22},"updated":"2018-11-26 08:36:59.000000000","message":"please, use common source build methods.\n\nThis means, add cyborg to the project list at\n\nhttps://github.com/openstack/kolla/blob/master/kolla/common/config.py#L290\n\nhttps://github.com/openstack/kolla/blob/master/docker/aodh/aodh-base/Dockerfile.j2#L69,L82","commit_id":"04a4d730f731e86bd0295fd0b6ff0a2b42f95406"},{"author":{"_account_id":29344,"name":"白永君","email":"bai.yongjun@99cloud.net","username":"yj.bai"},"change_message_id":"aeb76819d94e7bf6096e76e8c8c66cd4cb43d26f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% set cyborg_pip_packages \u003d ["},{"line_number":16,"context_line":"    \u0027openstack-cyborg\u0027"},{"line_number":17,"context_line":"] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RUN {{ macros.install_pip(cyborg_pip_packages | customizable(\"pip_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_f7bbc1da","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":22},"in_reply_to":"3f79a3b5_17d67d55","updated":"2018-11-27 09:27:14.000000000","message":"thanks","commit_id":"04a4d730f731e86bd0295fd0b6ff0a2b42f95406"},{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"95631211ce03616dfdf949c778d8d2e36f408820","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% block cybrog_footer %}{% endblock %}"},{"line_number":24,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_7aa558b2","line":23,"updated":"2018-11-26 09:47:11.000000000","message":"Typo: cybrog_footer -\u003e cyborg_footer","commit_id":"04a4d730f731e86bd0295fd0b6ff0a2b42f95406"},{"author":{"_account_id":29344,"name":"白永君","email":"bai.yongjun@99cloud.net","username":"yj.bai"},"change_message_id":"aeb76819d94e7bf6096e76e8c8c66cd4cb43d26f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% block cybrog_footer %}{% endblock %}"},{"line_number":24,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f79a3b5_bac5300b","line":23,"in_reply_to":"3f79a3b5_7aa558b2","updated":"2018-11-27 09:27:14.000000000","message":"please excuse my carelessness","commit_id":"04a4d730f731e86bd0295fd0b6ff0a2b42f95406"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"64f08dd7cf0e1d3fda5dad0a246a09ab25fed7fa","unresolved":false,"context_lines":[{"line_number":17,"context_line":"ADD cyborg-base-archive /cyborg-base-source"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% set cyborg_base_pip_packages \u003d ["},{"line_number":20,"context_line":"    \u0027openstack-cyborg\u0027"},{"line_number":21,"context_line":"] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN ln -s cyborg-base-source/* cyborg \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_b75f5b72","line":20,"updated":"2018-11-28 01:50:44.000000000","message":"This should be /cyborg","commit_id":"1ad52c5475715ea7473225b49f27665e5387025b"},{"author":{"_account_id":29344,"name":"白永君","email":"bai.yongjun@99cloud.net","username":"yj.bai"},"change_message_id":"7f385d18aff326f582f760bb7d3b50b95c092706","unresolved":false,"context_lines":[{"line_number":17,"context_line":"ADD cyborg-base-archive /cyborg-base-source"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% set cyborg_base_pip_packages \u003d ["},{"line_number":20,"context_line":"    \u0027openstack-cyborg\u0027"},{"line_number":21,"context_line":"] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN ln -s cyborg-base-source/* cyborg \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_97c1ffff","line":20,"in_reply_to":"3f79a3b5_b75f5b72","updated":"2018-11-28 06:14:43.000000000","message":"Done","commit_id":"1ad52c5475715ea7473225b49f27665e5387025b"},{"author":{"_account_id":28614,"name":"jacky06","email":"zhang.min@99cloud.net","username":"jacky06"},"change_message_id":"eb3fec2b65cd6287e7e976554b279c16a413924a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027  \\"},{"line_number":13,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% else %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ADD cyborg-base-archive /cyborg-base-source"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3f79a3b5_87e73fd8","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"updated":"2018-12-02 15:13:19.000000000","message":"I perfer to use {% elif install_type \u003d\u003d \u0027source\u0027 %} like the other dockerfiles\n\n\nand do we need base_distro check here?","commit_id":"adc19abc9c975876d201af5060dfe886da921bd4"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"d96c42c3ab24d1b541a8bf90e5fa096e150958b8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027  \\"},{"line_number":13,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% else %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ADD cyborg-base-archive /cyborg-base-source"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3f79a3b5_f657bf58","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"in_reply_to":"3f79a3b5_87e73fd8","updated":"2018-12-03 07:13:10.000000000","message":"agree with @jacky06, also try to add for source install_type as we maintain convention in writing.","commit_id":"adc19abc9c975876d201af5060dfe886da921bd4"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f9eff1a8f93750a2313953f2d656dfc80a02712f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027  \\"},{"line_number":13,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% else %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ADD cyborg-base-archive /cyborg-base-source"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3f79a3b5_e3312058","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"in_reply_to":"3f79a3b5_f657bf58","updated":"2018-12-04 11:50:16.000000000","message":"yeah, need add elif install_type here. \nabout base_distro, we do not need it for binary. check others https://github.com/openstack/kolla/blob/143213958b627378113bd58008fe44118043fb54/docker/zun/zun-base/Dockerfile.j2#L12","commit_id":"adc19abc9c975876d201af5060dfe886da921bd4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6d0be41c66253f84b0fa7c54b4269955c642bf2d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"COPY cyborg_sudoers /etc/sudoers.d/kolla_cyborg_sudoers"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"RUN chmod 750 /etc/sudoers.d \\"},{"line_number":33,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_cyborg_extend_start \\"},{"line_number":34,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_cyborg_extend_start"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% block cyborg_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3f79a3b5_c423ae11","line":33,"range":{"start_line":33,"start_character":28,"end_line":33,"end_character":53},"updated":"2018-12-05 09:51:39.000000000","message":"i don see this file used anywhere, cyborg doesnt need a database schema migration in api, if yes, this file will likely be the one running such bootstrap commands","commit_id":"c88ae02727892df03d11e6e75e8c1aab9d8a5188"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"fcd74bd70b5f1a74c4faba3b1f49fbd2a541d232","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% set cyborg_base_pip_packages \u003d ["},{"line_number":20,"context_line":"    \u0027/cyborg\u0027,"},{"line_number":21,"context_line":"    \u0027psycopg2-binary\u0027"},{"line_number":22,"context_line":"] %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"RUN ln -s cyborg-base-source/* cyborg \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"dfd5e7cf_436fe291","line":21,"updated":"2019-01-09 14:10:59.000000000","message":"why psycopg is required? this is used to connect postgresql and we do not use this in kolla.","commit_id":"c7f664bf5d76f52516ed177c149aa90e2fa803d6"}],"docker/cyborg/cyborg-generic-driver/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3997f7203c50d8a9ce183443af1da3731e91b31f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}cyborg-base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block cyborg_generic_driver_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_88884b21","line":1,"updated":"2018-11-23 01:53:03.000000000","message":"There is no process/script named cyborg-generic-driver, i think this image is useless","commit_id":"9c440d52d2d7be9203230c9baa010392151e5a12"}],"kolla/image/build.py":[{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"2b34ad20601270fb601372c105df1f3144ec7ea3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        \"solum-base\","},{"line_number":94,"context_line":"        \"vmtp\","},{"line_number":95,"context_line":"        \"zun-base\","},{"line_number":96,"context_line":"        \"cyborg-base\""},{"line_number":97,"context_line":"    ],"},{"line_number":98,"context_line":"    \u0027centos+source\u0027: ["},{"line_number":99,"context_line":"        \"ovsdpdk\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ce840bb2","line":96,"updated":"2018-11-23 07:46:31.000000000","message":"This list should be kept in alphabetical order.","commit_id":"52283b5527396deaac51a7f9f9b968bbe7a1d874"},{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"2b34ad20601270fb601372c105df1f3144ec7ea3","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \"vmtp\","},{"line_number":134,"context_line":"        \"zaqar\","},{"line_number":135,"context_line":"        \"zun-base\","},{"line_number":136,"context_line":"        \"cyborg-base\""},{"line_number":137,"context_line":"    ],"},{"line_number":138,"context_line":"    \u0027ubuntu+source\u0027: ["},{"line_number":139,"context_line":"        \"crane\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6eb7f789","line":136,"updated":"2018-11-23 07:46:31.000000000","message":"As above.","commit_id":"52283b5527396deaac51a7f9f9b968bbe7a1d874"},{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"2b34ad20601270fb601372c105df1f3144ec7ea3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        \"vmtp\","},{"line_number":175,"context_line":"        \"zaqar\","},{"line_number":176,"context_line":"        \"zun-base\","},{"line_number":177,"context_line":"        \"cyborg-base\""},{"line_number":178,"context_line":"    ],"},{"line_number":179,"context_line":"    \u0027debian+source\u0027: ["},{"line_number":180,"context_line":"        \"crane\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8ebcd36b","line":177,"updated":"2018-11-23 07:46:31.000000000","message":"Ditto.","commit_id":"52283b5527396deaac51a7f9f9b968bbe7a1d874"},{"author":{"_account_id":16984,"name":"Nick Jones","email":"nick@dischord.org","username":"yankcrime"},"change_message_id":"2b34ad20601270fb601372c105df1f3144ec7ea3","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"solum-base\","},{"line_number":200,"context_line":"        \"vmtp\","},{"line_number":201,"context_line":"        \"zun-base\","},{"line_number":202,"context_line":"        \"cyborg-base\""},{"line_number":203,"context_line":"    ],"},{"line_number":204,"context_line":"    \u0027oraclelinux+source\u0027: ["},{"line_number":205,"context_line":"        \"bifrost-base\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2ead7f33","line":202,"updated":"2018-11-23 07:46:31.000000000","message":"Ditto.","commit_id":"52283b5527396deaac51a7f9f9b968bbe7a1d874"}]}