)]}'
{"docker/puppet-tripleo/Dockerfile.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"09ec7e610a0813d9462981dd4ec46c35a02bb1fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block puppet_tripleo_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_95b125e6","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":48},"updated":"2018-11-26 10:53:08.000000000","message":"Dan, WDYT if using the base image here? Would that play nicely with the tripleoclient container image that I\u0027m changing here to be built on top of it instead of openstack-base? ( https://review.openstack.org/595866 was the original change ) \n\nI mean, do we really need to pull in the world http://git.openstack.org/cgit/openstack/kolla/tree/docker/openstack-base/Dockerfile.j2#n13 for just having a tripleo client working there?","commit_id":"d77d11c0b08815ba85332535fe9c76392bf00686"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"017a29ee10adb4d915b007187636228c75d6ffda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block puppet_tripleo_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_f03c27be","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":48},"in_reply_to":"3f79a3b5_95b125e6","updated":"2018-11-26 11:07:58.000000000","message":"That comment was basically for https://review.openstack.org/#/c/619736/2/docker/tripleoclient/Dockerfile.j2@1","commit_id":"d77d11c0b08815ba85332535fe9c76392bf00686"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"eaf4e4696f7fec938243a569faf1b762f9e6d6f6","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"COPY create_super_user.sh /usr/local/bin/create_super_user.sh"},{"line_number":29,"context_line":"RUN chmod 750 /usr/local/bin/create_super_user.sh"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block puppet_tripleo_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_17c51d3e","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":61},"updated":"2018-11-26 08:57:39.000000000","message":"this file does not exists","commit_id":"d77d11c0b08815ba85332535fe9c76392bf00686"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0aa5c3a835f29cd24f0a1a3a038098ce1cad9e9d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"COPY create_super_user.sh /usr/local/bin/create_super_user.sh"},{"line_number":29,"context_line":"RUN chmod 750 /usr/local/bin/create_super_user.sh"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block puppet_tripleo_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f79a3b5_55794d2f","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":61},"in_reply_to":"3f79a3b5_17c51d3e","updated":"2018-11-26 10:43:10.000000000","message":"omg, that was a bad copy \u0026 paste... Well spotted, thank you!","commit_id":"d77d11c0b08815ba85332535fe9c76392bf00686"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"e6a51a187af087bc46b7b95cd5f14b455a9c4151","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        {% set puppet_tripleo_packages \u003d ["},{"line_number":12,"context_line":"                \u0027puppet-tripleo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_732577bf","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":48},"updated":"2018-11-26 20:43:48.000000000","message":"srsly? can we get some fedora love?","commit_id":"49407bd59a4d5ae37b278112318ec62184ba9496"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"05809fba91a48ca0d3bddc975ee9c1b7d70f4898","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        {% set puppet_tripleo_packages \u003d ["},{"line_number":12,"context_line":"                \u0027puppet-tripleo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_56e70946","line":9,"in_reply_to":"3f79a3b5_732577bf","updated":"2018-11-26 20:52:24.000000000","message":"fedora is not a supported distribution in kolla, it was a few releases ago but become unmaintained and was deprecated https://openstack.nimeyo.com/97436/openstack-operators-kolla-decision-to-deprecate-fedora","commit_id":"49407bd59a4d5ae37b278112318ec62184ba9496"}],"docker/tripleoclient/Dockerfile.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4158c7f3c12c8231320318e903ba1af74f9d00ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}puppet-tripleo:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block tripleoclient_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_90461356","line":1,"updated":"2018-11-26 11:07:15.000000000","message":"Dan, WDYT, would that play nicely when building it on top of that new base, instead of openstack-base? ( https://review.openstack.org/595866\nwas the original change )\n \nI mean, do we really need to pull in the world http://git.openstack.org/cgit/openstack/kolla/tree/docker/openstack-base/Dockerfile.j2#n13\nfor just having a tripleo client working there? Probably not","commit_id":"49407bd59a4d5ae37b278112318ec62184ba9496"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0c2724474e6705bfa6e919d7959ad5d305360088","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}puppet-tripleo:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block tripleoclient_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_4da9afdb","line":1,"in_reply_to":"3f79a3b5_32728ee2","updated":"2018-11-27 10:06:40.000000000","message":"see https://review.openstack.org/620281, let\u0027s move this discussion there please","commit_id":"49407bd59a4d5ae37b278112318ec62184ba9496"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3204aa73a6e646484b0b14d265801b197c8e8c47","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}puppet-tripleo:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block tripleoclient_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_32728ee2","line":1,"in_reply_to":"3f79a3b5_90461356","updated":"2018-11-27 09:56:34.000000000","message":"Dan, could you please comment on that? Does it makes sense to try your zero-footprint work with the base image instead of openstack-base? That would save a lot of space in the end container for the client tooling.","commit_id":"49407bd59a4d5ae37b278112318ec62184ba9496"}],"kolla/common/config.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a4cd2865cb46f34874a67509471fceb153002d95","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":658,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"},{"line_number":659,"context_line":"                     \u0027panko-master.tar.gz\u0027)},"},{"line_number":660,"context_line":"    \u0027puppet-tripleo\u0027: {"},{"line_number":661,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":662,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/puppet-tripleo/\u0027"},{"line_number":663,"context_line":"                     \u0027puppet-tripleo-master.tar.gz\u0027)},"},{"line_number":664,"context_line":"    \u0027tempest-plugin-tempest-conf\u0027: {"},{"line_number":665,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":666,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/python-tempestconf/\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f79e6150","line":663,"range":{"start_line":660,"start_character":0,"end_line":663,"end_character":54},"updated":"2018-11-26 08:56:54.000000000","message":"not needed, source images are not created","commit_id":"d77d11c0b08815ba85332535fe9c76392bf00686"}]}